Skip to content

docs: add devreeda to README contributors - #22454

Merged
iamwhatever merged 2 commits into
kirodotdev:mainfrom
devreeda:docs/add-devreeda-contributor
Oct 20, 2026
Merged

iamwhatever merged 2 commits into
kirodotdev:mainfrom
devreeda:docs/add-devreeda-contributor

Conversation

@devreeda

Copy link
Copy Markdown

Problem / Motivation

Goal: Credit @devreeda in the README Contributors list.

@devreeda authored #17539, merged on 2026-10-13. The Add Contributor workflow has not completed a run since 2026-10-07 (every scheduled run since 2026-10-08 is cancelled at the 10-minute job timeout, and the 2026-10-13 run failed), so the entry was never added.

Why it matters

Contributors whose merged work is missed by the workflow should still be credited.

Not a goal

What changed (motivation → approach → change)

Ran python3 scripts/update_contributors.py --login devreeda, which inserted one entry into the README Contributors block at its sorted position (after developer-front). The GitHub profile has no display name, so the login is used, as for other such entries.

Backwards compatibility

Compatible: one README line added.

Removes nothing: the diff only adds a line.

Tests

N/A, docs-only change.

Manual verification

The diff shows exactly one added line in the Contributors block, in case-insensitive login order.

Related Issues

Related: #16405

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@devreeda
devreeda requested review from a team and KiroCrewCaptain as code owners October 20, 2026 08:11
@devreeda
devreeda requested a review from dodgeblaster October 20, 2026 08:11
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ⏭️ skipped

Revision df33a1f5dd0a02be1e37da005fcea9f3b047b78f ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision df33a1f5dd0a02be1e37da005fcea9f3b047b78f touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed df33a1f5dd0a02be1e37da005fcea9f3b047b78f via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] df33a1f

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of df33a1f5dd0a02be1e37da005fcea9f3b047b78f via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] df33a1f

Description read

[DESCRIPTION-READ] 37a431f2ef7e2323115beda01c142b802fbfcd16883d29bb9de78a664920bfe9

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed df33a1f5dd0a02be1e37da005fcea9f3b047b78f via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] df33a1f

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 20, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve at df33a1f5dd0a02be1e37da005fcea9f3b047b78f.

The diff adds one README Contributors entry for @devreeda (README.md#L556) at its case-insensitive sorted position. The credit is backed by #17539, merged 2026-10-13, and the entry is not on main yet. All AI lanes report no findings or skipped, there are no change requests, and every check on this head is green or skipped.

— crew-pr-reviewer (r115)

@iamwhatever
iamwhatever merged commit f0d0cd2 into kirodotdev:main Oct 20, 2026
100 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants