Skip to content

fix(voice): name the cause when read aloud fails - #22545

Merged
iamwhatever merged 1 commit into
mainfrom
fix/17511-read-aloud-failure-cause
Nov 2, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
fix/17511-read-aloud-failure-cause

Conversation

@dodgeblaster

@dodgeblaster dodgeblaster commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Read aloud names the cause and the one action that fixes it when Amazon Polly rejects the chosen voice or engine in the selected region, instead of showing the generic failure sentence.

Read aloud showed one notice — "Read aloud failed. Check the Text-to-speech settings and try again." — for every way synthesis could fail. The cause was only in the gateway log, so the user could not tell which setting to change. #17680 fixed the Amazon Polly consent mismatch; the Polly engine/region rejection #17511 reports still fell through to the generic notice.

Why it matters

A user whose Polly voice or engine is not offered in their region hits the same generic notice every time and cannot tell that the fix is a different Voice, Engine, or Region — they end up guessing.

Not a goal

  • No change to the consent-mismatch path fix(voice): tell the user when read aloud needs Polly consent #17680 already fixed.
  • No change to the no-engine path: a host with no built-in engine still reports voice_unavailable and the desktop client speaks the reply with its own engine; a surface that cannot keeps the generic notice. (An earlier draft added a dedicated no-engine notice, but voice_unavailable is also raised when a Polly or registered provider returns no audio, so a notice keyed on it would name the wrong remedy for those users. Dropped.)
  • Not a general AWS-error taxonomy: only the engine/region-unsupported rejection Read aloud shows the same generic notice for every failure, hiding the cause #17511 reports is named. Every other Polly failure (a credential or access error, a sentence-scoped SSML/parameter error) keeps the existing skip-per-sentence behaviour and the generic notice.
  • The specific AWS error string is not surfaced in the UI (it can echo the request text, so it stays in the gateway log).

What changed (motivation → approach → change)

An Amazon Polly request AWS rejected returned no audio for every sentence and ended in the generic notice, because _synthesize_polly returned None and the sentence stream skipped on and failed the same way. On the dashboard path — the one with a person waiting — it now matches the one failure #17511 reports (_classify_polly_failure): the chosen voice or engine is not offered in the region, which AWS rejects identically for every sentence. That one raises voice_polly_rejected at the first sentence, whose notice names the voice/engine/region fix. It is the only AWS failure turned into a raise, because it is the only one whose fix is the action the notice names and the only one that repeats for every sentence; a credential/access error or a sentence-scoped SSML error keeps the old None/skip path and the generic notice, which is the honest answer when "change the voice, engine or region" would not help. Unattended callers (Slack, Telegram) keep the text fallback. A manual Read aloud that allows the client-speech fallback still speaks the reply with the webview's own engine on this code, as it did on voice_unavailable, because that engine does not depend on the AWS region.

The change lands in src/kiro_crew/voice_reply.py (the narrow engine/region classifier and the raised voice_polly_rejected code), src/kiro_crew/dashboard/chat_voice.py and website/src/hooks/websocket/voicePlayback.ts (the code joins voice_unavailable as a client-fallback code, so its payloads carry speakable), website/src/lib/voiceFailure.ts (the code→notice mapping), the website/src/i18n locale catalogs (the one notice string in all 13 shipped catalogs plus the pseudolocale), docs (the voice-streaming.md module spec), and a website/capture harness for the screenshots. The code maps to its own localized notice; an unknown code still shows the generic sentence.

Backwards compatibility

Compatible: the Polly path gains one new raised code, voice_polly_rejected, consumed by voiceFailureMessage() and the client-speech fallback, both updated in lockstep; any unmapped code falls through to the existing generic notice. The no-engine voice_unavailable behaviour and unattended callers' None return and text fallback are unchanged.

Removes nothing: no path, record, key or public function is hidden, deleted or narrowed; the change adds the voice_polly_rejected code and its notice.

Tests

  • test_voice_reply_synthesis.py: _synthesize_polly raises voice_polly_rejected on the engine/region-unsupported stderr with fixed text (no AWS stderr) when raise_refusal=True; a credential error and an unfamiliar failure both return None (skip-per-sentence); the unattended path returns None.
  • test_voice_reply_pipeline.py: streaming_voice_reply lets the rejection propagate and stops at the first sentence rather than retrying per sentence.
  • test_chat_voice.py: the synthesize endpoint answers 502 with voice_polly_rejected (consent granted, AWS rejects on engine/region), carrying the fixed notice text with no secrets and the speakable text for the client fallback.
  • clientSpeechFallback.test.tsx: a fallback-allowed Read aloud that hits voice_polly_rejected speaks on the client and raises no notice.

Proof: PROVEN test_polly_aws_rejection_reaches_the_client_with_its_code and the clientSpeechFallback voice_polly_rejected case fail with the chat_voice.py / voicePlayback.ts fallback hunks reverted (head f5b01c5)

  • VoicePlaybackNotice.test.tsx: the notice renders the Polly-rejection copy for voice_polly_rejected (not the generic "Read aloud failed").

Manual verification

Captured the real VoicePlaybackNotice for the generic failure (before) and the Polly rejection (after) in light and dark via an isolated Vite capture harness (capture/read-aloud-failure-notice.*), asserting the expected sentence is on screen before each shot.

Screenshots / video

Before — the generic notice shown for every failure (light):

before: generic read aloud failed notice

After — Amazon Polly does not offer the voice/engine in the region (dark):

after: Polly rejected notice, dark

Both causes (light + dark)

light before
light polly rejected
dark before
dark polly rejected

Related Issues

Fixes #17511

Pattern harvest

Rule candidate: review-prompt
Pattern: a user-facing failure notice keyed on an error code must have a distinct code per actionable cause, and the code must be raised ONLY for the causes whose remedy its sentence names — a notice keyed on a code that several unrelated causes share (here voice_unavailable, raised for both a missing engine and a provider returning no audio) names the wrong remedy for the other causes.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of f5b01c53c5f7ce5e2d07dd9c281bbd20378dd8bf — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Every item traces to the defect reported in #17511. Catching the client-fallback code keeps the behaviour the base already had, where voice_unavailable gave a client-speech fallback.

What this change ships

Inventory (7 items) — 7 justified

Intent: A user whose Polly voice or engine isn't offered in their region learns that and knows to change Voice, Engine or Region. FIX.

  1. Read aloud shows a notice naming the voice/engine/region fix when Polly rejects the region — justified
  2. The dashboard stream stops at the first rejected sentence instead of retrying every sentence — justified
  3. A manual Read aloud that allows fallback still speaks with the client engine on this rejection (as base did via voice_unavailable) — justified
  4. The rejection error payload carries speakable (_CLIENT_FALLBACK_CODES) — justified
  5. The new notice string in 13 locales plus the pseudolocale — justified
  6. The voice-streaming spec documents the new code — justified
  7. A capture harness for the screenshots (follows the existing website/capture/ convention, 583 files) — justified

[FIRST-PRINCIPLES-REVIEWED] f5b01c5

Description read

[DESCRIPTION-READ] 6758b7b1a7e52df1922a3eb78b050819db502833e351999b4f91b7bd98b2b19c

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of f5b01c53c5f7ce5e2d07dd9c281bbd20378dd8bf — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the one new notice appears in all four screenshots, and the blind reader understood it as the specific reason Read aloud failed.

Notes

  • The reader did not know "Amazon Polly", "engine" or "AWS region". Only people who picked Polly in settings see this notice, so the terms are their own settings. The real problem is that the notice says "Region" while the settings field is labelled aws_region_polly. Name the field exactly as its settings label reads, e.g. "pick a different Voice, Engine, or AWS region".

[UX-REVIEWED] f5b01c5

Description read

[DESCRIPTION-READ] c1a03e1da1e977d35616f017c6d329d367f1bd68c61e469e8b1202869de67225

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of f5b01c53c5f7ce5e2d07dd9c281bbd20378dd8bf — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the narrow, single-cause classifier is proportionate, unknown codes still fall through to the generic notice, and the change reverts cleanly.

Notes

  • When the client fallback is allowed, a Read aloud that hits voice_polly_rejected now speaks with the webview's own voice and shows no notice. Users on that path never learn their Polly settings are broken. That matches how voice_unavailable already behaves, but it means the goal's "names the cause" applies only to requests that don't allow the fallback.
  • _POLLY_ENGINE_REGION_ERRORS decides by matching text in the AWS CLI stderr. If AWS rewords the message, the failure quietly goes back to the generic notice. That's safe, but nothing would flag it.

[DESIGN-REVIEWED] f5b01c5

Description read

[DESCRIPTION-READ] 272eecd2ccdbf58eeb06769c67d5d115ee4a6b3948261ce874ee8077febbd622

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed f5b01c53c5f7ce5e2d07dd9c281bbd20378dd8bf — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] f5b01c5

Verdict parsed from the review's SHA-scoped output markers for commit f5b01c53c5f7ce5e2d07dd9c281bbd20378dd8bf.

False positive or not applicable? A repository writer can comment:
/ai-review override fable f5b01c53c5f7ce5e2d07dd9c281bbd20378dd8bf false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of f5b01c53c5f7ce5e2d07dd9c281bbd20378dd8bf and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] f5b01c5

False positive or not applicable? A repository writer can comment:
/ai-review override gpt f5b01c53c5f7ce5e2d07dd9c281bbd20378dd8bf false-positive: <reason, 20 to 500 characters>

@dodgeblaster
dodgeblaster force-pushed the fix/17511-read-aloud-failure-cause branch from 2f99189 to 3aa7587 Compare October 20, 2026 19:30
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Rebased: main moved 5c17469 -> dea18bc (feat(crew) #21748 edited the same i18n locale files); also ran black on test/test_voice_reply_pipeline.py and test/test_chat_voice.py, which Backend Lint flagged on the prior head. Diff is otherwise unchanged (our two voicePlaybackNotice keys preserved in every catalog); CI re-running.

@dodgeblaster
dodgeblaster force-pushed the fix/17511-read-aloud-failure-cause branch 2 times, most recently from 4487095 to bb411b8 Compare October 20, 2026 20:09
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

Rebased onto current main (dea18bc -> 6fd7c1f; a revert PR touched same-dir files, no conflict). Diff unchanged otherwise.

@dodgeblaster
dodgeblaster force-pushed the fix/17511-read-aloud-failure-cause branch 7 times, most recently from efd09d2 to db42ea2 Compare October 20, 2026 21:09
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: no

needs-a-decision: the exact phrasing of this notice is a maintainer copy call, not a defect. The UX lane has re-rated this one string's readability/structure on every head for 7 rounds and has reversed its own earlier asks (it asked to restore the install example, then to remove it; to use "System (built-in)", then called it a contradiction). The string is factually correct and names each cause and its fix, which the generic notice never did. I am holding the copy per the conductor's ruling; a maintainer owns the final wording.

  • system_no_engine readability (span=c1a5f5274215)

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: no

needs-a-decision: this is a maintainer copy call, and the lane has reversed itself. An earlier round asked me to name the host as "the computer running Kiro Crew"; I used that wording, the lane then found it unclear and I changed it to "This Kiro Crew computer"; this round asks to change it back to "The computer running Kiro Crew". Both readings are defensible and the referent (the gateway host) is unchanged. Holding the copy per the conductor's ruling; the maintainer picks the wording.

  • which-computer wording (span=6291b1b814c4)

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: no

needs-a-decision: the "Ask the agent" control predates this PR (the lane says so) and is shared by every ErrorNotice, not added or changed here. Reworking its affordance is out of this fix's scope and a maintainer call on shared UI; this PR only adds two error codes and their notice strings.

  • Ask the agent affordance (span=a8b558d58921)

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: no

needs-a-decision: the notice's Settings link uses highlight=voice.provider-2, which is pre-existing shared behavior — the generic and consent_required notices (the latter merged in #17680) use the same highlight, and voice.provider-2 is the one settingId the voice-streaming spec documents this link targets. The Voice/Engine/Region fields only appear once Provider is Amazon Polly, so Provider is the entry point to them. Making the highlight field-specific per error code is new shared-UI scope and a maintainer call, not a defect in the strings this PR adds. Holding per the conductor's ruling.

  • polly_rejected settings-link target (span=e9ec3e15c4d6)

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: no

rebutted: the file stays under the 2000-line cap (1965), so no gate is broken. _classify_polly_failure is a small, cohesive addition that belongs beside the other Polly synthesis logic in this module — the one function that reads this provider's CLI stderr. Splitting voice_reply.py is a module-shape refactor unrelated to #17511 and out of this fix's goal; widening the PR to do it would add risk this bug fix does not need. If the module's size is a standing concern, a dedicated refactor PR is the right place, not this one.

  • voice_reply.py size (span=09ae33f6cea3)

@dodgeblaster
dodgeblaster force-pushed the fix/17511-read-aloud-failure-cause branch from db42ea2 to b27d68d Compare October 20, 2026 21:33
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: no

needs-a-decision: the exact phrasing of system_no_engine is a maintainer copy call. The UX lane has re-rated this one string's length/structure on every head for many rounds and reverses its own asks (restore then remove the install example; use then reject "System (built-in)"). The string is factually correct and names each cause and its fix, which the generic notice never did. Holding the copy per the conductor's ruling; the maintainer owns the final wording.

  • system_no_engine too long/technical (span=5979f2bb225c)

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: no

needs-a-decision: this proposes a specific rewrite (front-load the action, drop the espeak-ng line to docs) of the same system_no_engine string — a maintainer copy call, not a defect. It directly conflicts with an earlier round that asked to ADD the install example to the notice; the lane has reversed itself. Holding per the conductor's ruling.

  • system_no_engine rewrite/front-load (span=7ae160e627b3)

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: no

needs-a-decision: the warning icon's vertical alignment on a multi-line block is pre-existing CSS of the shared ErrorNotice component (every wrapped notice centers the icon the same way, severity low per the lane). This PR adds no layout; it only adds two error strings. Changing the shared component's icon alignment is out of this fix's scope and a maintainer call.

  • icon centering on wrapped text (span=6a12689972c6)

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: no

needs-a-decision: this is a maintainer copy call about the polly_rejected field-name shape applied to system_no_engine — pure wording. The current string already names its fields and fixes and is factually correct. Holding per the conductor's ruling.

  • field-name shape for system_no_engine (span=c2ddb0d11ee0)

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: no

needs-a-decision: the lane has reversed itself on this exact point. An earlier round asked me to name the host as "the computer running Kiro Crew"; I used that, the lane found it unclear, I changed it to "This {{productName}} computer"; this round asks to revert to "the computer running Kiro Crew". The referent (the gateway host) is unchanged and both readings are defensible. Holding the copy per the conductor's ruling; the maintainer picks the wording.

  • which-computer wording (span=607a1b18651b)

@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 20, 2026
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 21, 2026
@dodgeblaster
dodgeblaster force-pushed the fix/17511-read-aloud-failure-cause branch from 60b2624 to 877c8db Compare October 26, 2026 19:26
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

The Backend Tests (Windows) (4) red here is the pre-existing main failure tracked in #24514 — test/test_telegram_dispatcher.py::TestABusyReplyCarriesItsContext::test_a_declined_steer_with_an_injection_parent_audits_once_at_the_queue and ::test_an_injection_reply_on_the_queue_path_audits_exactly_once (assert [] == ['telegram_reply_parent']). It is not caused by this PR: this diff touches no telegram code. Fix PR #24531 is in flight on main.

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 26, 2026
@dodgeblaster
dodgeblaster force-pushed the fix/17511-read-aloud-failure-cause branch from 877c8db to 8d463db Compare October 26, 2026 20:04
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: a voiceFailureMessage() branch mapping voice_unavailable to the no-engine notice

  • Item 1 shows a no-engine remedy for causes that aren't a missing engine — symptom-level

fixed in 8d463db: applied the subtraction this blocker named. voice_unavailable is raised at three sites (chat_voice.py:682 no-engine, :542 Polly no chunks, :630 registered provider no chunks), so a notice keyed on it names "install a speech engine" for a Polly/registered failure that needs no engine.
Removed the voice_unavailable branch from voiceFailureMessage() and the system_no_engine strings from every catalog; the no-engine case keeps the generic notice (and the desktop client-speech fallback), and the PR now ships only the Polly-rejected half.

@dodgeblaster

Copy link
Copy Markdown
Contributor Author

The Integration (in-process gateway) red here is the pre-existing main failure tracked in #24528 — test/integration/test_boot_smoke.py::test_a_second_boot_touches_only_known_module_globals sees two unlisted module globals (kiro_crew.executors._memory_background_pool, kiro_crew.vector_memory_lifecycle._loop_lock_sites) introduced by #24290. It is not caused by this PR: this diff touches none of those modules (only voice_reply.py, the voice tests, the frontend notice/i18n, and the voice-streaming spec).

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 26, 2026
@dodgeblaster
dodgeblaster marked this pull request as ready for review October 27, 2026 16:03
@dodgeblaster
dodgeblaster requested review from a team and KiroCrewCaptain as code owners October 27, 2026 16:03
@dodgeblaster
dodgeblaster force-pushed the fix/17511-read-aloud-failure-cause branch from 8d463db to a6e1338 Compare November 2, 2026 03:43
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 2, 2026
Read aloud showed one generic "Read aloud failed" notice for every
failure, so the user could not tell which setting to change. #17680 fixed
the Polly consent mismatch; the Polly engine/region rejection #17511
reports still fell through to the generic notice.

An Amazon Polly request AWS rejected (an engine a region does not support)
returned no audio for every sentence and ended in the generic notice.
_synthesize_polly now raises voice_polly_rejected at the first rejection on
the person-waiting path (streaming_voice_reply) instead of being retried
once per sentence; the notice names the rejection and points at the
engine/region settings. _classify_polly_failure matches only that one
failure from the CLI stderr, because it is the only AWS failure whose fix
is the action the notice names and the only one that repeats for every
sentence. A credential/access error or a sentence-scoped SSML error keeps
the None/skip-per-sentence path and the generic notice. The AWS message
can echo the request text, so it stays in the gateway log and the notice
text is fixed. Unattended callers keep the text fallback.

The notice string is added to every locale catalog; unknown codes keep the
generic sentence.

Fixes #17511
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 2, 2026
@dodgeblaster
dodgeblaster force-pushed the fix/17511-read-aloud-failure-cause branch from a6e1338 to f5b01c5 Compare November 2, 2026 04:12
@dodgeblaster

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: voice_polly_rejected joins voice_unavailable as a client-speech fallback code

  • Polly region rejection now skips the client-speech fallback (voice_reply.py:1148)

fixed in f5b01c5: verified the path — tryClientFallback only accepted voice_unavailable, so the new raise turned a manual Read aloud that used to fall back to the webview's own engine into a notice with no audio.
chat_voice.py now carries speakable on every code in _CLIENT_FALLBACK_CODES (voice_unavailable, voice_polly_rejected), and voicePlayback.ts accepts both. A fallback-allowed Read aloud speaks on the client; a request without the fallback still gets the cause notice.
Tests: test_polly_aws_rejection_reaches_the_client_with_its_code asserts speakable on both payloads; clientSpeechFallback.test.tsx adds the voice_polly_rejected fallback case. Both fail with the fix reverted.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 2, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE, reviewed at f5b01c5.

The fix is narrow and fails safe. Only the engine/region-unsupported Polly rejection becomes voice_polly_rejected, and only on the dashboard path (voice_reply.py#L1133-L1151). The raised text is fixed, so no AWS stderr reaches the UI. Every other failure keeps the skip-per-sentence path. The client-speech fallback still works for the new code (voicePlayback.ts#L107). All AI lanes pass on this head, CI is green, and there are no change requests.

AI findings judged non-blocking

  • UX (note): the notice says "Region" while the settings field reads "AWS Region (Amazon Polly)". This is a wording nit, and the field is still easy to find. en.manual.json#L1637
  • Design (note 1): when the fallback is allowed, the webview speaks the reply and no notice is shown. This matches the existing voice_unavailable behaviour and is stated in the PR. chat_voice.py#L73
  • Design (note 2): the classifier matches on stderr text. If AWS rewords the message, the result is the pre-PR generic notice, so nothing gets worse. voice_reply.py#L961-L989

Tests were read and CI results checked; nothing was run locally.

— crew-pr-reviewer (r141)

@iamwhatever
iamwhatever enabled auto-merge (squash) November 2, 2026 18:53
@iamwhatever
iamwhatever merged commit 921770f into main Nov 2, 2026
96 checks passed
@iamwhatever
iamwhatever deleted the fix/17511-read-aloud-failure-cause branch November 2, 2026 18:54
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read aloud shows the same generic notice for every failure, hiding the cause

2 participants