Skip to content

fix(settings): plainer wording for the full-titles-on-scroll setting - #22547

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/scroll-peek-description
Oct 26, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/scroll-peek-description

Conversation

@Pearcekieser

@Pearcekieser Pearcekieser commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: make the "Full titles on scroll" setting's description readable on the first pass.

The description under the "Full titles on scroll" setting reads "While you scroll the session list, titles the sidebar cuts off show in full". The UX review on #20109 found it hard to parse on a first read, because "titles the sidebar cuts off" is a reduced relative clause that reads like a verb phrase until the second verb arrives. That finding was deferred to this PR so #20109 could merge without another review round.

Why it matters

The setting's description is the only explanation a user gets for what the toggle does. A sentence that needs a second read makes a small setting look harder than it is.

Not a goal

No change to the scroll peek itself, the setting's name, its default, or any translated string.

What changed (motivation → approach → change)

The English description now reads "While you scroll the session list, cut-off titles show in full", the wording the UX review suggested. The 12 translated strings already put "titles cut off by the sidebar" in their own natural order, so they keep their meaning and are not touched. The pseudo-locale is regenerated with npm run i18n:pseudo, and the settings registry with npm run gen:settings, which updates settings-registry.generated.json and settingsRegistry.gen.ts. The screenshot capture script matches the hint by its text, so its string is updated too.

Backwards compatibility

Text only. No setting key, value or default changes.

Tests

  • npm run i18n:check with I18N_BASE_REF=origin/main passes.
  • tsc -p tsconfig.app.json passes.
  • vitest on src/components/commandPalette and src/pages/settings, 55 files and 964 tests, passes.
  • test/test_settings_deeplink_registry.py, 8 tests, passes.

Manual verification

Built the SPA with vite build and opened Settings > Chat > Sessions against the stub dashboard API. Hovering the info icon beside "Show Full Titles While Scrolling" shows the new sentence, as in the screenshot below.

Screenshots / video

The reworded hint as it renders in Settings > Chat > Sessions, captured from the built SPA with scripts/capture-sidebar-scroll-peek.mjs (settings frame only; the script asserts the new text is visible):

Show Full Titles While Scrolling hint reading: While you scroll the session list, cut-off titles show in full

Related Issues

Follow-up to #20109. Mirrors Pearcekieser#42, from the #20109 UX review (span 0ac617ef3b8e).

Pattern harvest

Not generalizable: one sentence of copy that a reviewer found hard to read. No rule or check would have caught it.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

Fixes #22546

@Pearcekieser
Pearcekieser requested review from a team and KiroCrewCaptain as code owners October 20, 2026 19:21
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ✅ PASS

UX-level review of 10f50c7aa8c51d48c8c3976656fc1cde1b5e5c3b via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the reworded hint is the only user-visible change, and attachment-01 shows it rendered. This lane has no blind read, so nobody new to the product has read the new wording yet.

[UX-REVIEWED] 10f50c7

Description read

[DESCRIPTION-READ] ef7aeda814f5339ec40fda8dc72e12d3fbd1d672c8802109ce6e2ecb90e06fa2

That sha256 names everything this verdict read: the PR description, plus the 4 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of 10f50c7aa8c51d48c8c3976656fc1cde1b5e5c3b via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (3 items) — 3 justified

Intent: make the "Full titles on scroll" setting's description readable on the first pass. This is a FIX (copy only).

  1. The English hint under "Show Full Titles While Scrolling" now reads "…cut-off titles show in full". Tag: justified
  2. The command-palette and settings-registry hint copies, plus the pseudo-locale, were regenerated to match. Tag: justified
  3. The screenshot capture script now matches the new hint text. Tag: justified

[FIRST-PRINCIPLES-REVIEWED] 10f50c7

Description read

[DESCRIPTION-READ] 9d1f3655db7d0596a3c6c3b7a0b0ef72e2e41202760b9471cf475796c73a26ab

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 10f50c7aa8c51d48c8c3976656fc1cde1b5e5c3b via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Copy-only change: one English hint string, its generated mirrors and the pseudo-locale. A screenshot of this revision is attached, and nothing outside the patch reads the old string.

[DESIGN-REVIEWED] 10f50c7

Description read

[DESCRIPTION-READ] 77d9eeac963986a12cf71b6bfa4cd7ce640644773e4b0e97ecbb496144263d3b

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 10f50c7aa8c51d48c8c3976656fc1cde1b5e5c3b via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 10f50c7

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 10f50c7aa8c51d48c8c3976656fc1cde1b5e5c3b via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 10f50c7

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 20, 2026
The description now reads 'While you scroll the session list, cut-off
titles show in full'. The UX review on kirodotdev#20109 found 'titles the sidebar
cuts off show in full' hard to parse on a first read. The translated
strings already say the same thing in their own word order, so only the
English source, the pseudo-locale and the generated settings registry
change.
@iamwhatever
iamwhatever force-pushed the fix/scroll-peek-description branch from d4e0149 to 10f50c7 Compare October 26, 2026 05:54
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 26, 2026
@iamwhatever iamwhatever self-assigned this Oct 26, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. Copy-only change: the English hint for 'Show Full Titles While Scrolling' is reworded, and the generated settings registries, the pseudo-locale and the capture script follow it. No other reference to the old string remains at this head (en.json L9346). Translations are untouched, as the description says, and all five AI lanes pass with nothing to answer. All checks on this head are green.

Reviewed head: 10f50c7

— crew-pr-reviewer (r127)

@iamwhatever
iamwhatever merged commit 8159b8b into kirodotdev:main Oct 26, 2026
105 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings: plainer wording for the full-titles-on-scroll description

2 participants