Repository navigation
fix(settings): plainer wording for the full-titles-on-scroll setting - #22547
Conversation
UX Review (Opus 5.5, fork) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the reworded hint is the only user-visible change, and attachment-01 shows it rendered. This lane has no blind read, so nobody new to the product has read the new wording yet. [UX-REVIEWED] 10f50c7 Description read[DESCRIPTION-READ] ef7aeda814f5339ec40fda8dc72e12d3fbd1d672c8802109ce6e2ecb90e06fa2 That sha256 names everything this verdict read: the PR description, plus the 4 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (3 items) — 3 justifiedIntent: make the "Full titles on scroll" setting's description readable on the first pass. This is a FIX (copy only).
[FIRST-PRINCIPLES-REVIEWED] 10f50c7 Description read[DESCRIPTION-READ] 9d1f3655db7d0596a3c6c3b7a0b0ef72e2e41202760b9471cf475796c73a26ab That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Copy-only change: one English hint string, its generated mirrors and the pseudo-locale. A screenshot of this revision is attached, and nothing outside the patch reads the old string. [DESIGN-REVIEWED] 10f50c7 Description read[DESCRIPTION-READ] 77d9eeac963986a12cf71b6bfa4cd7ce640644773e4b0e97ecbb496144263d3b That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
The description now reads 'While you scroll the session list, cut-off titles show in full'. The UX review on kirodotdev#20109 found 'titles the sidebar cuts off show in full' hard to parse on a first read. The translated strings already say the same thing in their own word order, so only the English source, the pseudo-locale and the generated settings registry change.
d4e0149 to
10f50c7
Compare
iamwhatever
left a comment
There was a problem hiding this comment.
Approve. Copy-only change: the English hint for 'Show Full Titles While Scrolling' is reworded, and the generated settings registries, the pseudo-locale and the capture script follow it. No other reference to the old string remains at this head (en.json L9346). Translations are untouched, as the description says, and all five AI lanes pass with nothing to answer. All checks on this head are green.
Reviewed head: 10f50c7
— crew-pr-reviewer (r127)
Problem / Motivation
Goal: make the "Full titles on scroll" setting's description readable on the first pass.
The description under the "Full titles on scroll" setting reads "While you scroll the session list, titles the sidebar cuts off show in full". The UX review on #20109 found it hard to parse on a first read, because "titles the sidebar cuts off" is a reduced relative clause that reads like a verb phrase until the second verb arrives. That finding was deferred to this PR so #20109 could merge without another review round.
Why it matters
The setting's description is the only explanation a user gets for what the toggle does. A sentence that needs a second read makes a small setting look harder than it is.
Not a goal
No change to the scroll peek itself, the setting's name, its default, or any translated string.
What changed (motivation → approach → change)
The English description now reads "While you scroll the session list, cut-off titles show in full", the wording the UX review suggested. The 12 translated strings already put "titles cut off by the sidebar" in their own natural order, so they keep their meaning and are not touched. The pseudo-locale is regenerated with
npm run i18n:pseudo, and the settings registry withnpm run gen:settings, which updatessettings-registry.generated.jsonandsettingsRegistry.gen.ts. The screenshot capture script matches the hint by its text, so its string is updated too.Backwards compatibility
Text only. No setting key, value or default changes.
Tests
npm run i18n:checkwithI18N_BASE_REF=origin/mainpasses.tsc -p tsconfig.app.jsonpasses.src/components/commandPaletteandsrc/pages/settings, 55 files and 964 tests, passes.test/test_settings_deeplink_registry.py, 8 tests, passes.Manual verification
Built the SPA with
vite buildand opened Settings > Chat > Sessions against the stub dashboard API. Hovering the info icon beside "Show Full Titles While Scrolling" shows the new sentence, as in the screenshot below.Screenshots / video
The reworded hint as it renders in Settings > Chat > Sessions, captured from the built SPA with
scripts/capture-sidebar-scroll-peek.mjs(settings frame only; the script asserts the new text is visible):Related Issues
Follow-up to #20109. Mirrors Pearcekieser#42, from the #20109 UX review (span 0ac617ef3b8e).
Pattern harvest
Not generalizable: one sentence of copy that a reviewer found hard to read. No rule or check would have caught it.
Checklist
Contribution License Agreement
Contributed under the project's Apache-2.0 license.
Fixes #22546