Repository navigation
feat(dashboard): explain what the Older Sessions pane lists - #22563
Conversation
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 621264b Description read[DESCRIPTION-READ] a43e38d7c0d5024a1ce32e8f74af398bc733dbd90bb42429a3db7ed56feafa68 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS No first-time reader has seen the new ⓘ tip, and the glyph sits inside a Watch
[UX-REVIEWED] 621264b Description read[DESCRIPTION-READ] e75cdada123023337094033d7da20577ae4dcff860d47afa4f8ece525ea940c5 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check that the Clear button's Enter fix is accepted as a declared rider. It is a separate behaviour change bundled into a tooltip PR. Inventory (4 items) — 3 justifiedIntent: help a sidebar reader see from the header that "Older Sessions" lists every saved session not open as a tab, whatever its age. This is an ADDITION (part of #18235).
The new keydown guard is not a third way of doing this. The same [FIRST-PRINCIPLES-REVIEWED] 621264b Description read[DESCRIPTION-READ] 40fcf6bf351b7f28fd0b022fb90d034de51bad8afb56236f555fbc36c5b09aa1 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
|
|
|
|
|
7ac1cef to
04d22c9
Compare
|
|
|
|
|
|
04d22c9 to
10b2bfa
Compare
Add an InfoTip beside the "Older Sessions" label in the chat sidebar. The pane is the complement of the open tabs (the server filters `GET /api/sessions` with exclude_open=1 and user_only=1), so a chat closed a minute ago sits under TODAY while subagent and workflow transcripts and never-used tabs are left out. Nothing in the label said so. The tip states that rule in the sidebar's own words; the copy is added to all 12 catalogs and the pseudolocale is regenerated. The header row toggles on Enter/Space with preventDefault, which also cancelled the native activation of any control inside it (the Clear button, and now the glyph). The handler ignores keys whose target is not the row itself, the guard the history rows already use, so the glyph pins its tip and Clear clears. A render test pins the glyph, that its copy names the real rule, and that neither a click nor Enter/Space on it toggles the pane.
10b2bfa to
621264b
Compare
|
|
|
|
|
|
|
iamwhatever
left a comment
There was a problem hiding this comment.
APPROVE at 621264b. The change adds an InfoTip to the Older Sessions header and one target guard on the row's keydown (HistoryPane.tsx#L68). That guard matches the one already at L244, and it also fixes Enter on Clear. The InfoTip stops click propagation itself. Every current-head UX and First Principles item has a reasoned reply. The label rename is deferred to #18235, which covers that naming question. Base is main, the PR is mergeable, and every check on this head is green.
— crew-pr-reviewer (r116)
Problem / Motivation
Goal: A reader of the sessions sidebar can learn, from the Older Sessions header itself, what that pane lists.
The pane is titled "Older Sessions", but age plays no part in what it holds. Its rule is "every saved session that is not open as a tab right now": a session closed a moment ago is listed there under TODAY, and so are Slack and Discord chats. Nothing in the UI says so, so the title keeps misleading, and a user who just closed a chat looks for it elsewhere.
Why it matters
Every dashboard user sees this header. Without the explanation, people misread the pane: they hunt for a just-closed chat in the open list, or assume channel conversations are missing. One sentence at the point of confusion removes that guesswork at near-zero cost.
Not a goal
GET /api/sessions?exclude_open=1&user_only=1is unchanged).InfoTipcomponent itself.What changed (motivation → approach → change)
The header now carries an ⓘ glyph. Hover, focus or tap shows a tip that states the pane's real rule.
website/src/pages/chat-sidebar/HistoryPane.tsxwebsite/src/i18n/locales/*.jsonpages.chatSidebar.older_sessions_tipin all 12 catalogs,en-XAregeneratedThe tip copy, in plain words, restates the server's own filter for this list (
handlers/sessions_parts/history_reads.py): every saved session not open as a tab, whatever its age, Slack or Discord chats included; opening one brings it back as a tab. Two sentences, 28 words, using the header's own word "session". A code comment beside the glyph names that filter so the copy moves with it.The glyph is the existing
InfoTipcomponent, the same one Settings rows use, so readers meet one pattern. The row is arole="button"whose keydown handler cancelled Enter and Space from anywhere inside it. The glyph needs those keys, so the handler now ignores keys whose target is a control inside the row. The same guard fixes a pre-existing bug: Enter on the Clear button collapsed the pane instead of clearing it; a test presses Enter on Clear and fails without the guard.Backwards compatibility
Compatible: one catalog key and one glyph are added; no API, config, storage or route changes. The only behaviour that differs is Enter or Space pressed while focus is on the Clear button, which now activates Clear instead of collapsing the pane.
Removes nothing: the pane, its server rule, the Clear button and the row's own Enter/Space toggle all stay.
Tests
website/src/test/ChatSidebar.olderSessionsTip.test.tsxrenders the real sidebar against the English catalog:role="tooltip",titledropped while open) and leavesaria-expandedon the row untouched, with no history fetch;confirmnever answers yes. Without the row's target guard this test fails.Catalog gates on the changed values:
i18n:check19/19 pass withI18N_BASE_REF=origin/main,vitest src/i18n50 files / 1022 tests pass.Manual verification
Built SPA (
website/dist) served with stubbed/api/**through the same harness asscripts/capture-older-sessions-header.mjs:aria-expandedunchanged;playwright/sidebar-hairline-alignment.spec.tsstill readsrailHairlineY == olderHairlineY;window.confirmstubbed to answer no, so nothing is deleted).Screenshots / video
Related Issues
Part of #18235 (this PR explains the Older Sessions group; the lifecycle redesign that issue asks for stays open)
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)