Skip to content

feat(dashboard): explain what the Older Sessions pane lists - #22563

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
rkeely:feat/older-sessions-infotip
Oct 21, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
rkeely:feat/older-sessions-infotip

Conversation

@rkeely

@rkeely rkeely commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A reader of the sessions sidebar can learn, from the Older Sessions header itself, what that pane lists.

The pane is titled "Older Sessions", but age plays no part in what it holds. Its rule is "every saved session that is not open as a tab right now": a session closed a moment ago is listed there under TODAY, and so are Slack and Discord chats. Nothing in the UI says so, so the title keeps misleading, and a user who just closed a chat looks for it elsewhere.

Why it matters

Every dashboard user sees this header. Without the explanation, people misread the pane: they hunt for a just-closed chat in the open list, or assume channel conversations are missing. One sentence at the point of confusion removes that guesswork at near-zero cost.

Not a goal

  • Renaming the pane or changing which sessions the server lists (GET /api/sessions?exclude_open=1&user_only=1 is unchanged).
  • A tip on any other sidebar section.
  • Any change to the InfoTip component itself.

What changed (motivation → approach → change)

The header now carries an ⓘ glyph. Hover, focus or tap shows a tip that states the pane's real rule.

Where What a user sees
Older Sessions header, website/src/pages/chat-sidebar/HistoryPane.tsx An ⓘ glyph after the label; hover, focus or tap shows the tip
Same header, keyboard Enter and Space on the glyph or on the Clear button act on that control; only Enter and Space on the row itself toggle the pane
website/src/i18n/locales/*.json New key pages.chatSidebar.older_sessions_tip in all 12 catalogs, en-XA regenerated

The tip copy, in plain words, restates the server's own filter for this list (handlers/sessions_parts/history_reads.py): every saved session not open as a tab, whatever its age, Slack or Discord chats included; opening one brings it back as a tab. Two sentences, 28 words, using the header's own word "session". A code comment beside the glyph names that filter so the copy moves with it.

The glyph is the existing InfoTip component, the same one Settings rows use, so readers meet one pattern. The row is a role="button" whose keydown handler cancelled Enter and Space from anywhere inside it. The glyph needs those keys, so the handler now ignores keys whose target is a control inside the row. The same guard fixes a pre-existing bug: Enter on the Clear button collapsed the pane instead of clearing it; a test presses Enter on Clear and fails without the guard.

Backwards compatibility

Compatible: one catalog key and one glyph are added; no API, config, storage or route changes. The only behaviour that differs is Enter or Space pressed while focus is on the Clear button, which now activates Clear instead of collapsing the pane.

Removes nothing: the pane, its server rule, the Clear button and the row's own Enter/Space toggle all stay.

Tests

website/src/test/ChatSidebar.olderSessionsTip.test.tsx renders the real sidebar against the English catalog:

  • the glyph is in the header and its tip is the real rule (every saved session, not open as a tab, just closed, Slack or Discord, bring it back as a tab);
  • a click on the glyph pins the tip (role="tooltip", title dropped while open) and leaves aria-expanded on the row untouched, with no history fetch;
  • Enter and Space on the focused glyph are not cancelled by the row and do not toggle the pane, while Enter on the row itself still does;
  • Enter on the Clear button inside the open pane reaches Clear: the keydown is not cancelled by the row, the pane stays open, and the stubbed confirm never answers yes. Without the row's target guard this test fails.

Catalog gates on the changed values: i18n:check 19/19 pass with I18N_BASE_REF=origin/main, vitest src/i18n 50 files / 1022 tests pass.

Manual verification

Built SPA (website/dist) served with stubbed /api/** through the same harness as scripts/capture-older-sessions-header.mjs:

  • hover opens the tip beside the glyph; focus opens it at once; Enter on the focused glyph leaves aria-expanded unchanged;
  • the collapsed row stays 44px tall: the 16px glyph matches the 16px chevron that already set the row's content height, and the hairline probe from playwright/sidebar-hairline-alignment.spec.ts still reads railHairlineY == olderHairlineY;
  • with the pane open the header holds the label, glyph, Delete all button and chevron on one row; in the longest locale (ru, "Более старые сессии") the label wraps and the row grows, with no truncation and the glyph clear of the button;
  • in a real browser, Enter on the focused Delete all button runs its confirm once and leaves the pane open (window.confirm stubbed to answer no, so nothing is deleted).

Screenshots / video

Older Sessions header at rest, with the new ⓘ glyph after the label

Hovering the glyph shows the tip beside it

Focused glyph shows the same tip; Enter on it leaves the pane as it was

Pane open in the ru locale: the wrapped label, the glyph, the Delete all button and the chevron share the header row with no truncation

Related Issues

Part of #18235 (this PR explains the Older Sessions group; the lifecycle redesign that issue asks for stays open)

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@rkeely
rkeely requested review from a team and KiroCrewCaptain as code owners October 20, 2026 20:38
@rkeely
rkeely requested a review from CrysisDeu October 20, 2026 20:38
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 621264b00e8d0e15428d25464963f04b2ab74adc via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 621264b

Description read

[DESCRIPTION-READ] a43e38d7c0d5024a1ce32e8f74af398bc733dbd90bb42429a3db7ed56feafa68

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — 🟡 CONCERNS

UX-level review of 621264b00e8d0e15428d25464963f04b2ab74adc via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

No first-time reader has seen the new ⓘ tip, and the glyph sits inside a role="button" row, so screen readers may not reach it.

Watch

  • Screen-reader users may not reach the glyph. The diff adds <InfoTip …/> inside <div role="button" … aria-label>. ARIA treats everything inside a button as presentational, so many screen readers announce only "Older sessions, button" and skip the tip. They miss the one sentence this PR adds, every visit. That matters, but Clear already lives in the same row. The smallest fix is to move the glyph out of the row's role="button" element (for example, make the label-and-chevron part the button and put the glyph beside it), or to point aria-describedby on the row at the tip text.
  • The Russian header separates the glyph from its label. In attachment-04, "Более старые сессии" wraps onto three lines and the ⓘ floats beside the middle line, right next to "Очистить". It reads as belonging to Clear rather than to the title. This only affects long locales, so it is friction rather than a failure. Fix it by keeping the glyph inline with the label's last line, or by letting only the label shrink while the glyph stays attached to the text.

[UX-REVIEWED] 621264b

Description read

[DESCRIPTION-READ] e75cdada123023337094033d7da20577ae4dcff860d47afa4f8ece525ea940c5

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of 621264b00e8d0e15428d25464963f04b2ab74adc via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check that the Clear button's Enter fix is accepted as a declared rider. It is a separate behaviour change bundled into a tooltip PR.

Inventory (4 items) — 3 justified

Intent: help a sidebar reader see from the header that "Older Sessions" lists every saved session not open as a tab, whatever its age. This is an ADDITION (part of #18235).

  1. An ⓘ glyph after the "Older Sessions" label; hover, focus or tap shows what the pane lists — justified
  2. New tip copy in all 12 locale catalogs, with en-XA regenerated — justified
  3. Enter or Space on the glyph no longer toggles the pane; the row reacts only to keys pressed on the row itself — justified
  4. Enter on the open pane's Clear button now runs Clear instead of collapsing the pane — rides along; declared, with a test that fails on base

The new keydown guard is not a third way of doing this. The same e.target !== e.currentTarget check already exists at SessionRow.tsx:1198 and HistoryPane.tsx:233. I grepped website/src/pages/chat-sidebar for the old unguarded handler and found 1 match, the one this PR changes, so no unfixed siblings remain there. No default changes and no decision in docs/decisions/ is touched. The 2026-09-05 "Show all older sessions" entry covers row placement, not this header.

[FIRST-PRINCIPLES-REVIEWED] 621264b

Description read

[DESCRIPTION-READ] 40fcf6bf351b7f28fd0b022fb90d034de51bad8afb56236f555fbc36c5b09aa1

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 621264b00e8d0e15428d25464963f04b2ab74adc via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 621264b

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 621264b00e8d0e15428d25464963f04b2ab74adc via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 621264b

@rkeely

rkeely commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author
  • The tip is long and hard to scan (span=867429ad4e2d) — fixed in 9c67b24dba

fixed: older_sessions_tip is now 41 words in three one-fact sentences (was ~55 words with a semicolon joining an included list and an excluded list).
The bubble renders five lines instead of seven in the same 300px width (hover capture in the description, 119px tall vs 158px before).
The exclusion survives as one plain clause because the Design and First Principles lanes asked that the copy stay faithful to _MACHINE_NAMESPACES.

@rkeely

rkeely commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author
  • "subagent and workflow transcripts" is internal vocabulary (span=17fd8a7fb888) — fixed in 9c67b24dba

fixed: the clause now reads "Background transcripts the app makes for itself are left out." Neither "subagent" nor "workflow" appears in any of the 12 catalogs.
The plain wording also covers the secretary and channel namespaces the old copy omitted (history_reads.py _MACHINE_NAMESPACES).

@rkeely

rkeely commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author
  • Suggested shorter copy for older_sessions_tip (span=ede22cd34b72) — fixed in 9c67b24dba, with one addition

fixed: adopted the suggestion's shape ("Every saved conversation not open as a tab right now … Open one to bring it back as a tab.").
Kept one short exclusion sentence the suggestion dropped, because Design and First Principles both asked that the tip restate the server filter, which excludes machine-made transcripts.

@rkeely

rkeely commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author
  • The tip copy repeats the server filter by hand; is a code comment enough to keep it in sync? — answered

rebutted as disproportional: the filter (_MACHINE_NAMESPACES, user_only) lives in history_reads.py and the copy lives in 12 i18n catalogs, so no single source can feed both without a build-time generator for one tooltip.
The copy in 9c67b24dba names no namespace; it says "background transcripts the app makes for itself", which stays true when a namespace is added or renamed. The code comment beside the glyph names the filter so an editor of either side finds the other.
A test (ChatSidebar.olderSessionsTip.test.tsx) asserts each clause of the tip, so a rewrite that drops a fact fails in CI rather than in a user's hover.

@rkeely

rkeely commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author
  • The copy named only subagent/workflow transcripts, but _MACHINE_NAMESPACES also excludes secretary and channel — fixed in 9c67b24dba

fixed: the exclusion sentence no longer enumerates namespaces; "Background transcripts the app makes for itself are left out" covers subagent, secretary, channel and every wf* namespace alike.
Verified the remaining inclusion claim against code: Slack/Discord sessions live in CHANNEL_SESSION_NAMESPACES (constants.py), not in the excluded channel namespace, which is the agent-to-agent channel feature (channel.py mints channel:<id>:<agent>).

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Oct 20, 2026
@rkeely
rkeely force-pushed the feat/older-sessions-infotip branch from 7ac1cef to 04d22c9 Compare October 20, 2026 21:34
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Oct 20, 2026
@rkeely

rkeely commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author
  • One of the three tip sentences gives the user nothing to act on (span=7add97f733b9) — fixed in 10b2bfa

fixed: the sentence "Background transcripts the app makes for itself are left out." is removed from older_sessions_tip in all 13 catalogs (12 hand-translated, en-XA regenerated).
The tip is now two sentences, 28 words, and renders four lines in the 300px bubble (hover and focus captures in the description).
The code comment beside the glyph (HistoryPane.tsx) no longer mentions machine transcripts either, so copy and comment agree.

@rkeely

rkeely commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author
  • The tip uses different words from the header it explains (span=f37c0207b9c7) — fixed in 10b2bfa

fixed: the tip opens with "Lists every saved session not open as a tab", the header's own word; "conversation" no longer appears in any catalog's older_sessions_tip.
Each translation uses the same word for "session" as its own older_sessions_2 header (Sitzung, sesión, セッション, 세션, 会话, сессии, …), checked per catalog by the verifier.
"Slack or Discord chats" is kept as the suggestion wrote it; it names where those sessions come from, not what the rows are.

@rkeely

rkeely commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author
  • Suggested copy for older_sessions_tip (span=77cad61e6fcc) — fixed in 10b2bfa, adopted verbatim

fixed: en.json older_sessions_tip is byte-for-byte the suggested text: "Lists every saved session not open as a tab, including ones you just closed and Slack or Discord chats. Open one to bring it back as a tab."
Nothing was added this time: the exclusion sentence the previous round kept is gone (see the separate record for that Watch item), so the tip states only what the list holds and what opening a row does.
ChatSidebar.olderSessionsTip.test.tsx asserts each clause of the new copy, so a later rewrite that drops one fails in CI.

@rkeely

rkeely commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author
  • The tip's exclusion sentence overclaims against _MACHINE_NAMESPACES (span=07dab818773f) — fixed in 10b2bfa

fixed: the sentence "Background transcripts the app makes for itself are left out." is removed from older_sessions_tip in all 13 catalogs. The tip now makes no exclusion claim at all.
The finding is correct on the code: history_reads.py _MACHINE_NAMESPACES deliberately keeps cron, side and taskrunner listed, so a hide_in_chat cron run does appear in the pane and the old sentence was false for it.
What remains ("every saved session not open as a tab, including ones you just closed and Slack or Discord chats; open one to bring it back as a tab") restates only the exclude_open rule and the channel inclusion, both verified against history_reads.py and constants.py CHANNEL_SESSION_NAMESPACES.

@rkeely

rkeely commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author
  • The code comment says never-used tabs are excluded, but the tip does not mention them — answered; comment aligned in 10b2bfa, tip unchanged on this point

rebutted: the only rows user_only drops beyond the machine namespaces are tabs whose title still equals their storage key and that hold no message (history_reads.py _has_content, ~256-267). Such a row would show a storage key as its label, so it is not a "session" the user recognises or would look for.
Naming it in the tip would reopen the list-of-exclusions shape the UX lane asked to remove in its Watch and Suggestion items; the tip now states what the pane holds, not what it filters.
The code comment beside the glyph (HistoryPane.tsx) was the only place that mentioned never-used tabs; it now names just the exclude_open rule, so comment and copy no longer disagree.

@rkeely

rkeely commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author
  • No test pressed Enter on Clear, so the claimed keyboard fix for Clear was untested — fixed in 10b2bfa

fixed: ChatSidebar.olderSessionsTip.test.tsx adds "Enter on the Clear button reaches Clear instead of collapsing the pane": the pane is opened with a non-empty history mock so Clear renders, Enter is fired on Clear, and the test asserts the keydown was not cancelled and the row stayed aria-expanded="true". window.confirm is stubbed to false so nothing is deleted.
Negative control run by the repair agent: with only the header row's target guard (HistoryPane.tsx:68) removed, this test fails with "keydown Enter on Clear was cancelled by the row"; with the guard restored byte-identical, 4/4 pass under KIROCREW_ACT_STRICT=1.
The production guard itself did not change between 04d22c9 and 10b2bfa; only the test and the copy did.

@rkeely
rkeely force-pushed the feat/older-sessions-infotip branch from 04d22c9 to 10b2bfa Compare October 20, 2026 22:49
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Oct 20, 2026
Add an InfoTip beside the "Older Sessions" label in the chat sidebar.
The pane is the complement of the open tabs (the server filters
`GET /api/sessions` with exclude_open=1 and user_only=1), so a chat
closed a minute ago sits under TODAY while subagent and workflow
transcripts and never-used tabs are left out. Nothing in the label said
so. The tip states that rule in the sidebar's own words; the copy is
added to all 12 catalogs and the pseudolocale is regenerated.

The header row toggles on Enter/Space with preventDefault, which also
cancelled the native activation of any control inside it (the Clear
button, and now the glyph). The handler ignores keys whose target is not
the row itself, the guard the history rows already use, so the glyph
pins its tip and Clear clears.

A render test pins the glyph, that its copy names the real rule, and
that neither a click nor Enter/Space on it toggles the pane.
@rkeely
rkeely force-pushed the feat/older-sessions-infotip branch from 10b2bfa to 621264b Compare October 20, 2026 23:43
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 20, 2026
@rkeely

rkeely commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in the i18n locale catalogs (#21999 added a default-sidebar-folder key) since this head went green (965b374 -> 00968c4); CI re-running. The patch is byte-identical across the rebase.

@rkeely

rkeely commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author
  • The expanded header is not shown (span=03e0331e5abd) — fixed in 621264b

fixed: added one screenshot of the open pane's header in the longest locale (ru, "Более старые сессии") to the description, so the label, the ⓘ glyph, the Delete all button and the chevron are all shown sharing the row.
Verified from the built SPA: the long label wraps and the row grows to fit; nothing truncates and the glyph does not touch the button. The collapsed row stays 44px (hairline probe unchanged, railHairlineY == olderHairlineY).

@rkeely

rkeely commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author
  • The tip contradicts the title it explains (span=37820115bafe) — answered, out of this PR's goal

rebutted as out of goal: renaming the "Older Sessions" header is a user-visible label change this PR's ## Not a goal rules out, and it is tracked in #18235 (linked as "Part of #18235"). This review itself calls it "a known limit, not a defect in this PR".
The frozen goal is that the header explains what the pane lists; the tip is that mechanism. The rename decision belongs to #18235, where the lane suggested raising it, and this PR deliberately does not pre-empt it.

@rkeely

rkeely commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author
  • "every saved session" reads wider than the server filter — answered

rebutted: the rows user_only=1 drops beyond exclude_open are the machine namespaces (subagent, workflow, secretary, cron, side, taskrunner — _MACHINE_NAMESPACES) and untitled empty tabs (_has_content, history_reads.py ~256-267). None is a session a user recognises as one they saved.
This is the same class as the never-used-tabs point already recorded on 04d22c9: naming these exclusions reopens the list-of-exclusions problem the UX lane asked to remove. "Saved session" is the user-facing set the pane shows, not the raw namespace set.

@rkeely

rkeely commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author
  • Check that a real browser runs Clear's confirm when Enter is pressed on Clear — answered in 621264b

verified in a real browser (Chromium, built SPA): with the pane open, focusing the Delete all button and pressing Enter fires its confirm exactly once and leaves aria-expanded true; window.confirm was stubbed to answer no, so nothing was deleted. Recorded under Manual verification.
The jsdom unit test proves the row's guard does not cancel the key; this real-browser run proves the native Enter-on-button activation then reaches Clear's confirm. The "Older" rename stays deferred to #18235 as the premise review notes.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 21, 2026
@rkeely

rkeely commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author
  • Screen-reader users may not reach the glyph (span=119af7cb7a2a) — answered

rebutted: the glyph is its own focusable <button> (InfoTip.tsx) with aria-label="More information", aria-expanded, and the tip text as aria-describedby while open / title while closed. It is a Tab stop that announces its name and the tip when reached; the capture harness focuses it and it takes Enter (ENTER_ON_GLYPH in the evidence), so the help is not skipped.
The nested-interactive shape (an interactive control inside the role="button" row) is pre-existing: origin/main already nests the Clear <button> in that same row (HistoryPane.tsx). This PR adds no role to the row; de-nesting it is the #2887 disclosure-grammar, out of this PR's goal. jsx-a11y passes on the changed file.

@rkeely

rkeely commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author
  • The Russian header separates the glyph from its label (span=37cf4a9e4e9b) — answered

rebutted as disproportional, long-locale-only: the glyph sits immediately after the label text in DOM and reading order, so the association is correct for assistive tech and for every single-line locale (the common case). The drift is the row's items-center vertical centring against a label wrapped to three lines, seen only in the longest locales with the pane open at sidebar width.
Changing that alignment touches the row geometry the PR holds fixed (44px collapsed, railHairlineY == olderHairlineY, verified by the hairline probe). A cosmetic shift in one locale does not justify re-tuning that; the tip, its text and its reading order are unchanged.

@rkeely

rkeely commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author
  • Is the Clear-button Enter fix an accepted declared rider? — answered

declared and not separable: the body's Backwards compatibility names it ("the only behaviour that differs is Enter or Space on the Clear button, which now activates Clear instead of collapsing the pane"). It is the SAME one-line guard the glyph needs — if ((e.target) !== e.currentTarget) return in the row's onKeyDown — which stops the row swallowing Enter/Space from any control inside it.
Removing the Clear half would mean adding a check that singles out the glyph: more code, not less, and it would leave the pre-existing Clear bug in place. One guard, both controls it unblocks; the test presses Enter on each.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 21, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE at 621264b. The change adds an InfoTip to the Older Sessions header and one target guard on the row's keydown (HistoryPane.tsx#L68). That guard matches the one already at L244, and it also fixes Enter on Clear. The InfoTip stops click propagation itself. Every current-head UX and First Principles item has a reasoned reply. The label rename is deferred to #18235, which covers that naming question. Base is main, the PR is mergeable, and every check on this head is green.

— crew-pr-reviewer (r116)

@iamwhatever
iamwhatever merged commit 81bd1ba into kirodotdev:main Oct 21, 2026
100 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants