Repository navigation
fix(dashboard): name a partial last-copy download <stem>.partial.<ext> - #22643
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: a narrow filename fix with a pure helper and a matching spec update. No recorded decision fixes the old [DESIGN-REVIEWED] b6869bb Description read[DESCRIPTION-READ] 2a8775fa5a90297fac82693e4a13835b2b05f6ac09880b28e22f04e8408560bb That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the diff changes no on-screen control, label or state. The only change is the suggested filename of a download ( [UX-REVIEWED] b6869bb Description read[DESCRIPTION-READ] e4406238ec4d897c6b6337d4a0dcf0fd269b6e412cd42d0fc3dfe13f5d46309c That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This is a fix to one download name, and every item in it earns its place. Notes
What this change shipsInventory (4 items) — 4 justifiedIntent: when you save the only copy left of a partly-read file, it should still open in the right app. This is a FIX (part of #14449).
[FIRST-PRINCIPLES-REVIEWED] b6869bb Description read[DESCRIPTION-READ] 859d0d4da5b57b572c854f32e3d3bc2abf42b5f990d9c00858e06b634f85afe6 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
3ad8433 to
52b35b7
Compare
|
self-added: no
|
52b35b7 to
8d332d6
Compare
|
Frontend Tests (1) is red on head 8d332d6 because of It is a main red: it fails the same way locally on origin/main 7e09632. Main's own push CI misses it because it runs only an affected subset (421 of 885 test files). It is tracked by #25941, and the fix is #25944. When #25944 merges, this PR will be rebased onto it. |
8d332d6 to
b6869bb
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (6 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: a partial last-copy download is named .partial. so the OS keeps the file type, with tests. Spec files changed as a ride-along (a minority of the diff on both file count and changed lines), not reviewed as a design decision: docs/system-specs/modules/learn-cron-dashboard.md.
Problem / Motivation
Goal: When you download the last surviving copy of a partial file from the side panel, the saved file keeps its real type.
Downloading a partial last-copy buffer saved it as
release-checklist.md.partial. The OS reads a file by its trailing extension, so a.partialtail makes the download an unknown type — a Markdown file no longer opens as Markdown.Why it matters
The side panel offers this download when a file was deleted on disk and the buffer is the only copy left — the one moment the copy must be easy to keep and reopen. A name that breaks the file association defeats that: the user saves their only copy and then cannot open it in the right app.
Not a goal
What changed (motivation → approach → change)
A partial download was named by appending
.partialafter the whole filename, which left the extension buried mid-name where the OS cannot see it. The fix moves the tag before the extension, sonotes.mdsaves asnotes.partial.mdand still opens as Markdown. A newpartialDownloadNamehelper infileReadUrl.tsinserts the tag before the last extension, and appends it when there is nothing to preserve — a name with no extension, a dotfile whose leading dot is not an extension separator, or a trailing-dot name. The side panel's last-copy download inuseMarkdownPanelDisk.tscalls it for a partial buffer and the plain download name for a whole one; thepartial-prop comment inMarkdownPanel.tsxand the module specdocs/system-specs/modules/learn-cron-dashboard.mdare updated to match.Backwards compatibility
Compatible: this only changes the suggested filename of a browser download; no stored data, API, or contract changes.
Removes nothing: no capability, path, record, or key is removed — a download that was named
name.ext.partialis now namedname.partial.ext.Tests
partialDownloadNameunit tests (fileReadUrl.test.ts): tag goes before the extension (release-checklist.partial.md), before the last extension of a multi-dot name (archive.tar.partial.gz), appended when there is no extension (Makefile.partial,hosts.partial), a leading dot treated as a dotfile marker not an extension (.env.partial), and a trailing-dot name (weird..partial).MarkdownPanel.watchVisibleTab.test.tsxupdated: the partial last-copy download (banner and dialog rescue) now lands asb.partial.md, a whole copy staysb.md.Manual verification
N/A — unit coverage sufficient; the change is the string a download lands under, pinned by the tests above.
Screenshots / video
Why no screenshot: No rendered surface changes — the only user-visible delta is the suggested filename of a browser download, which has no on-screen pixels.
Related Issues
Part of #14449
Pattern harvest
Not generalizable: a one-off naming fix for one download site;
.partialbefore the extension is specific to this last-copy rescue.