Skip to content

feat(apps): add slack-channels-onboard to the app registry - #22664

Merged
KiroCrewCaptain merged 1 commit into
kirodotdev:mainfrom
mvn-bachhuynh-dn:feat/registry-slack-channels-onboard
Nov 1, 2026
Merged

KiroCrewCaptain merged 1 commit into
kirodotdev:mainfrom
mvn-bachhuynh-dn:feat/registry-slack-channels-onboard

Conversation

@mvn-bachhuynh-dn

@mvn-bachhuynh-dn mvn-bachhuynh-dn commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Let users install the Slack Channels Onboard app from the App Store's Discover tab.

Giving a Slack channel its own Kiro Crew agent today means hand-editing config.json: a workspaces.<name> entry, an agents.<name> entry and a slack.channels.<id> binding. Re-pointing a channel at another workspace, or cleaning up after the bot leaves a channel, also means editing JSON by hand. The app mvn-bachhuynh-dn/slack-channels-onboard does this from a dashboard page, but it cannot be found or installed from the store until the core registry lists it.

Why it matters

Operators who run Kiro Crew in several Slack channels can onboard a channel in one click, or automatically when the bot is invited, and manage workspace, activation and thread_follow per channel without touching config.json.

Not a goal

  • No change to Kiro Crew code. The app lives in its own repository; this PR only adds a registry entry pointing at it.
  • No change to Slack access control. Stock Kiro Crew stays owner-only on Slack. When the running gateway does not enforce per-user access, the app's member/maintainer section is shown read-only and its routes answer 409.
  • No featured flag.

What changed (motivation → approach → change)

The publishing guide (§10) lists a third-party app by adding {name, gitUrl, repo, branch} to src/kiro_crew/apps/app-registry.json. The store reads the app's own app.json and images from that repo. This PR appends one entry for slack-channels-onboard, pointing at https://github.com/mvn-bachhuynh-dn/slack-channels-onboard on its release branch. That branch sits at 6a6ad3b, the commit reviewed here; new work lands on the app's main first and is merged into release only after review, so a push to the app repo does not reach store users on its own.

About the app, for review (publishing guide §14):

  • app.json: kebab-case name, semver 1.0.0, minKiroCrewVersion: 0.9.0, tags slack/automation/team (Productivity category).
  • Artwork: 512×512 PNG icon, one screenshot, and 16:9 and 25:6 hero images in light and dark. All of them use mock data.
  • ui/dist/index.mjs is committed. The README lists the Slack scopes and the agent.apps_allow_third_party requirement.
  • The backend runs as in-gateway hooks, so it is third-party executable code and off by default. Every route is owner-only (require_owner_dashboard_request), and every write is SEL-audited.

Backwards compatibility

Compatible: one entry is appended to a JSON list, and existing entries are untouched.

Removes nothing: the diff only adds a registry entry.

Tests

No new tests. The change is data only, and the existing registry tests cover how entries are parsed:

  • test/test_apps_registry.py, test/test_apps_registry_coverage_gates.py, test/test_apps_registry_coverage_characterization.py, test/test_external_registry.py: 306 passed locally with this entry.
  • App repository: 33 backend unit tests pass (python -m pytest tests -q).

Manual verification

  • Installed the app from a local clone on a 0.9.0 gateway, enabled it, and opened its dashboard page. It lists channels, onboards a channel, and edits workspace, activation and thread_follow.
  • Verified that app-registry.json still parses (python -m json.tool).

Related Issues

N/A

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision 6ab473055d34c57091ba05f1d80511967e9041c7 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 6ab473055d34c57091ba05f1d80511967e9041c7 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this adds one registry row that has the same shape as the existing third-party entries, and the store's install path already reads its branch field.

Notes

  • This entry follows a branch tip, not a pinned commit, so whoever controls release in the app repo decides what users install. The "merged into release only after review" step is the app owner's own practice, not something the registry enforces.

[DESIGN-REVIEWED] 6ab4730

Description read

[DESCRIPTION-READ] e0e573279e144c26fabc336568c4f7827b8ad3830b9aee366ccdd1573d5f9bc8

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 6ab473055d34c57091ba05f1d80511967e9041c7 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 6ab4730

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of 6ab473055d34c57091ba05f1d80511967e9041c7 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. The diff adds one data-only registry entry, and the app it lists cannot run unless the user installs it and turns on agent.apps_allow_third_party.

What this change ships

Inventory (2 items) — 2 justified

Intent: let operators find and install a third-party app from the App Store's Discover tab, so they can bind Slack channels to agents without editing config.json by hand. ADDITION.

  1. The Discover tab now lists the third-party app "slack-channels-onboard" — justified
  2. Installs of that app follow its release branch, not main — justified

[FIRST-PRINCIPLES-REVIEWED] 6ab4730

Description read

[DESCRIPTION-READ] 10b45caf9ae9d7111d0c24b37f0e109c1cae108ba881b2556c3de4e80e55cad9

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 6ab473055d34c57091ba05f1d80511967e9041c7 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 6ab4730

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 21, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

HOLD for human review. This row puts third-party gateway code in the App Store, and that code changes who may use the bot on Slack.

Reviewed head: 6aba34e.

The row (

{
"name": "slack-channels-onboard",
"gitUrl": "https://github.com/mvn-bachhuynh-dn/slack-channels-onboard",
"repo": "https://github.com/mvn-bachhuynh-dn/slack-channels-onboard",
"branch": "main"
}
) points the store at mvn-bachhuynh-dn/slack-channels-onboard on branch main. At that branch's current commit 6a6ad3bebd, the app runs backend hooks inside the gateway with network and storage permission. Its routes replace slack.allowed_users, set per-channel maintainers, approved commands and programs, and edit slack.channels bindings (backend/core.py). Third-party apps stay off by default behind agent.apps_allow_third_party, and the routes are described as owner-only. Even so, this is an access-control surface, so a maintainer needs to vouch for it.

Open items:

  • The Design and First Principles lanes both ask a human to confirm that the tracked main branch is the code meant to ship. Nobody has replied on the PR. I confirmed that app.json's name matches. Because the row follows a branch rather than a commit, later pushes to that repo reach users without a review here.

What clears it: a maintainer reviews the app's backend at a specific commit and answers both lane checks on the PR. Pointing the row at a release branch the author controls deliberately would also help, as todo-ledger's row does.

— crew-pr-reviewer (r116)

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 21, 2026
@mvn-bachhuynh-dn

Copy link
Copy Markdown
Contributor Author

Thanks for the review. Answers to both lane checks, and the change you suggested:

  • app.json name: slack-channels-onboard, matching the registry row (as you confirmed).
  • Which code ships: the row now tracks a release branch instead of main (5715204). release points at 6a6ad3b, the commit you reviewed. New work goes to the app's main through a PR, and is merged into release only after review here, so a push to the app repo no longer reaches store users on its own. The first such change is already open as feat: pin an agent backend per channel mvn-bachhuynh-dn/slack-channels-onboard#1 and is not on release.

For the maintainer review, the access-control surface at 6a6ad3b:

  • backend/routes.py: every route calls require_owner_dashboard_request. On a gateway that does not enforce per-user Slack access, the member and maintainer routes answer 409 (access_capabilities() in backend/gateway_ops.py detects each control by the function the gateway exposes).
  • backend/gateway_ops.py: config writes go through update_config_locked; the roles file is written atomically with mode 600; every write is SEL-audited.
  • backend/core.py: pure validation and mutators (user and channel id formats, a command catalog, a never-approvable program list).

The app stays off unless agent.apps_allow_third_party is enabled.

@mvn-bachhuynh-dn
mvn-bachhuynh-dn force-pushed the feat/registry-slack-channels-onboard branch from 2299dcf to e187fe5 Compare October 21, 2026 10:59
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 21, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Oct 21, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 21, 2026
@mvn-bachhuynh-dn

Copy link
Copy Markdown
Contributor Author

Update for the maintainer review: please review the app at 98f8085 (current main) instead of 6a6ad3b. Once that commit is approved, release fast-forwards to it; until then it stays at 6a6ad3b, so nothing below reaches store users unreviewed. The registry row is unchanged (it tracks release), and this PR is now a single commit (e187fe5) after a squash.

Changes since 6a6ad3b (git diff 6a6ad3b 98f8085):

Runtime code (backend + UI, 249 lines across 6 files)

  • 1fe6cb9 Agent backend column: pins agents.<name>.acp_backend (the key proposed in Let a crewmate (or agent template) choose its own agent harness #21910 / feat(crew): let a crew member pin its own ACP backend #16200) for the agent bound to a channel. New owner-only route PUT /backend, SEL-audited (slack_channels_onboard.backend_update). Accepts only a backend in selectable_backends() that probe_backends() reports installed. The column and the route are active only when the running gateway's KiroCrewAgentConfig has an acp_backend field; on a gateway without it the column is hidden and the route refuses, so the app never writes a key that would be dropped.
  • 6e30499 nosemgrep marker on the fixed-host (https://slack.com/api/) urlopen.

Docs and assets only

  • 850a952 AGENTS.md (branch and release rules), CLAUDE.md, Kiro steering pointer.
  • fbea7a0 README screenshots (rendered from the real UI against mocked API responses; all names invented) and a refreshed store screenshot.
  • 042320c, 8081a89, a2f5b3e, f43a8ab gateway-patches/: optional patch sets for the installed package, published for users to read and decide, never installed by the app. The README there states the risks and the tested version. One finding worth flagging: on stock 0.9.0 a Slack chat turn ignores the channel's agent binding (reported as Slack chat turns ignore a channel's Crew agent binding (kiro agent + workspace); cron was fixed in #13422 #22763), so the README now says Set B is needed for the app's core purpose.

Tests: python -m pytest tests -q passes (38).

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 23, 2026
List the Slack Channels Onboard app in the App Store's Discover tab. The
row tracks the app repository's release branch, which sits at the
reviewed commit; new app work reaches release only after review here.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mvn-bachhuynh-dn
mvn-bachhuynh-dn force-pushed the feat/registry-slack-channels-onboard branch from af56c67 to 6ab4730 Compare October 24, 2026 07:42
@mvn-bachhuynh-dn

Copy link
Copy Markdown
Contributor Author

Squashed back to one commit on current main (head 6ab473055d) for PR Hygiene; three 'Merge branch main' commits had been added by the branch-update button. Content unchanged: one registry row tracking the app's release branch. Screenshot Evidence on the previous head was cancelled, not failed; this PR touches no UI.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 24, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

HOLD for human review at 6ab4730.

The diff is one registry row and is well formed. What it ships is the trust decision: the row puts third-party gateway code from mvn-bachhuynh-dn/slack-channels-onboard in the App Store, and that app edits slack.allowed_users, per-channel maintainers, approved commands and slack.channels bindings, so it changes who may use the bot on Slack. The row follows the app's release branch (currently 6a6ad3bebd), not a pinned commit, so later pushes to that branch reach store users without a review here.

Since the r116 hold the author moved the row from main to release and answered the Design and First Principles lane checks. That is an improvement, but no maintainer has yet recorded a review of the app backend at a specific commit.

What clears it: a maintainer reviews the app backend at the commit release points to and records that on this PR (or the project decides on a pinned-commit policy for third-party rows). CI is green and the branch merges cleanly.

Evidence:

{
"name": "slack-channels-onboard",
"gitUrl": "https://github.com/mvn-bachhuynh-dn/slack-channels-onboard",
"repo": "https://github.com/mvn-bachhuynh-dn/slack-channels-onboard",
"branch": "release"
}

— crew-pr-reviewer (r136)

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of the watch holder (bolichen). Lanes pass on 6ab4730, checks green, no conflict, no open change request.

@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 1, 2026 06:43
@KiroCrewCaptain
KiroCrewCaptain merged commit d465242 into kirodotdev:main Nov 1, 2026
104 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants