Repository navigation
feat(apps): add slack-channels-onboard to the app registry - #22664
KiroCrewCaptain merged 1 commit into
Conversation
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this adds one registry row that has the same shape as the existing third-party entries, and the store's install path already reads its Notes
[DESIGN-REVIEWED] 6ab4730 Description read[DESCRIPTION-READ] e0e573279e144c26fabc336568c4f7827b8ad3830b9aee366ccdd1573d5f9bc8 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The diff adds one data-only registry entry, and the app it lists cannot run unless the user installs it and turns on What this change shipsInventory (2 items) — 2 justifiedIntent: let operators find and install a third-party app from the App Store's Discover tab, so they can bind Slack channels to agents without editing
[FIRST-PRINCIPLES-REVIEWED] 6ab4730 Description read[DESCRIPTION-READ] 10b45caf9ae9d7111d0c24b37f0e109c1cae108ba881b2556c3de4e80e55cad9 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
|
HOLD for human review. This row puts third-party gateway code in the App Store, and that code changes who may use the bot on Slack. Reviewed head: 6aba34e. The row ( KiroCrew/src/kiro_crew/apps/app-registry.json Lines 20 to 25 in 6aba34e Open items:
What clears it: a maintainer reviews the app's backend at a specific commit and answers both lane checks on the PR. Pointing the row at a release branch the author controls deliberately would also help, as todo-ledger's row does. — crew-pr-reviewer (r116) |
|
Thanks for the review. Answers to both lane checks, and the change you suggested:
For the maintainer review, the access-control surface at
The app stays off unless |
2299dcf to
e187fe5
Compare
|
Update for the maintainer review: please review the app at Changes since Runtime code (backend + UI, 249 lines across 6 files)
Docs and assets only
Tests: |
List the Slack Channels Onboard app in the App Store's Discover tab. The row tracks the app repository's release branch, which sits at the reviewed commit; new app work reaches release only after review here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
af56c67 to
6ab4730
Compare
|
Squashed back to one commit on current |
|
HOLD for human review at 6ab4730. The diff is one registry row and is well formed. What it ships is the trust decision: the row puts third-party gateway code from mvn-bachhuynh-dn/slack-channels-onboard in the App Store, and that app edits slack.allowed_users, per-channel maintainers, approved commands and slack.channels bindings, so it changes who may use the bot on Slack. The row follows the app's Since the r116 hold the author moved the row from What clears it: a maintainer reviews the app backend at the commit Evidence: KiroCrew/src/kiro_crew/apps/app-registry.json Lines 20 to 25 in 6ab4730 — crew-pr-reviewer (r136) |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved on behalf of the watch holder (bolichen). Lanes pass on 6ab4730, checks green, no conflict, no open change request.
Problem / Motivation
Goal: Let users install the Slack Channels Onboard app from the App Store's Discover tab.
Giving a Slack channel its own Kiro Crew agent today means hand-editing
config.json: aworkspaces.<name>entry, anagents.<name>entry and aslack.channels.<id>binding. Re-pointing a channel at another workspace, or cleaning up after the bot leaves a channel, also means editing JSON by hand. The app mvn-bachhuynh-dn/slack-channels-onboard does this from a dashboard page, but it cannot be found or installed from the store until the core registry lists it.Why it matters
Operators who run Kiro Crew in several Slack channels can onboard a channel in one click, or automatically when the bot is invited, and manage workspace, activation and
thread_followper channel without touchingconfig.json.Not a goal
featuredflag.What changed (motivation → approach → change)
The publishing guide (§10) lists a third-party app by adding
{name, gitUrl, repo, branch}tosrc/kiro_crew/apps/app-registry.json. The store reads the app's ownapp.jsonand images from that repo. This PR appends one entry forslack-channels-onboard, pointing athttps://github.com/mvn-bachhuynh-dn/slack-channels-onboardon itsreleasebranch. That branch sits at6a6ad3b, the commit reviewed here; new work lands on the app'smainfirst and is merged intoreleaseonly after review, so a push to the app repo does not reach store users on its own.About the app, for review (publishing guide §14):
app.json: kebab-case name, semver1.0.0,minKiroCrewVersion: 0.9.0, tagsslack/automation/team(Productivity category).ui/dist/index.mjsis committed. The README lists the Slack scopes and theagent.apps_allow_third_partyrequirement.require_owner_dashboard_request), and every write is SEL-audited.Backwards compatibility
Compatible: one entry is appended to a JSON list, and existing entries are untouched.
Removes nothing: the diff only adds a registry entry.
Tests
No new tests. The change is data only, and the existing registry tests cover how entries are parsed:
test/test_apps_registry.py,test/test_apps_registry_coverage_gates.py,test/test_apps_registry_coverage_characterization.py,test/test_external_registry.py: 306 passed locally with this entry.python -m pytest tests -q).Manual verification
thread_follow.app-registry.jsonstill parses (python -m json.tool).Related Issues
N/A
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.