Skip to content

docs(rfc): restore the index audit-note sentences that #22280's merge dropped - #22691

Merged
bolichen97 merged 1 commit into
mainfrom
docs/rfc-index-restore-audit-note
Oct 21, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
docs/rfc-index-restore-audit-note

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Put back the three sentences the RFC index's audit note lost when #22280 merged.

#22280 merged as cbada20f26. Its last head was c5fdc47024, a GitHub web "Update branch" merge of main into the PR branch. That merge resolved a conflict on the audit-note line of docs/request-for-change/README.md by keeping the PR's own copy of the line. Main's copy had gained three sentences since the PR branched, and the merge dropped all three:

Sentence Added by
The rfc-python-rust-hybrid-backend row was re-audited 2026-10-19 against 207ed5ae4c for a new §2.4 #22065
The rfc-gated-pr-poll-loops row was added 2026-10-20 as draft and verified against 6432cad9ea #22440
The rfc-crewmate-heartbeat row was added 2026-10-15 as accepted and verified against 8da5b41552 #20934

Why it matters

The audit note is the index's record of when each row was added or re-audited, and against which commit. Without these sentences, three rows lose their record. Docs Lint stays green, because all of the index's rows are still there, so nothing would flag the loss.

Not a goal

  • Any other change to the index or to an RFC.
  • Changing the status of rfc-conductor-context-cap.md.

What changed (motivation → approach → change)

The audit-note line in docs/request-for-change/README.md is now main's line from before #22280 merged (0836784eef), with the sentence #22280 added still at its end. The three sentences go back where they stood. Every other line of the file, and every sentence main's line holds today, is unchanged.

Backwards compatibility

Compatible: documentation only; nothing reads the index at runtime.

Removes nothing: the diff only adds three sentences back.

Tests

N/A — documentation only. ./scripts/docs-lint.sh and python3 scripts/docs_lint.py --test pass on this branch.

Manual verification

N/A — documentation only. Checked on this branch: the one changed line keeps every sentence main's line holds today and adds exactly the three above.

Related Issues

Refs #22082

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision ea7143427296ea5d3c3036a6d0a601c543265f9e touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision ea7143427296ea5d3c3036a6d0a601c543265f9e ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of ea7143427296ea5d3c3036a6d0a601c543265f9e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Documentation only: it restores three audit-note sentences that a merge dropped. It takes nothing away and changes no rendered surface.

[DESIGN-REVIEWED] ea71434

Description read

[DESCRIPTION-READ] ea9efea809cfd8526d7038e97ed27b355d23793c04928a36d4935f18ecdc6d3b

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed ea7143427296ea5d3c3036a6d0a601c543265f9e — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] ea71434

Verdict parsed from the review's SHA-scoped output markers for commit ea7143427296ea5d3c3036a6d0a601c543265f9e.

False positive or not applicable? A repository writer can comment:
/ai-review override fable ea7143427296ea5d3c3036a6d0a601c543265f9e: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of ea7143427296ea5d3c3036a6d0a601c543265f9e and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ea71434

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ea7143427296ea5d3c3036a6d0a601c543265f9e: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 21, 2026
@iamwhatever
iamwhatever force-pushed the docs/rfc-index-restore-audit-note branch from e1021ec to ea71434 Compare October 21, 2026 10:54
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased onto main ef0ec3d, which carries the #22697 fix (#22717), so the test shards run again (e1021ec -> ea71434). The change is unchanged: it only adds back the three audit-note sentences; #22442 no longer edits that README line, so the two PRs do not conflict. Docs checks pass; CI re-running.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 21, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on ea71434. Docs only: restores the three index audit-note sentences (python-rust-hybrid-backend re-audit, gated-pr-poll-loops, crewmate-heartbeat) and changes nothing else on the line.

@bolichen97
bolichen97 merged commit ad34f87 into main Oct 21, 2026
105 checks passed
@bolichen97
bolichen97 deleted the docs/rfc-index-restore-audit-note branch October 21, 2026 13:29
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 21, 2026
@rubencu rubencu mentioned this pull request Oct 21, 2026
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants