Repository navigation
docs(rfc): restore the index audit-note sentences that #22280's merge dropped - #22691
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Documentation only: it restores three audit-note sentences that a merge dropped. It takes nothing away and changes no rendered surface. [DESIGN-REVIEWED] ea71434 Description read[DESCRIPTION-READ] ea9efea809cfd8526d7038e97ed27b355d23793c04928a36d4935f18ecdc6d3b That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
e1021ec to
ea71434
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Approving on ea71434. Docs only: restores the three index audit-note sentences (python-rust-hybrid-backend re-audit, gated-pr-poll-loops, crewmate-heartbeat) and changes nothing else on the line.
Problem / Motivation
Goal: Put back the three sentences the RFC index's audit note lost when #22280 merged.
#22280 merged as
cbada20f26. Its last head wasc5fdc47024, a GitHub web "Update branch" merge of main into the PR branch. That merge resolved a conflict on the audit-note line ofdocs/request-for-change/README.mdby keeping the PR's own copy of the line. Main's copy had gained three sentences since the PR branched, and the merge dropped all three:rfc-python-rust-hybrid-backendrow was re-audited 2026-10-19 against207ed5ae4cfor a new §2.4rfc-gated-pr-poll-loopsrow was added 2026-10-20 asdraftand verified against6432cad9earfc-crewmate-heartbeatrow was added 2026-10-15 asacceptedand verified against8da5b41552Why it matters
The audit note is the index's record of when each row was added or re-audited, and against which commit. Without these sentences, three rows lose their record. Docs Lint stays green, because all of the index's rows are still there, so nothing would flag the loss.
Not a goal
rfc-conductor-context-cap.md.What changed (motivation → approach → change)
The audit-note line in
docs/request-for-change/README.mdis now main's line from before #22280 merged (0836784eef), with the sentence #22280 added still at its end. The three sentences go back where they stood. Every other line of the file, and every sentence main's line holds today, is unchanged.Backwards compatibility
Compatible: documentation only; nothing reads the index at runtime.
Removes nothing: the diff only adds three sentences back.
Tests
N/A — documentation only.
./scripts/docs-lint.shandpython3 scripts/docs_lint.py --testpass on this branch.Manual verification
N/A — documentation only. Checked on this branch: the one changed line keeps every sentence main's line holds today and adds exactly the three above.
Related Issues
Refs #22082
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)