Skip to content

docs(rfc): mark the Living UI RFC implemented - #22712

Merged
iamwhatever merged 1 commit into
mainfrom
docs/living-ui-rfc-implemented
Oct 21, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
docs/living-ui-rfc-implemented

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The Living UI RFC and the RFC index say what is on main: the RFC is accepted and implemented.

docs/request-for-change/rfc-living-ui.md still says status: draft and "Nothing is built", and its README index row says the same. Every required row of its §11 plan has merged since.

Why it matters

A reader, or the First Principles lane, reads the status field to learn what is decided and built. A stale draft says the opposite of main.

Not a goal

  • No change to the design text, the open questions, or any other RFC or index row.
  • Row 9 (measure, then decide on host injection) is not done here. It is optional.

What changed (motivation → approach → change)

The maintainer decided, so the record follows. In the conductor chat on 2026-10-21 at about 08:25 UTC, the maintainer iamwhatever wrote: "我接受,开记账 PR 改成 implemented" (I accept; open the bookkeeping PR and mark it implemented).

  • rfc-living-ui.md front matter: status: implemented, implementation-prs lists the eleven PRs, last-audited: 2026-10-21, audited-at: 0b89e0c6f7.
  • Its - Status: line says who accepted it, when, and which PR carried each §11 row. Row 9 is marked optional and not done.
  • §2.1's heading and the §2.2 table header said "today"; they now say "before this RFC". The text under them is unchanged and still pinned to 9d088c85ad.
  • README.md: the index row is implemented with what shipped, PR links and verified at 0b89e0c6f7. The header log gets one clause for the move, matching the other moved rows.
§11 row PR
1 skill rules, 2 toolkit core #21897 (its squash merge carried row 1); #21840 fixed review findings in SKILL.md
3 readout, focusOne #22107
4 tour #22225
5 explode #22441
6 harness, checklist, example #22093, plus #22240 (Dashboard page mode, §7 step 1) and #22231 (example fix for #22133)
7 skill pointers #21874
8 dashboard gallery example #22117
10 isometric look #22091

Row 9 (measure, then decide on injection) is optional and not done.

Each PR above is merged, its merge commit is an ancestor of 0b89e0c6f7, and every file it touched exists there.

Backwards compatibility

Compatible: two Markdown files change; no code reads the RFC status text.

Removes nothing: only status and wording lines change; no file, row or anchor goes away (no link targets rfc-living-ui.md#...).

Tests

N/A — docs only. python3 scripts/docs_lint.py passes, and test/test_docs_lint_fact_checks.py passes (98).

Manual verification

Checked each PR with gh pr view (state MERGED) and git merge-base --is-ancestor against 0b89e0c6f7, and checked every file each PR touched is present.

Related Issues

Closes #21796 — every required §11 row has landed.

Refs #21797 (the RFC's doc PR).

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 21, 2026 08:37
@iamwhatever
iamwhatever requested a review from buluoray October 21, 2026 08:37
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision d248b0ea2555df4686839128d85e022ffee58bb2 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision d248b0ea2555df4686839128d85e022ffee58bb2 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of d248b0ea2555df4686839128d85e022ffee58bb2 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

This is a docs-only update to RFC status, and it follows a recorded maintainer decision. It adds no behaviour, surface or take-away, so there is nothing at design level to check.

[DESIGN-REVIEWED] d248b0e

Description read

[DESCRIPTION-READ] a9aaacd1874128ce4f01ca4ff6c9f263e6188cc3fe9c08f3457dccef3f905563

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed d248b0ea2555df4686839128d85e022ffee58bb2 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] d248b0e

Verdict parsed from the review's SHA-scoped output markers for commit d248b0ea2555df4686839128d85e022ffee58bb2.

False positive or not applicable? A repository writer can comment:
/ai-review override fable d248b0ea2555df4686839128d85e022ffee58bb2: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of d248b0ea2555df4686839128d85e022ffee58bb2 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] d248b0e

False positive or not applicable? A repository writer can comment:
/ai-review override gpt d248b0ea2555df4686839128d85e022ffee58bb2: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Oct 21, 2026
@iamwhatever
iamwhatever force-pushed the docs/living-ui-rfc-implemented branch from a2cd99d to d248b0e Compare October 21, 2026 15:57
@iamwhatever

Copy link
Copy Markdown
Contributor Author

RFC update to show the latest implementation status

@iamwhatever
iamwhatever merged commit bb5c0ae into main Oct 21, 2026
44 of 45 checks passed
@iamwhatever
iamwhatever deleted the docs/living-ui-rfc-implemented branch October 21, 2026 16:00
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 21, 2026
@rubencu rubencu mentioned this pull request Oct 21, 2026
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Living UI: style-neutral motion, focus and readout rules plus a small toolkit for widgets and dashboards

1 participant