Repository navigation
fix(side-chat): name the claude adapter floor and update step in the footer - #22725
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the footer now reads the adapter floor and the update command from the constants the turn's own check uses, so the text can't drift from them. [DESIGN-REVIEWED] 6e927b4 Description read[DESCRIPTION-READ] 20dfb475fc2bdaba953e0616a07c6c11d58759f1c3fd1a4b1bf0fe152004617e That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The PR routes existing constants into the footer copy. Only two small riders remain: a backend-footer rewrite and a third inline spelling of the floor join. Notes
What this change shipsInventory (5 items) — 3 justifiedIntent: a Claude Code user whose adapter is too old learns which adapter, which minimum version, and the exact update command. This is a FIX (#19061).
[FIRST-PRINCIPLES-REVIEWED] 6e927b4 Description read[DESCRIPTION-READ] 699835d064f9855e8ac3f025265449867d14f5801d306173cefeef45de121727 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS No blocker: the reader didn't understand the npm command, but this footer only appears for someone who already installed the Claude Code adapter with npm. All six footer variants are in the screenshots, and the reader identified each one. Notes
[UX-REVIEWED] 6e927b4 Description read[DESCRIPTION-READ] 425730bb5784baee169ffe8cbe5bb0663ba486c07167b2cadfb9da113f764bc7 That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
bolichen97
left a comment
There was a problem hiding this comment.
Thanks, the copy change reads well and the values come from the right constants. One thing blocks it: Backend Lint & Type Check (3.12) fails on this head because the agent-sdk boundary gate refuses the new ACP-layer import on line 21 of dashboard/handlers/side.py:
##[error]this change ADDS an ACP-layer import (the baseline covers only pre-existing lines).
The gate has no opt-out marker, so the fix is to read the floor through kiro_crew.agent_sdk.drivers.acp, the same way claude_adapter_install_command() already does. Details inline. Everything else (route fields, typed client, footer, the 13 locales with matching {{version}}/{{command}} placeholders, tests, spec rows) looks good to me, and I found no other open PR touching these files.
683338b to
6e927b4
Compare
Resolved on 6e927b4: the new ACP-layer import is gone and Backend Lint is green.
bolichen97
left a comment
There was a problem hiding this comment.
Thanks, the boundary fix landed. The earlier change request is resolved on this head (6e927b4): dashboard/handlers/side.py no longer adds an ACP-layer import, and the floor is read through the new claude_adapter_min_version() in kiro_crew.agent_sdk.drivers.acp, next to claude_adapter_install_command(). The returned string is built from the same constant the version check uses, so the footer and the check cannot drift.
Checked on this head: Backend Lint & Type Check (3.12) is green, every required check is green, readiness is passed, all AI review lanes report no blocking findings, the branch is mergeable into main, the linked issue is tier T2, and no file is on the security path list. The rest of the change (route fields, typed client, footer copy, locale placeholders, tests, spec rows) is unchanged from the version I reviewed before.
Approving and queueing a squash auto-merge.
Problem / Motivation
Goal: When Side Chat cannot run lookups because the Claude Code adapter is too old, the footer tells the user which adapter, which version, and the exact command to update it.
The footer said "Context only · Update claude-agent-acp to use read-only tools here." It gave no version and no command. It also started with "Context only" while the working state says "Read-only", so the two read like two different limits, and it said "read-only tools" where the working state says "lookups".
Why it matters
A Claude Code user who sees the old footer has no way to act on it without reading the spec or the server log. The footer is the only place the UI explains why Side Chat cannot look things up.
Not a goal
config_unavailablespec row (done in feat(side-chat): run read-only tools on the Claude Code backend #19059).What changed (motivation → approach → change)
Every Side Chat footer now starts with what works:
To update, run: npm i -g @agentclientprotocol/claude-agent-acpThe version and the command are not typed into the strings.
GET /api/chat/side/tools(dashboard/handlers/side.py, typed inapi/client/chat.ts) returns two new fields,claude_adapter_min_versionandclaude_adapter_update_command, read throughagent_sdk/drivers/acp.py(claude_adapter_min_version(), fromCLAUDE_ACP_SETTING_SOURCES_MIN_VERSION, andclaude_adapter_install_command()), the same values the turn's check and its server warning use.SideChat.tsxpasses them into the footer string. Both footer strings are rewritten inen.manual.jsonand all twelve translated locales, anden-XA.jsonis regenerated. The route row and the footer paragraph indocs/system-specs/modules/side.mdname the new fields.Backwards compatibility
Compatible: the route only gains two fields; no caller reads a field that went away.
Removes nothing: no key, field or route is removed; the two locale keys keep their names.
Tests
test/test_side_turn_confinement.py: the/api/chat/side/toolsanswers include the floor and thenpm i -gcommand, built from the adapter's own constants.website/src/test/SideChat.footerBackend.test.tsx: the outdated-adapter footer names claude-agent-acp,0.84.0and the full update command; the backend footer starts with "No lookups".website/src/test/SideChat.multiturn.test.tsx: exact footer text for each case.prove.py --base origin/main: PROVEN (an assertion fails with the production hunks reverted).-n 4, all green; frontend files under--sequence.shufflewith seeds 1-5, all green.src/i18nsuite (style, register, parity, pseudolocale) green.Manual verification
Rendered the real
SideChatwith/api/chat/side/toolsstubbed for each case (en dark/light, de, zh-CN) and checked the footer text and wrapping in the 420px dock.Screenshots / video
Outdated adapter, English, dark:
Backend outside the set, English, dark:
Other variants
Related Issues
Closes #19061
Pattern harvest
Not generalizable: a footer string that named a remedy without its version or command; the fix routes the existing constants into the copy.
Checklist