Skip to content

fix(side-chat): name the claude adapter floor and update step in the footer - #22725

Merged
bolichen97 merged 1 commit into
mainfrom
fix/19061-side-chat-footer
Oct 21, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/19061-side-chat-footer

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: When Side Chat cannot run lookups because the Claude Code adapter is too old, the footer tells the user which adapter, which version, and the exact command to update it.

The footer said "Context only · Update claude-agent-acp to use read-only tools here." It gave no version and no command. It also started with "Context only" while the working state says "Read-only", so the two read like two different limits, and it said "read-only tools" where the working state says "lookups".

Why it matters

A Claude Code user who sees the old footer has no way to act on it without reading the spec or the server log. The footer is the only place the UI explains why Side Chat cannot look things up.

Not a goal

What changed (motivation → approach → change)

Every Side Chat footer now starts with what works:

Case Footer starts Then says
Lookups run Read-only (unchanged)
Backend outside the set No lookups this backend can't run lookups here, answers come from the chat so far
Claude adapter too old No lookups needs claude-agent-acp 0.84.0 or newer, the Claude Code adapter; To update, run: npm i -g @agentclientprotocol/claude-agent-acp

The version and the command are not typed into the strings. GET /api/chat/side/tools (dashboard/handlers/side.py, typed in api/client/chat.ts) returns two new fields, claude_adapter_min_version and claude_adapter_update_command, read through agent_sdk/drivers/acp.py (claude_adapter_min_version(), from CLAUDE_ACP_SETTING_SOURCES_MIN_VERSION, and claude_adapter_install_command()), the same values the turn's check and its server warning use. SideChat.tsx passes them into the footer string. Both footer strings are rewritten in en.manual.json and all twelve translated locales, and en-XA.json is regenerated. The route row and the footer paragraph in docs/system-specs/modules/side.md name the new fields.

Backwards compatibility

Compatible: the route only gains two fields; no caller reads a field that went away.

Removes nothing: no key, field or route is removed; the two locale keys keep their names.

Tests

  • test/test_side_turn_confinement.py: the /api/chat/side/tools answers include the floor and the npm i -g command, built from the adapter's own constants.
  • website/src/test/SideChat.footerBackend.test.tsx: the outdated-adapter footer names claude-agent-acp, 0.84.0 and the full update command; the backend footer starts with "No lookups".
  • website/src/test/SideChat.multiturn.test.tsx: exact footer text for each case.
  • prove.py --base origin/main: PROVEN (an assertion fails with the production hunks reverted).
  • Determinism: backend tests 10 sequential repeats plus 3 runs under -n 4, all green; frontend files under --sequence.shuffle with seeds 1-5, all green.
  • src/i18n suite (style, register, parity, pseudolocale) green.

Manual verification

Rendered the real SideChat with /api/chat/side/tools stubbed for each case (en dark/light, de, zh-CN) and checked the footer text and wrapping in the 420px dock.

Screenshots / video

Outdated adapter, English, dark:

Outdated adapter footer, en dark

Backend outside the set, English, dark:

Backend footer, en dark

Other variants

Lookups work, en dark

Outdated adapter, en light

Outdated adapter, de dark

Outdated adapter, zh-CN dark

Related Issues

Closes #19061

Pattern harvest

Not generalizable: a footer string that named a remedy without its version or command; the fix routes the existing constants into the copy.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 21, 2026 09:58
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 6e927b4a243339a006ad6ba10c3d1b1ccf8c4002 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the footer now reads the adapter floor and the update command from the constants the turn's own check uses, so the text can't drift from them.

[DESIGN-REVIEWED] 6e927b4

Description read

[DESCRIPTION-READ] 20dfb475fc2bdaba953e0616a07c6c11d58759f1c3fd1a4b1bf0fe152004617e

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 6e927b4a243339a006ad6ba10c3d1b1ccf8c4002 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. The PR routes existing constants into the footer copy. Only two small riders remain: a backend-footer rewrite and a third inline spelling of the floor join.

Notes

  • Item 2 — rides along: the Goal covers only the outdated-adapter footer, but the diff also rewrites context_only_tools_unavailable_backend in 13 locales. Its only stated harm is wording mismatch ("read like two different limits"), with no report behind it.
    Subtraction: shrink the rewrite to the prefix relabel ("Context only" → "No lookups") and keep the old body text.
  • Item 4 — duplicate of an inline join: ".".join(str(part) for part in CLAUDE_ACP_SETTING_SOURCES_MIN_VERSION) already appears in 2 other places (acp/client_claude_session.py:387, agent_sdk/drivers/acp.py:659). The new claude_adapter_min_version() has 1 consumer, and neither of the existing places calls it.
    Subtraction: use the new helper at drivers/acp.py:659 and client_claude_session.py:387, and delete those inline joins.

What this change ships

Inventory (5 items) — 3 justified

Intent: a Claude Code user whose adapter is too old learns which adapter, which minimum version, and the exact update command. This is a FIX (#19061).

  1. The outdated-adapter footer now names claude-agent-acp, 0.84.0 and npm i -g … — justified
  2. The backend-outside-the-set footer is reworded to "No lookups · … answers come from the chat so far" — rides along
  3. The outdated-adapter footer's prefix changes from "Context only" to "No lookups" — justified
  4. New public helper claude_adapter_min_version() in agent_sdk/drivers/acp.py — one consumer, third spelling of an existing inline join
  5. /api/chat/side/tools gains claude_adapter_min_version and claude_adapter_update_command — justified

[FIRST-PRINCIPLES-REVIEWED] 6e927b4

Description read

[DESCRIPTION-READ] 699835d064f9855e8ac3f025265449867d14f5801d306173cefeef45de121727

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 6e927b4a243339a006ad6ba10c3d1b1ccf8c4002 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

No blocker: the reader didn't understand the npm command, but this footer only appears for someone who already installed the Claude Code adapter with npm. All six footer variants are in the screenshots, and the reader identified each one.

Notes

  • In context_only_claude_adapter_outdated, "Use the main chat to take action." sits between the version and "To update, run: {{command}}", so the cause and its fix are split apart (shot-01). Move the update step right after the version and end with the main-chat line.
  • The update command is plain prose in muted 11px text (text-[11px] … text-muted). The reader saw it only as "a command for a programmer" and didn't know where it goes. Show it in a monospace <code> span with a copy button so it looks like something you paste into a terminal.
  • The reader couldn't tell "No lookups" from "Read-only" because "lookups" is never defined. One option is a short gloss in the backend string, e.g. "can't look up files or run searches here".

[UX-REVIEWED] 6e927b4

Description read

[DESCRIPTION-READ] 425730bb5784baee169ffe8cbe5bb0663ba486c07167b2cadfb9da113f764bc7

That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 6e927b4a243339a006ad6ba10c3d1b1ccf8c4002 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 6e927b4

Verdict parsed from the review's SHA-scoped output markers for commit 6e927b4a243339a006ad6ba10c3d1b1ccf8c4002.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 6e927b4a243339a006ad6ba10c3d1b1ccf8c4002: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 6e927b4a243339a006ad6ba10c3d1b1ccf8c4002 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 6e927b4

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 6e927b4a243339a006ad6ba10c3d1b1ccf8c4002: <one-sentence reason>

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the copy change reads well and the values come from the right constants. One thing blocks it: Backend Lint & Type Check (3.12) fails on this head because the agent-sdk boundary gate refuses the new ACP-layer import on line 21 of dashboard/handlers/side.py:

##[error]this change ADDS an ACP-layer import (the baseline covers only pre-existing lines).

The gate has no opt-out marker, so the fix is to read the floor through kiro_crew.agent_sdk.drivers.acp, the same way claude_adapter_install_command() already does. Details inline. Everything else (route fields, typed client, footer, the 13 locales with matching {{version}}/{{command}} placeholders, tests, spec rows) looks good to me, and I found no other open PR touching these files.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 21, 2026
@iamwhatever
iamwhatever force-pushed the fix/19061-side-chat-footer branch from 683338b to 6e927b4 Compare October 21, 2026 10:19
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 21, 2026
@bolichen97
bolichen97 dismissed their stale review October 21, 2026 11:13

Resolved on 6e927b4: the new ACP-layer import is gone and Backend Lint is green.

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the boundary fix landed. The earlier change request is resolved on this head (6e927b4): dashboard/handlers/side.py no longer adds an ACP-layer import, and the floor is read through the new claude_adapter_min_version() in kiro_crew.agent_sdk.drivers.acp, next to claude_adapter_install_command(). The returned string is built from the same constant the version check uses, so the footer and the check cannot drift.

Checked on this head: Backend Lint & Type Check (3.12) is green, every required check is green, readiness is passed, all AI review lanes report no blocking findings, the branch is mergeable into main, the linked issue is tier T2, and no file is on the security path list. The rest of the change (route fields, typed client, footer copy, locale placeholders, tests, spec rows) is unchanged from the version I reviewed before.

Approving and queueing a squash auto-merge.

@bolichen97
bolichen97 merged commit f652146 into main Oct 21, 2026
104 of 106 checks passed
@bolichen97
bolichen97 deleted the fix/19061-side-chat-footer branch October 21, 2026 11:14
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Side Chat: clearer claude adapter-outdated footer, and spec the config_unavailable field

2 participants