Repository navigation
docs(sidebar): describe the first-load pinned-order seed accurately - #22919
mbriones98 wants to merge 2 commits into
Conversation
The pinned-order contract said pinned rows stay unranked until someone reorders. The sidebar's first list-view load seeds the order it shows, so rows gain a rank without a reorder. Say so, and list the cases where rows do stay unranked. Align the only_if_unset note on the gateway side. Fixes kirodotdev#22182
Say that rows stay unranked until the seed succeeds, that a failed seed waits for the next page load, and that a refused seed takes the stored order. Note that a board view with an old local order also seeds, and drop the remaining 'never reordered keeps the plain sort' lines.
UX Review (Opus 5.5, fork) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The diff only changes comments and docstrings in four files. No user-visible control, string or state is added or changed, so no screenshot is needed. [UX-REVIEWED] 6a01a17 Description read[DESCRIPTION-READ] c96df0ebf52bd55bea94f914d2b57848a6aac99d4d50be78a77d81625106117a That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Comment- and docstring-only change. The new wording matches what the seed code in [DESIGN-REVIEWED] 6a01a17 Description read[DESCRIPTION-READ] 38d835ddf4e7878f5845b4faeefbf807aebf4e0df6f4d652ba3b88ca8f151f4b That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
|
Replaced by #22936, the same commits opened from a repo branch. |
Pull request was closed
Fixes #22182
Summary
The pinned-order contract said pinned rows stay unranked until someone reorders. The sidebar's first load seeds the order it is showing, so rows gain a rank without a reorder. This is intended (two sidebar tests name the seed), so the text changes and the behaviour does not.
website/src/utils/pinnedSessionOrder.ts: describe the first-load seed, and list when rows do stay unranked (board view with no old local order, empty roster, before the seed succeeds, after a failed seed, and a refused seed taking the stored order).website/src/pages/chat-sidebar/pinnedOrder.ts: align two comments, including the board-view note (a board view with an old local order does seed).src/kiro_crew/dashboard/chat_folders.py,src/kiro_crew/dashboard/pinned_session_order.py: align theonly_if_unsetnote and the "never reordered keeps the plain sort" lines.Comments and docstrings only; no code changed.
Testing
pytest test/test_pinned_session_order.py test/test_pinned_order_real_sandbox.py: 132 passed, 6 skippedvitest runChatSidebar.hapticTaps + ChatSidebar.slotSearchOrder: 17 passedtsc --noEmit, eslint on the touched TS files, black/flake8/isort on the touched Python filesscripts/check_file_line_cap.py,scripts/docs_lint.py: pass