Skip to content

feat(members): fold the Profile card's settings behind one Settings row - #22975

Merged
CrysisDeu merged 1 commit into
mainfrom
ux/profile-settings-grouped-list
Oct 23, 2026
Merged

CrysisDeu merged 1 commit into
mainfrom
ux/profile-settings-grouped-list

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The crewmate Profile card shows its settings as a compact iOS-style group of rows, each opening its own picker page, instead of a raw form on the card.

The Profile tab ends in four full-width selects (Permissions, Model, Worker model, plus the two effort selects when the model reasons) and a switch, each with a two-line hint, sitting on the same level as the About blurb, the Memory / Workspace tiles and the Notes row. The card is meant to be a summary with doors; this block is the one thing on it that is the full machinery, exposed. It is the tallest block on the card, it reads as "edit me" on a surface the person opens to look at a crewmate, and a mis-click on the Permissions select changes the crewmate's approval ceiling with no intermediate step. Decided by the maintainer in #22960 after three rendered options.

Why it matters

Every crewmate owner opens this card; the permission ceiling of every thread with the crewmate is set on it. A form that invites edits on a reading surface is how a ceiling gets changed by accident, and a card that is two-thirds settings hides what the card is for (the crewmate's description, memory, workspace, notes).

Not a goal

  • No new settings, fields, writes or routes: what is saved, where, and the compare-and-set on approval_mode are unchanged.
  • No change to the crew editor (the pencil) or to where the dashboard lock is set.
  • No change to the card's tabs, tab order or opening tab (docs/decisions 2026-10-08).
  • Not a Settings-page change: the group lives on the Profile card only.

What changed (motivation → approach → change)

Goal: the card stays a summary with doors. Approach: reuse the two shapes the card already has — the Row (Notes) and the pushed page (About / Notes / New schedule / the Goals tab's pages) — instead of inventing a disclosure or a modal. Of the options rendered for #22960 (a grouped list on the Profile tab itself; a single Settings row; a gear in the title bar; a 2×2 tile grid; a fifth tab; a summary chip under the name), the maintainer first picked the grouped list on the tab, then, seeing it rendered, asked for the settings to leave the Profile tab entirely and picked the single Settings row (the PR comment below records that call). So: one row on the card, the group one push away, each picker one push further.

  • website/src/pages/members/profileRow.tsx (new): the card's Row moves here with an optional right-aligned value and an aria-label for a row whose accessible name must be the label alone (a find_ui location); plus RowStatic (a row holding its own control) and RowGroup (the rounded group with an optional caption). CrewProfilePanel.tsx imports Row / TONE from it.
  • website/src/pages/members/CrewProfilePanel.tsx: the tab-page push becomes a stack. ProfilePagePush.open(title, onPop, depth = 0) pushes at a depth (or retitles the page already there, keeping the pages over it, so a tab's effect re-running does not rebuild a deeper level), close(depth?) drops from a depth up, hosts[depth] is one portal host per level (host stays hosts[0] for the Goals tab, whose calls are unchanged). One layer per level; a layer under a deeper one slides a quarter-width left and goes inert, exactly as the card does under the first; the one back control names the page under the top (Settings), or the mate under the first. Escape pops one level. Focus: a push lands on the back control; a pop returns to the opener of the popped level, else the back control of the level now on top, else (nothing left and the opener gone) the card itself (tabIndex={-1}, only after a pop, never on open). The settingsBody slot now renders inside the Notes row's group, under the push provider.
  • website/src/pages/members/CrewProfileSettings.tsx: the card gets ONE Row — Settings, reading permission · model (not the worker pick: "Same as Kiro" beside Kiro's own name read as a riddle to the UX lane's blind reader) — carrying the members.settings find_ui location and the members.settings reveal scope (useGuideRevealScope). Tapping it pushes the Settings page (depth 0): the group of rows. The two page-opening effects key on the stable push.open / push.close, never on the push object (which changes when a host mounts), so a host mounting never re-runs open and swaps the level's opener for the back control. Each picker row pushes its single-choice page (depth 1): a radiogroup, one radio per option, the option's description under its label (what each permission mode lets the mate do; what an Inherited model or effort resolves to, so the reader sees it before picking), a trade-off caption under the list where there is one (effort, worker pages), a check on the stored value. The group has one Tab stop (the checked option); Up/Down/Home/End move focus between options and never pick; Enter / Space picks. A pick saves exactly as before (compare-and-set for approval_mode, last-write-wins for the rest, live-slot follow-up for model / effort) and the picker stays open with the check moved, so a 409 notice or a failed write is where the person is looking. While a save runs the options are held with aria-disabled (and aria-busy on the page), never the disabled attribute: the pick is made from the focused option, and disabling it mid-save would drop focus onto the body, outside the card's Escape handler; save already refuses a second pick through inFlight. A row that folds while its page is open (clearing a stale effort level from its own page) pops the page via close(1); the last rendered page keeps painting, held, through the exit slide. The group's pop drops any open picker with it. The checked option's label is accent-coloured and its check slot shows a spinner while its save runs, so a pick visibly lands. The lock stays a Toggle in a RowStatic; its hint is the group's caption. GuideTrustRootRegion wraps the Permissions row and its page; members.permissions sits on the row. The Field / ModelField / SimpleSelect imports go.
  • find_ui (website/src/uiLocations/areas/members.ts, conditions.ts, regenerated guidePlans.gen.ts + src/kiro_crew/docs/ui-index.generated.json): two new locations — members.profile-tab (the card's Profile tab; the card opens on Sessions, so a guide to anything on Profile selects it first; reveal state crewmate_profile_tab_closed, scope reported by CrewProfilePanel) and members.settings (the row; reveal state crewmate_settings_closed, scope reported by CrewProfileSettings). members.settings requires shown_by members.edit then shown_by members.profile-tab; members.permissions requires those two and then shown_by members.settings, so a guide walks card → Profile tab → Settings → Permissions. To put a marker on a Tablist tab, Tablist gains the segments prop SegmentedControl and CrewEditorNextRail already have ({ key, label, ...uiLocation(id) }), is added to the generator's SEGMENT_HOSTS and to FORWARDING_PROVEN, with a rendered forwarding test in src/test/Tablist.test.tsx.
  • i18n (12 catalogs + regenerated en-XA): profile_settings ("Settings", the row and page title) added; profile_mode_{normal,reads,trust}_hint → profile_mode_{normal,reads,trust}_desc (the per-option descriptions, without the trailing "Pick Normal to approve each step" sentence — Normal is the row above); profile_dashboard (the form's "Dashboard" field label) removed. Translations of the descs are the existing hint translations with that last sentence dropped.
  • website/scripts/capture-crewmate-profile-settings.mjs (new): the evidence harness, real built SPA behind serveDist + stubDashboardApi, with checks (one Settings row reading permission · model and no group on the card; the Settings page titled Settings with back naming the mate; no form control; every row reads its value; the picker titled with its row, back naming Settings; three options with Trust checked; one compare-and-set PUT on a pick; the page stays open; the row behind reads the new value; each other page carries its caption; a 409 shows the stored value and the notice on the page).
  • Specs: docs/system-specs/modules/crew-mode.md (the Profile tab paragraph: the row, the stack, the reveal scope) and docs/feature-map/README.md (the Crew Members row).

Backwards compatibility

Compatible: no API, record field, route or storage shape changes; the same PUT /api/agents/{name} bodies are sent for the same picks. ProfilePagePush only gains optional parameters and a hosts array; the Goals tab's calls are unchanged and its tests pass.

Removes nothing: the form's five controls become five rows + pages with the same options, one push in; the three hint keys and one label key removed from the catalogs had CrewProfileSettings.tsx as their only reader (grep on origin/main @ 2e648a7), and their text survives as the per-option descriptions.

Tests

website/src/pages/members/CrewProfileSettings.test.tsx (rewritten; 52 tests, driven through a fake ProfilePagePush with two hosts the test owns):

  • the card shows the Settings row alone, reading Trust · claude-opus-5 (no worker part), accessible name "Settings" AND accessible description = that reading (aria-describedby on the sub line); nothing pushed until tapped; a new push object with the same open/close does not re-push (the effects key on the callbacks, not the object); arrow keys move focus between options with one Tab stop and never save; tapping pushes ('Settings', fn, 0) and the group renders into hosts[0];
  • the group is rows reading their values with no select / combobox / listbox; a row pushes (label, fn, 1) into hosts[1]; the picker's pop callback hands it back; the group's pop drops an open picker too; notices sit under the group while no picker is open, on the picker while one is;
  • permission: unset reads Trust on the row and on the page; a stored mode reads as stored; the row has accessible name "Permissions" and description = value; row AND page are trust-root targets; each option says what the mode lets the mate do, no "Pick Normal"; one compare-and-set PUT, no chatMode call, page stays open, check and row move; tapping the checked option writes nothing; record-only without a thread; one save at a time (page aria-busy, options aria-disabled); the picked option stays focusable and focused through the save; roster cache updated; nothing saved while waiting; 409 shows the stored value and the notice on the page; a failed save puts the stored value back with the error on the page;
  • model / effort: writes record + slot; Inherited as ''; a stored model the list no longer carries is offered, checked; the Inherited option names the model / level it resolves to; resolve error and degraded list notices; effort hidden on a model that does not reason; the effort page pops (close(1)) when its row folds, and a page whose own pick folded its row keeps painting, held, for the exit slide;
  • worker pair and dashboard lock: the existing cases, read off the rows and pages.

website/src/pages/members/CrewProfilePanel.test.tsx (52): the existing cases pass (the "no guide marker" case becomes "exactly one, the Profile tab"), plus: re-opening the level under an open page keeps that page and its opener (back still returns focus to the row, not the back control); a second page stacks over the first (title and back control name each level, the lower level goes inert, back pops one level and focus returns to the row that pushed it, back again pops to the card); Escape pops one level at a time, then closes; close(0) drops a level and everything over it; a page popping with its opener unmounted lands focus on the card itself and Escape then closes it; opening the card never pulls focus onto it.

The dashboard-lock switch stays live while a pick saves or while the thread is waiting: it is its own endpoint (memberDashboardLock), touches no thread and is not part of the one-save-at-a-time chain, so there is nothing to hold it for (at base it merely sat inside the same disabled fieldset).

members.locations.test.ts pins the three locations' tuples; src/test/Tablist.test.tsx proves a segments marker lands on that tab alone and the roving-focus ref still works; uiIndex.test.ts (136) and GuideLayer.uiShow.test.tsx (62) pass on the regenerated index; CrewGoals.test.tsx (37) passes on the stacked push unchanged.

Manual verification

node scripts/capture-crewmate-profile-settings.mjs against the real built SPA, light and dark: all checks OK (listed in the harness header). Verified in the renders: the Profile tab with the Settings row in the Notes group and nothing else of the settings; the Settings page with back naming the mate; the Permissions page with back naming Settings; the check moving to Normal after a pick with the page still open; the row behind reading Normal; the Worker model page's caption; the 409 state.

Screenshots / video

Light: the Profile tab (one Settings row, Opus pinned), the Settings page one push in, the Permissions page one push further (back names Settings), and the same page after picking Normal:

Profile tab: the Settings row, light
Settings page: the group, light
Permissions page, Trust checked, light
Permissions page after picking Normal, light

A refused pick (409 approval_mode_conflict): the page stays open, the check lands on the stored value, the notice is on the page:

Permissions page after a refused pick, light

The other pages with their captions under the list:

Model page, light
Reasoning effort page, light
Worker model page, dark
Worker reasoning effort page, dark

The flow (row → Settings → Permissions → pick Reads → back → Model → back → back to the card):

walkthrough.webm
Other theme variants

Profile tab: the Settings row, dark
Settings page: the group, dark
Permissions page, dark
Permissions page after picking Normal, dark
Permissions page after a refused pick, dark
Model page, dark
Reasoning effort page, dark
Worker model page, light
Worker reasoning effort page, light

Related Issues

Closes #22960

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners October 22, 2026 00:16
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 22, 2026
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 86c862817e0fef76077d6cea648314fb18900e85 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the change reuses the card's existing Row and pushed-page shapes, keeps every save path the same, and rendered evidence of this revision is attached.

Notes

  • The ## Backwards compatibility section is past the truncation cut, so I couldn't check it. Nothing in the tree still reads the removed i18n keys (profile_mode_*_hint, profile_dashboard).
  • The ProfilePagePush page stack has no stated depth limit; only depths 0 and 1 are used. Unless a third level is planned, keeping it to two levels would make the focus and Escape handling simpler to reason about.

[DESIGN-REVIEWED] 86c8628

Description read

[DESCRIPTION-READ] 566bf03d3e62baaf0370261d11166b954d622adcef520409b3a430f97312d8da

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 86c862817e0fef76077d6cea648314fb18900e85 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. The settings move from the card into a pushed page. That is a regroup, not a removal or a changed default. Its only provenance is the description's account of a maintainer call in #22960.

Notes

What this change ships

Inventory (10 items) — 9 justified

Intent: crewmate owners get a Profile card that reads as a summary, with the settings one tap away instead of shown as a raw form. This is an ADDITION (a regroup).

  1. Permission, model, effort, worker pair and lock leave the Profile tab for a pushed Settings page — unjustified move: the decision exists only in the description
  2. Each pick now takes row → picker page instead of an inline select — justified
  3. A new Settings row on the card reads "permission · model" — justified
  4. Picker pages show a description under each option, and the trailing "Pick Normal…" hint sentence is dropped — justified
  5. After a pick the picker stays open with the check moved — justified
  6. Pushed pages stack: Escape pops one level, and each back control names the page under it — justified
  7. The "Dashboard" field label is removed and the lock's help becomes the group caption — justified
  8. find_ui gains the members.profile-tab and members.settings locations, and the permissions guide now walks card → tab → Settings — justified
  9. Tablist gains the segments marker prop and joins SEGMENT_HOSTS — justified
  10. A new screenshot harness, capture-crewmate-profile-settings.mjs — justified

[FIRST-PRINCIPLES-REVIEWED] 86c8628

Description read

[DESCRIPTION-READ] 243afe9e7f755e6b566bc3e96422d7f2c79f8a1f52cfd3716dc1e87dd591bd29

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 86c862817e0fef76077d6cea648314fb18900e85 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the blind reader identified the new Settings row and each picker correctly and would use them. The pushed-page transition has a recording.

Notes

  • The dashboard_locked_badge / _label strings ("Layout locked — unlock on Profile") now send people to the Profile tab, but the switch isn't there any more; it's behind the Settings row. Change them to "unlock in Profile › Settings".
  • The blind reader read profile_permission_changed in a red box as an error ("I can't tell whether my own choice was thrown away"). Show it as a neutral info notice, not in error styling.
  • The Inherited options read "Inherited – Thinking at Medium" next to a checked "High", and the reader couldn't tell which level is in use. Change the description to "Would use Medium" so it reads as what picking it would do.

[UX-REVIEWED] 86c8628

Description read

[DESCRIPTION-READ] c6f229bac705595ad0e5b09f0d648896389597fa31b121c5e1f74719a02b01c6

That sha256 names everything this verdict read: the PR description, plus the 21 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — 🔴 changes requested (blocking)

GPT 6.1 found at least one blocking issue that must be resolved before merging 86c862817e0fef76077d6cea648314fb18900e85. Adjudication upheld 1 of 1 blocking finding(s); those must be resolved before merging.

This comment is updated in place on each push.

BLOCKING -- website/src/pages/members/CrewProfileSettings.tsx:271 -- Inherited options advertise the current pin rather than the fallback

desc: l === '' && resolved?.reasoning_effort ? t('pages.kiroCrewAgentsPage.effort_resolves_to', { effort: effortLabel(resolved.reasoning_effort) }) : undefined,
Trigger: Open Settings → Reasoning effort for a mate pinned to high with the configured chat default at medium. api.agentResolvedModel → /api/agents/resolved-model → resolve_session_effort returns the current pin, which this line displays under Inherited.
Outcome: Inherited advertises High, but selecting it writes reasoning_effort: '', making new sessions resolve Medium. The model option at line 258 likewise advertises the current pinned model instead of the inherited fallback.
Anchor: defect
Fix: Show these descriptions only when the response reports the corresponding field as unpinned (effort_pinned / pinned), or resolve the fallback separately with that pin excluded.

[BLOCK-MERGE] 86c8628
[GPT-REVIEWED] 86c8628

Adjudication (Opus 5.5) — is blocking on each finding proportionate?

F1 — Harm is LOW-MEDIUM. The picker shows a false description of what "Inherited" resolves to, and acting on it silently changes the effort and model that new sessions run at.
Confirmed in the code: crew_records.py:87-99 returns the current effort pin as reasoning_effort and the current model pin as model, and it also returns pinned and effort_pinned. CrewProfileSettings.tsx:258 and :271 now attach the description to the Inherited option whatever the current pin is. The old code only showed it when the current value was already inherited (removed hunk: value('reasoning_effort') === '' && …), so this PR introduced the regression.
The fix is cheap: add !resolved.pinned / !resolved.effort_pinned to the two existing ternaries. Both fields are already in the response, so it needs no new state or mechanism, and the remedy costs far less than the harm.

[ADJUDICATION] 86c862817e0fef76077d6cea648314fb18900e85 total=1 uphold=1 downgrade=0
UPHOLD F1 website/src/pages/members/CrewProfileSettings.tsx:271 reason=harm-warrants-remedy
[GPT-ADJUDICATED] 86c862817e0fef76077d6cea648314fb18900e85

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 86c862817e0fef76077d6cea648314fb18900e85: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 86c862817e0fef76077d6cea648314fb18900e85 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 86c8628

Verdict parsed from the review's SHA-scoped output markers for commit 86c862817e0fef76077d6cea648314fb18900e85.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 86c862817e0fef76077d6cea648314fb18900e85: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 22, 2026
@CrysisDeu
CrysisDeu force-pushed the ux/profile-settings-grouped-list branch from 731512d to 782a960 Compare October 22, 2026 02:35
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 22, 2026
@CrysisDeu
CrysisDeu force-pushed the ux/profile-settings-grouped-list branch from 782a960 to 417a565 Compare October 22, 2026 04:10
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 22, 2026
@CrysisDeu
CrysisDeu force-pushed the ux/profile-settings-grouped-list branch from 417a565 to d6b8766 Compare October 22, 2026 04:27
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 22, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

HOLD at d6b8766: the UX lane's notes have no reply.

The regroup looks sound. A pick still goes through the unchanged save (compare-and-set on approval_mode, one save at a time), so the permission write path is the same (CrewProfileSettings.tsx L372-L415). Checks are green and the other lanes passed.

To clear, reply to or fix each UX note:

  1. The Model page names what Inherited resolves to only after it is picked. Consider putting it in the Inherited option's description.
  2. After a 409, the refused option keeps its pressed background while the check moves to the stored value.
  3. In dark theme the lock switch's off state is hard to read.
    If you defer any of these, open an issue and link it in the description.

One question as well: BASE disabled the dashboard-lock switch with the rest of the form while a save ran or while waiting (fieldset disabled). Now the Toggle stays live in both states. Is that intended?

— crew-pr-reviewer (r119)

@CrysisDeu
CrysisDeu force-pushed the ux/profile-settings-grouped-list branch from d6b8766 to 5526481 Compare October 22, 2026 18:06
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 22, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at 339a3d7.

Request changes — one blocking item (the Opus lane's BLOCK on this head, which I confirmed in source).

Blocking

website/src/pages/members/CrewProfileSettings.tsx — the Profile tab's Settings row is rendered with aria-label={t('pages.membersPage.profile_settings')} and the summary passed as sub={summary}. In profileRow.tsx, aria-describedby is only set when value is passed (const valueId = ariaLabel && value ? … : undefined), and aria-label replaces the name the button would otherwise take from its content. A screen-reader user therefore hears "Settings, button" and never the permission · model · worker model reading shown on screen. The test only pins toHaveAccessibleName('Settings'); nothing asserts the description (setting valueId to undefined reddens only the Permissions-row test).
Fix: describe the row by its sub line whenever aria-label is set (give RowText's sub span an id), or pass the summary as value. Then add expect(settingsRow()).toHaveAccessibleDescription('Trust · claude-opus-5 · Same as …').

Verified

  • The merge conflict label is stale: this head sits on main's tip (4ef2a92) and merges cleanly. The earlier overlap with #21007/#22966 was only the generated ui-index, the locale catalogs and the feature-map row.
  • npm run gen:ui and npm run i18n:pseudo on this head leave the tree unchanged, so the index, guidePlans.gen.ts and en-XA are regenerated, not hand-edited. npm run i18n:check passes. The new keys are in all 13 catalogs, and the removed keys have no remaining readers.
  • Every setting is still reachable: Permissions, Model, Reasoning effort, Worker model, Worker reasoning effort and the dashboard lock are all on the Settings page, and the effort rows keep base's visibility conditions. save() is unchanged, including the compare-and-set on approval_mode.
  • No recorded decision in docs/decisions/ covers this placement. The 2026-10-08 tab-order decision is untouched.
  • tsc -p tsconfig.app.json is clean. Vitest over CrewProfileSettings, CrewProfilePanel, Tablist, members.locations, uiIndex and CrewGoals: 319 passed.
  • Mutations: the retitle-keeps-upper-pages, one-level pop, card-focus fallback, inert covered level, back label, fold-closes-page, Tablist marker/ref, aria-disabled-not-disabled and group-pop-drops-picker guards each redden a named test.

Non-blocking follow-ups

  1. Test gap: re-capturing the opener on a retitle survives. The retitle test does not move focus to the back control before re-opening, which is the case the "keep the opener" branch exists for.
  2. Test gap: keying the page-open effect on push instead of push.open survives, because the fake push object is stable. The invariant the description calls out is not pinned.
  3. The option pages use role="radiogroup"/role="radio", but every option is its own Tab stop and arrow keys do nothing. Either add roving focus with arrow keys, or drop the radio roles in favour of plain buttons with aria-pressed/aria-current.
  4. Please answer the open questions already on the thread: the three UX notes (409 notice wording, the unprefixed worker-model summary value, the hover background lingering on a non-checked option), and whether the dashboard lock switch staying live while a save runs or while waiting is intended (at base it sat inside the disabled fieldset). It is harmless as far as I can see, since it is a separate endpoint and touches no thread, but the description should say so.

CI at this head: 43 success, 8 skipped, 1 neutral (CodeQL), 1 failure (the Opus lane BLOCK above), 6 still running. Auto-merge is off.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Oct 22, 2026
@CrysisDeu
CrysisDeu force-pushed the ux/profile-settings-grouped-list branch from 339a3d7 to f71203c Compare October 23, 2026 00:27
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 23, 2026
buluoray
buluoray previously approved these changes Oct 23, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at f71203c.

Approve. The blocking item from 339a3d7 is fixed and pinned by a test.

The fix

  • website/src/pages/members/profileRow.tsx: when aria-label is set, the row is now described by its sub line as well as its value. subId is derived the same way valueId is, aria-describedby joins the two, and RowText puts the id on the sub span. The Settings row now reads "Settings, button, Trust · claude-opus-5 · Same as …" instead of "Settings, button".
  • Permissions passes no sub, so its description is still the value alone (the existing toHaveAccessibleDescription('Trust') still passes). No other Row sets both aria-label and sub.
  • CrewProfileSettings.test.tsx now asserts toHaveAccessibleDescription('Trust · claude-opus-5 · Same as oncall') on the Settings row.

Verified on this head

  • The range-diff against 339a3d7 contains only this change: profileRow.tsx plus the one new assertion.
  • Three mutations each redden CrewProfileSettings row and group > shows one Settings row on the card, reading the three picks every crewmate has: subId forced to undefined; aria-describedby set back to valueId alone (the pre-fix line); and the sub span left without its id.
  • Vitest over CrewProfilePanel, CrewProfileSettings, Tablist, members.locations and uiIndex: 282 passed. tsc -p tsconfig.app.json is clean, npm run i18n:check passes, and npm run gen:ui leaves the tree unchanged.
  • The branch merges cleanly into current main (b8f981b, 5 commits ahead of this base). Only one file overlaps: docs/system-specs/modules/crew-mode.md.
  • All five AI lanes (Opus, GPT, Design, First Principles, UX) report PASS or no blocking findings on this head.

Non-blocking follow-ups (still open from the last round)

  1. Test gap: re-capturing the opener on a retitle survives a mutation, because the retitle test does not move focus to the back control before re-opening.
  2. Test gap: keying the page-open effect on push instead of push.open survives, because the fake push object is stable.
  3. The option pages use role="radiogroup"/role="radio", but each option is its own Tab stop and arrow keys do nothing. Either add roving focus with arrow keys, or use plain buttons with aria-pressed.
  4. Please reply on the thread to the UX lane's three notes on this head (the "Same as Kiro" summary wording, the lingering hover background in the shots, and "Inherited" not naming the model it resolves to), and say whether the dashboard lock switch staying live during a save or while waiting is intended.
  5. The test list in the description still names only the Settings row's accessible name. Add the new description assertion.

CI at this head when reviewed: 63 success, 11 skipped, 0 failure, 26 still running or queued; PR Readiness pending. Auto-merge is off.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

@buluoray thanks — all addressed; the next head carries them (pushing once the current head's round is terminal).

Blocking — fixed in f71203c3a4 already (your review landed on 339a3d76ca): Row now puts an id on its sub line and aria-describedby names it (and the value) whenever aria-label is set, so the Settings row reads "Settings — Trust · claude-opus-5". The test asserts toHaveAccessibleDescription(...). Opus lane is green on that head.

Follow-ups

  1. Retitle test: the existing case does move focus to the back control before the re-open (expect(document.activeElement).toBe(crew-profile-back) right before reopen settings), so the keep-the-opener branch is the one exercised; the fireEvent.click on the hidden button does not move focus in jsdom.
  2. Added: does not re-push when the card hands down a new push object with the same callbacks — rerenders with a fresh context object (same open/close), asserts open is not called again.
  3. Done: the options are now a real radio group — the checked option is the Tab stop, Up/Down/Home/End move focus (wrapping) and never pick, Enter/Space picks. Test added.
  4. Answers:
    • 409 wording: unchanged existing key profile_permission_changed ("The permission changed elsewhere. This is the current setting."); it moved onto the open page, no copy change.
    • Worker summary: dropped from the row — it now reads permission · model only ("Same as Kiro" beside Kiro's own name was the riddle the UX reader hit).
    • Hover lingering in shots: harness now moves the pointer off the card before every still; re-captured.
    • Also per the UX lane: the Inherited option on the Model and Reasoning effort pages now carries what it resolves to as its description ("Using claude-opus-5, the crew default" / "Medium"), reusing the existing hint keys.
    • Dashboard lock staying live while a save runs / while waiting: intended. It is its own endpoint, touches no thread and is not in the one-save-at-a-time chain; at base it only sat inside the same disabled fieldset by accident of layout. Now stated in the description.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 23, 2026
@CrysisDeu
CrysisDeu force-pushed the ux/profile-settings-grouped-list branch from f71203c to 3ab17e0 Compare October 23, 2026 01:58
@CrysisDeu
CrysisDeu requested a review from buluoray October 23, 2026 01:59
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 23, 2026
buluoray
buluoray previously approved these changes Oct 23, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving at 3ab17e0fb1c7a464c4874a3355ecafcc69e71905. My approval at f71203c was dismissed by this push.

I compared the PR's own diff at the two heads (git range-diff over each merge-base). The push answers the follow-ups from my last review and the UX notes:

  • The option pages are a real radio group now: one Tab stop on the checked option (tabIndex={on ? 0 : -1}), Up/Down/Left/Right move with wrap, Home/End jump, and moving only focuses (Enter/Space picks). CrewProfileSettings.test.tsx pins it ("moves between options with the arrow keys, one Tab stop on the checked one, and never picks by moving").
  • "Inherited" now names what it resolves to on the option itself (model and reasoning effort), instead of only in the caption.
  • The Settings row's summary drops the worker pick ("Same as Kiro" beside Kiro's own name), keeping the ceiling and the model.
  • The crew-mode spec, the feature map and the capture script follow.

Checked on this head: CrewProfileSettings.test.tsx, CrewProfilePanel.test.tsx, Tablist.test.tsx pass (121), tsc -p tsconfig.app.json is clean. CI on this head: 84 success, 0 failures.

Before it can merge: the branch conflicts with main again, only in src/kiro_crew/docs/ui-index.generated.json (every other file auto-merges). Rebase and regenerate it with npm run gen:ui; do not hand-merge it.

Non-blocking: if a stored value matches none of the options, every radio gets tabIndex=-1 and the group has no Tab stop. Falling back to the first option's tab stop when none is checked would cover it.

The crewmate Profile card's Profile tab ended in a raw form: four
full-width selects and a switch, each with a two-line hint, on the same
level as the About blurb, the tiles and the Notes row. It was the
tallest block on a card meant to be a summary with doors, and a
mis-click on the Permissions select changed the crewmate's approval
ceiling with no intermediate step.

The Profile tab now shows one Settings row beside Notes, reading the
three picks every mate has. Tapping it pushes a Settings page over the
card: one iOS-style group where each picker is a row reading its value
before a chevron, and tapping that pushes a single-choice page one level
deeper. Both go through the card's own ProfilePagePushContext (the Goals
tab's mechanism), which now stacks by depth with one back control per
level naming the page under it. The picker page is titled with the row,
one option per row with its description or the resolved value as a
caption, a check on the stored value. A pick saves on the spot and the
page stays open with the check moved, so a refused permission or a
failed write is not popped out of sight. The lock stays a switch in the
group with its help as the group's caption. The Row primitive moves to
profileRow.tsx so the card and the settings share it.

The permission-mode hints become per-option descriptions
(profile_mode_*_desc) without the "Pick Normal" coda, since Normal is
the row above; the unused "Dashboard" field label goes with the form.
No field, write or route changes.

Closes #22960
@CrysisDeu
CrysisDeu force-pushed the ux/profile-settings-grouped-list branch from 3ab17e0 to 86c8628 Compare October 23, 2026 18:14
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 23, 2026
@CrysisDeu
CrysisDeu merged commit 5c4666b into main Oct 23, 2026
50 of 53 checks passed
@CrysisDeu
CrysisDeu deleted the ux/profile-settings-grouped-list branch October 23, 2026 18:17
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ux(members): fold the Profile card's settings form into an iOS grouped list with pushed pickers

3 participants