Repository navigation
feat(members): fold the Profile card's settings behind one Settings row - #22975
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the change reuses the card's existing Row and pushed-page shapes, keeps every save path the same, and rendered evidence of this revision is attached. Notes
[DESIGN-REVIEWED] 86c8628 Description read[DESCRIPTION-READ] 566bf03d3e62baaf0370261d11166b954d622adcef520409b3a430f97312d8da That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The settings move from the card into a pushed page. That is a regroup, not a removal or a changed default. Its only provenance is the description's account of a maintainer call in #22960. Notes
What this change shipsInventory (10 items) — 9 justifiedIntent: crewmate owners get a Profile card that reads as a summary, with the settings one tap away instead of shown as a raw form. This is an ADDITION (a regroup).
[FIRST-PRINCIPLES-REVIEWED] 86c8628 Description read[DESCRIPTION-READ] 243afe9e7f755e6b566bc3e96422d7f2c79f8a1f52cfd3716dc1e87dd591bd29 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the blind reader identified the new Settings row and each picker correctly and would use them. The pushed-page transition has a recording. Notes
[UX-REVIEWED] 86c8628 Description read[DESCRIPTION-READ] c6f229bac705595ad0e5b09f0d648896389597fa31b121c5e1f74719a02b01c6 That sha256 names everything this verdict read: the PR description, plus the 21 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — 🔴 changes requested (blocking)GPT 6.1 found at least one blocking issue that must be resolved before merging This comment is updated in place on each push. BLOCKING -- website/src/pages/members/CrewProfileSettings.tsx:271 -- Inherited options advertise the current pin rather than the fallback
[BLOCK-MERGE] 86c8628 Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1 — Harm is LOW-MEDIUM. The picker shows a false description of what "Inherited" resolves to, and acting on it silently changes the effort and model that new sessions run at. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
731512d to
782a960
Compare
782a960 to
417a565
Compare
417a565 to
d6b8766
Compare
|
HOLD at d6b8766: the UX lane's notes have no reply. The regroup looks sound. A pick still goes through the unchanged To clear, reply to or fix each UX note:
One question as well: BASE disabled the dashboard-lock switch with the rest of the form while a save ran or while — crew-pr-reviewer (r119) |
d6b8766 to
5526481
Compare
buluoray
left a comment
There was a problem hiding this comment.
Reviewed at 339a3d7.
Request changes — one blocking item (the Opus lane's BLOCK on this head, which I confirmed in source).
Blocking
website/src/pages/members/CrewProfileSettings.tsx — the Profile tab's Settings row is rendered with aria-label={t('pages.membersPage.profile_settings')} and the summary passed as sub={summary}. In profileRow.tsx, aria-describedby is only set when value is passed (const valueId = ariaLabel && value ? … : undefined), and aria-label replaces the name the button would otherwise take from its content. A screen-reader user therefore hears "Settings, button" and never the permission · model · worker model reading shown on screen. The test only pins toHaveAccessibleName('Settings'); nothing asserts the description (setting valueId to undefined reddens only the Permissions-row test).
Fix: describe the row by its sub line whenever aria-label is set (give RowText's sub span an id), or pass the summary as value. Then add expect(settingsRow()).toHaveAccessibleDescription('Trust · claude-opus-5 · Same as …').
Verified
- The
merge conflictlabel is stale: this head sits on main's tip (4ef2a92) and merges cleanly. The earlier overlap with #21007/#22966 was only the generated ui-index, the locale catalogs and the feature-map row. npm run gen:uiandnpm run i18n:pseudoon this head leave the tree unchanged, so the index,guidePlans.gen.tsanden-XAare regenerated, not hand-edited.npm run i18n:checkpasses. The new keys are in all 13 catalogs, and the removed keys have no remaining readers.- Every setting is still reachable: Permissions, Model, Reasoning effort, Worker model, Worker reasoning effort and the dashboard lock are all on the Settings page, and the effort rows keep base's visibility conditions.
save()is unchanged, including the compare-and-set onapproval_mode. - No recorded decision in
docs/decisions/covers this placement. The 2026-10-08 tab-order decision is untouched. tsc -p tsconfig.app.jsonis clean. Vitest over CrewProfileSettings, CrewProfilePanel, Tablist, members.locations, uiIndex and CrewGoals: 319 passed.- Mutations: the retitle-keeps-upper-pages, one-level pop, card-focus fallback, inert covered level, back label, fold-closes-page, Tablist marker/ref,
aria-disabled-not-disabledand group-pop-drops-picker guards each redden a named test.
Non-blocking follow-ups
- Test gap: re-capturing the opener on a retitle survives. The retitle test does not move focus to the back control before re-opening, which is the case the "keep the opener" branch exists for.
- Test gap: keying the page-open effect on
pushinstead ofpush.opensurvives, because the fake push object is stable. The invariant the description calls out is not pinned. - The option pages use
role="radiogroup"/role="radio", but every option is its own Tab stop and arrow keys do nothing. Either add roving focus with arrow keys, or drop the radio roles in favour of plain buttons witharia-pressed/aria-current. - Please answer the open questions already on the thread: the three UX notes (409 notice wording, the unprefixed worker-model summary value, the hover background lingering on a non-checked option), and whether the dashboard lock switch staying live while a save runs or while
waitingis intended (at base it sat inside the disabled fieldset). It is harmless as far as I can see, since it is a separate endpoint and touches no thread, but the description should say so.
CI at this head: 43 success, 8 skipped, 1 neutral (CodeQL), 1 failure (the Opus lane BLOCK above), 6 still running. Auto-merge is off.
339a3d7 to
f71203c
Compare
buluoray
left a comment
There was a problem hiding this comment.
Reviewed at f71203c.
Approve. The blocking item from 339a3d7 is fixed and pinned by a test.
The fix
website/src/pages/members/profileRow.tsx: whenaria-labelis set, the row is now described by itssubline as well as itsvalue.subIdis derived the same wayvalueIdis,aria-describedbyjoins the two, andRowTextputs the id on the sub span. The Settings row now reads "Settings, button, Trust · claude-opus-5 · Same as …" instead of "Settings, button".- Permissions passes no
sub, so its description is still the value alone (the existingtoHaveAccessibleDescription('Trust')still passes). No otherRowsets botharia-labelandsub. CrewProfileSettings.test.tsxnow assertstoHaveAccessibleDescription('Trust · claude-opus-5 · Same as oncall')on the Settings row.
Verified on this head
- The range-diff against 339a3d7 contains only this change:
profileRow.tsxplus the one new assertion. - Three mutations each redden
CrewProfileSettings row and group > shows one Settings row on the card, reading the three picks every crewmate has:subIdforced to undefined;aria-describedbyset back tovalueIdalone (the pre-fix line); and the sub span left without its id. - Vitest over CrewProfilePanel, CrewProfileSettings, Tablist, members.locations and uiIndex: 282 passed.
tsc -p tsconfig.app.jsonis clean,npm run i18n:checkpasses, andnpm run gen:uileaves the tree unchanged. - The branch merges cleanly into current main (b8f981b, 5 commits ahead of this base). Only one file overlaps:
docs/system-specs/modules/crew-mode.md. - All five AI lanes (Opus, GPT, Design, First Principles, UX) report PASS or no blocking findings on this head.
Non-blocking follow-ups (still open from the last round)
- Test gap: re-capturing the opener on a retitle survives a mutation, because the retitle test does not move focus to the back control before re-opening.
- Test gap: keying the page-open effect on
pushinstead ofpush.opensurvives, because the fake push object is stable. - The option pages use
role="radiogroup"/role="radio", but each option is its own Tab stop and arrow keys do nothing. Either add roving focus with arrow keys, or use plain buttons witharia-pressed. - Please reply on the thread to the UX lane's three notes on this head (the "Same as Kiro" summary wording, the lingering hover background in the shots, and "Inherited" not naming the model it resolves to), and say whether the dashboard lock switch staying live during a save or while
waitingis intended. - The test list in the description still names only the Settings row's accessible name. Add the new description assertion.
CI at this head when reviewed: 63 success, 11 skipped, 0 failure, 26 still running or queued; PR Readiness pending. Auto-merge is off.
|
@buluoray thanks — all addressed; the next head carries them (pushing once the current head's round is terminal). Blocking — fixed in Follow-ups
|
f71203c to
3ab17e0
Compare
buluoray
left a comment
There was a problem hiding this comment.
Re-approving at 3ab17e0fb1c7a464c4874a3355ecafcc69e71905. My approval at f71203c was dismissed by this push.
I compared the PR's own diff at the two heads (git range-diff over each merge-base). The push answers the follow-ups from my last review and the UX notes:
- The option pages are a real radio group now: one Tab stop on the checked option (
tabIndex={on ? 0 : -1}), Up/Down/Left/Right move with wrap, Home/End jump, and moving only focuses (Enter/Space picks).CrewProfileSettings.test.tsxpins it ("moves between options with the arrow keys, one Tab stop on the checked one, and never picks by moving"). - "Inherited" now names what it resolves to on the option itself (model and reasoning effort), instead of only in the caption.
- The Settings row's summary drops the worker pick ("Same as Kiro" beside Kiro's own name), keeping the ceiling and the model.
- The crew-mode spec, the feature map and the capture script follow.
Checked on this head: CrewProfileSettings.test.tsx, CrewProfilePanel.test.tsx, Tablist.test.tsx pass (121), tsc -p tsconfig.app.json is clean. CI on this head: 84 success, 0 failures.
Before it can merge: the branch conflicts with main again, only in src/kiro_crew/docs/ui-index.generated.json (every other file auto-merges). Rebase and regenerate it with npm run gen:ui; do not hand-merge it.
Non-blocking: if a stored value matches none of the options, every radio gets tabIndex=-1 and the group has no Tab stop. Falling back to the first option's tab stop when none is checked would cover it.
The crewmate Profile card's Profile tab ended in a raw form: four full-width selects and a switch, each with a two-line hint, on the same level as the About blurb, the tiles and the Notes row. It was the tallest block on a card meant to be a summary with doors, and a mis-click on the Permissions select changed the crewmate's approval ceiling with no intermediate step. The Profile tab now shows one Settings row beside Notes, reading the three picks every mate has. Tapping it pushes a Settings page over the card: one iOS-style group where each picker is a row reading its value before a chevron, and tapping that pushes a single-choice page one level deeper. Both go through the card's own ProfilePagePushContext (the Goals tab's mechanism), which now stacks by depth with one back control per level naming the page under it. The picker page is titled with the row, one option per row with its description or the resolved value as a caption, a check on the stored value. A pick saves on the spot and the page stays open with the check moved, so a refused permission or a failed write is not popped out of sight. The lock stays a switch in the group with its help as the group's caption. The Row primitive moves to profileRow.tsx so the card and the settings share it. The permission-mode hints become per-option descriptions (profile_mode_*_desc) without the "Pick Normal" coda, since Normal is the row above; the unused "Dashboard" field label goes with the form. No field, write or route changes. Closes #22960
3ab17e0 to
86c8628
Compare
Problem / Motivation
Goal: The crewmate Profile card shows its settings as a compact iOS-style group of rows, each opening its own picker page, instead of a raw form on the card.
The Profile tab ends in four full-width selects (Permissions, Model, Worker model, plus the two effort selects when the model reasons) and a switch, each with a two-line hint, sitting on the same level as the About blurb, the Memory / Workspace tiles and the Notes row. The card is meant to be a summary with doors; this block is the one thing on it that is the full machinery, exposed. It is the tallest block on the card, it reads as "edit me" on a surface the person opens to look at a crewmate, and a mis-click on the Permissions select changes the crewmate's approval ceiling with no intermediate step. Decided by the maintainer in #22960 after three rendered options.
Why it matters
Every crewmate owner opens this card; the permission ceiling of every thread with the crewmate is set on it. A form that invites edits on a reading surface is how a ceiling gets changed by accident, and a card that is two-thirds settings hides what the card is for (the crewmate's description, memory, workspace, notes).
Not a goal
approval_modeare unchanged.What changed (motivation → approach → change)
Goal: the card stays a summary with doors. Approach: reuse the two shapes the card already has — the
Row(Notes) and the pushed page (About / Notes / New schedule / the Goals tab's pages) — instead of inventing a disclosure or a modal. Of the options rendered for #22960 (a grouped list on the Profile tab itself; a single Settings row; a gear in the title bar; a 2×2 tile grid; a fifth tab; a summary chip under the name), the maintainer first picked the grouped list on the tab, then, seeing it rendered, asked for the settings to leave the Profile tab entirely and picked the single Settings row (the PR comment below records that call). So: one row on the card, the group one push away, each picker one push further.website/src/pages/members/profileRow.tsx(new): the card'sRowmoves here with an optional right-alignedvalueand anaria-labelfor a row whose accessible name must be the label alone (a find_ui location); plusRowStatic(a row holding its own control) andRowGroup(the rounded group with an optional caption).CrewProfilePanel.tsximportsRow/TONEfrom it.website/src/pages/members/CrewProfilePanel.tsx: the tab-page push becomes a stack.ProfilePagePush.open(title, onPop, depth = 0)pushes at a depth (or retitles the page already there, keeping the pages over it, so a tab's effect re-running does not rebuild a deeper level),close(depth?)drops from a depth up,hosts[depth]is one portal host per level (hoststayshosts[0]for the Goals tab, whose calls are unchanged). One layer per level; a layer under a deeper one slides a quarter-width left and goes inert, exactly as the card does under the first; the one back control names the page under the top (Settings), or the mate under the first. Escape pops one level. Focus: a push lands on the back control; a pop returns to the opener of the popped level, else the back control of the level now on top, else (nothing left and the opener gone) the card itself (tabIndex={-1}, only after a pop, never on open). ThesettingsBodyslot now renders inside the Notes row's group, under the push provider.website/src/pages/members/CrewProfileSettings.tsx: the card gets ONERow— Settings, readingpermission · model(not the worker pick: "Same as Kiro" beside Kiro's own name read as a riddle to the UX lane's blind reader) — carrying themembers.settingsfind_ui location and themembers.settingsreveal scope (useGuideRevealScope). Tapping it pushes the Settings page (depth 0): the group of rows. The two page-opening effects key on the stablepush.open/push.close, never on thepushobject (which changes when a host mounts), so a host mounting never re-runsopenand swaps the level's opener for the back control. Each picker row pushes its single-choice page (depth 1): aradiogroup, oneradioper option, the option's description under its label (what each permission mode lets the mate do; what an Inherited model or effort resolves to, so the reader sees it before picking), a trade-off caption under the list where there is one (effort, worker pages), a check on the stored value. The group has one Tab stop (the checked option); Up/Down/Home/End move focus between options and never pick; Enter / Space picks. A pick saves exactly as before (compare-and-set forapproval_mode, last-write-wins for the rest, live-slot follow-up for model / effort) and the picker stays open with the check moved, so a 409 notice or a failed write is where the person is looking. While a save runs the options are held witharia-disabled(andaria-busyon the page), never thedisabledattribute: the pick is made from the focused option, and disabling it mid-save would drop focus onto the body, outside the card's Escape handler;savealready refuses a second pick throughinFlight. A row that folds while its page is open (clearing a stale effort level from its own page) pops the page viaclose(1); the last rendered page keeps painting, held, through the exit slide. The group's pop drops any open picker with it. The checked option's label is accent-coloured and its check slot shows a spinner while its save runs, so a pick visibly lands. The lock stays aTogglein aRowStatic; its hint is the group's caption.GuideTrustRootRegionwraps the Permissions row and its page;members.permissionssits on the row. TheField/ModelField/SimpleSelectimports go.website/src/uiLocations/areas/members.ts,conditions.ts, regeneratedguidePlans.gen.ts+src/kiro_crew/docs/ui-index.generated.json): two new locations —members.profile-tab(the card's Profile tab; the card opens on Sessions, so a guide to anything on Profile selects it first; reveal statecrewmate_profile_tab_closed, scope reported byCrewProfilePanel) andmembers.settings(the row; reveal statecrewmate_settings_closed, scope reported byCrewProfileSettings).members.settingsrequiresshown_by members.editthenshown_by members.profile-tab;members.permissionsrequires those two and thenshown_by members.settings, so a guide walks card → Profile tab → Settings → Permissions. To put a marker on aTablisttab,Tablistgains thesegmentspropSegmentedControlandCrewEditorNextRailalready have ({ key, label, ...uiLocation(id) }), is added to the generator'sSEGMENT_HOSTSand toFORWARDING_PROVEN, with a rendered forwarding test insrc/test/Tablist.test.tsx.en-XA):profile_settings("Settings", the row and page title) added;profile_mode_{normal,reads,trust}_hint→profile_mode_{normal,reads,trust}_desc(the per-option descriptions, without the trailing "Pick Normal to approve each step" sentence — Normal is the row above);profile_dashboard(the form's "Dashboard" field label) removed. Translations of the descs are the existing hint translations with that last sentence dropped.website/scripts/capture-crewmate-profile-settings.mjs(new): the evidence harness, real built SPA behindserveDist+stubDashboardApi, with checks (one Settings row readingpermission · modeland no group on the card; the Settings page titled Settings with back naming the mate; no form control; every row reads its value; the picker titled with its row, back naming Settings; three options with Trust checked; one compare-and-set PUT on a pick; the page stays open; the row behind reads the new value; each other page carries its caption; a 409 shows the stored value and the notice on the page).docs/system-specs/modules/crew-mode.md(the Profile tab paragraph: the row, the stack, the reveal scope) anddocs/feature-map/README.md(the Crew Members row).Backwards compatibility
Compatible: no API, record field, route or storage shape changes; the same
PUT /api/agents/{name}bodies are sent for the same picks.ProfilePagePushonly gains optional parameters and ahostsarray; the Goals tab's calls are unchanged and its tests pass.Removes nothing: the form's five controls become five rows + pages with the same options, one push in; the three hint keys and one label key removed from the catalogs had
CrewProfileSettings.tsxas their only reader (grep on origin/main @ 2e648a7), and their text survives as the per-option descriptions.Tests
website/src/pages/members/CrewProfileSettings.test.tsx(rewritten; 52 tests, driven through a fakeProfilePagePushwith two hosts the test owns):Trust · claude-opus-5(no worker part), accessible name "Settings" AND accessible description = that reading (aria-describedbyon the sub line); nothing pushed until tapped; a new push object with the sameopen/closedoes not re-push (the effects key on the callbacks, not the object); arrow keys move focus between options with one Tab stop and never save; tapping pushes('Settings', fn, 0)and the group renders intohosts[0];(label, fn, 1)intohosts[1]; the picker's pop callback hands it back; the group's pop drops an open picker too; notices sit under the group while no picker is open, on the picker while one is;chatModecall, page stays open, check and row move; tapping the checked option writes nothing; record-only without a thread; one save at a time (pagearia-busy, optionsaria-disabled); the picked option stays focusable and focused through the save; roster cache updated; nothing saved while waiting; 409 shows the stored value and the notice on the page; a failed save puts the stored value back with the error on the page;''; a stored model the list no longer carries is offered, checked; the Inherited option names the model / level it resolves to; resolve error and degraded list notices; effort hidden on a model that does not reason; the effort page pops (close(1)) when its row folds, and a page whose own pick folded its row keeps painting, held, for the exit slide;website/src/pages/members/CrewProfilePanel.test.tsx(52): the existing cases pass (the "no guide marker" case becomes "exactly one, the Profile tab"), plus: re-opening the level under an open page keeps that page and its opener (back still returns focus to the row, not the back control); a second page stacks over the first (title and back control name each level, the lower level goes inert, back pops one level and focus returns to the row that pushed it, back again pops to the card); Escape pops one level at a time, then closes;close(0)drops a level and everything over it; a page popping with its opener unmounted lands focus on the card itself and Escape then closes it; opening the card never pulls focus onto it.The dashboard-lock switch stays live while a pick saves or while the thread is
waiting: it is its own endpoint (memberDashboardLock), touches no thread and is not part of the one-save-at-a-time chain, so there is nothing to hold it for (at base it merely sat inside the same disabled fieldset).members.locations.test.tspins the three locations' tuples;src/test/Tablist.test.tsxproves asegmentsmarker lands on that tab alone and the roving-focus ref still works;uiIndex.test.ts(136) andGuideLayer.uiShow.test.tsx(62) pass on the regenerated index;CrewGoals.test.tsx(37) passes on the stacked push unchanged.Manual verification
node scripts/capture-crewmate-profile-settings.mjsagainst the real built SPA, light and dark: all checks OK (listed in the harness header). Verified in the renders: the Profile tab with the Settings row in the Notes group and nothing else of the settings; the Settings page with back naming the mate; the Permissions page with back naming Settings; the check moving to Normal after a pick with the page still open; the row behind reading Normal; the Worker model page's caption; the 409 state.Screenshots / video
Light: the Profile tab (one Settings row, Opus pinned), the Settings page one push in, the Permissions page one push further (back names Settings), and the same page after picking Normal:
A refused pick (409
approval_mode_conflict): the page stays open, the check lands on the stored value, the notice is on the page:The other pages with their captions under the list:
The flow (row → Settings → Permissions → pick Reads → back → Model → back → back to the card):
walkthrough.webm
Other theme variants
Related Issues
Closes #22960
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.