Repository navigation
fix(website): label untitled sessions in the grid picker, Sessions page and Older Sessions - #22987
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Each of the three surfaces reuses the existing What this change shipsInventory (6 items) — 6 justifiedIntent: a person sees "Untitled session" instead of a machine slot id when a session has no real title. This is a FIX (#20873, #20875, #20876).
[FIRST-PRINCIPLES-REVIEWED] d748a30 Description read[DESCRIPTION-READ] 1325a49ffa3008bf7f2f5903e7506bb3864fb5aee3ffeb92f03277c2a7a2ff3c That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. Three label call sites now use the shared Notes
[DESIGN-REVIEWED] d748a30 Description read[DESCRIPTION-READ] aa2c018bb5ead558fc5662a813e5d2eef637921c0fe371e85cfeaca8c4e68811 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The blind reader read "Untitled session" as "conversations that were never given a name" on all three surfaces, in both themes. Notes
[UX-REVIEWED] d748a30 Description read[DESCRIPTION-READ] 68bf1174c029ad151d4ab6a7989b77df24b4a4177225b750ef357971fbbdde9b That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Real Adapter Contract Tests is red here for a reason outside this PR. The same three tests in 🤖 AI-assisted comment 🤖 |
…ge and Older Sessions
9504393 to
d748a30
Compare
|
Review-ready on head d748a30: all 105 checks pass, Main has moved one commit since this head went green, in This PR fixes the grid picker, the Sessions page and Older Sessions, and closes #20873, #20875 and #20876. #22049 stays open for the remaining sites. It now waits only on a maintainer review. I have not merged, approved or turned on auto-merge. 🤖 AI-assisted comment 🤖 |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (7 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: the session grid picker, the Sessions page and Older Sessions show the shared untitled-session label instead of the raw slot key. Spec files changed as a ride-along (a minority of the diff on both file count and changed lines), not reviewed as a design decision: docs/system-specs/modules/history.md.
Problem / Motivation
Goal: An untitled session shows "Untitled session" instead of its internal slot key in the session grid picker, on the Sessions page and in the chat sidebar's Older Sessions rows.
Three surfaces fell back to
title || key. A session with no title, or with its key as its title, showed a machine id such aschat-9-1785440411as its name.Why it matters
The key means nothing to a reader. Two untitled rows looked like two random ids, and the Older Sessions hover tooltip repeated the id.
Not a goal
title || keysites listed in Route the remaining untitled-session labels through sessionDisplayTitle #22049 (session tabs, chat pane, command palette providers, composer dock, notices, system rows, memory tab). They follow in later PRs.What changed (motivation → approach → change)
components/SessionGridView.tsx)pages/SessionsPage.tsx)pages/chat-sidebar/HistoryPane.tsx)All three read the shared
sessionDisplayTitlehelper from #22041. It treats a missing title and a title equal to the key as untitled. A real title shows as before, and a title that arrives later replaces the label on the next render.Only the shown label changes. The grid picker still finds a session by its key and opens that key. A Sessions page click still goes to
/chat?sid=<key>. An Older Sessions row still resumes its key, and theresumeFromHistorypayload title staystitle || key.The
history.mdspec section on the Sessions sidebar states the rule for the three surfaces.Backwards compatibility
Compatible: only the displayed label of an untitled session changes; keys, routes, payloads and stored data are untouched.
Removes nothing: no path, key, record or function is removed; search reads the same fields as before.
Tests
website/src/test/SessionGridViewCoverage.test.tsx: an untitled row and a key-titled row read "Untitled session" and not their keys; a named row keeps its name; typing the key still finds the untitled row and picking it opens that key. Replaces the case that pinned the key fallback.website/src/test/SessionsPage.test.tsx: the same three rows on the Sessions page; a click on the untitled row navigates with its key.website/src/test/ChatSidebar.historyUntitledLabel.test.tsx(new): renders the real sidebar and opens Older Sessions; untitled rows read "Untitled session" in text and hover title; Enter on one resumes with(key, key), the unchanged payload.All three cases fail with the production files reverted to
origin/mainand pass with them. Determinism: the three files passed 3 of 3 runs with--sequence.shuffle.Manual verification
Rendered the real
SessionGridView,SessionsPageandChatSidebaron a loopback vite server with stubbed API answers, in dark and light themes. Before each capture the script asserted that no untitled key appears in the rendered text.Screenshots / video
Session grid picker, light:
Sessions page, light:
Older Sessions, dark:
Other theme
Related Issues
Part of #22049
Closes #20873
Closes #20875
Closes #20876
Pattern harvest
Rule candidate: semgrep
Pattern: a session label rendered as
title || keyin website/src shows an internal id; route it throughsessionDisplayTitle.Checklist