Repository navigation
feat(sidebar): setting to make Cmd/Ctrl-click on New open the active tab - #22994
Pearcekieser wants to merge 1 commit into
Conversation
|
note (non-blocking): labels and a ruling check. This fork account cannot add labels. Could a maintainer add a high-priority label to #22993 and this PR? The reporter asked for high priority. @bolichen97, this adds an opt-in setting next to your 2026-10-17 ruling on #18544 rather than reversing it. The default stays background, and the setting only swaps the Shift meaning on the create controls. Does that work for you? |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Default-off opt-in. With the setting off, the gesture logic is equivalent to the shipped ruling, and the exception the setting creates is already put to a maintainer. Notes
[DESIGN-REVIEWED] ef7344c Description read[DESCRIPTION-READ] d5afc2828add2a513701d38015db9387a651a473a35e81b46b4a0a0744fa4878 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. Both toggle states are in the screenshots, but no first-time reader has seen them because this is the fork lane. Pushing the branch to this repository would get the blind read. Notes
[UX-REVIEWED] ef7344c Description read[DESCRIPTION-READ] 01687902e02421315270b2e2e20f31f800a38a1893c66e5639e7c23e2dff4e3f That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS The opt-in defaults off, so the 2026-10-17 ruling still holds for everyone who doesn't choose it. The description itself flags that the setting departs from that ruling when on and needs a maintainer to accept it. Notes
What this change shipsInventory (6 items) — 5 justifiedIntent: let someone who opens new chats with Ctrl/Cmd-click land in the new chat without a second click. ADDITION.
[FIRST-PRINCIPLES-REVIEWED] ef7344c Description read[DESCRIPTION-READ] 1691b6e7d2b86353db4dc4d3b1dc7d4937bcfdf6eb5f58b8249d5857e800f93e That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review (fork) — 🔴 changes requested (blocking)Reviewed Blocks: the new opt-in setting reverses a recorded maintainer decision, and the PR adds no superseding entry. The decision says Cmd/Ctrl-click opens a background tab on every sidebar control, so that a session row and a create control never do different things for the same click. BLOCKING — website/src/pages/chat-sidebar/chrome.tsx:350 Notes:
|
|
target=design head=e95dded46e8fdf63c888eee222316edc0a80b073 disposition=rebutted
note (non-blocking): agreed, nothing to change.
|
|
target=first-principles head=e95dded46e8fdf63c888eee222316edc0a80b073 disposition=rebutted
note (non-blocking): the inherited item is accepted as written.
|
|
target=ux head=e95dded46e8fdf63c888eee222316edc0a80b073 disposition=rebutted
note (non-blocking): no blind read is possible from a fork.
|
|
chore (non-blocking): two CI jobs need a rerun, and a fork account cannot start one. Screenshot Evidence was cancelled during its checkout step, before it read anything (job). Fork Opus 5.5 Review finished with no verdict for e95dded (check). Neither is a finding on the code. Could a maintainer rerun both? |
GPT 6.1 Review (fork) — 🔴 changes requested (blocking)Reviewed 1 of 1 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands. BLOCKING -- website/src/pages/chat-sidebar/chrome.tsx:36 -- Opt-in gesture swap reverses a recorded maintainer decision
[BLOCK-MERGE] ef7344c Adjudication (Opus 5.5) — is blocking on each finding proportionate?I couldn't flag F1: the only thing it needs is the person turning on the new setting, which is ordinary use, not a rare edge case. I upheld it as fenced. F1: the change is opt-in, and the default stays |
|
target=gpt head=e95dded46e8fdf63c888eee222316edc0a80b073 span=3d475fa4ca2b disposition=needs-a-decision
question (blocking): @bolichen97, does an opt-in exception to the 2026-10-17 ruling work for you?
|
e95dded to
772ec38
Compare
|
chore (non-blocking): rebased on main with no behaviour change. The conflict was in the generated ui-index.generated.json, which I regenerated with npm run gen:ui. The same push fixes the Frontend Tests (3) red. The Hindi label used the आप verb form जाएँ, which the hi style test rejects, so it now uses the तुम form जाओ. The GPT finding on span=3d475fa4ca2b still waits for @bolichen97's call on the 2026-10-17 decision. |
|
target=gpt head=772ec385a97e4d7825a61175d0de54a8965579a4 span=3d475fa4ca2b disposition=needs-a-decision
question (blocking): waiting on a maintainer ruling on the opt-in exception.
|
|
target=fable head=772ec385a97e4d7825a61175d0de54a8965579a4 span=dcd3b9c2e30f disposition=needs-a-decision
question (blocking): waiting on a maintainer ruling on the opt-in exception.
|
|
target=design head=772ec385a97e4d7825a61175d0de54a8965579a4 disposition=rebutted
note (non-blocking): agreed, nothing to change.
|
|
target=first-principles head=772ec385a97e4d7825a61175d0de54a8965579a4 disposition=rebutted
note (non-blocking): agreed, nothing to change.
|
|
target=design head=56812f8b173e521bbd0f088e2905592fe555178a disposition=rebutted
note (non-blocking): agreed, nothing to change. Off keeps the ruling, and the swap stays inside createTabModeForClick. |
|
target=first-principles head=56812f8b173e521bbd0f088e2905592fe555178a disposition=rebutted
note (non-blocking): agreed, nothing to change. The default is unchanged and the setting traces to #22993. |
|
target=ux head=56812f8b173e521bbd0f088e2905592fe555178a disposition=rebutted
note (non-blocking): agreed, nothing to change. A fork PR cannot get the blind read. The off and on states are in the committed screenshots under temp-screenshots/new-chat-tab-active. The hint text is new_chat_tab_active_desc in en.json. |
|
target=fable head=6ddcada0d9141004a29c0411453fd6c1224c6910 span=dcd3b9c2e30f disposition=rebutted
issue (blocking): rebutted as a defect. The exception needs a maintainer decision.
@bolichen97, if the opt-in exception is fine with you, this line clears the Opus lane for this head: |
|
target=gpt head=6ddcada0d9141004a29c0411453fd6c1224c6910 span=3d475fa4ca2b disposition=rebutted
issue (blocking): rebutted as a defect. The exception needs a maintainer decision.
@bolichen97, if the opt-in exception is fine with you, this line clears the GPT lane for this head: |
|
target=first-principles head=6ddcada0d9141004a29c0411453fd6c1224c6910 span=21a12a580aa7 disposition=rebutted
issue (blocking): framing corrected. The reversal needs a maintainer decision.
@bolichen97, if the opt-in exception is fine with you, this line clears the First Principles lane for this head: |
|
target=design head=6ddcada0d9141004a29c0411453fd6c1224c6910 disposition=rebutted
note (non-blocking): agreed, nothing to change. Off keeps the ruling, and the swap stays inside createTabModeForClick. |
|
target=ux head=6ddcada0d9141004a29c0411453fd6c1224c6910 disposition=rebutted
note (non-blocking): agreed, nothing to change. A fork PR cannot get the blind read. The off and on states are in the committed screenshots under temp-screenshots/new-chat-tab-active. The hint text is new_chat_tab_active_desc in en.json. |
|
target=fable head=ec19c2f91eeb79bf4e16722c2e797044096018ee span=dcd3b9c2e30f disposition=rebutted
issue (blocking): rebutted as a defect. The exception needs a maintainer decision.
@bolichen97, if the opt-in exception is fine with you, this line clears the Opus lane for this head: |
|
target=gpt head=ec19c2f91eeb79bf4e16722c2e797044096018ee span=3d475fa4ca2b disposition=rebutted
issue (blocking): rebutted as a defect. The exception needs a maintainer decision.
@bolichen97, if the opt-in exception is fine with you, this line clears the GPT lane for this head: |
|
target=ux head=029e18fcb9d3503a8fb9c6b659fdd54cbf43c4d1 disposition=rebutted
note (non-blocking): agreed, nothing to change. A fork PR cannot get the blind read. The off and on states are in the committed screenshots under temp-screenshots/new-chat-tab-active. The hint text is new_chat_tab_active_desc in en.json. |
|
target=fable head=029e18fcb9d3503a8fb9c6b659fdd54cbf43c4d1 span=dcd3b9c2e30f disposition=rebutted
issue (blocking): rebutted as a defect. The exception needs a maintainer decision.
@bolichen97, if the opt-in exception is fine with you, this line clears the Opus lane for this head: |
|
target=design head=029e18fcb9d3503a8fb9c6b659fdd54cbf43c4d1 span=d751722bc9cc disposition=rebutted
note (non-blocking): agreed. The exception needs a maintainer to accept it, and the code does not change.
|
|
target=first-principles head=029e18fcb9d3503a8fb9c6b659fdd54cbf43c4d1 disposition=rebutted
note (non-blocking): agreed, nothing to change. The setting is off by default, and the description says that with it on, the PR departs from the 2026-10-17 ruling. A maintainer still has to accept that exception, and the Opus and GPT dispositions for this head carry the override lines for it. |
|
target=fable head=4320df0c45b79dcaa9c61accbe0f0dce91d94942 span=dcd3b9c2e30f disposition=rebutted
issue (blocking): rebutted as a defect. The exception needs a maintainer decision.
@bolichen97, if the opt-in exception is fine with you, this line clears the Opus lane for this head: |
|
target=fable head=c69b1949f01d13480948af961f3e56c361bddc32 span=dcd3b9c2e30f disposition=rebutted
issue (blocking): rebutted as a defect. The exception needs a maintainer decision.
@bolichen97, if the opt-in exception is fine with you, this line clears the Opus lane for this head: |
|
target=gpt head=c69b1949f01d13480948af961f3e56c361bddc32 span=3d475fa4ca2b disposition=rebutted
issue (blocking): rebutted as a defect. The exception needs a maintainer decision.
@bolichen97, if the opt-in exception is fine with you, this line clears the GPT lane for this head: |
|
target=fable head=2400871e49bd9e08dc363a1d94aeebc924f56c04 span=dcd3b9c2e30f disposition=rebutted
issue (blocking): rebutted as a defect. The exception needs a maintainer decision.
@bolichen97, if the opt-in exception is fine with you, this line clears the Opus lane for this head: |
|
target=gpt head=2400871e49bd9e08dc363a1d94aeebc924f56c04 span=3d475fa4ca2b disposition=rebutted
issue (blocking): rebutted as a defect. The exception needs a maintainer decision.
@bolichen97, if the opt-in exception is fine with you, this line clears the GPT lane for this head: |
|
target=fable head=5e1fe06f5c1953e40ed427c604f256178c49dbb8 span=dcd3b9c2e30f disposition=rebutted
issue (blocking): rebutted as a defect. The exception needs a maintainer decision.
@bolichen97, if the opt-in exception is fine with you, this line clears the Opus lane for this head: |
|
target=gpt head=5e1fe06f5c1953e40ed427c604f256178c49dbb8 span=3d475fa4ca2b disposition=rebutted
issue (blocking): rebutted as a defect. The exception needs a maintainer decision.
@bolichen97, if the opt-in exception is fine with you, this line clears the GPT lane for this head: |
|
target=design head=5e1fe06f5c1953e40ed427c604f256178c49dbb8 span=2ed749b97bfb disposition=rebutted
note (non-blocking): agreed. The exception needs a maintainer to accept it, and the code does not change.
|
|
target=first-principles head=5e1fe06f5c1953e40ed427c604f256178c49dbb8 disposition=rebutted
note (non-blocking): agreed, nothing to change. The setting is off by default, and the description says that with it on, the PR departs from the 2026-10-17 ruling. A maintainer still has to accept that exception, and the Opus and GPT dispositions for this head carry the override lines for it. |
|
target=ux head=5e1fe06f5c1953e40ed427c604f256178c49dbb8 disposition=rebutted
note (non-blocking): agreed, nothing to change. A fork PR cannot get the blind read. The off and on states are in the committed screenshots under temp-screenshots/new-chat-tab-active. The hint text is new_chat_tab_active_desc in en.json. |
|
target=fable head=ef7344ce58e3ed4666a47f3e5d4a20ae7bc26f55 span=dcd3b9c2e30f disposition=rebutted
issue (blocking): rebutted as a defect. The exception needs a maintainer decision.
@bolichen97, if the opt-in exception is fine with you, this line clears the Opus lane for this head: |
|
target=gpt head=ef7344ce58e3ed4666a47f3e5d4a20ae7bc26f55 span=3d475fa4ca2b disposition=rebutted
issue (blocking): rebutted as a defect. The exception needs a maintainer decision.
@bolichen97, if the opt-in exception is fine with you, this line clears the GPT lane for this head: |
|
target=first-principles head=ef7344ce58e3ed4666a47f3e5d4a20ae7bc26f55 disposition=rebutted
note (non-blocking): agreed, nothing to change. The setting is off by default, and the description says that with it on, the PR departs from the 2026-10-17 ruling. A maintainer still has to accept that exception, and the Opus and GPT dispositions for this head carry the override lines for it. |
|
target=ux head=ef7344ce58e3ed4666a47f3e5d4a20ae7bc26f55 disposition=rebutted
note (non-blocking): agreed, nothing to change. A fork PR cannot get the blind read. The off and on states are in the committed screenshots under temp-screenshots/new-chat-tab-active. The hint text is new_chat_tab_active_desc in en.json. |
Problem / Motivation
Goal: Let a user choose that Ctrl-click (Cmd-click on macOS) on a sidebar New control opens the new chat as the active tab.
Since the 2026-10-17 ruling on #18544, Ctrl-click on the header New button, a folder's
+or an empty folder's "New chat in " row opens the new chat in a background tab. Ctrl+Shift-click opens it as the active tab. A new chat is empty, and you almost always open one to start typing straight away. A background tab for it is rarely what you want, so you end up clicking over to it every time.Why it matters
Anyone who opens new chats with Ctrl-click pays an extra click per chat, or a two-modifier chord, to reach the chat they just made. The setting gives them the one-modifier gesture. With the setting off, every gesture stays as the ruling shipped it.
Not a goal
What changed (motivation → approach → change)
createTabModeForClickinchrome.tsxalready decides the tab mode for all five create-control click sites. I made it read a newmc-chat-configfield,newChatTabActive, at click time. When the field is true, the Shift key's meaning flips. Ctrl-click opens the active tab and Ctrl+Shift-click opens a background tab, the same swap a browser's "switch to new tabs immediately" option makes. Any value other thantruereads as off, so an older stored blob or a partial config keeps today's behaviour.The toggle is "Switch to New Chat Tabs" in Settings > Chat > Sessions, below "Show Full Titles While Scrolling". Its label and hint are in every
website/src/i18n/locales/*.jsoncatalog, including the pseudo-localeen-XA.json.npm run gen:settingsandnpm run gen:uiregeneratedsettings-registry.generated.json,settingsRegistry.gen.tsandui-index.generated.jsonso the toggle is searchable and deep-linkable. Becausemc-chat-configis already inDURABLE_PREF_KEYS, the choice is backed up with the rest of the chat config.With the setting on, this change departs from
docs/decisions/2026-10-17-sidebar-create-controls-shift-opens-the-active-tab.md. That ruling says that Ctrl-click opens a background tab on every control, so that a session row and a create control never act differently for the same click. With the setting on, Ctrl-click on a create control opens the active tab, but Ctrl-click on a session row still opens a background tab. A maintainer must accept this opt-in exception before the PR merges, with an override or a superseding entry.Backwards compatibility
Compatible: the new field defaults to false, and
loadChatConfigcoerces a non-boolean to false, so every existing client keeps the shipped gestures.Removes nothing: the change adds one optional config field and one toggle, and no existing gesture, key or setting is removed or renamed.
Tests
ChatSidebar.folderCreateInTab.test.tsxgets two cases with the setting on. In the first, Ctrl-click on a folder's+opens a foreground tab. In the second, Ctrl+Shift-click on the empty-folder row opens a background tab. Both check that the create does not activate the new session itself, because the tab opener switches to it. The existing default-off cases still pass unchanged, which pins the default.Locally, 299 related frontend test files (5089 tests) passed, along with
tsc -p tsconfig.app.json, and 14 backend files that read the generated registry and UI index (857 tests) passed. The related backend batch fromlocal-gate.pyhad 115 failures in seven files, includingtest_file_explorer_app.pyandtest_cloud_source.py. Those files fail the same way on a cleanorigin/mainworktree on this host, so CI decides them.Manual verification
I rendered the built SPA against fixture data with the settings capture harness. The toggle shows in the Sessions card, off by default, and one click stores
{"newChatTabActive":true}inmc-chat-config.Screenshots / video
The setting off, which is the default:
The setting on:
Related Issues
Follow-up to #18544, which set the background-tab default.
Checklist
Fixes #22993