Skip to content

feat(sidebar): setting to make Cmd/Ctrl-click on New open the active tab - #22994

Open
Pearcekieser wants to merge 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/folder-new-session-ctrl-click-focus
Open

Pearcekieser wants to merge 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/folder-new-session-ctrl-click-focus

Conversation

@Pearcekieser

@Pearcekieser Pearcekieser commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Let a user choose that Ctrl-click (Cmd-click on macOS) on a sidebar New control opens the new chat as the active tab.

Since the 2026-10-17 ruling on #18544, Ctrl-click on the header New button, a folder's + or an empty folder's "New chat in " row opens the new chat in a background tab. Ctrl+Shift-click opens it as the active tab. A new chat is empty, and you almost always open one to start typing straight away. A background tab for it is rarely what you want, so you end up clicking over to it every time.

Why it matters

Anyone who opens new chats with Ctrl-click pays an extra click per chat, or a two-modifier chord, to reach the chat they just made. The setting gives them the one-modifier gesture. With the setting off, every gesture stays as the ruling shipped it.

Not a goal

  • Changing the default. Off keeps the ruling exactly as shipped.
  • Changing Ctrl-click on session rows, middle-click or plain click.
  • Writing a superseding decision entry. AGENTS.md says that only a maintainer writes one.

What changed (motivation → approach → change)

createTabModeForClick in chrome.tsx already decides the tab mode for all five create-control click sites. I made it read a new mc-chat-config field, newChatTabActive, at click time. When the field is true, the Shift key's meaning flips. Ctrl-click opens the active tab and Ctrl+Shift-click opens a background tab, the same swap a browser's "switch to new tabs immediately" option makes. Any value other than true reads as off, so an older stored blob or a partial config keeps today's behaviour.

The toggle is "Switch to New Chat Tabs" in Settings > Chat > Sessions, below "Show Full Titles While Scrolling". Its label and hint are in every website/src/i18n/locales/*.json catalog, including the pseudo-locale en-XA.json. npm run gen:settings and npm run gen:ui regenerated settings-registry.generated.json, settingsRegistry.gen.ts and ui-index.generated.json so the toggle is searchable and deep-linkable. Because mc-chat-config is already in DURABLE_PREF_KEYS, the choice is backed up with the rest of the chat config.

With the setting on, this change departs from docs/decisions/2026-10-17-sidebar-create-controls-shift-opens-the-active-tab.md. That ruling says that Ctrl-click opens a background tab on every control, so that a session row and a create control never act differently for the same click. With the setting on, Ctrl-click on a create control opens the active tab, but Ctrl-click on a session row still opens a background tab. A maintainer must accept this opt-in exception before the PR merges, with an override or a superseding entry.

Backwards compatibility

Compatible: the new field defaults to false, and loadChatConfig coerces a non-boolean to false, so every existing client keeps the shipped gestures.

Removes nothing: the change adds one optional config field and one toggle, and no existing gesture, key or setting is removed or renamed.

Tests

ChatSidebar.folderCreateInTab.test.tsx gets two cases with the setting on. In the first, Ctrl-click on a folder's + opens a foreground tab. In the second, Ctrl+Shift-click on the empty-folder row opens a background tab. Both check that the create does not activate the new session itself, because the tab opener switches to it. The existing default-off cases still pass unchanged, which pins the default.

Locally, 299 related frontend test files (5089 tests) passed, along with tsc -p tsconfig.app.json, and 14 backend files that read the generated registry and UI index (857 tests) passed. The related backend batch from local-gate.py had 115 failures in seven files, including test_file_explorer_app.py and test_cloud_source.py. Those files fail the same way on a clean origin/main worktree on this host, so CI decides them.

Manual verification

I rendered the built SPA against fixture data with the settings capture harness. The toggle shows in the Sessions card, off by default, and one click stores {"newChatTabActive":true} in mc-chat-config.

Screenshots / video

The setting off, which is the default:

Sessions settings with Switch to New Chat Tabs off

The setting on:

Sessions settings with Switch to New Chat Tabs on

Related Issues

Follow-up to #18544, which set the background-tab default.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Fixes #22993

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

note (non-blocking): labels and a ruling check. This fork account cannot add labels. Could a maintainer add a high-priority label to #22993 and this PR? The reporter asked for high priority. @bolichen97, this adds an opt-in setting next to your 2026-10-17 ruling on #18544 rather than reversing it. The default stays background, and the setting only swaps the Shift meaning on the create controls. Does that work for you?

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 22, 2026
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of ef7344ce58e3ed4666a47f3e5d4a20ae7bc26f55 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Default-off opt-in. With the setting off, the gesture logic is equivalent to the shipped ruling, and the exception the setting creates is already put to a maintainer.

Notes

  • With the setting on, it overrides the "one modifier keeps one meaning across the sidebar" reason in docs/decisions/2026-10-17-sidebar-create-controls-shift-opens-the-active-tab.md. The description says a maintainer must accept this exception before merge. That acceptance should be a superseding decision entry, not just a PR comment, so the next reader of the decision log can see the toggle.

[DESIGN-REVIEWED] ef7344c

Description read

[DESCRIPTION-READ] d5afc2828add2a513701d38015db9387a651a473a35e81b46b4a0a0744fa4878

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ✅ PASS

UX-level review of ef7344ce58e3ed4666a47f3e5d4a20ae7bc26f55 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. Both toggle states are in the screenshots, but no first-time reader has seen them because this is the fork lane. Pushing the branch to this repository would get the blind read.

Notes

  • The label "Switch to New Chat Tabs" doesn't say it only applies to Cmd/Ctrl-click. Read on its own, it sounds like it changes a plain click on New, and the modifier is only explained behind the ⓘ tooltip. A label like "Cmd/Ctrl-Click on New Opens the Active Tab" would carry that meaning.
  • No screenshot shows the tooltip text (new_chat_tab_active_desc). Attaching a capture of the hovered ⓘ would show how the {{mod}} substitution and the length of that line actually render.

[UX-REVIEWED] ef7344c

Description read

[DESCRIPTION-READ] 01687902e02421315270b2e2e20f31f800a38a1893c66e5639e7c23e2dff4e3f

That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of ef7344ce58e3ed4666a47f3e5d4a20ae7bc26f55 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

The opt-in defaults off, so the 2026-10-17 ruling still holds for everyone who doesn't choose it. The description itself flags that the setting departs from that ruling when on and needs a maintainer to accept it.

Notes

  • Item 2 — inherited: the foreground gesture already exists ("Ctrl+Shift-click opens it as the active tab"). The setting only saves one modifier key, its premise is a preference ("rarely what you want"), and its model is an analogy ("the same swap a browser's … option makes"). It also breaks the ruling's stated reason when on: "One modifier keeps one meaning across the sidebar." Subtraction: delete newChatTabActive and keep Ctrl+Shift-click as the one foreground gesture, unless a maintainer accepts the exception.

What this change ships

Inventory (6 items) — 5 justified

Intent: let someone who opens new chats with Ctrl/Cmd-click land in the new chat without a second click. ADDITION.

  1. New "Switch to New Chat Tabs" toggle in Settings › Chat › Sessions, off by default — justified
  2. With it on, Ctrl/Cmd-click on New, folder + or the empty-folder row opens the active tab — inherited: one-modifier saving over an existing gesture
  3. With it on, Ctrl/Cmd+Shift-click on those controls opens a background tab — justified
  4. The toggle can be found in command-palette search and opened by deep link (generated registry and UI index) — justified
  5. Label and hint translated in every locale catalog — justified
  6. Two screenshot PNGs committed under temp-screenshots/ (the fork exception in .gitignore) — justified

[FIRST-PRINCIPLES-REVIEWED] ef7344c

Description read

[DESCRIPTION-READ] 1691b6e7d2b86353db4dc4d3b1dc7d4937bcfdf6eb5f58b8249d5857e800f93e

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — 🔴 changes requested (blocking)

Reviewed ef7344ce58e3ed4666a47f3e5d4a20ae7bc26f55 via the fork AI-review pipeline; updated in place on each push.

Blocks: the new opt-in setting reverses a recorded maintainer decision, and the PR adds no superseding entry. The decision says Cmd/Ctrl-click opens a background tab on every sidebar control, so that a session row and a create control never do different things for the same click.

BLOCKING — website/src/pages/chat-sidebar/chrome.tsx:350
const foreground = e.shiftKey !== (loadChatConfig().newChatTabActive === true)
Trigger: A user turns on Settings → Chat → Sessions → "Switch to New Chat Tabs" (ChatPanel.tsx:1124). They then Cmd/Ctrl-click the New button, a folder +, or an empty folder's row. Each of these calls createTabModeForClick and now gets 'foreground'.
Outcome: Cmd/Ctrl-click on a create control opens the chat as the active tab, while Cmd/Ctrl-click on a session row still opens a background tab. The same modifier now does two different things in the sidebar. That is the behaviour docs/decisions/2026-10-17-sidebar-create-controls-shift-opens-the-active-tab.md records and rules out ("Cmd/Ctrl-click means 'open in a background tab' on every control"; "One modifier keeps one meaning across the sidebar"). The diff adds no superseding entry.
Anchor: recorded-decisions-are-not-regressions
Fix: Either add a superseding docs/decisions/ entry with a Supersedes: line that cites a maintainer's on-record ruling, landed through the maintainer-override path, or drop the swap setting and keep the gesture contract as recorded.

Notes:

  • temp-screenshots/new-chat-tab-active/*.png are scratch PR-evidence binaries committed at the repo root, and nothing references them. They belong on the PR, not in the tree.
  • The new_chat_tab_active_desc hint names only the New button, but the swap also applies to folder +, empty-folder rows and board-lane create controls.

[BLOCK-MERGE] ef7344c
[OPUS-REVIEWED] ef7344c

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=design head=e95dded46e8fdf63c888eee222316edc0a80b073 disposition=rebutted

note (non-blocking): agreed, nothing to change.

Off is the default, and with it off createTabModeForClick returns the base mode for every modifier combination. The two default-off tests in ChatSidebar.folderCreateInTab.test.tsx still pass unchanged.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=first-principles head=e95dded46e8fdf63c888eee222316edc0a80b073 disposition=rebutted

note (non-blocking): the inherited item is accepted as written.

The setting rests on the per-chat cost: a new chat is empty, so a background tab for it means one more click before typing. The browser option is a description of the swap, not the justification.
With the setting on, a user has chosen to give up one-modifier-one-meaning for the create controls. Off keeps the ruling, so nobody loses it without opting in.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=ux head=e95dded46e8fdf63c888eee222316edc0a80b073 disposition=rebutted

note (non-blocking): no blind read is possible from a fork.

This PR comes from a fork, so a same-repo push is not available to the author. Both screenshots are committed under temp-screenshots/new-chat-tab-active and show the toggle off by default and on. A maintainer can run the same-repo lane if they want the blind read.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

chore (non-blocking): two CI jobs need a rerun, and a fork account cannot start one. Screenshot Evidence was cancelled during its checkout step, before it read anything (job). Fork Opus 5.5 Review finished with no verdict for e95dded (check). Neither is a finding on the code. Could a maintainer rerun both?

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — 🔴 changes requested (blocking)

Reviewed ef7344ce58e3ed4666a47f3e5d4a20ae7bc26f55 via the fork AI-review pipeline; updated in place on each push.

1 of 1 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands.

BLOCKING -- website/src/pages/chat-sidebar/chrome.tsx:36 -- Opt-in gesture swap reverses a recorded maintainer decision

const foreground = e.shiftKey !== (loadChatConfig().newChatTabActive === true)
Trigger: Enable “Switch to New Chat Tabs,” then Cmd/Ctrl-click New while connected and remain on the current session until creation completes; createTabModeForClick → createChatMutation → openSlotInNewTab passes background: false and switches sessions.
Outcome: The click activates the new chat while the identical click on a session row opens a background tab, reversing docs/decisions/2026-10-17-sidebar-create-controls-shift-opens-the-active-tab.md without a superseding decision.
Anchor: recorded-decisions-are-not-regressions
Fix: Obtain an explicit maintainer override accepting this opt-in exception through the recorded-decision process.

[BLOCK-MERGE] ef7344c
[GPT-REVIEWED] ef7344c

Adjudication (Opus 5.5) — is blocking on each finding proportionate?

I couldn't flag F1: the only thing it needs is the person turning on the new setting, which is ordinary use, not a rare edge case. I upheld it as fenced.

F1: the change is opt-in, and the default stays false (authentic.patch:377, and :385 coerces a stored non-boolean to false). Once someone turns it on, chrome.tsx:350 swaps the gestures. Cmd/Ctrl-click on a create control then opens the new chat as the active tab, while the same click on a session row still opens a background tab. The 2026-10-17 decision exists to keep those two the same. The PR adds no superseding entry under docs/decisions/. The toggle undoes it (ChatPanel.tsx, authentic.patch:397). Clearing it takes a maintainer's superseding decision, not a code change.

[ADJUDICATION] ef7344ce58e3ed4666a47f3e5d4a20ae7bc26f55 total=0 uphold=0 downgrade=0
[GPT-ADJUDICATED] ef7344ce58e3ed4666a47f3e5d4a20ae7bc26f55

[ADJUDICATION-FENCED] ef7344ce58e3ed4666a47f3e5d4a20ae7bc26f55 fenced=1 flagged=0
UPHOLD-FENCED F1 website/src/pages/chat-sidebar/chrome.tsx:36 -- Any user who turns on the new setting gets the reversed gesture, a normal condition rather than an extreme one, and only a maintainer's superseding decision entry can accept the exception.
[GPT-ADJUDICATED-FENCED] ef7344ce58e3ed4666a47f3e5d4a20ae7bc26f55

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=gpt head=e95dded46e8fdf63c888eee222316edc0a80b073 span=3d475fa4ca2b disposition=needs-a-decision

question (blocking): @bolichen97, does an opt-in exception to the 2026-10-17 ruling work for you?

The finding is right that docs/decisions/2026-10-17-sidebar-create-controls-shift-opens-the-active-tab.md does not limit itself to defaults, and only a maintainer can write a superseding entry.
The setting is off by default, so with it off every gesture matches the ruling. With it on, only the create controls swap: Cmd/Ctrl-click opens the active tab and Cmd/Ctrl+Shift-click opens a background tab. Session rows keep background.
If you agree, a superseding entry (or an /ai-review override gpt naming this head) clears the lane. If you would rather keep the ruling with no exception, I will close this PR.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Oct 22, 2026
@Pearcekieser
Pearcekieser force-pushed the fix/folder-new-session-ctrl-click-focus branch from e95dded to 772ec38 Compare October 22, 2026 03:43
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

chore (non-blocking): rebased on main with no behaviour change. The conflict was in the generated ui-index.generated.json, which I regenerated with npm run gen:ui. The same push fixes the Frontend Tests (3) red. The Hindi label used the आप verb form जाएँ, which the hi style test rejects, so it now uses the तुम form जाओ. The GPT finding on span=3d475fa4ca2b still waits for @bolichen97's call on the 2026-10-17 decision.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 22, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=gpt head=772ec385a97e4d7825a61175d0de54a8965579a4 span=3d475fa4ca2b disposition=needs-a-decision

question (blocking): waiting on a maintainer ruling on the opt-in exception.

Both blocking findings name the same gap: docs/decisions/2026-10-17-sidebar-create-controls-shift-opens-the-active-tab.md does not limit itself to defaults, and only a maintainer can supersede it. The question to @bolichen97 is in the earlier needs-a-decision comment.
Off is the default, so with it off every gesture matches the ruling. If the exception is not wanted, this PR closes.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=fable head=772ec385a97e4d7825a61175d0de54a8965579a4 span=dcd3b9c2e30f disposition=needs-a-decision

question (blocking): waiting on a maintainer ruling on the opt-in exception.

Both blocking findings name the same gap: docs/decisions/2026-10-17-sidebar-create-controls-shift-opens-the-active-tab.md does not limit itself to defaults, and only a maintainer can supersede it. The question to @bolichen97 is in the earlier needs-a-decision comment.
Off is the default, so with it off every gesture matches the ruling. If the exception is not wanted, this PR closes.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=design head=772ec385a97e4d7825a61175d0de54a8965579a4 disposition=rebutted

note (non-blocking): agreed, nothing to change.

Off keeps the 2026-10-17 ruling as shipped, and the swap is confined to createTabModeForClick, which every create-control click already goes through.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=first-principles head=772ec385a97e4d7825a61175d0de54a8965579a4 disposition=rebutted

note (non-blocking): agreed, nothing to change.

The default is unchanged and the setting traces to #22993. Whether the exception is allowed at all is the maintainer question on the blocking findings.

@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 22, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=design head=56812f8b173e521bbd0f088e2905592fe555178a disposition=rebutted

note (non-blocking): agreed, nothing to change. Off keeps the ruling, and the swap stays inside createTabModeForClick.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=first-principles head=56812f8b173e521bbd0f088e2905592fe555178a disposition=rebutted

note (non-blocking): agreed, nothing to change. The default is unchanged and the setting traces to #22993.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=ux head=56812f8b173e521bbd0f088e2905592fe555178a disposition=rebutted

note (non-blocking): agreed, nothing to change. A fork PR cannot get the blind read. The off and on states are in the committed screenshots under temp-screenshots/new-chat-tab-active. The hint text is new_chat_tab_active_desc in en.json.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=fable head=6ddcada0d9141004a29c0411453fd6c1224c6910 span=dcd3b9c2e30f disposition=rebutted

issue (blocking): rebutted as a defect. The exception needs a maintainer decision.

With newChatTabActive off, which is the default, createTabModeForClick returns the same mode as main for every modifier combination. With it on, Ctrl-click on a create control opens the active tab, but Ctrl-click on a session row still opens a background tab. That is an opt-in exception to the 2026-10-17 ruling, and the PR description now says so.

This is a UX finding with no security, data-loss or corruption path. Only a maintainer can accept the exception, with an override or a superseding entry.

@bolichen97, if the opt-in exception is fine with you, this line clears the Opus lane for this head:

/ai-review override fable 6ddcada0d9141004a29c0411453fd6c1224c6910: agent: opt-in setting, off by default; maintainer accepts this exception to the 2026-10-17 ruling

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=gpt head=6ddcada0d9141004a29c0411453fd6c1224c6910 span=3d475fa4ca2b disposition=rebutted

issue (blocking): rebutted as a defect. The exception needs a maintainer decision.

With newChatTabActive off, which is the default, createTabModeForClick returns the same mode as main for every modifier combination. With it on, Ctrl-click on a create control opens the active tab, but Ctrl-click on a session row still opens a background tab. That is an opt-in exception to the 2026-10-17 ruling, and the PR description now says so.

This is a UX finding with no security, data-loss or corruption path. Only a maintainer can accept the exception, with an override or a superseding entry.

@bolichen97, if the opt-in exception is fine with you, this line clears the GPT lane for this head:

/ai-review override gpt 6ddcada0d9141004a29c0411453fd6c1224c6910: agent: opt-in setting, off by default; maintainer accepts this exception to the 2026-10-17 ruling

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=first-principles head=6ddcada0d9141004a29c0411453fd6c1224c6910 span=21a12a580aa7 disposition=rebutted

issue (blocking): framing corrected. The reversal needs a maintainer decision.

The finding is right that the 2026-10-17 ruling has no notion of a default. I rewrote the description. It now says that with the setting on, a create control and a session row act differently for Ctrl-click, which departs from the ruling, and that a maintainer must accept that.

I did not apply the subtraction, because it removes the reason for #22993. Ctrl+Shift-click reaches the active tab, but it is a two-modifier chord on every new chat.

@bolichen97, if the opt-in exception is fine with you, this line clears the First Principles lane for this head:

/ai-review override first-principles 6ddcada0d9141004a29c0411453fd6c1224c6910 decision-reversal: opt-in newChatTabActive setting, off by default, accepted as an exception to the 2026-10-17 sidebar ruling

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=design head=6ddcada0d9141004a29c0411453fd6c1224c6910 disposition=rebutted

note (non-blocking): agreed, nothing to change. Off keeps the ruling, and the swap stays inside createTabModeForClick.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=ux head=6ddcada0d9141004a29c0411453fd6c1224c6910 disposition=rebutted

note (non-blocking): agreed, nothing to change. A fork PR cannot get the blind read. The off and on states are in the committed screenshots under temp-screenshots/new-chat-tab-active. The hint text is new_chat_tab_active_desc in en.json.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=fable head=ec19c2f91eeb79bf4e16722c2e797044096018ee span=dcd3b9c2e30f disposition=rebutted

issue (blocking): rebutted as a defect. The exception needs a maintainer decision.

With newChatTabActive off, which is the default, createTabModeForClick returns the same mode as main for every modifier combination. With it on, Ctrl-click on a create control opens the active tab, but Ctrl-click on a session row still opens a background tab. That is an opt-in exception to the 2026-10-17 ruling, and the PR description now says so.

This is a UX finding with no security, data-loss or corruption path. Only a maintainer can accept the exception, with an override or a superseding entry.

@bolichen97, if the opt-in exception is fine with you, this line clears the Opus lane for this head:

/ai-review override fable ec19c2f91eeb79bf4e16722c2e797044096018ee: agent: opt-in setting, off by default; maintainer accepts this exception to the 2026-10-17 ruling

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=gpt head=ec19c2f91eeb79bf4e16722c2e797044096018ee span=3d475fa4ca2b disposition=rebutted

issue (blocking): rebutted as a defect. The exception needs a maintainer decision.

With newChatTabActive off, which is the default, createTabModeForClick returns the same mode as main for every modifier combination. With it on, Ctrl-click on a create control opens the active tab, but Ctrl-click on a session row still opens a background tab. That is an opt-in exception to the 2026-10-17 ruling, and the PR description now says so.

This is a UX finding with no security, data-loss or corruption path. Only a maintainer can accept the exception, with an override or a superseding entry.

@bolichen97, if the opt-in exception is fine with you, this line clears the GPT lane for this head:

/ai-review override gpt ec19c2f91eeb79bf4e16722c2e797044096018ee: agent: opt-in setting, off by default; maintainer accepts this exception to the 2026-10-17 ruling

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=ux head=029e18fcb9d3503a8fb9c6b659fdd54cbf43c4d1 disposition=rebutted

note (non-blocking): agreed, nothing to change. A fork PR cannot get the blind read. The off and on states are in the committed screenshots under temp-screenshots/new-chat-tab-active. The hint text is new_chat_tab_active_desc in en.json.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=fable head=029e18fcb9d3503a8fb9c6b659fdd54cbf43c4d1 span=dcd3b9c2e30f disposition=rebutted

issue (blocking): rebutted as a defect. The exception needs a maintainer decision.

With newChatTabActive off, which is the default, createTabModeForClick returns the same mode as main for every modifier combination. With it on, Ctrl-click on a create control opens the active tab, but Ctrl-click on a session row still opens a background tab. That is an opt-in exception to the 2026-10-17 ruling, and the PR description now says so.

This is a UX finding with no security, data-loss or corruption path. Only a maintainer can accept the exception, with an override or a superseding entry.

@bolichen97, if the opt-in exception is fine with you, this line clears the Opus lane for this head:

/ai-review override fable 029e18fcb9d3503a8fb9c6b659fdd54cbf43c4d1: agent: opt-in setting, off by default; maintainer accepts this exception to the 2026-10-17 ruling

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=design head=029e18fcb9d3503a8fb9c6b659fdd54cbf43c4d1 span=d751722bc9cc disposition=rebutted

note (non-blocking): agreed. The exception needs a maintainer to accept it, and the code does not change.

With the setting off, which is the default, every gesture works as the 2026-10-17 ruling shipped it. With it on, Ctrl-click on a create control opens the active tab, and Ctrl-click on a session row still opens a background tab. The PR description names that departure and asks a maintainer to accept it.

The Clears when line accepts a maintainer override on this PR. The Opus and GPT dispositions for this head each carry the override line for their lane.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=first-principles head=029e18fcb9d3503a8fb9c6b659fdd54cbf43c4d1 disposition=rebutted

note (non-blocking): agreed, nothing to change. The setting is off by default, and the description says that with it on, the PR departs from the 2026-10-17 ruling. A maintainer still has to accept that exception, and the Opus and GPT dispositions for this head carry the override lines for it.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=fable head=4320df0c45b79dcaa9c61accbe0f0dce91d94942 span=dcd3b9c2e30f disposition=rebutted

issue (blocking): rebutted as a defect. The exception needs a maintainer decision.

With newChatTabActive off, which is the default, createTabModeForClick returns the same mode as main for every modifier combination. With it on, Ctrl-click on a create control opens the active tab, but Ctrl-click on a session row still opens a background tab. That is an opt-in exception to the 2026-10-17 ruling, and the PR description now says so.

This is a UX finding with no security, data-loss or corruption path. Only a maintainer can accept the exception, with an override or a superseding entry.

@bolichen97, if the opt-in exception is fine with you, this line clears the Opus lane for this head:

/ai-review override fable 4320df0c45b79dcaa9c61accbe0f0dce91d94942: agent: opt-in setting, off by default; maintainer accepts this exception to the 2026-10-17 ruling

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=fable head=c69b1949f01d13480948af961f3e56c361bddc32 span=dcd3b9c2e30f disposition=rebutted

issue (blocking): rebutted as a defect. The exception needs a maintainer decision.

With newChatTabActive off, which is the default, createTabModeForClick returns the same mode as main for every modifier combination. With it on, Ctrl-click on a create control opens the active tab, but Ctrl-click on a session row still opens a background tab. That is an opt-in exception to the 2026-10-17 ruling, and the PR description now says so.

This is a UX finding with no security, data-loss or corruption path. Only a maintainer can accept the exception, with an override or a superseding entry.

@bolichen97, if the opt-in exception is fine with you, this line clears the Opus lane for this head:

/ai-review override fable c69b1949f01d13480948af961f3e56c361bddc32: agent: opt-in setting, off by default; maintainer accepts this exception to the 2026-10-17 ruling

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=gpt head=c69b1949f01d13480948af961f3e56c361bddc32 span=3d475fa4ca2b disposition=rebutted

issue (blocking): rebutted as a defect. The exception needs a maintainer decision.

With newChatTabActive off, which is the default, createTabModeForClick returns the same mode as main for every modifier combination. With it on, Ctrl-click on a create control opens the active tab, but Ctrl-click on a session row still opens a background tab. That is an opt-in exception to the 2026-10-17 ruling, and the PR description now says so.

This is a UX finding with no security, data-loss or corruption path. Only a maintainer can accept the exception, with an override or a superseding entry.

@bolichen97, if the opt-in exception is fine with you, this line clears the GPT lane for this head:

/ai-review override gpt c69b1949f01d13480948af961f3e56c361bddc32: agent: opt-in setting, off by default; maintainer accepts this exception to the 2026-10-17 ruling

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=fable head=2400871e49bd9e08dc363a1d94aeebc924f56c04 span=dcd3b9c2e30f disposition=rebutted

issue (blocking): rebutted as a defect. The exception needs a maintainer decision.

With newChatTabActive off, which is the default, createTabModeForClick returns the same mode as main for every modifier combination. With it on, Ctrl-click on a create control opens the active tab, but Ctrl-click on a session row still opens a background tab. That is an opt-in exception to the 2026-10-17 ruling, and the PR description now says so.

This is a UX finding with no security, data-loss or corruption path. Only a maintainer can accept the exception, with an override or a superseding entry.

@bolichen97, if the opt-in exception is fine with you, this line clears the Opus lane for this head:

/ai-review override fable 2400871e49bd9e08dc363a1d94aeebc924f56c04: agent: opt-in setting, off by default; maintainer accepts this exception to the 2026-10-17 ruling

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=gpt head=2400871e49bd9e08dc363a1d94aeebc924f56c04 span=3d475fa4ca2b disposition=rebutted

issue (blocking): rebutted as a defect. The exception needs a maintainer decision.

With newChatTabActive off, which is the default, createTabModeForClick returns the same mode as main for every modifier combination. With it on, Ctrl-click on a create control opens the active tab, but Ctrl-click on a session row still opens a background tab. That is an opt-in exception to the 2026-10-17 ruling, and the PR description now says so.

This is a UX finding with no security, data-loss or corruption path. Only a maintainer can accept the exception, with an override or a superseding entry.

@bolichen97, if the opt-in exception is fine with you, this line clears the GPT lane for this head:

/ai-review override gpt 2400871e49bd9e08dc363a1d94aeebc924f56c04: agent: opt-in setting, off by default; maintainer accepts this exception to the 2026-10-17 ruling

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=fable head=5e1fe06f5c1953e40ed427c604f256178c49dbb8 span=dcd3b9c2e30f disposition=rebutted

issue (blocking): rebutted as a defect. The exception needs a maintainer decision.

With newChatTabActive off, which is the default, createTabModeForClick returns the same mode as main for every modifier combination. With it on, Ctrl-click on a create control opens the active tab, but Ctrl-click on a session row still opens a background tab. That is an opt-in exception to the 2026-10-17 ruling, and the PR description now says so.

This is a UX finding with no security, data-loss or corruption path. Only a maintainer can accept the exception, with an override or a superseding entry.

@bolichen97, if the opt-in exception is fine with you, this line clears the Opus lane for this head:

/ai-review override fable 5e1fe06f5c1953e40ed427c604f256178c49dbb8: agent: opt-in setting, off by default; maintainer accepts this exception to the 2026-10-17 ruling

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=gpt head=5e1fe06f5c1953e40ed427c604f256178c49dbb8 span=3d475fa4ca2b disposition=rebutted

issue (blocking): rebutted as a defect. The exception needs a maintainer decision.

With newChatTabActive off, which is the default, createTabModeForClick returns the same mode as main for every modifier combination. With it on, Ctrl-click on a create control opens the active tab, but Ctrl-click on a session row still opens a background tab. That is an opt-in exception to the 2026-10-17 ruling, and the PR description now says so.

This is a UX finding with no security, data-loss or corruption path. Only a maintainer can accept the exception, with an override or a superseding entry.

@bolichen97, if the opt-in exception is fine with you, this line clears the GPT lane for this head:

/ai-review override gpt 5e1fe06f5c1953e40ed427c604f256178c49dbb8: agent: opt-in setting, off by default; maintainer accepts this exception to the 2026-10-17 ruling

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=design head=5e1fe06f5c1953e40ed427c604f256178c49dbb8 span=2ed749b97bfb disposition=rebutted

note (non-blocking): agreed. The exception needs a maintainer to accept it, and the code does not change.

With the setting off, which is the default, every gesture works as the 2026-10-17 ruling shipped it. With it on, Ctrl-click on a create control opens the active tab, and Ctrl-click on a session row still opens a background tab. The PR description names that departure and asks a maintainer to accept it.

The Clears when line accepts a maintainer override on this PR. The Opus and GPT dispositions for this head each carry the override line for their lane.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=first-principles head=5e1fe06f5c1953e40ed427c604f256178c49dbb8 disposition=rebutted

note (non-blocking): agreed, nothing to change. The setting is off by default, and the description says that with it on, the PR departs from the 2026-10-17 ruling. A maintainer still has to accept that exception, and the Opus and GPT dispositions for this head carry the override lines for it.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=ux head=5e1fe06f5c1953e40ed427c604f256178c49dbb8 disposition=rebutted

note (non-blocking): agreed, nothing to change. A fork PR cannot get the blind read. The off and on states are in the committed screenshots under temp-screenshots/new-chat-tab-active. The hint text is new_chat_tab_active_desc in en.json.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=fable head=ef7344ce58e3ed4666a47f3e5d4a20ae7bc26f55 span=dcd3b9c2e30f disposition=rebutted

issue (blocking): rebutted as a defect. The exception needs a maintainer decision.

With newChatTabActive off, which is the default, createTabModeForClick returns the same mode as main for every modifier combination. With it on, Ctrl-click on a create control opens the active tab, but Ctrl-click on a session row still opens a background tab. That is an opt-in exception to the 2026-10-17 ruling, and the PR description now says so.

This is a UX finding with no security, data-loss or corruption path. Only a maintainer can accept the exception, with an override or a superseding entry.

@bolichen97, if the opt-in exception is fine with you, this line clears the Opus lane for this head:

/ai-review override fable ef7344ce58e3ed4666a47f3e5d4a20ae7bc26f55: agent: opt-in setting, off by default; maintainer accepts this exception to the 2026-10-17 ruling

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=gpt head=ef7344ce58e3ed4666a47f3e5d4a20ae7bc26f55 span=3d475fa4ca2b disposition=rebutted

issue (blocking): rebutted as a defect. The exception needs a maintainer decision.

With newChatTabActive off, which is the default, createTabModeForClick returns the same mode as main for every modifier combination. With it on, Ctrl-click on a create control opens the active tab, but Ctrl-click on a session row still opens a background tab. That is an opt-in exception to the 2026-10-17 ruling, and the PR description now says so.

This is a UX finding with no security, data-loss or corruption path. Only a maintainer can accept the exception, with an override or a superseding entry.

@bolichen97, if the opt-in exception is fine with you, this line clears the GPT lane for this head:

/ai-review override gpt ef7344ce58e3ed4666a47f3e5d4a20ae7bc26f55: agent: opt-in setting, off by default; maintainer accepts this exception to the 2026-10-17 ruling

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=first-principles head=ef7344ce58e3ed4666a47f3e5d4a20ae7bc26f55 disposition=rebutted

note (non-blocking): agreed, nothing to change. The setting is off by default, and the description says that with it on, the PR departs from the 2026-10-17 ruling. A maintainer still has to accept that exception, and the Opus and GPT dispositions for this head carry the override lines for it.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
target=ux head=ef7344ce58e3ed4666a47f3e5d4a20ae7bc26f55 disposition=rebutted

note (non-blocking): agreed, nothing to change. A fork PR cannot get the blind read. The off and on states are in the committed screenshots under temp-screenshots/new-chat-tab-active. The hint text is new_chat_tab_active_desc in en.json.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting: Cmd/Ctrl-click on New opens the new chat as the active tab

3 participants