Skip to content

fix(website): label untitled sessions in the palette and the composer's history suggestions - #23023

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
fix/22049-untitled-labels-palette-history
Oct 22, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
fix/22049-untitled-labels-palette-history

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: An untitled session shows "Untitled session" instead of its internal slot key in the command palette's recent rows and session search, and in the composer's "Continue a previous chat" suggestions.

Four rows fell back to title || key. A session with no title, or with its key as its title, showed a machine id such as chat-9-1785440411 as its name.

Why it matters

The key means nothing to a reader. In the palette, two untitled rows looked like two random ids, and searching for one showed only another id.

Not a goal

  • The other title || key sites listed in Route the remaining untitled-session labels through sessionDisplayTitle #22049 (session tabs, chat pane, chat notices, system rows, memory tab). They follow in later PRs.
  • Changing search, ranking, navigation, resume, open, copy or delete. Each surface keeps its keys.
  • The "New Session…" create row, which already shows its placeholder title.
  • New locale strings.

What changed (motivation → approach → change)

Surface Before After
Palette recent rows, live (commandPalette/providers/recentsProvider.ts) key Untitled session
Palette recent rows, older key Untitled session
Palette session search (commandPalette/providers/sessionsProvider.ts) key Untitled session
"Continue a previous chat" suggestions (pages/chat/page/ComposerDockView.tsx) key Untitled session

All four read the shared sessionDisplayTitle helper from #22041. It treats a missing title and a title equal to the key as untitled. A real title shows as before, and a title that arrives later replaces the label on the next render.

Only the shown label changes. A live row still switches to its key. An older row and a suggestion still resume their key, with the payload title still title || key. A search row still opens, splits and copies with the same {key, title || key} it carried before.

Session search still ranks an untitled row by its key, so the order is unchanged. Its name highlights are matched against the shown label, so they never point past the end of the text drawn on screen.

Two rows that both read "Untitled session" still need telling apart. Where nothing else on the row does it, the key leads the second line, never the name:

Row Second line
Untitled search hit, no body snippet <key> · <agent>, the query highlighted in the key
Untitled search hit with a snippet the snippet, as before
Untitled "Continue a previous chat" row <key> · <date>
Palette recent rows preview and time, as before

The history.md spec paragraph on untitled labels names these surfaces.

The issue for the suggestions (#20877) points at ChatPage.tsx; that list now lives in ComposerDockView.tsx.

Backwards compatibility

Compatible: only the displayed label of an untitled session changes; keys, routes, payloads, ranking and stored data are untouched.

Removes nothing: no path, key, record or function is removed; search reads the same fields as before.

Tests

  • website/src/components/commandPalette/providers/recentsProvider.cov80.test.tsx: an untitled live row and a key-titled live row read "Untitled session", a named row keeps its name, and activating one switches to its key. The same for older rows, where activation resumes with the unchanged payload. Replaces the case that pinned the key fallback.
  • website/src/components/commandPalette/providers/sessionsProvider.test.ts: untitled search hits read "Untitled session" with their own key as the subtitle; the Enter payload and openSession still carry the key. A key match still scores, no name highlight points past the shown label, and the query is highlighted in the key line. An untitled body hit keeps its snippet. Replaces the case that pinned the key fallback.
  • website/src/pages/ChatPage.composerDock.test.tsx: untitled suggestions read "Untitled session" on the name line and their key on the second line, next to a named one; mouse and Enter resume with the key and the old payload title.

Each production file reverted to origin/main on its own makes its cases fail. Reverting only the highlight line, or only the key lines, makes those cases fail. Determinism: the three files passed 3 of 3 runs with --sequence.shuffle.

Manual verification

Rendered the real CommandPalette (recent rows, and a search for 1785) and the real ComposerDockView suggestion list on a loopback vite server with stubbed API answers, in dark and light themes. The composer input was stubbed out of the dock render. Before each capture the script asserted that no untitled key appears in the rendered text.

Screenshots / video

Palette recent rows, dark:

palette recents dark

Palette session search for 1785, dark:

palette search dark

"Continue a previous chat", light:

history suggestions light

Other theme

palette recents light

palette search light

history suggestions dark

Related Issues

Part of #22049

Closes #20877
Closes #20879
Closes #20880
Closes #20881

Pattern harvest

Rule candidate: semgrep
Pattern: a session label rendered as title || key in website/src shows an internal id; route it through sessionDisplayTitle.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 22, 2026 04:28
@iamwhatever
iamwhatever requested a review from CrysisDeu October 22, 2026 04:28
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 22, 2026
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 2d49e39956c1ab61181e8021bec1f1eedf584f91 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

The four relabels reuse the existing sessionDisplayTitle helper and are tied to issues #20877–#20881. The two pins that showed the key are replaced with those issues cited. Showing the key on the second line is the one rider.

Notes

  • Item 5 — rides along: the Goal covers only the name, but the diff also adds "the key leads the second line" in two places (sessionsProvider.ts's keyLine and the ComposerDockView.tsx subtitle). Without it, two "Untitled session" rows would look the same, so this is small and has a reason.

What this change ships

Inventory (6 items) — 5 justified

Intent: a person sees "Untitled session" instead of a machine slot id in the palette and the composer's resume suggestions. This is a FIX.

  1. Untitled live rows in the palette's recent list read "Untitled session" — justified
  2. Untitled older rows in the palette's recent list read "Untitled session" — justified
  3. Untitled hits in palette session search read "Untitled session", with name highlights matched to the shown label — justified
  4. Untitled "Continue a previous chat" suggestions read "Untitled session" — justified
  5. Untitled search hits with no snippet, and untitled suggestions, show the key on their second line — rides along
  6. The history.md paragraph on untitled labels now lists these surfaces — justified

[FIRST-PRINCIPLES-REVIEWED] 2d49e39

Description read

[DESCRIPTION-READ] 5b2a1df8dd9d4914a8709fefe2cabd8ec1b4b19b2abcda2b5c1fe47bbc9b0e0a

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 2d49e39956c1ab61181e8021bec1f1eedf584f91 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a display-only change through the existing sessionDisplayTitle helper. Keys, payloads and ranking are unchanged, and screenshots of this revision are attached.

[DESIGN-REVIEWED] 2d49e39

Description read

[DESCRIPTION-READ] a2ce75d5a46d7d68beecd8a7a69395e8587b51c3826fee10e8af71667e66154c

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 2d49e39956c1ab61181e8021bec1f1eedf584f91 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. All four changed surfaces appear in the screenshots in both themes, and the blind reader correctly took "Untitled session" for a past chat with no name and would open it.

Notes

  • The palette's recent rows (shot-01) tell two "Untitled session" rows apart only by the grey preview line. A row with an empty preview would look identical to its neighbour, so fall back to the key on the second line there, the way search and the suggestions already do.
  • In the palette search, the named row "Plan the onboarding tour" matched 1785 but shows only kirocrew, and the reader had "no idea why it's here". When a named row matches on its key, show the key on the second line too.

[UX-REVIEWED] 2d49e39

Description read

[DESCRIPTION-READ] 8fca3fff21b60411e78d3f9409a626ff820e2b06a3232643e9fb405884f2d1f1

That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 2d49e39956c1ab61181e8021bec1f1eedf584f91 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 2d49e39

Verdict parsed from the review's SHA-scoped output markers for commit 2d49e39956c1ab61181e8021bec1f1eedf584f91.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 2d49e39956c1ab61181e8021bec1f1eedf584f91: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 2d49e39956c1ab61181e8021bec1f1eedf584f91 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 2d49e39

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 2d49e39956c1ab61181e8021bec1f1eedf584f91: <one-sentence reason>

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/pages/chat/page/ComposerDockView.tsx since this head went green (4c9d96a -> a1d3703); CI re-running. Main's change there is the agent label (#22944), not the history list this PR edits; no conflict. New head 764152c.

🤖 AI-assisted comment 🤖

@iamwhatever
iamwhatever force-pushed the fix/22049-untitled-labels-palette-history branch from 1435e62 to 764152c Compare October 22, 2026 05:23
@iamwhatever
iamwhatever force-pushed the fix/22049-untitled-labels-palette-history branch from 764152c to 2d49e39 Compare October 22, 2026 05:36
@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Identical "Untitled session" rows in the composer suggestions (span=ce6228135a88)

fixed in 2d49e39: an untitled "Continue a previous chat" row's second line is now <key> · <date>, so two untitled rows read differently; the name line still never shows the key.
A titled row is unchanged. ChatPage.composerDock.test.tsx pins the name lines and the key lines; neutering the key line makes it fail.

🤖 AI-assisted comment 🤖

@iamwhatever

Copy link
Copy Markdown
Contributor Author
  • Search finds untitled sessions by a key it no longer shows (span=845890fb873a)

fixed in 2d49e39: an untitled search hit with no body snippet now shows <key> · <agent> as its subtitle, with the query highlighted in the key, so a key search shows why it matched and two untitled hits differ.
A hit with a snippet keeps the snippet; titled rows and the open/split/copy payloads are unchanged. sessionsProvider.test.ts pins the subtitle and its highlight indices.

🤖 AI-assisted comment 🤖

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 22, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) October 22, 2026 07:03

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (7 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: display-only fix that labels untitled sessions "Untitled session" in the command palette and the composer's history suggestions, with the open, resume and copy payloads unchanged. Spec files changed as a ride-along (a minority of the diff on both file count and changed lines), not reviewed as a design decision: docs/system-specs/modules/history.md.

@KiroCrewCaptain
KiroCrewCaptain merged commit 6bb453a into main Oct 22, 2026
108 of 116 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the fix/22049-untitled-labels-palette-history branch October 22, 2026 07:04
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants