Repository navigation
fix(dashboard): drop the Required badge from the Kiro CLI setup card - #23026
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: a misleading badge with no state behind it is removed, and the three catalog keys only it read go with it. What this change shipsInventory (3 items) — 3 justifiedIntent: let people who already use another coding agent finish first-run setup without being told Kiro CLI is "Required". This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] cef46d0 Description read[DESCRIPTION-READ] 811b998cc61246ebe94f4bcf5e531bd875cf18442b0b9355ca21f42fa2312034 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. The badge always rendered the same constant, so taking it out removes nothing. The three catalog keys had only that one reader, and the description includes screenshots of this revision. [DESIGN-REVIEWED] cef46d0 Description read[DESCRIPTION-READ] 89fa45712a3338e98c4baa722debc72ccc6ae417bae5913289d8935149787468 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the change removes one badge, both affected states have before and after screenshots, and the blind reader found the old "Required" pill odd next to "is installed". Notes
[UX-REVIEWED] cef46d0 Description read[DESCRIPTION-READ] 7b5a2c6005535ff5da40200465088fcec886963c3e2a08b6346c96f35be0aa2c That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
0f41183 to
edff256
Compare
edff256 to
fe2788b
Compare
Set up Kiro tagged its Get Kiro CLI card "Required" in every state, right above "Use other coding agents", which finishes setup without Kiro CLI. People who already run Claude Code or another agent read the tag as Kiro CLI being mandatory. The badge is left over from the two-step setup layout. When #13888 merged the steps into one card, it pinned the badge to "Required", so the badge reported no state. Remove StepStatus, its one call and the flex wrapper that only positioned it, plus the three catalog keys only it read (required, waiting, complete) from every locale. en-XA comes from its generator.
fe2788b to
cef46d0
Compare
|
Rebased: main moved in the 14 locale catalogs under website/src/i18n/locales since this head's CI ran (a932db7 -> 8e80404); CI re-running. The patch is unchanged (git range-diff: fe2788b = cef46d0), and the related frontend tests, i18n:check and tsc pass on the new head. The UX Review lane on fe2788b failed twice before reviewing (Claude Code installer download returned HTTP 429), so this push also gives it a fresh run. |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (16 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: frontend fix that removes the false "Required" step badge from the Kiro CLI setup card, because a user can finish setup with another coding agent; drops the now-unused locale strings and adds a test for the card.
Problem / Motivation
Goal: First-run setup stops labeling Kiro CLI "Required" when another coding agent can finish setup instead.
Set up Kiro shows a "Required" badge on its Get Kiro CLI card in every state. Right below the card, "Use other coding agents" lets the user pick an installed agent, such as Claude Code, and finish setup without Kiro CLI. People who already use another agent take the badge at its word and stop at the Kiro CLI card.
Why it matters
Anyone who reaches first-run setup without a signed-in Kiro CLI sees the badge. On v0.9.0 and v0.10.0-insider.4, which default to Kiro CLI, that is every desktop user who has not signed in yet. On main it is any host with Claude Code, or another installed agent, and no Kiro CLI. The badge steers the people the other-agents option serves away from it.
Not a goal
What changed (motivation → approach → change)
The badge said "Required" every time because nothing fed it state. It comes from the earlier two-step setup layout, where it moved from Required to Waiting to Complete. #13888 merged the steps into one card and called it as
<StepStatus complete={false} current />.The badge is deleted, not relabeled. The card's first line already says where Kiro CLI stands ("isn't installed on this host yet" or "is installed. Finish signing in"), and a new label such as "Recommended" would rank Kiro CLI above the agent the user already has, which is #5155's call.
KiroPrerequisiteGate.tsxlosesStepStatus, its one call, the flex wrapper that only positioned it, and theBadgeandCheckCircle2imports nothing else used. The three catalog keys only it read (components.kiroPrerequisiteGate.required,.waitingand.complete) leave every catalog inwebsite/src/i18n/locales, anden-XA.jsonis regenerated withnpm run i18n:pseudo.Backwards compatibility
Compatible: nothing that works today stops working. The badge reported no state, and the three keys had a single reader, deleted here.
Reader: website/src/components/KiroPrerequisiteGate.tsx:StepStatus -- crew page -- deleted with its one call; git grep on origin/main finds no other reference to the three keys
Reader: website/src/i18n/deadKeys.test.ts:BASELINE -- release -- stays at 27, because the keys leave with their only caller
No Playwright spec, capture script or GUI-user scenario on origin/main looks for the badge's text. One open PR, #16962 (zh-TW catalog), carries the three keys; once this merges, its catalog-parity test reports them as extra until it drops them.
Tests
KiroPrerequisiteGate.agentChoice.test.tsxaddsdoes not call Kiro CLI required when it is %sfor two states: not installed, and installed but signed out. It asserts the Get Kiro CLI card has no text containing the word "required" (a word match, so a badge showing its raw catalog key fails it too) and that the "Use other coding agents" toggle is present.--sequence.shuffle(seeds 101-120) with noact()warnings.Manual verification
Rendered the built dashboard from origin/main (3d6cda4) and from this branch behind the repo's loopback static server (
website/scripts/lib/serve-dist.mjs) with stubbed/apiresponses. Two states, both withagent.acp_backend: "kiro"and Claude Code installed: Kiro CLI installed but signed out on a macOS desktop host, and Kiro CLI not installed on a Linux host. Before: one "Required" on the card in each. After: none, with the state line, commands, Check button and "Use other coding agents" unchanged.Screenshots / video
Kiro CLI installed, signed out (macOS desktop host):
Kiro CLI not installed (Linux host)
Related Issues
Closes #23018
Related: #5155
Pattern harvest
Not generalizable: the badge went constant when a layout merge pinned its props at its only call site, and a constant prop at one call site is ordinary code, so no rule can tell this one from a deliberate one.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)