Skip to content

fix(dashboard): drop the Required badge from the Kiro CLI setup card - #23026

Merged
adlio merged 1 commit into
mainfrom
fix/setup-kiro-required-badge
Oct 22, 2026
Merged

adlio merged 1 commit into
mainfrom
fix/setup-kiro-required-badge

Conversation

@adlio

@adlio adlio commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: First-run setup stops labeling Kiro CLI "Required" when another coding agent can finish setup instead.

Set up Kiro shows a "Required" badge on its Get Kiro CLI card in every state. Right below the card, "Use other coding agents" lets the user pick an installed agent, such as Claude Code, and finish setup without Kiro CLI. People who already use another agent take the badge at its word and stop at the Kiro CLI card.

Why it matters

Anyone who reaches first-run setup without a signed-in Kiro CLI sees the badge. On v0.9.0 and v0.10.0-insider.4, which default to Kiro CLI, that is every desktop user who has not signed in yet. On main it is any host with Claude Code, or another installed agent, and no Kiro CLI. The badge steers the people the other-agents option serves away from it.

Not a goal

  • Redesigning first-run setup to ask for an agent first; that is Make Kiro CLI an optional provider prerequisite #5155.
  • The side panel's "Install Kiro CLI, sign in once" line, which every setup state shares.
  • The notice that says Kiro Crew "is set to use KAS" on a host with no Kiro CLI when KAS is only the default. Telling a default from a choice needs a new field from the gateway.

What changed (motivation → approach → change)

The badge said "Required" every time because nothing fed it state. It comes from the earlier two-step setup layout, where it moved from Required to Waiting to Complete. #13888 merged the steps into one card and called it as <StepStatus complete={false} current />.

The badge is deleted, not relabeled. The card's first line already says where Kiro CLI stands ("isn't installed on this host yet" or "is installed. Finish signing in"), and a new label such as "Recommended" would rank Kiro CLI above the agent the user already has, which is #5155's call.

KiroPrerequisiteGate.tsx loses StepStatus, its one call, the flex wrapper that only positioned it, and the Badge and CheckCircle2 imports nothing else used. The three catalog keys only it read (components.kiroPrerequisiteGate.required, .waiting and .complete) leave every catalog in website/src/i18n/locales, and en-XA.json is regenerated with npm run i18n:pseudo.

Backwards compatibility

Compatible: nothing that works today stops working. The badge reported no state, and the three keys had a single reader, deleted here.

Reader: website/src/components/KiroPrerequisiteGate.tsx:StepStatus -- crew page -- deleted with its one call; git grep on origin/main finds no other reference to the three keys
Reader: website/src/i18n/deadKeys.test.ts:BASELINE -- release -- stays at 27, because the keys leave with their only caller

No Playwright spec, capture script or GUI-user scenario on origin/main looks for the badge's text. One open PR, #16962 (zh-TW catalog), carries the three keys; once this merges, its catalog-parity test reports them as extra until it drops them.

Tests

  • KiroPrerequisiteGate.agentChoice.test.tsx adds does not call Kiro CLI required when it is %s for two states: not installed, and installed but signed out. It asserts the Get Kiro CLI card has no text containing the word "required" (a word match, so a badge showing its raw catalog key fails it too) and that the "Use other coding agents" toggle is present.
  • Both cases fail against the old component, with or without the deleted keys put back.
  • The whole file (73 tests) passed 20 runs under --sequence.shuffle (seeds 101-120) with no act() warnings.

Manual verification

Rendered the built dashboard from origin/main (3d6cda4) and from this branch behind the repo's loopback static server (website/scripts/lib/serve-dist.mjs) with stubbed /api responses. Two states, both with agent.acp_backend: "kiro" and Claude Code installed: Kiro CLI installed but signed out on a macOS desktop host, and Kiro CLI not installed on a Linux host. Before: one "Required" on the card in each. After: none, with the state line, commands, Check button and "Use other coding agents" unchanged.

Screenshots / video

Kiro CLI installed, signed out (macOS desktop host):

Before: the Get Kiro CLI card carries a Required badge

After: the same card with no badge

Kiro CLI not installed (Linux host)

Before: the install card carries a Required badge

After: the install card with no badge

Related Issues

Closes #23018

Related: #5155

Pattern harvest

Not generalizable: the badge went constant when a layout merge pinned its props at its only call site, and a constant prop at one call site is ordinary code, so no rule can tell this one from a deliberate one.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable): no doc describes the badge
  • No secrets, credentials, or internal references in the diff

@adlio
adlio requested review from a team and KiroCrewCaptain as code owners October 22, 2026 04:59
@adlio
adlio requested a review from mbriones98 October 22, 2026 04:59
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 22, 2026
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of cef46d0139c08d5f100e84635b8df7f83fdc148e — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: a misleading badge with no state behind it is removed, and the three catalog keys only it read go with it.

What this change ships

Inventory (3 items) — 3 justified

Intent: let people who already use another coding agent finish first-run setup without being told Kiro CLI is "Required". This is a FIX.

  1. The Get Kiro CLI card no longer shows a "Required" badge in either state (not installed, or installed but signed out) — justified
  2. The heading and state line sit straight in the card, without the wrapper that placed the badge beside them — justified
  3. The required, waiting and complete keys under kiroPrerequisiteGate are removed from every locale catalog (grep on website/src: no reader left besides the new test's comment) — justified

[FIRST-PRINCIPLES-REVIEWED] cef46d0

Description read

[DESCRIPTION-READ] 811b998cc61246ebe94f4bcf5e531bd875cf18442b0b9355ca21f42fa2312034

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of cef46d0139c08d5f100e84635b8df7f83fdc148e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. The badge always rendered the same constant, so taking it out removes nothing. The three catalog keys had only that one reader, and the description includes screenshots of this revision.

[DESIGN-REVIEWED] cef46d0

Description read

[DESCRIPTION-READ] 89fa45712a3338e98c4baa722debc72ccc6ae417bae5913289d8935149787468

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of cef46d0139c08d5f100e84635b8df7f83fdc148e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the change removes one badge, both affected states have before and after screenshots, and the blind reader found the old "Required" pill odd next to "is installed".

Notes

  • The "Get Kiro CLI" title still reads as an instruction once the CLI is installed (shot-01/02: "the title and the status disagree"). Consider "Sign in to Kiro CLI" for that state as a follow-up.

[UX-REVIEWED] cef46d0

Description read

[DESCRIPTION-READ] 7b5a2c6005535ff5da40200465088fcec886963c3e2a08b6346c96f35be0aa2c

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed cef46d0139c08d5f100e84635b8df7f83fdc148e — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] cef46d0

Verdict parsed from the review's SHA-scoped output markers for commit cef46d0139c08d5f100e84635b8df7f83fdc148e.

False positive or not applicable? A repository writer can comment:
/ai-review override fable cef46d0139c08d5f100e84635b8df7f83fdc148e: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of cef46d0139c08d5f100e84635b8df7f83fdc148e and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] cef46d0

False positive or not applicable? A repository writer can comment:
/ai-review override gpt cef46d0139c08d5f100e84635b8df7f83fdc148e: <one-sentence reason>

@adlio

adlio commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in the 14 locale catalogs under website/src/i18n/locales since this head's CI started (4c9d96a -> a1d3703); CI re-running. The patch is unchanged (git range-diff: 0f41183 = edff256), and the related frontend tests, i18n:check and tsc pass on the new head.

@adlio
adlio force-pushed the fix/setup-kiro-required-badge branch from 0f41183 to edff256 Compare October 22, 2026 05:13
@adlio
adlio enabled auto-merge (squash) October 22, 2026 06:20
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 22, 2026
@adlio

adlio commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in the 14 locale catalogs under website/src/i18n/locales since this head went green (a1d3703 -> a932db7); CI re-running. The patch is unchanged (git range-diff: edff256 = fe2788b), and the related frontend tests, i18n:check and tsc pass on the new head.

@adlio
adlio force-pushed the fix/setup-kiro-required-badge branch from edff256 to fe2788b Compare October 22, 2026 06:57
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision readiness: checking Automated validation is still running labels Oct 22, 2026
Set up Kiro tagged its Get Kiro CLI card "Required" in every state,
right above "Use other coding agents", which finishes setup without
Kiro CLI. People who already run Claude Code or another agent read
the tag as Kiro CLI being mandatory.

The badge is left over from the two-step setup layout. When #13888
merged the steps into one card, it pinned the badge to "Required", so
the badge reported no state. Remove StepStatus, its one call and the
flex wrapper that only positioned it, plus the three catalog keys only
it read (required, waiting, complete) from every locale. en-XA comes
from its generator.
@adlio
adlio force-pushed the fix/setup-kiro-required-badge branch from fe2788b to cef46d0 Compare October 22, 2026 08:11
@adlio

adlio commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in the 14 locale catalogs under website/src/i18n/locales since this head's CI ran (a932db7 -> 8e80404); CI re-running. The patch is unchanged (git range-diff: fe2788b = cef46d0), and the related frontend tests, i18n:check and tsc pass on the new head. The UX Review lane on fe2788b failed twice before reviewing (Claude Code installer download returned HTTP 429), so this push also gives it a fresh run.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 22, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: fix (16 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: frontend fix that removes the false "Required" step badge from the Kiro CLI setup card, because a user can finish setup with another coding agent; drops the now-unused locale strings and adds a test for the card.

@adlio
adlio merged commit 17008c1 into main Oct 22, 2026
107 checks passed
@adlio
adlio deleted the fix/setup-kiro-required-badge branch October 22, 2026 10:34
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up Kiro labels Kiro CLI "Required" even when another coding agent can finish setup

2 participants