Skip to content

docs(pi): refresh the pi worked example now the parity gaps have landed - #23152

Merged
iamwhatever merged 1 commit into
mainfrom
docs/pi-worked-example-gaps-refresh
Oct 22, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
docs/pi-worked-example-gaps-refresh

Conversation

@kyleseaman

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The pi worked example in harness-onboarding.md describes what main's pi support actually does today, instead of listing as open three gaps that have since landed.

The "Worked example: the Pi harness" table's open gaps row still says pi is out of ACP_BACKENDS_HONOR_ZERO_TOOL_BAN and ACP_BACKENDS_MEMBER_PANEL, and that CI installs neither pi nor pi-acp. On main all three are no longer true: #22808 added pi to the zero-tool-ban set, #22813 added it to the member-panel set, and #22807 pinned pi-acp + pi in test/real_adapters/ and drives them in the Real Adapter Contract Tests lane. The 3 spawn path and 8 live spill rows also predate the node-engine guard (#22883) and the two new live captures.

Why it matters

This section is the reference a reader uses to onboard the next harness and to see where pi stands. A row that calls merged work "open" sends readers chasing gaps that are closed and hides which ones are still open.

Not a goal

What changed (motivation → approach → change)

Stale rows → checked each claim against main's set definitions (agent_sdk/backends_mcp.py, backends_members.py, backends_turns.py), test/real_adapters/package.json, .github/workflows/ci.yml and test/fixtures/acp_frames/pi/ → moved each landed gap into the row that owns it, in the section's existing style:

  • 2 capability sets: adds pi's membership in ACP_BACKENDS_MEMBER_PANEL (own evidence: the handoff carries the panel element, member-panel-mount-live.jsonl) and in ACP_BACKENDS_HONOR_ZERO_TOOL_BAN as its one mirror-less member (_mirrorless_member_mounts reads "tools": [], _deny_zero_tools refuses each gate dialog, zero-tools-refused-live.jsonl).
  • 3 spawn path: adds the Node engines.node guard (acp/harness/pi_node.py, fix(pi): run pi under a Node that meets its engine floor #22883): the fallback order, the refusal, the confined probe, and which cases it leaves to the read-back.
  • 8 live spill: seven live captures instead of five; adds the Real Adapter lane, which pins pi-acp 0.0.34 / pi 1.3.0 and drives test_pi_real_adapter.py through PiLaunch.resolve_spawn on every backend PR.
  • open gaps: drops the zero-tool-ban, real-adapter-lane and member-panel entries. Saved-spec verification, the spec's own MCP servers / per-tool deny set (projection still broker-only; ACP_BACKENDS_MEMBER_TOOL_LIMITS is still {kiro}), and mid-turn steer stay in the row, unchanged.

Not every gap is closed, so the row stays rather than being marked "at parity".

Heads-up for #22911: it edits the same open gaps line, so its next rebase will hit a one-line conflict here. Resolving it means keeping this PR's row and swapping in #22911's saved-spec sentence. #22923 does not touch this row.

Backwards compatibility

Compatible: documentation only; no code, config or test changed.
Removes nothing: the only text removed is three open gaps entries describing state main no longer has; each is restated as current state in the row that owns it.

Tests

N/A — docs only. Run locally: ./scripts/docs-lint.sh (all documentation checks passed), and pytest test/test_backend_id_uniqueness.py test/test_provider_mirrors.py test/test_harness_parity.py (the tests that read this doc or pin these sets; 153 passed).

Manual verification

Checked every membership claim in the edited rows against main at 69b2e50: pi is in ACP_BACKENDS_HONOR_ZERO_TOOL_BAN, ACP_BACKENDS_MEMBER_PANEL and ACP_BACKENDS_MEMBER_DISPATCH; it is not in ACP_BACKENDS_MEMBER_CAPABILITIES, ACP_BACKENDS_MEMBER_TOOL_LIMITS ({kiro}), ACP_BACKENDS_STEER, ACP_BACKENDS_STEERING_REQUEST or ACP_BACKENDS_STEER_CONCURRENT_PROMPT; its projection is ProjectionKind.BROKER_ONLY. Sensitive Change Review: the one changed path matches none of SENSITIVE_GLOBS.

Related Issues

Follows #22807, #22808, #22813, #22883, #22951.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@kyleseaman
kyleseaman requested review from a team and KiroCrewCaptain as code owners October 22, 2026 17:59
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision e2c57e7f75893bdfc76b120caaa63a435cd4c4bb ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of e2c57e7f75893bdfc76b120caaa63a435cd4c4bb — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing to check: this is a docs-only refresh, and the claims I spot-checked match main. Pi is in ACP_BACKENDS_HONOR_ZERO_TOOL_BAN and in ACP_BACKENDS_MEMBER_PANEL. acp/harness/pi_node.py exists, and test/fixtures/acp_frames/pi/ holds seven captures.

[DESIGN-REVIEWED] e2c57e7

Description read

[DESCRIPTION-READ] 05b9fbf635dd3d40642f2a077d97455ab590306d94fc87e56ec3cce11053e14f

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision e2c57e7f75893bdfc76b120caaa63a435cd4c4bb touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed e2c57e7f75893bdfc76b120caaa63a435cd4c4bb — this comment is updated in place on each push.

Review details

The claims check out against the repo.

No findings.

[OPUS-REVIEWED] e2c57e7

Verdict parsed from the review's SHA-scoped output markers for commit e2c57e7f75893bdfc76b120caaa63a435cd4c4bb.

False positive or not applicable? A repository writer can comment:
/ai-review override fable e2c57e7f75893bdfc76b120caaa63a435cd4c4bb: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of e2c57e7f75893bdfc76b120caaa63a435cd4c4bb and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] e2c57e7

False positive or not applicable? A repository writer can comment:
/ai-review override gpt e2c57e7f75893bdfc76b120caaa63a435cd4c4bb: <one-sentence reason>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 22, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE. Reviewed head e2c57e7f75893bdfc76b120caaa63a435cd4c4bb.

Docs-only refresh of the pi worked example in harness-onboarding.md. Every membership claim I checked matches main: pi is in ACP_BACKENDS_HONOR_ZERO_TOOL_BAN and ACP_BACKENDS_MEMBER_PANEL, still out of ACP_BACKENDS_MEMBER_CAPABILITIES and ACP_BACKENDS_MEMBER_TOOL_LIMITS; test/real_adapters/package.json pins pi-acp 0.0.34 and pi 1.3.0 and the Real Adapter lane drives test_pi_real_adapter.py; pi_node.py and the seven live captures exist. The gaps left open are tracked by open PRs #22911 and #22923. AI lanes pass and all checks on this head are green.

— crew-pr-reviewer (r121)

@iamwhatever
iamwhatever merged commit afead19 into main Oct 22, 2026
105 checks passed
@iamwhatever
iamwhatever deleted the docs/pi-worked-example-gaps-refresh branch October 22, 2026 23:34
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants