Skip to content

fix(acp): redact provider text in the credential give-up line - #23277

Merged
bolichen97 merged 1 commit into
mainfrom
fix/redact-credential-give-up-21491
Oct 24, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/redact-credential-give-up-21491

Conversation

@JLargent42

@JLargent42 JLargent42 commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The credential give-up line shows the provider's text redacted, on every surface, and ends on the provider's words.

When the agent cannot load its cloud credentials even after a restart, the dashboard row and the channel post end on a give-up line that carries the provider's error text. credential_give_up_text put that text into the line as it came, and neither the dashboard row nor the channel post redacts on its own. Every other dashboard row that shows provider text runs it through redact_exfiltration_urls and redact_credentials first. The line also ended with the frame's data repr, e.g. ...try again.: {'errorKind': 'cloud_credential_error'}.

Why it matters

A provider error that carries a link or a credential-shaped string reaches the dashboard and a channel unredacted, and a channel post can be read by other members. Low likelihood, but it is the one provider-text line without the guard the others have.

Not a goal

  • Slack: its outbound boundary already redacts. Using CREDENTIAL_RELOAD_RETRY_NOTICE on a Slack credential recycle (the issue's optional item) is left for a separate change.
  • Changing how the ACP formatter words or redacts errors.

What changed (motivation → approach → change)

The line is built in one place, so the redaction goes there: credential_give_up_text (llm_helpers_parts/backend_errors.py) now drops the frame's trailing {'errorKind': ...} repr (a match anchored at its :, so it stays linear on long whitespace), then runs the text through redact_via_context, the egress redaction path. That path finds link and credential spans on the original text and rewrites it once, so a value that one pass would keep after the other pass rewrote its surroundings (a token parameter after a long query parameter in a link) is still removed; two passes run one after the other cannot guarantee that in either order. Every caller (dashboard, channel, Slack) gets the scrubbed line without a change at the call site. The owning spec, docs/system-specs/common/error-handling.md, states the redaction, and security_posture.py lists backend_errors.py with the shared non-egress redaction builders, since the surfaces that deliver the line are the registered sinks. The llm_helpers.py facade manifest names the new pattern constant and redact_via_context, which it forwards.

Backwards compatibility

Compatible: the line keeps its wording and the provider's remedy; only link, credential and frame-data content is removed from it.

Removes nothing: no path, record, key or function is removed.

Tests

test/test_credential_give_up_redaction.py, with neutral fixtures (the AWS documentation's example key id, a presigned-style storage link, and a collector.example link whose token parameter follows a 40-character one):

  • for each fixture, the function removes the link, key and token value, given an exception or a string, and keeps the provider's remedy sentence;
  • the text the ACP formatter builds for a credential frame loses its errorKind tail and ends on the provider's words;
  • a brace in the middle of provider prose is kept;
  • a 400,000-space provider text finishes under a 60 s timeout, and whitespace before the frame tail is trimmed;
  • for each fixture, the dashboard give-up row and the channel give-up post are both redacted, end to end through _run_chat and run_channel_agent.

The four token-parameter cases (helper with an exception and a string, dashboard, channel) fail on the previous head, which ran the two passes one after the other, and pass now. With main's function body restored, the link-and-key cases fail too; the brace case is the control and passes either way. With the tail pattern starting at the whitespace before the :, the whitespace case times out at 60 s. Repeated 5 times under -n 4 and once in reversed order: all pass. 203 credential, redaction, facade, security-posture, channel and session-recovery test files: 7617 pass, including test_security_posture.py, test_facade_mirror_guards.py and test_llm_helpers_facade.py. isort, flake8, black, mypy, comment-history and docs-lint are clean.

Manual verification

N/A — unit coverage sufficient: the dashboard and channel paths are driven end to end in the tests above.

Related Issues

Closes #21491

Sibling sweep

Swept: git grep -n "credential_give_up_text(" -- src/
Siblings: none -- the dashboard, channel and Slack give-up lines all call credential_give_up_text, which is changed here.

Pattern harvest

Not generalizable: the defect is one formatter that skipped the redaction its sibling rows apply; the fix puts it inside the shared formatter.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@JLargent42
JLargent42 requested review from a team and KiroCrewCaptain as code owners October 23, 2026 01:07
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 23, 2026
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision eecf180c922b569b4cebfcfa29f5f8e8b3ace0cc touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of eecf180c922b569b4cebfcfa29f5f8e8b3ace0cc — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. The redaction now happens once, inside the shared builder every give-up surface calls, through the existing egress redaction path. The change takes nothing away.

[DESIGN-REVIEWED] eecf180

Description read

[DESCRIPTION-READ] f1dd8b658c8556cef986df19c8cf06b1393d3a86202af848b800413c08d5786c

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of eecf180c922b569b4cebfcfa29f5f8e8b3ace0cc — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. The redaction is a fix at the mechanism level, inside the one function all three call sites use. Linked issue #21491 and tests that fail on base back the defect.

What this change ships

Inventory (5 items) — 5 justified

Intent: keep link and credential text from the provider out of the credential give-up line on the dashboard, channel and Slack. This is a FIX.

  1. The give-up line on the dashboard, in channels and on Slack now hides links and credential-shaped strings from the provider text. — justified
  2. The give-up line no longer ends with the frame's {'errorKind': ...} data; it ends on the provider's own words. — justified
  3. backend_errors.py is now listed among the shared non-egress redaction modules in the security-posture list. — justified
  4. The llm_helpers facade's type-checking imports now name _FRAME_DATA_TAIL_RE and redact_via_context. — justified
  5. The error-handling spec now says this line is redacted and its frame data dropped. — justified

[FIRST-PRINCIPLES-REVIEWED] eecf180

Description read

[DESCRIPTION-READ] e667e7ebef58bd98677ca4698829848b4d11ed82ae8e097fa9adf8be3026019c

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed eecf180c922b569b4cebfcfa29f5f8e8b3ace0cc — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] eecf180

Verdict parsed from the review's SHA-scoped output markers for commit eecf180c922b569b4cebfcfa29f5f8e8b3ace0cc.

False positive or not applicable? A repository writer can comment:
/ai-review override fable eecf180c922b569b4cebfcfa29f5f8e8b3ace0cc: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 23, 2026
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of eecf180c922b569b4cebfcfa29f5f8e8b3ace0cc and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] eecf180

False positive or not applicable? A repository writer can comment:
/ai-review override gpt eecf180c922b569b4cebfcfa29f5f8e8b3ace0cc: <one-sentence reason>

@JLargent42
JLargent42 force-pushed the fix/redact-credential-give-up-21491 branch from 32eb6b4 to 9ea9bc8 Compare October 23, 2026 01:14
@JLargent42

Copy link
Copy Markdown
Contributor Author

Fast Gate: test_security_posture.py::TestOmissionDetection::test_every_redactor_call_site_is_a_registered_sink_or_allowlisted failed on 32eb6b4 because llm_helpers_parts/backend_errors.py now calls the redactors. Fixed in 9ea9bc8: it is listed in NON_EGRESS_REDACTION_MODULES beside model_fallback.py (a shared builder that owns no output; the dashboard, channel and Slack surfaces that deliver the line are the registered sinks). The Fast Gate pytest set passes locally (172 passed). Base unchanged: the PR is MERGEABLE, not DIRTY.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Sensitive Change Review

Sensitive files changed:

  • src/kiro_crew/security_posture.py

  • @JLargent42 posted a complete reasoning template for eecf180.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 23, 2026
@JLargent42

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: 9ea9bc8
  • What rule changed: no redaction rule changed. security_posture.py gains one entry in NON_EGRESS_REDACTION_MODULES, llm_helpers_parts/backend_errors.py, the module that builds the credential give-up line and now calls redact_exfiltration_urls and redact_credentials on the provider text it carries.
  • Before -> after (what was allowed/blocked, now): before, the omission-detection test refused this PR because a module calling a redactor was in neither bucket. After, the module is classified as a shared builder that owns no output, beside model_fallback.py. The surfaces that deliver the line (dashboard/chat_runner.py, channel.py, Slack handler_runtime/delivery.py) remain the registered sinks. No sink row is added or removed, so the posture panel's counts are unchanged.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): the module would be misclassified in the posture inventory, under-counting one egress row. No text is redacted less: the redaction call in the builder is new in this PR, and the delivering sinks are unchanged.
  • Evidence checked (which sandbox result proves it): N/A, no sandbox rule is touched. The posture classification is checked by test/test_security_posture.py (56 passed locally on this head) and the Fast Gate pytest set (172 passed locally on this head).
  • No regression:
    • Tools still work (which tools/commands were run, result): no tool or command path changed; test_security_posture.py, test_session_not_found_surfaces.py, test_chat_session_not_found_recovery.py, test_acp_error_surface.py and test_credential_give_up_redaction.py all pass.
    • Backward compatible (old config / old data / old callers still work, how checked): yes; the change adds one set member and touches no config, stored data or caller.
    • Existing tests (which suites passed on this head): Fast Gate pytest set (172), the four credential/session suites (138), isort, flake8, black, mypy, comment-history, docs-lint.
  • How to undo: revert the PR; the set entry and the builder's redaction call come out together.

@JLargent42
JLargent42 force-pushed the fix/redact-credential-give-up-21491 branch from 9ea9bc8 to 5978848 Compare October 23, 2026 02:35
@JLargent42

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: 5978848
  • What rule changed: no redaction rule changed (this head adds only the llm_helpers.py facade manifest entry for the new pattern constant). security_posture.py gains one entry in NON_EGRESS_REDACTION_MODULES, llm_helpers_parts/backend_errors.py, the module that builds the credential give-up line and now calls redact_exfiltration_urls and redact_credentials on the provider text it carries.
  • Before -> after (what was allowed/blocked, now): before, the omission-detection test refused this PR because a module calling a redactor was in neither bucket. After, the module is classified as a shared builder that owns no output, beside model_fallback.py. The surfaces that deliver the line (dashboard/chat_runner.py, channel.py, Slack handler_runtime/delivery.py) remain the registered sinks. No sink row is added or removed, so the posture panel's counts are unchanged.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): the module would be misclassified in the posture inventory, under-counting one egress row. No text is redacted less: the redaction call in the builder is new in this PR, and the delivering sinks are unchanged.
  • Evidence checked (which sandbox result proves it): N/A, no sandbox rule is touched. The posture classification is checked by test/test_security_posture.py (56 passed locally on this head) and the Fast Gate pytest set (172 passed locally on this head).
  • No regression:
    • Tools still work (which tools/commands were run, result): no tool or command path changed; test_security_posture.py, test_session_not_found_surfaces.py, test_chat_session_not_found_recovery.py, test_acp_error_surface.py and test_credential_give_up_redaction.py all pass.
    • Backward compatible (old config / old data / old callers still work, how checked): yes; the change adds one set member and touches no config, stored data or caller.
    • Existing tests (which suites passed on this head): Fast Gate pytest set (172), the four credential/session suites (138), isort, flake8, black, mypy, comment-history, docs-lint.
  • How to undo: revert the PR; the set entry and the builder's redaction call come out together.

@JLargent42

Copy link
Copy Markdown
Contributor Author

CI on 9ea9bc8:

  • Backend Tests (3.12, 2) and (Windows) (2): test_facade_mirror_guards.py::test_every_mirrored_facade_manifest_names_what_it_forwards failed because llm_helpers.py's TYPE_CHECKING manifest did not name the new _FRAME_DATA_TAIL_RE. Fixed in 5978848; the guard passes locally (70 passed).
  • Backend Tests (Windows) (7): test_sibling_list_check.py::test_a_heading_is_found_exactly_when_the_template_check_finds_it also fails on other heads that do not touch it; open fix fix(test): skip the sibling-list bash cross-check on Windows #23264 skips that bash cross-check on Windows. Not caused by this diff.

@JLargent42

Copy link
Copy Markdown
Contributor Author

Backend Tests (Windows) (5) on 5978848: test_security_sensitive_paths.py::TestHomeDirTargetsCache::test_cache_dict_is_bounded stalled on the runner's home directory; recorded on the flake ledger #23251 and re-run once. Not caused by this diff (it changes no path-resolution code). Windows (7) is the inherited test_sibling_list_check red that open #23264 fixes.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 23, 2026
@JLargent42
JLargent42 force-pushed the fix/redact-credential-give-up-21491 branch from 5978848 to 22021ac Compare October 23, 2026 06:31
@JLargent42

Copy link
Copy Markdown
Contributor Author

Rebased once onto main for the #23264 Windows fix.

@JLargent42

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: 22021ac
  • What rule changed: no redaction rule changed (this head is the same change rebased onto main). security_posture.py gains one entry in NON_EGRESS_REDACTION_MODULES, llm_helpers_parts/backend_errors.py, the module that builds the credential give-up line and now calls redact_exfiltration_urls and redact_credentials on the provider text it carries.
  • Before -> after (what was allowed/blocked, now): before, the omission-detection test refused this PR because a module calling a redactor was in neither bucket. After, the module is classified as a shared builder that owns no output, beside model_fallback.py. The surfaces that deliver the line (dashboard/chat_runner.py, channel.py, Slack handler_runtime/delivery.py) remain the registered sinks. No sink row is added or removed, so the posture panel's counts are unchanged.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): the module would be misclassified in the posture inventory, under-counting one egress row. No text is redacted less: the redaction call in the builder is new in this PR, and the delivering sinks are unchanged.
  • Evidence checked (which sandbox result proves it): N/A, no sandbox rule is touched. The posture classification is checked by test/test_security_posture.py (56 passed locally on this head) and the Fast Gate pytest set (172 passed locally on this head).
  • No regression:
    • Tools still work (which tools/commands were run, result): no tool or command path changed; test_security_posture.py, test_session_not_found_surfaces.py, test_chat_session_not_found_recovery.py, test_acp_error_surface.py and test_credential_give_up_redaction.py all pass.
    • Backward compatible (old config / old data / old callers still work, how checked): yes; the change adds one set member and touches no config, stored data or caller.
    • Existing tests (which suites passed on this head): Fast Gate pytest set (172), the four credential/session suites (138), isort, flake8, black, mypy, comment-history, docs-lint.
  • How to undo: revert the PR; the set entry and the builder's redaction call come out together.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 23, 2026
@JLargent42

Copy link
Copy Markdown
Contributor Author

Backend Tests (Windows) (7) on 22021ac: test_ci_file_shards.py::TestFileShards::test_reduced_backend_scope_populates_every_ci_shard timed out at 45 s running scripts/ci-surface-tests.py as a subprocess on the Windows runner. This PR does not touch CI sharding; recorded on the flake ledger as #23365. It gets one re-run once the workflow run finishes.

@JLargent42

Copy link
Copy Markdown
Contributor Author

Windows (7) re-run hit the same 45 s timeout in test_ci_file_shards.py::...test_reduced_backend_scope_populates_every_ci_shard (flake ledger #23365, second report). The script it times does not depend on this diff: it lists the same 1029 files in 13-17 s on Linux on this branch and two others, and the same shard passed on #23257 and #23293. The one allowed re-run is used; leaving it for a maintainer.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 23, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking security finding: URL-first redaction can remove the &token= anchor before credential redaction runs. For example, https://collector.example/?pad=aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa&token=)opaque-value-xyz can leave opaque-value-xyz visible.

Required fix: use the existing composed redaction path instead of two serial passes. Add this case through the real helper, dashboard, and channel outputs.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 23, 2026
@JLargent42
JLargent42 force-pushed the fix/redact-credential-give-up-21491 branch from 22021ac to eecf180 Compare October 23, 2026 18:10
@JLargent42

Copy link
Copy Markdown
Contributor Author

@bolichen97 thanks, the finding held. Addressed in eecf180 (one commit, same base):

  • Composed path: credential_give_up_text now runs the provider text through redact_via_context, the egress path that finds link and credential spans on the original text and rewrites it once, instead of the two passes in sequence.
  • Regression: test/test_credential_give_up_redaction.py adds your case (https://collector.example/?pad=<40 a>&token=)opaque-value-xyz) through the helper (exception and string), the dashboard give-up row via _run_chat, and the channel give-up post via run_channel_agent. All four fail on 22021ac and pass now.
  • Also updated: the owning spec docs/system-specs/common/error-handling.md, the security_posture.py note for backend_errors.py, and the llm_helpers.py facade manifest, which now names the forwarded redact_via_context. 7617 tests pass across the credential, redaction, facade, security-posture, channel and session-recovery files.

@JLargent42
JLargent42 requested a review from bolichen97 October 23, 2026 18:10
@JLargent42

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: eecf180
  • What rule changed: no redaction rule changed. llm_helpers_parts/backend_errors.py (the builder of the credential give-up line) now redacts the provider text it carries through redact_via_context, the composed egress path, instead of redact_exfiltration_urls then redact_credentials. security_posture.py keeps the module in NON_EGRESS_REDACTION_MODULES with its note updated; the llm_helpers.py facade manifest names the forwarded redact_via_context.
  • Before -> after (what was allowed/blocked, now): on main the line carried provider text unredacted; on the previous head it ran the two passes in sequence, which kept a token value whose parameter anchor the link pass had already rewritten. Now both passes find spans on the original text and the line is rewritten once, so that value is removed too. The delivering sinks (dashboard/chat_runner.py, channel.py, Slack handler_runtime/delivery.py) are unchanged.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): the give-up line removes more provider text than intended; the remedy sentence is pinned as kept by the tests. Nothing is redacted less than on main or the previous head.
  • Evidence checked (which sandbox result proves it): N/A, no sandbox rule is touched. test/test_credential_give_up_redaction.py drives the reviewed case through the helper, the dashboard row and the channel post; all four fail on 22021ac and pass on this head.
  • No regression:
    • Tools still work (which tools/commands were run, result): no tool or command path changed; the dashboard and channel paths are driven end to end in the tests above.
    • Backward compatible (old config / old data / old callers still work, how checked): yes; no config, stored data or caller changes, and the line keeps its wording.
    • Existing tests (which suites passed on this head): 203 credential, redaction, facade, security-posture, channel and session-recovery test files (7617 passed); isort, flake8, black, mypy, comment-history, docs-lint clean.
  • How to undo: revert the PR; the builder's redaction call, the posture note, the facade line, the spec text and the tests come out together.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 23, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to ship. My earlier blocking finding is fixed on this head.

Head reviewed: eecf180.

What changed my mind: credential_give_up_text now calls redact_via_context. That path delegates to the composed security.redact, so link and credential spans are found on the original text and the text is rewritten once. The token value after a long query parameter is now removed. The new regression case runs through the helper (exception and string), the dashboard row and the channel post.

What I verified: I applied this commit on top of current main (the merge is clean) and ran test/test_credential_give_up_redaction.py, test/test_security_posture.py, test/test_facade_mirror_guards.py and test/test_llm_helpers_facade.py: 164 passed. The four callers of credential_give_up_text on main (dashboard, channel, Slack) all get the scrubbed line without a call site change. The frame tail pattern is anchored at the colon, so it stays linear on long whitespace.

One small non-blocking note is inline. I will approve when PR Readiness passes on this head.

# the dashboard row, the
# channel post and the Slack reply that carry it all get the same safe
# text. It owns no output; those delivering surfaces
# (dashboard/chat_runner.py, channel.py, and for Slack

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 The sink path in this note is stale on current main

Main moved the dashboard give-up call out of dashboard/chat_runner.py into dashboard/chat_turn/acp_recovery.py in a recent refactor. This branch still merges cleanly, so the note will name a file that no longer holds the sink after merge.

        # (dashboard/chat_runner.py, channel.py, and for Slack
        # handler_runtime/delivery.py) are the registered sinks.

Why it matters: a reader who audits the posture inventory follows this note to find the sink, and lands in the wrong file.

Suggestion: if you rebase for another reason, name dashboard/chat_turn/acp_recovery.py and slack/handler_runtime/delivery.py. Not a blocker.

@JLargent42

Copy link
Copy Markdown
Contributor Author

CI note for head eecf180c922b569b4cebfcfa29f5f8e8b3ace0cc: Backend Tests (3.12, 4) failed in test/test_remote_workspace_file_integrity.py::test_a_regex_that_overflows_is_a_tool_error_not_a_dead_server with unraisable RecursionError warnings. This is the open flake #23382; this PR does not touch that test or the code it covers. Logged on #23382; the job gets one re-run when the workflow run finishes. No code change for it.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Oct 23, 2026
@bolichen97
bolichen97 dismissed their stale review October 24, 2026 00:53

Dismissing my earlier change request: the current head addresses it and all readiness checks and review lanes are green.

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving head eecf180. Verified: readiness label passed, PR Readiness green, no failing required check, all AI review lanes green with no BLOCK, no outstanding change requests from other reviewers. Thanks for the contribution.

@bolichen97
bolichen97 enabled auto-merge (squash) October 24, 2026 00:54
@bolichen97
bolichen97 merged commit da75985 into main Oct 24, 2026
155 of 159 checks passed
@bolichen97
bolichen97 deleted the fix/redact-credential-give-up-21491 branch October 24, 2026 00:54
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(acp): redact provider text in the credential give-up line

2 participants