Repository navigation
docs: propose Slack channel roles for teammates and maintainers - #23362
mvn-bachhuynh-dn wants to merge 2 commits into
Conversation
e4e5b38 to
6ef3fad
Compare
First Principles Review (Opus 5.5, fork) — ⏭️ skippedRevision |
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
Design Review (Opus 5.5, fork) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)Design-level review of Design-Verdict: PASS The RFC sets up a second Slack role system and never mentions the accepted roles model or the owner's earlier decision on the same issue, #22759, so the two designs conflict. BlockersIgnores accepted Notes
[DESIGN-REVIEWED] e2ae29e Description read[DESCRIPTION-READ] b024d330385a922b23759a6192130745bcf7c6b7c592711d56e4dda0e04a7775 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — 🔴 changes requested (blocking)Reviewed The RFC's "Current state" section and its README row say Slack is owner-only, but the base tree already ships BLOCKING — docs/request-for-change/rfc-slack-channel-roles.md:87 |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
|
Deep review found no code inconsistency, but this pull request defines new Slack channel roles for teammates and maintainers. It changes the team communication and authority model, so the design needs a maintainer decision rather than an automated approval. design-doc-gate: Rule D — this changes a design document, so it needs a human to agree to the design. Not approved and not rejected by this review. |
|
Hold at 6ef3fad. This is a draft RFC that would reverse Slack's owner-only default and change governance profile selection, so a maintainer has to accept or reshape the design. Nothing automated can approve that. Two concrete points from the Design Review notes have no reply yet:
Two checks are red on this head: Dependency License Gate ("Dependency review is not supported on this repository") and Sensitive Change Review ("Could not read the PR from the API; re-run this job"). Both look like infrastructure failures and should pass after a re-run. To clear this hold: answer the two design notes and get a maintainer's design acceptance. — crew-pr-reviewer (r123) |
|
Thanks. Both design notes are addressed in revision 2 (head
On the two red checks (Dependency License Gate, Sensitive Change Review): agreed they look like infrastructure failures; I cannot re-run them from the fork, so they need a maintainer re-run. I'm happy to reshape further before a design decision; the remaining open questions are confinement, memory scoping, and whether the owner-approval cards should also replace today's per-tool card. |
6ef3fad to
6c0ff05
Compare
6c0ff05 to
9bbee40
Compare
|
Rebased onto current |
be753d9 to
a5b796e
Compare
a5b796e to
8b350a6
Compare
Code change approver recommendation: A person should decideWhy: the decider raised 1 possible problem and estimates a 62% chance that this change introduces a defect; a person should check it. This is a docs-only PR that adds a draft RFC for Slack channel roles and its README index row. What it says about the current code is accurate. But it was written and audited before Things to check (possible problems the decider raised; at this confidence many turn out to be fine):
An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
|
This adds a new concept, so it needs a design sign-off from a maintainer before it can merge. A maintainer will post the decision here. To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/). Review result on this head: no blocking defect. The PR changes only docs: the new RFC and one row in the index. I checked the current-state claims against main and they hold. Optional notes for the next revision:
For the security review:
|
8b350a6 to
c164cbf
Compare
|
Stale-PR cleanup note: every other check on this head passes. The fork Security Scope Review lane failed twice (run https://github.com/kirodotdev/KiroCrew/actions/runs/44194792125, first attempt and one rerun) because the workflow's GitHub App hit the installation API rate limit ( |
RFC for kirodotdev#22759: let a single-owner gateway admit named Slack users with narrow per-channel rights (read-only teammates, open channels, per-channel maintainers confined to the channel's workspace, owner approvals in the thread), expressed as governance profiles selected by the turn's sender, so the evaluator stays POLICY ∩ PROFILE. Draft; nothing built. Owner-only behaviour is unchanged with no roles set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s checks - Specify role-profile evaluation fails closed on PreToolUse hooks error - Add exit criterion in Phase 2 for harness declaration and refusal when unconfined Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
c164cbf to
e2ae29e
Compare
|
Stale-PR cleanup note: rebased onto current main as e2ae29e (the only conflict was the RFC index in The Opus 5.5 Review now blocks on a design point, not a mechanical fix: main ships |
Problem / Motivation
Goal: Record a proposed design for letting a single-owner gateway admit named Slack users with narrow, per-channel rights, so maintainers can accept, reshape or decline it before any code is written.
Slack is owner-only by construction today (
is_allowed_userreturnsis_owner;slack.allowed_usersis pruned to the owner at boot). A team running one Kiro Crew per project, one Slack channel per project, has no middle ground between "only the owner" and "any allow-listed user with the owner's power". Issue #22759 asked for this; the triage answer was to propose a design through the RFC process.Why it matters
The change reverses a deliberate security default, touches the Slack gate, the tool gate, governance profile selection and the sandbox, and would be expensive to undo. GOVERNANCE.md's scope test puts that behind an RFC, and the First Principles lane needs an accepted document on the base before any implementing PR can land.
Not a goal
What changed (motivation → approach → change)
principalbind type), so the evaluator staysPOLICY ∩ PROFILEand a role is data; owner-only surfaces (DMs, buttons, linked slots, commands) stay owner-only; out-of-role calls become owner approvals in the thread; the maintainer fast path only for an OS-confined session.docs/request-for-change/rfc-slack-channel-roles.md(statusdraft, revision 2 audited at9ae6bc7124, six ordered phases with exit criteria and stated dependencies, three open questions) and its row indocs/request-for-change/README.md.Backwards compatibility
Compatible: documentation only; no code, config or behaviour changes.
Removes nothing: the PR adds one document and one index row.
Tests
N/A — documentation only.
scripts/docs-lint.shandscripts/check_brand_name.pypass on the change.Manual verification
N/A — documentation only. Every statement about current code was checked against
mainat7796e2af52(definitions and callers), cited by symbol per the docs-lint rule.Related Issues
Proposes a design for #22759. Related: #12673 (hosted multi-user, out of scope here).
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.
🤖 Generated with Claude Code