Repository navigation
docs: list all eleven MCP servers in the enterprise governance registry guide - #23494
Conversation
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5, fork) — ⏭️ skippedRevision |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Docs only; all eleven server names and subcommands match Notes
[DESIGN-REVIEWED] b96ece4 Description read[DESCRIPTION-READ] 492d0dc7a699257e9e40d178f84fa10d537f718d95bcd6413ad9ee39e4a01009 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
22482c6 to
e382fad
Compare
|
Both blocking reviews are right: the authoritative map ( |
e382fad to
b96ece4
Compare
|
Rebased onto latest main. Since this PR was opened, #23855 added an eleventh managed server, |
iamwhatever
left a comment
There was a problem hiding this comment.
Approve. Reviewed head b96ece4b2756a83a5b66fded81cd2e5dac387e47.
The guide now lists the eleven managed servers, split into the five always-emitted and six assignable sets, and each table row and registry JSON entry matches _MANAGED_MCP_SERVERS and its mcp-* subcommand on both this head and current main. The file has not moved on main, the merge is clean, and CI is green. The registry launch-route question stays out of scope and is tracked in #23488.
AI findings judged non-blocking
- Design (Notes): the PR description still says six servers and six JSON names while the diff documents eleven. Does not block: it is PR prose, not the shipped guide, and the eleven-server correction is on record in the author and maintainer replies (#23494 (comment), #23494 (comment)).
- Design (Notes):
kirocrew-dashboardandkirocrew-panelare listed as assignable though conductors mount them structurally. Does not block: the code marks bothopt_in: True(,KiroCrew/src/kiro_crew/agent.py
Line 603 in b96ece4
) and the guide row says dashboard is mounted on every conductor ( ).KiroCrew/src/kiro_crew/agent.py
Line 678 in b96ece4
- Own reading:
kirocrew-computersits under 'Always emitted, on every install', but its entry has aspec_gateand is emitted only when supported and enabled (). Does not block: the row itself says it is inert unless enabled ( ), and an admin who allow-lists it loses nothing.KiroCrew/src/kiro_crew/agent.py
Line 588 in b96ece4
Optional: refresh the description's What changed and Tests sections to say eleven.
— crew-pr-reviewer (r141)
bolichen97
left a comment
There was a problem hiding this comment.
[operator: bolichen97] Approving at b96ece4.
Checked against _MANAGED_MCP_SERVERS in src/kiro_crew/agent.py on main: it has exactly these eleven servers, six of them opt_in (work, dashboard, panel, crew-log, debug, secrets), and each registry entry's subcommand matches the server's _kirocrew_mcp_invocation argument.
AI-assisted, approved by bolichen97
Problem / Motivation
Goal: The enterprise MCP governance guide names every server a governed fleet actually needs, so an admin following it does not silently strip the conductor, dashboard and member-panel surfaces.
The guide's allow-list section says Kiro Crew "needs three servers" and its table and registry JSON example cover only
kirocrew-core,kirocrew-cronandkirocrew-computer. The code ships six:kirocrew-workis mounted on every conductor (the work ledger its dispatches are recorded to, which the Dashboard's Workstreams board is minted from),kirocrew-dashboardis the control surface mounted beside it, andkirocrew-panelcarries the member panel tools of member-scoped agents. The registry filter applies to all of them, so an admin who allow-lists exactly what the guide shows runs conductor fleets whose boards stay empty, with nothing explaining why. (#23488 reports this as part of a broader report on the registry example.)Why it matters
This guide is written for the person with the least room to experiment — an enterprise admin configuring a governed fleet. A list that is complete for a chat-only install and silently half-complete for a conductor fleet fails exactly the reader it exists for.
Not a goal
pypiexample should carry an explicit index pointer (registryBaseUrl) or whether a different launch route is the intended one (the open question in Registry mode drops built-in kirocrew-core/kirocrew-cron on ungoverned accounts, removing learn_add/spawn_run/cron_add from sessions #13390) — is a maintainer decision about the supported path, deliberately not taken here. The guide's existing statement that the wheel must be mirrored into an index visible touvxis kept as is.What changed (motivation → approach → change)
Observed: the guide's table, its "needs three servers" framing and its JSON example cover three of the six server names the code mounts. Verified against the tree:
agent_materialization/conductor_agents.pymountskirocrew-workon every conductor andkirocrew-dashboardbeside it,acp/kas_agents.pyjoins@kirocrew-dashboard/@kirocrew-panelinto agent tools, and the CLI exposes the matchingmcp-work/mcp-dashboard/mcp-panelsubcommands. Change: the section now says six servers with which installs need which; the table gains the three missing rows with what is lost without each; the JSON example gains the three matching entries (same one-package/packageArgumentsshape as the existing three); and "all three Kiro Crew servers live behind one package" becomes "every Kiro Crew server". The example block still parses as JSON (checked) and lists all six names.Backwards compatibility
Documentation only. An admin who already allow-listed three servers loses nothing; the guide now tells them what the other three are for before a conductor rollout surfaces it the hard way.
Tests
N/A — documentation; the registry JSON example was machine-checked to parse, with all six server names present.
Manual verification
Server names and subcommands cross-checked against the code (
conductor_agents.py,kas_agents.py, themcp-*CLI subcommands) rather than taken from the issue text.Screenshots / video
N/A — documentation.
Related Issues
Addresses the incomplete server list reported in #23488 (the registry launch-route half of that issue is left open on purpose — see Not a goal).
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions accepted under the project's Apache-2.0 license per CONTRIBUTING.md.