Repository navigation
Conversation
…22450) Edits to $KIROCREW_HOME/.env took effect only after a full gateway restart: the live config watcher fingerprinted config.json only and nothing re-read .env after boot. The dashboard's own credential writer applied its changes live, but a hand edit or any non-dashboard writer did not. ConfigWatch now reconciles .env in the same cycle that reloads config.json. It tracks a separate env fingerprint (loader.env_fingerprint), kept out of _config_fingerprint because that one is the parsed-config cache key. On an .env change it re-reads the raw credential map off the loop, diffs it against a baseline, and pushes changed keys into os.environ (set/pop), dispatching the same path a synthetic credentials.<KEY> change takes so the channel-restart applier restarts only the channels whose descriptor credentials changed (restart_channel, which re-reads load_credentials). Slack is host-managed with no in-process restart path, so a Slack token change logs a restart-needed notice instead. Teams gains a restart_credentials descriptor field for keys (the tenant id) that are restart-relevant but not required for readiness, since folding the tenant into `credentials` would wrongly report multi-tenant Teams as un-startable. Diff semantics, built up across review rounds and pinned by tests: - A removed key is popped from os.environ only when the current value still equals what .env last propagated, so an inherited shell/systemd value a removal never set is left alone. - The overwrite warning fires only on a genuinely foreign value collision, not on every routine rotation. - The watcher's diff baseline is seeded from the raw .env map the first boot-time load_credentials() actually read (recorded once, consumed once), not a later disk read, so a credential rotated in the boot window is still diffed and applied instead of silently adopted as the new baseline. - The fingerprint and baseline only advance after an apply succeeds; a failed apply (e.g. a malformed `=value` line in the same write as a real rotation) leaves both untouched so the next tick retries the whole diff, and the apply validates every key before mutating anything so a batch is atomic. - Every post-boot credential read (channel reconnect, readiness badge, jira/doctor/upload-destination readers) now calls load_credentials(propagate=False), so a worker-thread read can no longer reseed a credential the live watcher just removed. The dashboard's own credential writer routes through the same apply_env_credential_changes instead of hand-rolling os.environ set/pop, so it inherits the Docker-scrub skip and PATH carve-out. - A non-BOM decode error on .env is treated as non-definitive (warned once, retried) instead of wedging the watcher permanently. - Teams: a credential removal closes the live client but its inbound webhook route stays registered, so TeamsClient now re-checks "closed" after the processing awaits (not just at entry) and 503s once closed; closing clears the bound activity handler. Adds loader helpers (env_fingerprint, read_env_credentials_raw, changed_env_keys, apply_env_credential_changes, record_boot_raw_env/take_boot_raw_env) and registry.changed_credential_keys (case-insensitive on Windows), plus tests for the loader helpers, the watcher's .env tracking and boot- window baseline, the credential-driven channel restart, and the Teams webhook-after-close race. Later review rounds, folded into this commit: - A .env PATH line is expanded and validated off the event loop (ConfigWatch._prepare_path_additions -> env.prepare_env_path_additions, run via asyncio.to_thread) and handed to the applier as path_additions, so a ~otheruser entry's pwd.getpwnam / SAM lookup never blocks the loop. os.path.expanduser semantics are unchanged. - The applier decides per os.environ ENTRY, not per .env spelling: on Windows (case-insensitive os.environ) all spellings of a key are grouped and resolved once, to the first non-empty spelling in .env order (boot's setdefault precedence), so renames, partial duplicate removals and both-spellings edits are no longer order-dependent. - Ownership is recorded only when a write takes the entry over (new key, rotation, overwrite of a foreign value). A line that merely matches an inherited service/shell value is not owned, so removing it keeps the inherited credential. - Teams: the webhook handler (state.teams_on_activity) is bound only once a client is the accepted handle (after boot's start_channels, and after a restart passes its generation check), so a restart superseded mid-connect never exposes its handler. - Slack: the restart-needed notice matches credential keys by canonical entry name, like registry.changed_credential_keys. - The watcher's diff (changed_env_keys) also compares each entry's effective value, so a Windows save that only reorders two spellings with different values is applied rather than adopted as the new baseline. - The Weixin QR sign-in writes its token through apply_env_credential_changes like the dashboard channel writer, so it records .env ownership (a later removal revokes it in-process) and keeps the Docker scrub guard. - The Weixin QR sign-in's .env + config.json commit runs under live.hold() (like every sibling channel saver) and through drained_to_thread, so the watcher never restarts Weixin between the two writes and a cancelled request never releases the hold mid-write. - The boot .env record is tied to the file it was read from; the watcher adopts it only for the same .env. The root test conftest resets the boot record and the ownership set around every test.
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The change is backend only, with no [UX-REVIEWED] 5e779ea Description read[DESCRIPTION-READ] 6a51684f8d29645ae9e3ce5dc9aa961a17fc79e43df01896503e7ad134634544 That sha256 names everything this verdict read: the PR description, plus the 4 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS No design-level concerns: Notes
[DESIGN-REVIEWED] 5e779ea Description read[DESCRIPTION-READ] cd94ea0cd50eb1254834ff8f50d59ee4598be6e320916b4e96c6ca87b2fba648 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK The Notes
What this change shipsInventory (10 items) — 8 justifiedIntent: make an operator's
BlockersSecond spelling of the exec-successor hand-off — duplicate of [FIRST-PRINCIPLES-REVIEWED] 5e779ea Description read[DESCRIPTION-READ] 59ffa95772ce62af959a09289f8e350ac2fcf6a517b01e2a1556e3cf40517491 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
HOLD (policy-sensitive) at 609fb58. This PR changes how credentials reach and leave the gateway's process environment. It adds a live In the parts I read, I found no definite defect. The applier validates the whole diff before writing, pops only keys What clears it: a maintainer reviews the credential and Teams changes and Sensitive Change Review completes. — crew-pr-reviewer (r123) |
|
Disposition at Thanks for the read. This comment covers what I could address without a new commit. It does not clear the hold: the credential and Teams admission changes still need a maintainer's review, and Sensitive Change Review is still waiting for a runner. What this does to credentials and Teams admission, in plain words
The safety properties you named, as the code does them
Advisory notes
Still neededA maintainer review of the credential handling and the Teams admission change, and Sensitive Change Review completing. This comment is context for that review, not a substitute for it. |
On Windows os.environ is case-insensitive, so slack_bot_token and SLACK_BOT_TOKEN are one entry. The dashboard channel writer and the WeChat sign-in writer matched .env lines by literal spelling, so a hand-typed lowercase line stayed in place and the new uppercase line was appended after it. Boot and the watcher take the first non-empty spelling, so the old token came back while the save reported success. Both writers now match by the loader's canonical entry name (_env_name_key): the first spelling is rewritten under the declared name and the rest are dropped; a clear removes every spelling, and the rollback read returns the spelling boot actually propagates. POSIX stays case-sensitive, so nothing changes there. Refs #22450
|
Superseded by #23836. |
…22450) Edits to $KIROCREW_HOME/.env took effect only after a full gateway restart: the live config watcher fingerprinted config.json only. The watcher now reconciles .env in the same poll cycle, applies the diff to os.environ through one applier (honouring the Docker credentials scrub and the PATH carve-out), pops only keys .env itself owns, and restarts only the channel whose credential changed. Slack, which has no in-process restart, logs a "run kirocrew restart" notice. The .env ownership record is carried across an in-app re-exec through the existing keep_for_reexec channel, so a post-restart .env removal still pops what .env owned. The dashboard channel writer and the Weixin sign-in writer match .env lines by canonical os.environ entry name, so on Windows a lowercase spelling of a saved key cannot keep an old token in force. POSIX stays case-sensitive. Supersedes #23569. Fixes #22450
…22450) Edits to $KIROCREW_HOME/.env took effect only after a full gateway restart: the live config watcher fingerprinted config.json only. The watcher now reconciles .env in the same poll cycle, applies the diff to os.environ through one applier (honouring the Docker credentials scrub and the PATH carve-out), pops only keys .env itself owns, and restarts only the channel whose credential changed. Slack, which has no in-process restart, logs a "run kirocrew restart" notice. The .env ownership record is carried across an in-app re-exec through the existing keep_for_reexec channel, so a post-restart .env removal still pops what .env owned. The dashboard channel writer and the Weixin sign-in writer match .env lines by canonical os.environ entry name, so on Windows a lowercase spelling of a saved key cannot keep an old token in force. POSIX stays case-sensitive. Supersedes #23569. Fixes #22450
…22450) Edits to $KIROCREW_HOME/.env took effect only after a full gateway restart: the live config watcher fingerprinted config.json only. The watcher now reconciles .env in the same poll cycle, applies the diff to os.environ through one applier (honouring the Docker credentials scrub and the PATH carve-out), pops only keys .env itself owns, and restarts only the channel whose credential changed. Slack, which has no in-process restart, logs a "run kirocrew restart" notice. The .env ownership record is carried across an in-app re-exec through the existing keep_for_reexec channel, so a post-restart .env removal still pops what .env owned. The dashboard channel writer and the Weixin sign-in writer match .env lines by canonical os.environ entry name, so on Windows a lowercase spelling of a saved key cannot keep an old token in force. POSIX stays case-sensitive. Supersedes #23569. Fixes #22450
…22450) Edits to $KIROCREW_HOME/.env took effect only after a full gateway restart: the live config watcher fingerprinted config.json only. The watcher now reconciles .env in the same poll cycle, applies the diff to os.environ through one applier (honouring the Docker credentials scrub and the PATH carve-out), pops only keys .env itself owns, and restarts only the channel whose credential changed. Slack, which has no in-process restart, logs a "run kirocrew restart" notice. The .env ownership record is carried across an in-app re-exec through the existing keep_for_reexec channel, so a post-restart .env removal still pops what .env owned. The dashboard channel writer and the Weixin sign-in writer match .env lines by canonical os.environ entry name, so on Windows a lowercase spelling of a saved key cannot keep an old token in force. POSIX stays case-sensitive. Supersedes #23569. Fixes #22450
…22450) Edits to $KIROCREW_HOME/.env took effect only after a full gateway restart: the live config watcher fingerprinted config.json only. The watcher now reconciles .env in the same poll cycle, applies the diff to os.environ through one applier (honouring the Docker credentials scrub and the PATH carve-out), pops only keys .env itself owns, and restarts only the channel whose credential changed. Slack, which has no in-process restart, logs a "run kirocrew restart" notice. The .env ownership record is carried across an in-app re-exec through the existing keep_for_reexec channel, so a post-restart .env removal still pops what .env owned. The dashboard channel writer and the Weixin sign-in writer match .env lines by canonical os.environ entry name, so on Windows a lowercase spelling of a saved key cannot keep an old token in force. POSIX stays case-sensitive. Supersedes #23569. Fixes #22450
…22450) Edits to $KIROCREW_HOME/.env took effect only after a full gateway restart: the live config watcher fingerprinted config.json only. The watcher now reconciles .env in the same poll cycle, applies the diff to os.environ through one applier (honouring the Docker credentials scrub and the PATH carve-out), pops only keys .env itself owns, and restarts only the channel whose credential changed. Slack, which has no in-process restart, logs a "run kirocrew restart" notice. The .env ownership record is carried across an in-app re-exec through the existing keep_for_reexec channel, so a post-restart .env removal still pops what .env owned. The dashboard channel writer and the Weixin sign-in writer match .env lines by canonical os.environ entry name, so on Windows a lowercase spelling of a saved key cannot keep an old token in force. POSIX stays case-sensitive. Supersedes #23569. Fixes #22450
…22450) Edits to $KIROCREW_HOME/.env took effect only after a full gateway restart: the live config watcher fingerprinted config.json only. The watcher now reconciles .env in the same poll cycle, applies the diff to os.environ through one applier (honouring the Docker credentials scrub and the PATH carve-out), pops only keys .env itself owns, and restarts only the channel whose credential changed. Slack, which has no in-process restart, logs a "run kirocrew restart" notice. The .env ownership record is carried across an in-app re-exec through the existing keep_for_reexec channel, so a post-restart .env removal still pops what .env owned. The dashboard channel writer and the Weixin sign-in writer match .env lines by canonical os.environ entry name, so on Windows a lowercase spelling of a saved key cannot keep an old token in force. POSIX stays case-sensitive. Supersedes #23569. Fixes #22450
…22450) Edits to $KIROCREW_HOME/.env took effect only after a full gateway restart: the live config watcher fingerprinted config.json only. The watcher now reconciles .env in the same poll cycle, applies the diff to os.environ through one applier (honouring the Docker credentials scrub and the PATH carve-out), pops only keys .env itself owns, and restarts only the channel whose credential changed. Slack, which has no in-process restart, logs a "run kirocrew restart" notice. The .env ownership record is carried across an in-app re-exec through the existing keep_for_reexec channel, so a post-restart .env removal still pops what .env owned. The dashboard channel writer and the Weixin sign-in writer match .env lines by canonical os.environ entry name, so on Windows a lowercase spelling of a saved key cannot keep an old token in force. POSIX stays case-sensitive. Supersedes #23569. Fixes #22450
…22450) Edits to $KIROCREW_HOME/.env took effect only after a full gateway restart: the live config watcher fingerprinted config.json only. The watcher now reconciles .env in the same poll cycle, applies the diff to os.environ through one applier (honouring the Docker credentials scrub and the PATH carve-out), pops only keys .env itself owns, and restarts only the channel whose credential changed. Slack, which has no in-process restart, logs a "run kirocrew restart" notice. The .env ownership record is carried across an in-app re-exec through the existing keep_for_reexec channel, so a post-restart .env removal still pops what .env owned. The dashboard channel writer and the Weixin sign-in writer match .env lines by canonical os.environ entry name, so on Windows a lowercase spelling of a saved key cannot keep an old token in force. POSIX stays case-sensitive. Supersedes #23569. Fixes #22450
…22450) Edits to $KIROCREW_HOME/.env took effect only after a full gateway restart: the live config watcher fingerprinted config.json only. The watcher now reconciles .env in the same poll cycle, applies the diff to os.environ through one applier (honouring the Docker credentials scrub and the PATH carve-out), pops only keys .env itself owns, and restarts only the channel whose credential changed. Slack, which has no in-process restart, logs a "run kirocrew restart" notice. The .env ownership record is carried across an in-app re-exec through the existing keep_for_reexec channel, so a post-restart .env removal still pops what .env owned. The dashboard channel writer and the Weixin sign-in writer match .env lines by canonical os.environ entry name, so on Windows a lowercase spelling of a saved key cannot keep an old token in force. POSIX stays case-sensitive. Supersedes #23569. Fixes #22450
…22450) (#23836) Edits to $KIROCREW_HOME/.env took effect only after a full gateway restart: the live config watcher fingerprinted config.json only. The watcher now reconciles .env in the same poll cycle, applies the diff to os.environ through one applier (honouring the Docker credentials scrub and the PATH carve-out), pops only keys .env itself owns, and restarts only the channel whose credential changed. Slack, which has no in-process restart, logs a "run kirocrew restart" notice. The .env ownership record is carried across an in-app re-exec through the existing keep_for_reexec channel, so a post-restart .env removal still pops what .env owned. The dashboard channel writer and the Weixin sign-in writer match .env lines by canonical os.environ entry name, so on Windows a lowercase spelling of a saved key cannot keep an old token in force. POSIX stays case-sensitive. Supersedes #23569. Fixes #22450
Problem / Motivation
Goal: An edit to
$KIROCREW_HOME/.envtakes effect on a running gateway, restarting only the affected channel, without a full gateway restart.Edits to
$KIROCREW_HOME/.envtook effect only after a full gateway restart. The live config watcher fingerprintedconfig.jsononly, and nothing re-read.envafter boot. The dashboard's own credential writer applied its changes live, but a hand edit or any other writer did not, so a rotated token kept reading as the old value until someone restarted the gateway.Why it matters
Operators rotate channel credentials by editing
.env. Today the edit silently does nothing until a restart, so a revoked token keeps a channel failing to authenticate, and a new token looks "saved" but is not in force. Requiring a full restart for a credential change also drops every running session.Not a goal
kirocrew restart" notice instead..envsupports or how boot reads it.What changed (motivation → approach → change)
Symptom: a
.envedit is ignored until restart. Root cause:ConfigWatchnever watched.env. Change:.envis reconciled in the same poll cycle that already reloadsconfig.json.load_credentials(propagate=False), so a worker-thread read cannot reseed a credential the watcher just removed.apply_env_credential_changesinstead of its own set/pop loop, so it also respects the Docker credentials scrub..envPATHline is expanded and validated off the event loop (env.prepare_env_path_additions, run viaasyncio.to_thread) and handed to the applier aspath_additions. A~otheruserentry callspwd.getpwnam/ the SAM database, and that lookup no longer runs on the loop.os.path.expandusersemantics are unchanged..envownership only when the write takes the entry over (a new key, a rotation, an overwrite of a foreign value, or a key.envalready owns). A line whose value merely matches what the process inherited from a service unit or shell is not owned, so removing it later leaves the inherited credential in place, as boot'ssetdefaultalready does..envownership record survives an in-app restart through one environment marker,_KIROCREW_ENV_OWNED_KEYS. The record is Python module state, andos.execvkeepsos.environbut resets module state, so without it the restarted gateway would find every.envkey already set, treat each one as inherited, and never pop any of them on a later removal. Right before the exec,reexec_launcher/reexec_python_modulecall_carry_env_ownership_across_reexec, which writes the owned key NAMES (comma-joined, no values; an empty marker when nothing is owned) into_KIROCREW_ENV_OWNED_KEYS. In the successor, the firstload_credentials(propagate=True)(at the latest the one inrun_gateway, which runs before the orchestrator is built and before anything in that function spawns a process) callsadopt_env_owned_keys_from_reexec, which pops the marker fromos.environand restores the record, so spawned children never inherit it. The only callers of those two seams are the gateway's update/restart paths, and a failed exec there exits the process (exit_after_failed_restart_exec) rather than leaving it running with the marker set. If writing the marker fails, the restart still goes ahead (a warning is logged), and the only effect is that the restarted gateway treats those keys as inherited: a later.envremoval leaves them set until the next full restart, the same as any inherited value.os.environENTRY rather than per.envspelling. On Windows (case-insensitiveos.environ) every spelling of a key (HTTPS_PROXY/https_proxy) is grouped and resolved once, to the first non-empty spelling in.envorder (boot'ssetdefaultprecedence), so a rename, a partial duplicate removal, or both spellings edited in one save cannot leave the entry depending on iteration order. On POSIX each entry has one spelling, so nothing changes there.changed_env_keys) also compares each entry's effective value, so a Windows save that only reorders two spellings with different values is applied instead of silently adopted as the new baseline.apply_env_credential_changesas the dashboard channel writer, so it records.envownership (a later removal of the line revokes it in-process) and keeps the Docker scrub guard..env+config.jsoncommit runs underlive.hold()(like every sibling channel saver) and throughdrained_to_thread, so the watcher never restarts Weixin between the two writes and a cancelled request never releases the hold mid-write..envrecord is tied to the file it was read from: the watcher adopts it only for the same.env, so a record from another data home is never taken as its baseline.restart_credentialsdescriptor field. The tenant gets its own descriptor field rather than joiningcredentialsbecause readiness (channels.pychannel_readiness) reports any absentcredentialskey as missing, and an unset tenant is the supported multi-tenant mode.state.teams_on_activity) is bound only once a client is the accepted handle, after boot'sstart_channelsand after a restart passes its generation check.maybe_start_teamsno longer binds it before the connect completes, so a restart superseded mid-connect never exposes its handler (the route answers 503 until then).registry.changed_credential_keys, so a lowercase.envSlack key on Windows still gets the notice..envwriters match lines by canonical entry name (_env_name_key), not literal spelling: the dashboard channel writer (_write_env_updates_locked) and the Weixin sign-in's_write_env_secret/_read_env_value/_delete_env_key. Before this, on Windows a hand-typedslack_bot_token=line was left in place and the savedSLACK_BOT_TOKEN=was appended after it, so the first-non-empty-spelling rule above put the OLD token back in force while the save reported success. Now a save rewrites the first case-equivalent spelling under the declared name and drops the rest, a clear removes every spelling, and the rollback read returns the spelling boot actually propagates. On POSIX the canonical name is the name itself, so a lowercase line is a different variable and is left alone.This supersedes #23027, #23470, #23491 and #23514 (all closed). The reviewed change is one commit on current
main, plus a second commit for the Windows case-spelling writer fix above, so PR Hygiene's two-commit limit is met without a force-push. It folds in every review fix from those PRs, including the structural-guard registrations, the Weixin sign-in hold, and scoping the boot.envrecord.Backwards compatibility
Compatible: boot still seeds
.envwithsetdefault, every key.envaccepted before is still accepted, andPATHentries resolve exactly as before.Removes nothing: the diff adds a watcher input and routes existing credential writes through one applier; no key, kind, public function or stored data is removed or renamed.
Reader: src/kiro_crew/dashboard/messaging_api/channel_config_writes.py:write_channel_env -- crew page -- under
_KIROCREW_CREDS_SCRUBBEDa dashboard save no longer writes credential keys intoos.environ, matching the boot loop; children read them from.env(test_a_landed_write_honours_the_docker_creds_scrub)Tests
Proof: PROVEN test/test_channel_boot_hot_reload.py::TestTeamsCloseClearsWebhookHandler::test_closing_teams_clears_the_late_bound_webhook_handler, test/test_channel_boot_hot_reload.py::TestTeamsWebhookPublishedOnlyForTheAcceptedClient::test_an_accepted_start_binds_its_handler, test/test_channel_boot_hot_reload.py::TestCredentialChangeRestartsChannel::test_a_credential_change_restarts_the_owning_channel, test/test_channel_boot_hot_reload.py::TestCredentialChangeRestartsChannel::test_a_credential_change_for_a_degraded_channel_is_deferred_not_dropped, test/test_channel_boot_hot_reload.py::TestSlackCredentialChangeWarns::test_a_slack_token_change_logs_a_restart_needed_notice , test/test_slack_config_handlers.py::test_windows_save_replaces_a_lowercase_spelling_of_the_key (head 5e779ea)
test/test_env_credential_hot_reload.py: an env-only edit dispatchescredentials.<KEY>and appliesos.environ; a failed apply leaves the baseline so a repair re-applies the rotation; an undecodable or wide-encoded.envis retried rather than read as every key cleared; a removal pops only what.envpropagated; a.envPATH edit is expanded on a worker thread, not the loop thread; a Windows case-duplicate keeps its entry when one spelling is removed; a live add that matches an inherited value does not take ownership, so deleting the line keeps the inherited token, while an add that writes a new value does own it and is popped on removal; both spellings edited in one save resolve to boot's precedence in either iteration order, modelled with a case-foldingos.environ; a reorder of two Windows spellings with different values is a diff and installs the new winner, while a reorder of equal values is not.test/test_dotenv_path_extension.py: a.envPATH line appends absolute directories behind the existing PATH, deduped; relative and unexpanded entries are dropped with a warning;~and~otheruserstill expand throughos.path.expanduser.test/test_channel_boot_hot_reload.py: a credential change restarts only the owning channel; a degraded channel's change is deferred, not dropped; a Slack token change logs the restart notice; closing Teams clears the late-bound webhook handler; a Teams restart superseded mid-connect never binds its webhook handler while an accepted one does; a lowercase Slack key on Windows still logs the notice.test/test_weixin_qr.py: a first sign-in records ownership, so deleting the line afterwards revokes the token in-process; a confirmed sign-in persists while the watcher is held and a cancelled one keeps the hold until the write finishes; a boot record from another.envfile is refused; on Windows a sign-in replaces a lowercaseweixin_tokenline and the rollback delete removes every spelling, while on POSIX both leave the lowercase name alone.test/test_slack_config_handlers.py: on Windows a dashboard save replaces a lowercase spelling of the key, collapses several spellings to one line where the first was, and a clear removes every spelling; on POSIX a lowercase name is left untouched. The five Windows cases fail against the previous writers.test/conftest_resets.py: the boot.envrecord and the ownership set are reset around every test, so neither leaks across an xdist worker.test/test_teams_gateway.py:maybe_start_teamsregisters the transport but leaves the webhook handler unbound for the host.test/test_channel_env_write_off_loop.py: the dashboard writer honours the Docker credentials scrub.Local on head
609fb58fbc(Python 3.12): 1775 passed across every changed test file plus the facade-mirror, gateway-bindings, composition-contract, loader-owners, env BOM, config-live, host-isolation and flake-ratchet suites; flake-pattern ratchet passes against the merge base.Local on head
5e779ea66e(Python 3.12): 1367 passed across all 15 changed test files; isort and flake8 clean on every file the second commit changes;mypy src/kiro_crew/clean (3584 files);scripts/check_black_formatting.pygate passes.Manual verification
N/A — the watcher cycle, applier, and channel restart dispatch are each driven end to end by the
ConfigWatch._cycle()tests above against a real temp.env, which is the path a hand edit takes.Related Issues
Fixes #22450
Sibling sweep
Swept: git grep -nE "load_credentials(|apply_env_credential_changes|os.environ[.*] *=" -- src/
Sibling: src/kiro_crew/dashboard/messaging_api/channel_config_writes.py -- changed here
Sibling: src/kiro_crew/slack/gateway_runtime/channel_lifecycle.py -- changed here
Sibling: src/kiro_crew/dashboard/source_providers/jira.py -- changed here
Sibling: src/kiro_crew/dashboard/upload_destination.py -- changed here
Swept (case-equivalent
.envspellings): git grep -nE 'split("=", 1)[0]|partition("=")' -- src/Sibling: src/kiro_crew/dashboard/messaging_api/channel_config_writes.py:_write_env_updates_locked -- changed here
Sibling: src/kiro_crew/dashboard/handlers/weixin_qr.py:_write_env_secret, _read_env_value, _delete_env_key -- changed here
Sibling: src/kiro_crew/cli_setup.py:_read_env_pairs -- not changed:
kirocrew setup --slackkeys its merge by literal spelling, so on Windows a lowercase Slack line also survives a setup save. That is pre-existing, outside this diff, and is a CLI setup path rather than the dashboard rotation the finding names; left for a follow-up so this PR stays within two commits.Pattern harvest
Not generalizable: the defect was one missing watcher input (
.envalongsideconfig.json), not a repeated code shape a rule could catch.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)docs/system-specs/modules/config.mdContribution License Agreement
Contributed under the project's Apache-2.0 license.