Repository navigation
fix(crew): a worker report asks the crewmate to update its Dashboard page - #23576
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the instruction now sits on the one wake a dispatched job always reaches, and every failure path just drops the extra line. Notes
[DESIGN-REVIEWED] bfc4042 Description read[DESCRIPTION-READ] 1aab58068c1d2f28a8aa82e6df4db427eb04a742b64a997bd11826a329378690 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. One note: Notes
What this change shipsInventory (6 items) — 5 justifiedIntent: a crewmate records its worker's job progress on its Dashboard page in the same turn, without being asked. FIX.
[FIRST-PRINCIPLES-REVIEWED] bfc4042 Description read[DESCRIPTION-READ] b0b4f211a61d6c17ff1ccfb245ad7fbb5d4648e29b9c53e56a6dd6b2c5463ef5 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
…page A dispatched job's state changes on the [Worker report] wake, and that wake told the crewmate only to tell the user in chat. The check-ins that ask for the page run only with a goal and a switch on, so a one-shot job left the page empty. The wake now ends on one line: the page's own fields to write with dashboard_write before the turn ends, or the suggestions page's build-your-page line.
31c7aa5 to
bfc4042
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (5 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: a worker-report wake now ends with one line naming the crewmate's Dashboard fields to write, and skips the wake when the thread closes during the page read; covered by new tests. Spec files changed as a ride-along (a minority of the diff on both file count and changed lines), not reviewed as a design decision: docs/system-specs/modules/crew-mode.md.
Problem / Motivation
Goal: A crewmate whose worker finishes or moves a job puts the news on its Dashboard page in that same turn, without the user having to ask.
A crewmate ran a whole remediation job through its workers and its Dashboard page stayed empty. It filled the headline and the Needs-you cards only after the user asked why the page was blank, and it said it had never updated the fields. Nothing reminded it at the moment the work changed:
[Worker report]wake, where a dispatched job's state changes, only said "tell the user in this thread" (worker_report.guidance). It said nothing about the page.dashboard/goal_reminder.py) only run when there is a goal and their switch is on, so a one-shot job never reaches them.[DASHBOARD]block that lists the page's fields is part of the member section. That section is injected at session start, on a slim resume and after a compaction, not on every wake.Why it matters
The Dashboard tab is where a crewmate's user follows its work when they are not reading the thread. A crewmate that does real work and leaves the page empty looks idle, and the decisions waiting on the user never reach the page they read.
Not a goal
[DASHBOARD]block or how often the member section is injected.What changed (motivation → approach → change)
Symptom (the page stays empty after a worker-run job) → cause (the only wake on the path of a dispatched job asks for a chat reply and never names the page, and the wakes that do name it are gated on a goal) → put the page on that wake, worded for the page's state at that moment.
dashboard/mate_thread_wakes.py:page_line(slug)reads the crewmate's tab off the event loop, once per flush, before the idle check.with_pageadds that line at the end of the[Worker report]prompt. It returns one of three things:worker_report.dashboard_fieldspiece. It names those fields (for project-report:ci, for_you, verdict) and asks for them to be written withdashboard_writebefore the turn ends.dashboard_agentic.SUGGESTIONS_LINE, the turn block's existing build-your-page line.agent.crew_paneloff, under the person's lock while the tab shows suggestions (an apply would be refused), or for a page whose every field is folded. A page that cannot be read also costs only the line.crewmate_prompts.json: one new key,worker_report.dashboard_fields, plus its_aboutentry. Both sit away from the lines feat(crew): let a crewmate request tools for its worker (preview) #23562 edits.docs/system-specs/modules/crew-mode.md: the "A worker reports back on its own" paragraph describes the line.Backwards compatibility
Compatible: the wake gains one closing line;
report_prompt's signature and output are unchanged, and every existing caller keeps working.Removes nothing: the diff only adds a line to a gateway-authored prompt and one prompt key.
Tests
test_mate_thread_wakes.py::test_the_wake_a_worker_report_starts_carries_the_page_line: a worker's turn end makes the crewmate's wake end on the page line, read for the crewmate's own slug.test_a_report_on_a_page_names_its_fields_to_write_this_turn,test_a_report_on_the_suggestions_page_carries_the_build_lineandtest_no_page_line_without_page_tools_or_fieldscheck each statepage_lineanswers: page in force, suggestions page, suggestions under lock, panel off, no writable fields, empty slug.The wake-path fixtures in
test_mate_thread_wakes.pyandtest_cron_crewmate_report.pystubpage_line. The cron test's_settlenow waits for the flush task, because the page read is a thread hop.test_a_thread_closed_during_the_page_read_gets_no_wake[closing|removed|replaced]: the fake page read closes, removes or replaces the crewmate thread while it runs (no sleeps). No wake starts and the report stays pending.Proof: PROVEN test/test_mate_thread_wakes.py::test_the_wake_a_worker_report_starts_carries_the_page_line, test/test_mate_thread_wakes.py::test_a_thread_closed_during_the_page_read_gets_no_wake[closing], test/test_mate_thread_wakes.py::test_a_thread_closed_during_the_page_read_gets_no_wake[removed], test/test_mate_thread_wakes.py::test_a_thread_closed_during_the_page_read_gets_no_wake[replaced] (head bfc4042)
Manual verification
page_linewas run against the real instance store and the shipped templates in a throwawayKIROCREW_HOME. An unadopted crewmate got the suggestions line. Afterinstance.adopt(slug, "project-report")it got: "The user follows this work on your Dashboard page, not in this thread. Before you end this turn, write what these reports changed to its fields (ci, for_you, verdict) with dashboard_write; ...".[Worker report]turn. That is model behaviour and needs a pod run.scripts/local-gate.py: backend related tests passed (29). The frontend leg could not start in this worktree, becausewebsite/node_modulesis not installed. The diff touches no frontend file.Related Issues
Refs: an internal bug report on crewmate Dashboard pages (issue 4 of that report). There is no public issue.
Sibling sweep
Swept:
git grep -n "dispatch_hidden_turn(" -- src/kiro_crew/dashboard(every gateway-authored wake in a crewmate's thread)Sibling: src/kiro_crew/dashboard/goal_reminder.py -- not affected -- the daily and heartbeat prompts already ask for the page fields, gated on a goal by design
Sibling: src/kiro_crew/dashboard/goal_setup.py -- not affected -- goal kickoff and milestone wakes hand research to a worker, whose report now carries the line
Sibling: src/kiro_crew/mate_upgrade_notice.py -- not affected -- a one-time notice about the worker, no work state to record
Pattern harvest
Rule candidate: review-prompt
Pattern: an instruction that must fire when state changes lives only in session-start context or in a wake gated on unrelated settings, so the turn where the state actually changes never carries it.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.