Skip to content

test(scratch): turn off git auto-maintenance on release/0.10.0 - #23672

Merged
bolichen97 merged 1 commit into
release/0.10.0from
fix/release-0.10.0-scratch-maintenance-race
Oct 25, 2026
Merged

bolichen97 merged 1 commit into
release/0.10.0from
fix/release-0.10.0-scratch-maintenance-race

Conversation

@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Problem / Motivation

Goal: Make the 0.10.0 release test gate pass, so release/0.10.0 gets a green insider run that stable can be promoted from.

The v0.10.0-insider.5 Release run (40053443797) failed "Test Release Candidate SHA (8)" on both attempts. Each time the only failure was test/test_agent_scratch.py::TestGitTreesAreQuarantined::test_a_git_dir_whose_head_is_gone_is_moved (1 failed, 22799 passed). Attempt 1 hit FileNotFoundError on .git/objects/maintenance.lock; attempt 2 failed the snapshot compare for the same reason. The fixture git starts background auto-maintenance, which creates and removes that lock while the test walks the tree.

Why it matters

The red test gate skips "Record Immutable Promotion Bundle". stable-gate needs a successful same-commit insider run, so without this fix the bare v0.10.0 cannot ship from release/0.10.0.

Not a goal

What changed (motivation → approach → change)

Symptom: the quarantine test sees .git/objects/maintenance.lock come and go -> cause: the fixture _git helper lets git run auto-maintenance and auto-gc in the background -> change: cherry-pick of #21236 (0bc9d241f), which passes -c maintenance.auto=false -c gc.auto=0 to every fixture git call in test/test_agent_scratch.py. The pick applied with no conflict.

Backwards compatibility

Compatible: the change is inside one test helper and alters no shipped behavior.

Removes nothing: the diff only adds two git config flags to a test fixture.

Tests

test/test_agent_scratch.py on this branch: all pass. -k TestGitTreesAreQuarantined run 25 times in a row: 25 green.

Manual verification

N/A: test-only change; the insider.6 Release run on the merge commit is the end-to-end check.

Related Issues

Backport of #21236 to release/0.10.0.

Pattern harvest

Not generalizable here: main already carries the general guard (#20311) for fixture git auto-maintenance; this release branch only needs the targeted fix.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

…es (#21236)

A background git maintenance or auto-gc could create and remove
.git/objects/maintenance.lock while _snapshot walked the tree, so the
walk listed the file and then failed to read it.

Closes #20325

(cherry picked from commit 0bc9d24)
@KiroCrewCaptain
KiroCrewCaptain requested a review from a team as a code owner October 24, 2026 05:47
@KiroCrewCaptain
KiroCrewCaptain requested review from chenmingwei23 and removed request for a team October 24, 2026 05:47
@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision d276c51855a569e22dbe49851be8c5d1210aaaca ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision d276c51855a569e22dbe49851be8c5d1210aaaca touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Advisory — does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of d276c51855a569e22dbe49851be8c5d1210aaaca — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] d276c51

Description read

[DESCRIPTION-READ] 9554fd8c47dd14b796c5054c3f9674f03fafff88b6a0f196bffcfa45ecacb52e

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed d276c51855a569e22dbe49851be8c5d1210aaaca — this comment is updated in place on each push.

Review details

I found no defects in the diff. The candidate list was empty, so there was nothing to falsify. The change only adds two -c options to a test fixture's git call (turning off auto-maintenance and auto-gc) and expands its docstring.

No findings.

[OPUS-REVIEWED] d276c51

Verdict parsed from the review's SHA-scoped output markers for commit d276c51855a569e22dbe49851be8c5d1210aaaca.

False positive or not applicable? A repository writer can comment:
/ai-review override fable d276c51855a569e22dbe49851be8c5d1210aaaca: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of d276c51855a569e22dbe49851be8c5d1210aaaca and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] d276c51

False positive or not applicable? A repository writer can comment:
/ai-review override gpt d276c51855a569e22dbe49851be8c5d1210aaaca: <one-sentence reason>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 24, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

HOLD at d276c51.

The change is a faithful cherry-pick of #21236 (0bc9d241f): its changed lines are identical to the main commit, it only adds -c maintenance.auto=false -c gc.auto=0 to a test fixture (test_agent_scratch.py#L933-L963), and every check is green. It is held only because the base is release/0.10.0, and approving a release-branch backport is a maintainer's decision, not this reviewer's.

— crew-pr-reviewer (r124)

@bolichen97
bolichen97 merged commit 294fa06 into release/0.10.0 Oct 25, 2026
25 checks passed
@bolichen97
bolichen97 deleted the fix/release-0.10.0-scratch-maintenance-race branch October 25, 2026 02:06
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants