Repository navigation
test(scratch): turn off git auto-maintenance on release/0.10.0 - #23672
Conversation
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] d276c51 Description read[DESCRIPTION-READ] 9554fd8c47dd14b796c5054c3f9674f03fafff88b6a0f196bffcfa45ecacb52e That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsI found no defects in the diff. The candidate list was empty, so there was nothing to falsify. The change only adds two No findings. [OPUS-REVIEWED] d276c51 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
HOLD at d276c51. The change is a faithful cherry-pick of #21236 ( — crew-pr-reviewer (r124) |
Problem / Motivation
Goal: Make the 0.10.0 release test gate pass, so
release/0.10.0gets a green insider run that stable can be promoted from.The
v0.10.0-insider.5Release run (40053443797) failed "Test Release Candidate SHA (8)" on both attempts. Each time the only failure wastest/test_agent_scratch.py::TestGitTreesAreQuarantined::test_a_git_dir_whose_head_is_gone_is_moved(1 failed, 22799 passed). Attempt 1 hitFileNotFoundErroron.git/objects/maintenance.lock; attempt 2 failed the snapshot compare for the same reason. The fixture git starts background auto-maintenance, which creates and removes that lock while the test walks the tree.Why it matters
The red test gate skips "Record Immutable Promotion Bundle".
stable-gateneeds a successful same-commit insider run, so without this fix the barev0.10.0cannot ship fromrelease/0.10.0.Not a goal
src/is untouched.v0.10.0-insider.6on the merge commit by hand.What changed (motivation → approach → change)
Symptom: the quarantine test sees
.git/objects/maintenance.lockcome and go -> cause: the fixture_githelper lets git run auto-maintenance and auto-gc in the background -> change: cherry-pick of #21236 (0bc9d241f), which passes-c maintenance.auto=false -c gc.auto=0to every fixture git call intest/test_agent_scratch.py. The pick applied with no conflict.Backwards compatibility
Compatible: the change is inside one test helper and alters no shipped behavior.
Removes nothing: the diff only adds two git config flags to a test fixture.
Tests
test/test_agent_scratch.pyon this branch: all pass.-k TestGitTreesAreQuarantinedrun 25 times in a row: 25 green.Manual verification
N/A: test-only change; the insider.6 Release run on the merge commit is the end-to-end check.
Related Issues
Backport of #21236 to
release/0.10.0.Pattern harvest
Not generalizable here: main already carries the general guard (#20311) for fixture git auto-maintenance; this release branch only needs the targeted fix.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.