Skip to content

feat(chat): fill the main chat's user bubble with the accent - #23755

Closed
ash663 wants to merge 1 commit into
kirodotdev:mainfrom
ash663:feat/main-chat-accent-bubble
Closed

ash663 wants to merge 1 commit into
kirodotdev:mainfrom
ash663:feat/main-chat-accent-bubble

Conversation

@ash663

@ash663 ash663 commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: In the main dashboard chat, the user's own messages are filled with the theme accent, so they stand apart from the agent's replies at a glance.

In the main chat your message is a neutral gray card and the agent's reply has no bubble at all. In a long session the two look almost the same, and a short question gets lost between long replies (#23358). A crewmate's chat already solved this with an accent-filled user bubble (#17839, shipped in #17918).

Why it matters

The main chat is where most conversations happen. Scrolling back through a long session, you look for your own questions first, and today you have to read each block to find them. Dark and light themes are both affected.

Not a goal

  • A gray bubble for the agent's reply (the other half of the crewmate chat's pairing). Replies stay unboxed.
  • A new tone, new CSS or a setting. The accent tone, its CSS and its contrast come from feat(crewmate-chat): colour the two speakers like iMessage #17918 unchanged.
  • The crewmate chat, which is already accent.
  • The steer bubble's own tint, the edit-mode input box, and CLI mode's neutral bubble.

What changed (motivation → approach → change)

Your messages in the main chat are now filled with the theme accent, so you can tell them from the agent's replies at a glance. It is the same bubble a crewmate's chat already draws.

Four files draw your message, and each one now asks for the accent tone. That reaches these surfaces:

Surface (file) Why it is in
main chat page, its popout, the pages that embed it (pages/chat/page/transcriptRendering.tsx) it is the chat the issue is about
split panes and Side Chat (app-sdk/messageRenderers.tsx, the shared user row) they draw the main chat's rows on the same page; left gray, one page would show two user colours
an app's chat embed (the same shared row) it is "Kiro Crew's native transcript" for apps and draws that row; it keeps gray only by registering its own row
the Members page's Side Chat (the same shared row) Side Chat is one component; it now matches that page's own accent bubbles
a crew window (pages/chat/crew-window/crewWindowRenderers.tsx) it opens over the main chat page and draws the main chat's bubbles for a connected crew's session
the pinned prompt card (pages/chat/PinnedPrompt.tsx) it is a pixel copy of your bubble; left gray, the hand-off from bubble to card would jump from purple to gray

The docs say where the accent applies: docs/system-specs/modules/crew-mode.md, plus the comments on UserMessage's tone and on the CSS hook in styles/chat-transcript.css. A one-pager records the decision, as tier:T3 asks: docs/request-for-change/rfc-main-chat-accent-user-bubble.md, indexed in the directory README.

Backwards compatibility

Compatible: tone already exists and stays optional, and only class names on four elements change. No prop, key, type or row kind is renamed or removed. An app that wants a neutral bubble can still register its own user row.

Removes nothing: the neutral default tone stays the component default, and every reader of .user-bubble, .message-bubble and data-testid="pinned-prompt" still finds them.

Tests

  • website/src/pages/ChatPage.transcriptRendering.test.tsx: the main chat page's user row draws user-bubble-accent. Fails if the page stops passing the tone.
  • website/src/test/UserMessage.accentTone.test.tsx: the user row that a split pane, the Side Chat and a crew window each resolve (each registry built the way its host builds it) draws the accent. Fails if the shared row or the crew window row drops it. The file's comments now describe the main chat as well.
  • website/src/test/kiroLightShellHooks.test.ts: the pinned card's class pin names the accent hooks, so the card cannot drift from the bubble.
  • Mutation check: reverting any one of the four changes alone turns one of these tests red.
  • Determinism: the three files pass 20 serial runs, 10 runs beside crewmateBubbles.test.ts and ChatMessageList.test.tsx, and a shuffled order (--sequence.shuffle --sequence.seed=2746).

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

The real ChatPage in Chromium, with no gateway: a throwaway capture page mounts the page on a fixture transcript and Playwright answers its API calls. Each check compares a computed colour with the theme's own token, in kiro-dark and kiro-light:

Check Result
every plain user bubble background var(--accent), text var(--accent-fg)
inline code and a link inside it text var(--accent-fg); code keeps its own patch
sent quote card bar var(--accent-fg), excerpt a 90% --accent-fg mix
collapsed paste chip drawn inside the bubble in var(--accent-fg)
steer with its badge keeps var(--accent-subtle)
Edit & Resend (dark) opens the editor holding the text; Escape brings the bubble back
pinned prompt card (dark) background var(--accent)
phone, 390×844 (dark) bubbles var(--accent)
CLI mode (data-ui="cli"), both themes bubbles and the pinned card stay neutral; text readable on both
same page on main every bubble and the pinned card neutral

Nearby inputs that reach the same code:

Input Tested
plain text, inline code, link, sent quote card, paste chip, steer yes, captured in both themes
Edit & Resend, pinned prompt, phone width yes, captured in dark
split pane, Side Chat, crew window unit test on the same row
an app's chat embed unit level, through the shared row the test resolves for Side Chat
image attachment, file card, folder chip, session link not captured: the same renderUserContent path, inside the same token scope
CLI mode yes, computed colours in both themes
forced colors not captured: its CSS guard is unchanged

Screenshots / video

The real ChatPage, the same fixture on both trees.

before (main) after
dark dark, before dark, after
light light, before light, after

Phone, 390×844, dark, after:

phone, dark, after

Pinned prompt and Edit & Resend (dark, after)

pinned prompt, dark, after

edit and resend, dark, after

Related Issues

Closes #23358

The accent tone this reuses: #17839, shipped in #17918.

Sibling sweep

N/A -- a feature, not a fix.

Pattern harvest

N/A -- a feature, not a fix.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

In the main chat the user's messages and the agent's replies look
almost the same: a neutral bg-card bubble beside a reply with no
bubble. A crewmate's chat already fills the user's bubble with the
theme accent through tone="accent" on UserMessage.

Pass that tone at every seam the main chat draws the user's row
from: ChatPage's bubble row, the SDK's default user row (split
panes, Side Chat, app chat embeds) and the crew window's row. The
pinned-prompt card is a pixel copy of the bubble, so it takes the
same hooks and the hand-off stays invisible. A one-pager records
the decision, the crew-mode spec says where the accent applies,
and before/after captures sit under temp-screenshots/.
@ash663
ash663 requested review from a team and KiroCrewCaptain as code owners October 24, 2026 14:34
@ash663
ash663 requested a review from bolichen97 October 24, 2026 14:34
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Oct 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 2e9c7b0f7d0596afafd8e75c1b0b43a3f8ecb1d7 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: one existing tone is passed at each place the main chat draws a user bubble, the screenshots are committed, and a revert undoes it cleanly.

Notes

  • Changing the SDK's default user row also turns every app's ChatEmbed accent, and no app opts in. Name that change in the App Kit reference, so an app author knows to register their own user row to keep the neutral bubble.

[DESIGN-REVIEWED] 2e9c7b0

Description read

[DESCRIPTION-READ] 30c17f133a658323b6195cde260da7f20eac98e3b4d29d36cd1b56346fd9e84d

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ✅ PASS

UX-level review of 2e9c7b0f7d0596afafd8e75c1b0b43a3f8ecb1d7 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The screenshots show the accent bubble in the main chat, the pinned card, Edit & Resend, and a phone in both themes. No first-time reader has looked at them, because this lane reviews forks without a blind read.

Notes

  • Split pane, Side Chat, crew window and the app chat embed also turn accent, but no screenshot shows them. Adding a split-pane or Side Chat capture would show that one page no longer mixes two user-bubble colours.
  • Next to the solid accent bubbles, the steer bubble (attachment-04, "Also check the Windows build.") now looks dim, like a message that didn't go through. Its "Steered into the running turn" badge is the only cue it was sent; worth checking that a reader takes it as sent.

[UX-REVIEWED] 2e9c7b0

Description read

[DESCRIPTION-READ] 09081c46326fe0961f970d0419eb5eeb4c6c1306831d4de61249de76ae3f9727

That sha256 names everything this verdict read: the PR description, plus the 10 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — 🔴 BLOCK

Premise-level review of 2e9c7b0f7d0596afafd8e75c1b0b43a3f8ecb1d7 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: BLOCK

product-shape change without accepted RFC: every user's main chat, and every app's default chat embed, switches from a neutral user bubble to an accent-filled one. The only decision record is the RFC this same diff adds.

What this change ships

Inventory (8 items) — 5 justified

Intent: make your own messages in the main dashboard chat easy to tell apart from the agent's replies. ADDITION.

  1. Your messages on the main chat page, its popout and the pages that embed it are now accent-filled — product shape, no recorded decision
  2. Split panes and Side Chat (the Members page included) draw the accent bubble — justified
  3. An app's ChatEmbed draws the accent bubble unless the app registers its own user row — product shape, no recorded decision
  4. A crew window draws the accent bubble — justified
  5. The pinned prompt card is accent-filled to match the bubble — justified
  6. crew-mode.md drops "The single-chat page's user bubble is untouched." — justified
  7. New RFC plus a README row marked implemented — proposes a decision, does not record one
  8. Before/after screenshots under temp-screenshots/ — justified

Blockers

product-shape change without accepted RFC: the main chat's user bubble becomes accent by default (items 1, 3)
Trigger: tone="accent" is added at transcriptRendering.tsx:262 and in defaultMessageRenderers (app-sdk/messageRenderers.tsx:683), so every user and every app embed gets the new look with no choice. rfc-main-chat-accent-user-bubble.md is not in the base RFC status list. The diff adds it, so this run reads it as draft.
Outcome: the default look of the main chat changes for everyone, and the App SDK's default user row changes for third-party apps, with no decision on record. The base spec said the single-chat bubble stays "untouched".
Clears when: an RFC covering the accent user bubble in the main chat and the SDK default row is merged on the base as non-draft (then push or rebase), or a maintainer posts /ai-review override first-principles 2e9c7b0f7d0596afafd8e75c1b0b43a3f8ecb1d7 product-shape: <decision>.

[FIRST-PRINCIPLES-REVIEWED] 2e9c7b0

Description read

[DESCRIPTION-READ] 43042b40968fb19daa0731b04f2425363d527dc66f68e19fa912bf57e3dbdc8d

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 2e9c7b0f7d0596afafd8e75c1b0b43a3f8ecb1d7 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 2e9c7b0

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 2e9c7b0f7d0596afafd8e75c1b0b43a3f8ecb1d7 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 2e9c7b0

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a design decision before merge. The code itself looks good.

Head reviewed: 2e9c7b0. Lanes read on this head: Design PASS, UX PASS, Opus no blocking findings, GPT no blocking findings, First Principles BLOCK. Readiness is action required, and CI is still running.

What I checked:

  • The four tone="accent" seams (ChatPage row, SDK default user row, crew window row, pinned prompt card). Each one reuses the existing user-bubble-accent hook unchanged. The msg-content class added to the pinned card is what the existing selectors in chat-transcript.css need, and the CLI guard still turns it off.
  • A steer with its badge still wins over the tone in UserMessage, so the steer tint is unchanged.
  • Each seam has a test that goes red if its tone is dropped.

Why this is a comment and not an approval: the linked issue #23358 is tier:T3 and is not on the current plan. A T3 change needs a design sign-off from a maintainer. The First Principles lane blocks on the same point: the only decision record is the RFC this PR adds, and the RFC index says an RFC shipped beside its change proposes a decision but does not record one. One way forward is to land the RFC on its own as draft and let a maintainer accept it, then rebase this PR. A maintainer can also record the decision on this PR directly.

🔴 0 must-fix · 🟡 1 should-fix (inline). Not repeated: the product-shape blocker the First Principles lane already states.

@@ -0,0 +1,77 @@
---
title: The main chat's user bubble uses the accent tone
status: implemented

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 The RFC records itself as implemented before anyone accepted it or anything merged

The front matter sets status: implemented, but doc-pr is empty, implementation-prs is [], and the index row says what is "actually on main" while the change is still open. The status vocabulary defines implemented as "every phase is verifiably on main". A reader of the index sees an accepted and shipped decision that does not exist yet. If this PR waits or closes, the index stays wrong.

status: implemented
...
doc-pr:
implementation-prs: []

Why it matters: the index is the record other reviewers and the First Principles lane trust for product-shape decisions. A self-set implemented row makes the record say a decision was taken when it was only proposed.

Suggestion: set status: draft here and in the README row, and describe the row as proposed. After a maintainer accepts the design, move it to accepted, then fill doc-pr and implementation-prs when the change lands. If a maintainer already agreed, name that in the prose status line.
Rule: docs/request-for-change/README.md "Status vocabulary" and "Keeping this honest"

@ash663

ash663 commented Oct 24, 2026

Copy link
Copy Markdown
Contributor Author

Closing this. A theme can already do it with no code change: an overrides.css rule on .message-bubble.user-bubble fills the user's bubble with the accent and white text. That keeps it opt-in, so the default doesn't need to change.

@ash663 ash663 closed this Oct 24, 2026
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard chat: user and assistant messages look almost the same

2 participants