Repository navigation
fix(dashboard): give the board hidden-folder notice the muted gray of its sibling reveal rows - #23875
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS No design-level concerns. The notice now uses the same token-based muted tint as its sibling reveal rows, and the old test's point that the notice must not look like the accent view toggle still holds. [DESIGN-REVIEWED] ff8209f Description read[DESCRIPTION-READ] 90dca37e44c4a9d3b913e15b60dd361eec6862e01ddf90d532a0cb2d4b70d5b4 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (2 items) — 2 justifiedIntent: make the board's hidden-folder notice read as the person's own choice, not a warning. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] ff8209f Description read[DESCRIPTION-READ] 6ddfeb1bd1dd0f53b6f258786b4e10bb4c02eb532b3e1279857f5a86f2e8cb9b That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the restyle matches the sibling reveal row's classes, and the blind reader read the gray notice as the same control, now "less alarming." Notes
[UX-REVIEWED] ff8209f Description read[DESCRIPTION-READ] 606b59dcf73469fbcb3d125d206eb1ab56eae7521501a0068df1a68ee2250550 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Bundle Size Gate is red on this head, but not from this diff: 🤖 AI-assisted comment 🤖 |
… its sibling reveal rows
8d8b0b3 to
ff8209f
Compare
cruisercohen
left a comment
There was a problem hiding this comment.
Approving ff8209f8a4. This is a visual-only fix for #14087 item 2 and is not security scope.
The board lane's hidden-folder notice moves from the warn strip to the muted, transparent style of the other lanes' reveal row. The hide is the person's own choice, so it no longer reads as a warning. The button's behaviour, test ids, aria-label and count attribute are unchanged; only the class list and a comment change. The updated test pins text-muted, checks that no warn token remains, and checks that no literal colour is used, so it still holds in every theme.
I could not run the website vitest suite locally, so this approval rests on the diff. CI's readiness passed (91 pass, 15 skipping).
|
Review-ready on head
Waiting on a maintainer's review. Not merged, not approved, no auto-merge. 🤖 AI-assisted comment 🤖 |
buluoray
left a comment
There was a problem hiding this comment.
Approving at ff8209f.
- The new classes on the board notice (
boardLane.tsx:390) match the sibling reveal row infolderBlocks.tsx:746exactly:text-muted, no border or fill,hover:text-text hover:bg-accent-subtle. Theme tokens only. - The funnel's warn tint is untouched (
SearchDock.tsx:240), so the new comment is accurate. The scope matches the item-2-only decision on #14087. - Ran
ChatSidebar.hiddenFolderBoardTrace.test.tsx: 24/24 pass.tsc -p tsconfig.app.jsonis clean. With the old warn classes put back,wears the same muted gray as the other lanes' reveal row, not a warninggoes red, so the test pins the change.
Non-blocking: the test title and the code comment carry the issue number. The reason in the comment stands without it.
Problem / Motivation
Goal: The board's "1 hidden folder" notice looks like the other lanes' hidden-folder row, not like a warning.
On the board lane, a folder the person unchecked shows a notice above the columns. It wears a yellow warning strip (
bg-warn-subtle border border-warn/40 text-warn-text). The tree, flat and conductor lanes show the same state as a plain muted gray reveal row. Item 2 of #14087.Why it matters
Hiding a folder is something the person asked for. A yellow strip on every board visit makes that choice look like a fault.
Not a goal
Showword promises vs. what the click does). That is a product call.text-warntint, so it still reads as different from the accent view toggle beside it.What changed (motivation → approach → change)
The notice in
website/src/pages/chat-sidebar/boardLane.tsxtakes the same classes as the sibling reveal row infolderBlocks.tsx:text-muted, no border, no fill, andhover:text-text hover:bg-accent-subtle. No new colour or theme variable. The eye-off icon, the count text and theShowword stay as they are. A code comment says why the notice is gray and the funnel stays warn.Backwards compatibility
Compatible: only CSS classes on one button change; its test ids, text, name and click stay the same.
Removes nothing: the notice, its text and its click handler all remain.
Tests
website/src/test/ChatSidebar.hiddenFolderBoardTrace.test.tsx: the colour test now checks the notice carriestext-mutedand nowarnclass, and no literal colour. 24/24 pass. With the old warn classes put back, that test fails (mutant checked by hand).Proof: not provable -- frontend test (prove.py runs Python only)
Local GPT and Opus review lanes were skipped: the host was low on memory. CI runs both lanes on this PR.
Manual verification
Ran
website/scripts/capture-lane-folder-hide.mjson a local vite server (127.0.0.1) at origin/main and at this head. All board-lane checks in that script passed on both. Its conductor frames fail the same way on origin/main, so that is not from this change.Screenshots / video
Board lane, one folder hidden. Before (origin/main) and after, dark and light.
Related Issues
Part of #14087
Decision note on the issue: #14087 (comment)
Sibling sweep
Swept: git grep -n "bg-warn-subtle" -- website/src/pages/chat-sidebar/
Siblings: none -- the board notice is the only hidden-folder reveal that used the warn strip; folderBlocks.tsx already uses text-muted
Pattern harvest
Not generalizable: a one-off tint choice on one notice, not a repeated code shape.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)