Skip to content

fix(dashboard): give the board hidden-folder notice the muted gray of its sibling reveal rows - #23875

Merged
iamwhatever merged 1 commit into
mainfrom
fix/14087-board-hidden-notice-muted
Oct 25, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
fix/14087-board-hidden-notice-muted

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The board's "1 hidden folder" notice looks like the other lanes' hidden-folder row, not like a warning.

On the board lane, a folder the person unchecked shows a notice above the columns. It wears a yellow warning strip (bg-warn-subtle border border-warn/40 text-warn-text). The tree, flat and conductor lanes show the same state as a plain muted gray reveal row. Item 2 of #14087.

Why it matters

Hiding a folder is something the person asked for. A yellow strip on every board visit makes that choice look like a fault.

Not a goal

What changed (motivation → approach → change)

The notice in website/src/pages/chat-sidebar/boardLane.tsx takes the same classes as the sibling reveal row in folderBlocks.tsx: text-muted, no border, no fill, and hover:text-text hover:bg-accent-subtle. No new colour or theme variable. The eye-off icon, the count text and the Show word stay as they are. A code comment says why the notice is gray and the funnel stays warn.

Backwards compatibility

Compatible: only CSS classes on one button change; its test ids, text, name and click stay the same.

Removes nothing: the notice, its text and its click handler all remain.

Tests

website/src/test/ChatSidebar.hiddenFolderBoardTrace.test.tsx: the colour test now checks the notice carries text-muted and no warn class, and no literal colour. 24/24 pass. With the old warn classes put back, that test fails (mutant checked by hand).

Proof: not provable -- frontend test (prove.py runs Python only)

Local GPT and Opus review lanes were skipped: the host was low on memory. CI runs both lanes on this PR.

Manual verification

Ran website/scripts/capture-lane-folder-hide.mjs on a local vite server (127.0.0.1) at origin/main and at this head. All board-lane checks in that script passed on both. Its conductor frames fail the same way on origin/main, so that is not from this change.

Screenshots / video

Board lane, one folder hidden. Before (origin/main) and after, dark and light.

Dark Light
Before before dark before light
After after dark after light

Related Issues

Part of #14087

Decision note on the issue: #14087 (comment)

Sibling sweep

Swept: git grep -n "bg-warn-subtle" -- website/src/pages/chat-sidebar/
Siblings: none -- the board notice is the only hidden-folder reveal that used the warn strip; folderBlocks.tsx already uses text-muted

Pattern harvest

Not generalizable: a one-off tint choice on one notice, not a repeated code shape.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 24, 2026 23:42
@iamwhatever
iamwhatever requested a review from CrysisDeu October 24, 2026 23:42
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 24, 2026
@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of ff8209f8a46eb7643b172f1c6e1e5343ca8ab35e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

No design-level concerns. The notice now uses the same token-based muted tint as its sibling reveal rows, and the old test's point that the notice must not look like the accent view toggle still holds.

[DESIGN-REVIEWED] ff8209f

Description read

[DESCRIPTION-READ] 90dca37e44c4a9d3b913e15b60dd361eec6862e01ddf90d532a0cb2d4b70d5b4

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of ff8209f8a46eb7643b172f1c6e1e5343ca8ab35e — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (2 items) — 2 justified

Intent: make the board's hidden-folder notice read as the person's own choice, not a warning. This is a FIX.

  1. The board's "N hidden folders" notice is now muted gray with no yellow fill or border, the same as the tree, flat and conductor lanes' reveal row. — justified
  2. Hovering the notice now brightens its text and shows the accent-subtle fill, not the deeper warn fill. — justified

[FIRST-PRINCIPLES-REVIEWED] ff8209f

Description read

[DESCRIPTION-READ] 6ddfeb1bd1dd0f53b6f258786b4e10bb4c02eb532b3e1279857f5a86f2e8cb9b

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of ff8209f8a46eb7643b172f1c6e1e5343ca8ab35e — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the restyle matches the sibling reveal row's classes, and the blind reader read the gray notice as the same control, now "less alarming."

Notes

[UX-REVIEWED] ff8209f

Description read

[DESCRIPTION-READ] 606b59dcf73469fbcb3d125d206eb1ab56eae7521501a0068df1a68ee2250550

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed ff8209f8a46eb7643b172f1c6e1e5343ca8ab35e — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] ff8209f

Verdict parsed from the review's SHA-scoped output markers for commit ff8209f8a46eb7643b172f1c6e1e5343ca8ab35e.

False positive or not applicable? A repository writer can comment:
/ai-review override fable ff8209f8a46eb7643b172f1c6e1e5343ca8ab35e false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of ff8209f8a46eb7643b172f1c6e1e5343ca8ab35e and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ff8209f

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ff8209f8a46eb7643b172f1c6e1e5343ca8ab35e false-positive: <reason, 20 to 500 characters>

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Bundle Size Gate is red on this head, but not from this diff: ModelEffortDropdown is 505.0 KB over its 500.0 KB budget, and this PR touches only CSS classes in boardLane.tsx and one test. The same failure is on pristine main, tracked in #23866, with the fix in #23867. This PR waits for that fix to merge, then rebases once and re-runs CI.

🤖 AI-assisted comment 🤖

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 25, 2026
@iamwhatever
iamwhatever force-pushed the fix/14087-board-hidden-notice-muted branch from 8d8b0b3 to ff8209f Compare October 25, 2026 01:22
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 25, 2026

@cruisercohen cruisercohen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ff8209f8a4. This is a visual-only fix for #14087 item 2 and is not security scope.

The board lane's hidden-folder notice moves from the warn strip to the muted, transparent style of the other lanes' reveal row. The hide is the person's own choice, so it no longer reads as a warning. The button's behaviour, test ids, aria-label and count attribute are unchanged; only the class list and a comment change. The updated test pins text-muted, checks that no warn token remains, and checks that no literal colour is used, so it still holds in every theme.

I could not run the website vitest suite locally, so this approval rests on the diff. CI's readiness passed (91 pass, 15 skipping).

@iamwhatever

Copy link
Copy Markdown
Contributor Author

Review-ready on head ff8209f8a46eb7643b172f1c6e1e5343ca8ab35e (rebased onto main c4ce1efa5d77, which carries the bundle-size fix from #23867).

  • pr_status.py: CLEAN. 106 checks, 0 failing, 0 running. Label readiness: passed.
  • Bundle Size Gate passes after the rebase.
  • GPT 6.1, Opus 5.5, Design, First Principles and UX reviews all pass on this head, with no findings to answer.
  • green_age.py: FRESH. Mergeable, single commit.

Waiting on a maintainer's review. Not merged, not approved, no auto-merge.

🤖 AI-assisted comment 🤖

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at ff8209f.

  • The new classes on the board notice (boardLane.tsx:390) match the sibling reveal row in folderBlocks.tsx:746 exactly: text-muted, no border or fill, hover:text-text hover:bg-accent-subtle. Theme tokens only.
  • The funnel's warn tint is untouched (SearchDock.tsx:240), so the new comment is accurate. The scope matches the item-2-only decision on #14087.
  • Ran ChatSidebar.hiddenFolderBoardTrace.test.tsx: 24/24 pass. tsc -p tsconfig.app.json is clean. With the old warn classes put back, wears the same muted gray as the other lanes' reveal row, not a warning goes red, so the test pins the change.

Non-blocking: the test title and the code comment carry the issue number. The reason in the comment stands without it.

@iamwhatever
iamwhatever enabled auto-merge (squash) October 25, 2026 06:35
@iamwhatever
iamwhatever merged commit 08aa735 into main Oct 25, 2026
108 checks passed
@iamwhatever
iamwhatever deleted the fix/14087-board-hidden-notice-muted branch October 25, 2026 07:10
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants