Skip to content

fix(dashboard): name the Kiro account and subscription on the credits pill - #23878

Merged
bolichen97 merged 1 commit into
mainfrom
fix/account-subscription-label-23812
Oct 25, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/account-subscription-label-23812

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Someone who wants to manage or cancel their Kiro plan can tell, from the top bar, that the credits pill leads to their account and subscription.

After sign-in, the only desktop path to the plan page (app.kiro.dev/settings/account) is the credits pill in the top bar, then the Kiro Account modal, then its link. Today the pill is named only "Kiro credit usage" and the link says "Manage account". Neither one mentions an account on the pill or a subscription anywhere, so a user who is looking for "subscription" or "cancel" never finds it.

Why it matters

Users who try to cancel or change their plan can't find where to do it. That causes frustration and support load (#23812).

Not a goal

  • A new navigation entry or menu item for the account. Where a visible "Account" entry should live is an owner design call, and it is tracked on Account/subscription management page hard to locate after sign-in #23812.
  • Changing what the modal shows or where the link points. The URL stays https://app.kiro.dev/settings/account.
  • Non-Kiro backends, which have no Kiro account or credits pill.

What changed (motivation → approach → change)

The pill and link name only credits and "account", so "subscription" appears nowhere on the path. The smallest change that keeps the design is to rename both. The pill gets its own title and aria-label, "Kiro account & credits — view usage, manage subscription". Every pill state (checking, unavailable, no reading, sign-in needed, API key, config unreadable) now starts with "Kiro account & credits — …". The modal link reads "Manage account & subscription".

Surface Before After
Pill title / aria-label (reading) Kiro credit usage Kiro account & credits — view usage, manage subscription
Pill title / aria-label (other states) Kiro credit usage — … Kiro account & credits — …
Modal link Manage account Manage account & subscription

All 12 locale catalogs in website/src/i18n/locales/ carry the same edit, and en-XA was regenerated with npm run i18n:pseudo. The modal's meter keeps its "Kiro credit usage" name because it really is the credit meter. website/src/shell/topbar/kiroUsageReadout.tsx holds the one source change, which reads the new app.kiro_account_credits key. The screenshot script website/scripts/capture-usage-refresh.mjs finds the pill by its new name.

Backwards compatibility

Compatible: copy-only. No key is removed or renamed, one key (app.kiro_account_credits) is added, and the link target is unchanged.

Removes nothing: only label text changes. Every element, route and key that exists today stays.

Tests

  • KiroAccountModal.test.tsx › "names the subscription on the link to the Kiro plan page (Account/subscription management page hard to locate after sign-in #23812)" pins the link's accessible name "Manage account & subscription" and its href.
  • App.topbarAndShortcuts.test.tsx › "renders used/limit and percentage once loaded" pins the pill's title and aria-label to the new text.
  • The existing pill-state tests in App.topbarAndShortcuts.test.tsx, App.creditPillError.test.tsx and AppRootCoverage.test.tsx now match the new titles.

Proof: not provable -- frontend test (prove.py runs Python only). Both new assertions name strings that origin/main does not render ("Kiro credit usage" / "Manage account"), so they fail there.

Manual verification

I rendered the real built SPA (website/dist) with /api/** answered from fixtures (Kiro backend, a 3,044 / 10,000 reading). I captured it on origin/main and on this branch: the pill's accessible name, then the opened modal. The rendered label and link read back from the DOM as shown below. I couldn't check the live gateway because this is an isolated harness.

Screenshots / video

Pill: a native tooltip never paints in a screenshot, so the harness prints the pill's title/aria-label under it in a yellow tag. That tag is evidence only and not part of the UI.

Before (origin/main):

before pill

After:

after pill

Kiro Account modal, before → after (the link at the bottom):

before modal

after modal

Related Issues

Part of #23812

This relabels the existing path. The issue also asks for a visibly labeled "Account" entry on the post-login screen, and the pill shows only an icon and numbers. Where that entry should live is a design call for the owner, so the issue stays open.

Sibling sweep

Swept: git grep -nE "kiroAccountModal.kiro_account|kiro_credit_usage|manage_account" -- website/src
Sibling: website/src/App.tsx:475 -- not affected -- the phone nav row is already labelled "Kiro Account"
Sibling: website/src/components/KiroAccountModal.tsx:644 -- not affected -- the credit meter progressbar, correctly named "Kiro credit usage"

Pattern harvest

Not generalizable: a one-off copy gap where an entry point was named after its readout rather than its destination.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners October 24, 2026 23:48
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 24, 2026
@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of c9146a92f679a170e3f86883b08d2944e72db5ad — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Copy-only relabel that targets the stated findability gap; no key removed, link target unchanged, rendered evidence attached.

Notes

  • Relabelling an icon-and-numbers pill helps tooltip and screen-reader users, but sighted users still can't see the word "subscription" until they open the modal. The visible "Account" entry tracked on Account/subscription management page hard to locate after sign-in #23812 is the real fix, as the PR says.
  • Existing keys kiro_credit_usage_* now hold "Kiro account & credits" text. The key names no longer describe their content, which will confuse whoever edits these strings next.

[DESIGN-REVIEWED] c9146a9

Description read

[DESCRIPTION-READ] 92a53c514b208e9ac0ed01786b3add317ebd6fc383fe0dafc797b25345a3f1af

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of c9146a92f679a170e3f86883b08d2944e72db5ad — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Relabel of an existing path; issue #23812 names the people failing to find it, and the meter keeps its own key.

What this change ships

Inventory (5 items) — 4 justified

Intent: Let a user who wants to manage or cancel their Kiro plan see that the credits pill leads there. FIX (copy-only relabel).

  1. The pill's title and aria-label now read "Kiro account & credits — view usage, manage subscription" instead of "Kiro credit usage" — justified
  2. Every other pill state now starts with "Kiro account & credits — …" — justified
  3. The modal link now reads "Manage account & subscription" — justified
  4. The pill reads its own key app.kiro_account_credits instead of the meter's key (one consumer, singular) — justified
  5. The rewritten de/fr/hi/bn state strings also switch from formal to informal address ("melden Sie sich" → "melde dich", "reconnectez-vous" → "reconnecte-toi", "करें" → "करो") — undeclared, rides along

[FIRST-PRINCIPLES-REVIEWED] c9146a9

Description read

[DESCRIPTION-READ] 1353660d9ade38a8b94ec751b7970f37e37d6a1d573f5b123e6dc1944b26fbb6

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of c9146a92f679a170e3f86883b08d2944e72db5ad — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks: the only change is to labels, and the blind reader read the main link correctly, was sure of it, and would click it.

Notes

  • The pill still shows only an icon and "3K/10K". The new name lives only in the hover tooltip and the screen-reader label, so the reader said "Nothing in the bar says 'account'" and could only guess what the pill does. The visible "Account" entry tracked in Account/subscription management page hard to locate after sign-in #23812 is what fixes this.
  • The modal now says "Plan" in one place and "subscription" in the link, and the reader asked whether they are the same thing. Use one word for both, or rename the link to "Manage account & plan".

[UX-REVIEWED] c9146a9

Description read

[DESCRIPTION-READ] 691ddff406ada21a38052c1fc8523761711e7fd449ca0fc7780098cf87a3a760

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed c9146a92f679a170e3f86883b08d2944e72db5ad — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] c9146a9

Verdict parsed from the review's SHA-scoped output markers for commit c9146a92f679a170e3f86883b08d2944e72db5ad.

False positive or not applicable? A repository writer can comment:
/ai-review override fable c9146a92f679a170e3f86883b08d2944e72db5ad false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of c9146a92f679a170e3f86883b08d2944e72db5ad and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] c9146a9

False positive or not applicable? A repository writer can comment:
/ai-review override gpt c9146a92f679a170e3f86883b08d2944e72db5ad false-positive: <reason, 20 to 500 characters>

@bolichen97
bolichen97 enabled auto-merge (squash) October 24, 2026 23:58
@bolichen97

Copy link
Copy Markdown
Contributor Author

[operator: bolichen97] Bundle Size Gate red here is main's, not this PR's: ModelEffortDropdown is byte-identical on origin/main 0dab198 and this head 94b1015 (519,856 bytes in a local build; this diff only edits label strings and moves no code between chunks). Tracked in #23866, fix in #23867. This PR will rebase once that lands; no push or override for this red.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 25, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

[operator: bolichen97] Frontend Tests (1-4) red on 94b1015 was this PR's: the [changed-values] register gates (de/fr/ru/hi/bn style tests) flagged formal address carried over from the old suffixes of values this PR rewrote. Fixed in 7205166 (informal du/tu/ты/तुम/তুমি forms, only on the keys this PR touches); I18N_BASE_REF=origin/main npx vitest run src/i18n 51/51 green locally. Bundle Size Gate remains main's (#23866 / #23867).

@bolichen97
bolichen97 force-pushed the fix/account-subscription-label-23812 branch from 94b1015 to 7205166 Compare October 25, 2026 00:52
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 25, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

[operator: bolichen97] Rebased: main moved and now carries the Bundle Size Gate fix #23867 (0dab198 -> c4ce1ef); CI re-running on c9146a9.

@bolichen97
bolichen97 force-pushed the fix/account-subscription-label-23812 branch from 7205166 to c9146a9 Compare October 25, 2026 01:44
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 25, 2026
@bolichen97
bolichen97 merged commit eee0f6a into main Oct 25, 2026
107 checks passed
@bolichen97
bolichen97 deleted the fix/account-subscription-label-23812 branch October 25, 2026 07:11
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants