Repository navigation
feat: let a person cancel an MCP elicitation from the card - #23973
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS The UI reaches a [DESIGN-REVIEWED] edfc3af Description read[DESCRIPTION-READ] 6039c320343a6cfa37aab957528c3b2d8ff40e43aad6cb30a8776981ee141add That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The new control sends an MCP answer the backend already accepts, and the card already has a way to show it. Notes
What this change shipsInventory (4 items) — 3 justifiedIntent: let a person dismiss an MCP server's question without it being read as a refusal. ADDITION.
[FIRST-PRINCIPLES-REVIEWED] edfc3af Description read[DESCRIPTION-READ] 24df6bad487b196680b8e56d6988b68381b90d36dc9bbff86205371898923fa1 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The blind reader read "Close without answering" correctly ("closes the box without saying yes or no"). They hesitated but did not refuse to click it. Notes
[UX-REVIEWED] edfc3af Description read[DESCRIPTION-READ] ed4ff28929e193354508efd78d90545f5823cae184f537ef807a6bd677cd6a75 That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
fda1cd1 to
fc6cd17
Compare
|
Backend Tests shard 4 (Linux + Windows) fails on |
fc6cd17 to
75e0458
Compare
75e0458 to
5012714
Compare
|
UX Review blocker on 75e0458, addressed in 5012714: the X's name/tooltip now says what the server hears and how that differs from Decline — "Skip: the tool hears you didn't answer, not a no" (all 12 catalogs, context sidecar updated, hover screenshot in the description replaced). Notes, not taken:
|
|
UX blockers on 5012714, addressed in 6438ff1: the X now reads "Skip without answering. Not a no: whoever asked decides what happens next." in all 12 catalogs (no 'tool', no 'hears'; it does not promise the action is or isn't taken, because that is the asking server's call). All four screenshots retaken on this build and the 'What changed' bullet now quotes the shipped string. |
5012714 to
6438ff1
Compare
|
The UX lane's read of 6438ff1 saw the cropped hover shot (the tooltip is two lines and the capture clipped the first). Shot-02 and shot-04 were retaken with the whole tooltip in frame and swapped into the description after that run started; re-running the lane so it judges the real copy. The gold outline is a 2.5 s pulse, not a hover effect; the two shots caught different phases. |
|
Owner decision (Zezhen): the X follows the convention every dialog's corner X already has — close without choosing — and its tooltip says exactly that, "Close without answering", in all 12 catalogs. It deliberately does not explain the protocol or predict what the asking server does next; no dialog's X does, and Kiro Crew cannot know. Decline is the control that says no. Screenshots retaken; the description quotes the shipped string. |
8d4faf7 to
13f3b8d
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Maintainer decision on the copy, so this stops going round: keep "Close without answering" and main's "Not answered" row. Those are fine. What the UX Review blocker is really about at 13f3b8d is that the control is icon-only. Its words live only in the aria-label and the tooltip, so a sighted reader never sees them before clicking.
Requesting one change:
- Show the label as visible text on the card, for example a small text button "Close without answering" in the action row next to Submit / Decline, or the X with that text beside it. Use the same string you already have in all 12 catalogs, so no new translation is needed.
- While you are there, place the tooltip (if you keep one) below or to the side so it does not cover "This cannot be undone."
The resolved-row wording and a distinct cancel cause stay out of scope, as you said. With a visible label and green CI I will approve.
13f3b8d to
1ba7b35
Compare
|
@bolichen97 Thanks. Addressed in 1ba7b35 (re review 5777767458):
Before/after screenshots (dark, light, hovered, and the Not answered row) are in the PR body. Rebased onto current main; still one commit. |
1ba7b35 to
f2467d5
Compare
|
@bolichen97 Follow-up in f2467d5: Opus and GPT both blocked 1ba7b35 on the blocking UX Review also asked for a wordier label ("Skip, don't decline"). I kept "Close without answering" per your decision on the copy. It did catch the hover fill making the button look like the suggested choice; the new button has no fill, and hover only lifts the text from muted to body color. |
|
Maintainer decision on the UX Review blocker at f2467d5: the copy stays "Close without answering". The real UX problem on earlier heads was that the control was icon-only, so a reader never saw its words. It is now visible text on its own line under Submit / Decline, in all 12 catalogs, and the test pins that the label is the button's own text. Further rewording ("Skip without saying no" and the like) has gone back and forth over several rounds. The card also cannot promise what the server does after a |
|
/ai-review override ux f2467d5 owner-decision: agent: maintainer decision keeps the visible label "Close without answering"; the icon-only control was the real issue and is fixed. Decision: #23973 (comment) |
Human judgment recorded@bolichen97 recorded a owner-decision release (class
This decision applies only to this commit. A new push requires a new judgment. |
|
Could you update this branch onto main? The shard 7 failures ( |
The elicitation card offered Accept and Decline only, so a person who wanted to put the server's question away without taking a position had to press Decline, which the server reads as an explicit no. The wire and the slot route already accept MCP's third answer, `cancel`; only the card withheld it. An X in the card's corner now posts `cancel` through the same route and stamps the row "Not answered". It is a corner dismiss rather than a third button beside Decline: the action row holds two actions, and a dismiss is not a sibling of yes / no. New catalog key `pages.chat.elicitationCard.dismiss` in all 12 languages plus the context sidecar; the resolved row still renders no control at all. Closes #23972
bolichen97
left a comment
There was a problem hiding this comment.
Approving at edfc3af.
This head only brings the branch onto main. The PR's own changes are identical to f2467d5: "Close without answering" is now visible text on its own line under Submit / Decline in all 12 catalogs, and the test pins that the label is the button's own text. That is the change I asked for, and it matches the maintainer decision on the wording above. Shard 7 is green now that the main regression is fixed, every lane passes after the rate-limited checks were re-run, and no regex is involved.
Problem / Motivation
Goal: A person can put an MCP server's question away without answering it, which the server reads as MCP's
cancel, not as a refusal.The elicitation card offers Accept (Submit / I've finished) and Decline only. Someone who wants to dismiss the question without taking a position has to press Decline, and the MCP server reads that as an explicit no. Every layer under the card already accepts
cancel(acp/client_elicitation.py'sELICITATION_ACTIONS,POST /api/chat/slots/{slot}/elicitation); today it is only ever sent on the person's behalf, by the approval timeout, a Stop, or the end of the turn.Why it matters
MCP gives the person three answers for a reason:
declineis "no",cancelis "I dismissed this". A server that branches on the two (retry later vs. abandon, record a refusal vs. record nothing) gets the wrong signal from every Kiro Crew user who just wanted the card out of the way, and Stop is the only other way out, which ends the whole turn.Not a goal
cancel.What changed (motivation → approach → change)
Goal: hand the person the third answer. Approach: a muted text button, "Close without answering", on its own line under the Submit / Decline row, so its words are on the card before anyone clicks it and the action row keeps two peers (the
max-two-buttons-per-rowrule) (maintainer decision on review 5777767458: the earlier corner X was icon-only and its words lived only in the aria-label and tooltip). Change:website/src/pages/chat/ElicitationCard.tsx:ElicitationActiontype (accept | decline | cancel);answer()takes it; a line under the action row renders "Close without answering" (X icon + visible label, muted text, hover only lifts it to body text) while the ask is pending and not busy, postingaction: "cancel"to the existing route and stamping the row throughresolveByApprovalId, which the existingresolved_cancel("Not answered") branch then draws. No tooltip, so nothing covers "This cannot be undone."pages.chat.elicitationCard.dismiss("Close without answering") in all 12 languages,en-XAregenerated, and a translator-context entry inen.context.jsondescribing it as a visible button label.docs/system-specs/modules/acp-client.md: the MCP elicitation section names the three answers the card offers and why the cancel's label is visible text.Backwards compatibility
Compatible: nothing is renamed, removed or rejected; a new control calls an existing route with a value it already accepts.
Removes nothing: the diff only adds a control, a catalog key and a spec paragraph.
Tests
ElicitationCard.test.tsx: new case — clicking "Close without answering" posts{request_id, request_mid, action: 'cancel'}and the store row resolves tocancel(so the dismiss can never be a decline in disguise). It also asserts the label is the button's own text content and that the button carries noaria-label, so it cannot regress to icon-only.Manual verification
Real card from the isolated capture entry
website/capture/elicitation-card.htmlon a Vite dev server bound to 127.0.0.1, shot with Playwright: the pending form card dark + light, hovered, before (head 13f3b8d) and after this change, plus the "Not answered" row. On the after head the dismiss button'sinnerTextreads "Close without answering" in both themes; on the before head it was empty.Screenshots / video
Before (13f3b8d), dark: the dismiss is an icon-only X in the corner, and its hover tip covers "This cannot be undone.":
After, dark: "Close without answering" is a visible muted text button on its own line under Submit / Decline:
After, light, hovered: no tooltip, the question text stays readable:
After clicking it the row reads "Not answered", with no control left (unchanged from main):
Related Issues
Closes #23972
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.