Repository navigation
test(windows): collect five suites whose Windows blockers are gone - #24037
KiroCrewCaptain merged 1 commit into
Conversation
test_stop_kill_cancel.py, the three test_theme_install*.py parts and test_file_office_preview.py sit in windows-collect-ignore.txt for reasons that no longer hold: the kill-path tests skip their POSIX-only cases per test (kirodotdev#6963), theme packs are served on Windows (kirodotdev#5943), and the file schema accepts a drive-letter path (kirodotdev#4647). The 338 tests in them pass on Windows, so drop the five entries and the same names from the set test_ci_surface_tests.py pins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5, fork) — ⏭️ skippedRevision |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the change only re-enables collection of five test files, the author ran them on a Windows host, and the Windows CI shards exercise them on this PR. [DESIGN-REVIEWED] fa6be0b Description read[DESCRIPTION-READ] ce52d7726e7a2ebd839cf0e4cd7582ad2cf7f24e5aa94b04fbbbf10219b3b8bc That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: test (2 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only change that removes five suites from the Windows collect-ignore list and updates the matching inventory test.
Problem / Motivation
Goal: the Windows shards run the stop/kill/cancel, theme-install and Office-preview suites, whose Windows blockers are already fixed on
main, instead of skipping all 338 of their tests at collection.test/windows-collect-ignore.txtkeeps whole files from being collected on Windows. Five entries are still there for reasons that no longer hold:test_stop_kill_cancel.py, "killpg/getuid kill-path semantics": test(mcp-gateway): scope stop and kill paths by platform #6963 scoped these tests by platform. Its two POSIX-only cases skip themselves on Windows, andTestKillPathIsPlatformCorrectexists to keep the Windows kill path on the async tree-kill helper. Its docstring says the Windows behaviour "is unreachable on this POSIX runner", and the Windows shards never collect it.test_theme_install.py,test_theme_install_declarations.py,test_theme_install_identity.py, "POSIX readable/mode gate rejects NTFS modes": fix(themes): enable theme pack routes on Windows #5943 removed the HTTP 501 that served every theme-pack route on Windows, and the tests carry Windows-aware helpers.test_file_office_preview.py, "FILE_READ_SCHEMA rejects C:\ paths (POSIX-only pattern)": fix(dashboard): accept Windows absolute paths in the file I/O schema gate #4647 made the file schema accept a drive-letter path.Named on the command line on a Windows host, which bypasses the hook, all five pass.
Why it matters
The list's own rule is that removing an entry re-enables the suite on Windows and that residual gaps go into
windows-expected-failures.txt. Leaving these entries means a Windows regression in theme install, Office preview or the gateway's kill path never shows up in CI, including the kill-path regression the stop/kill tests were written for.Not a goal
test_snapshot.pyand its two topic parts, bothtest_outbox_*.pyfiles,test_file_raw.py,test_file_download.py,test_dashboard_file_io.py,test_webapp_preview.py,test_env.pyandtest_app_backend_stale_reap.pystill fail on Windows here, need a symlink privilege this host lacks, or are being edited by another open PR (fix(dashboard): answer Range requests on /api/outbox so chat videos can seek #23601 adds tests totest_outbox_binary.py).What changed (motivation → approach → change)
test/windows-collect-ignore.txt, whichtest/conftest.py'spytest_ignore_collecthook andscripts/ci-surface-tests.pyboth read, for blockers fixed since they were listed.test/windows-collect-ignore.txt: the five entries go.test/test_ci_surface_tests.py: the same five names leave the exact settest_ignore_list_matches_the_names_conftest_previously_inlinedpins. Its docstring records why, as it already does fortest_harness.py. None of the five is in_OBSERVED_WINDOWS_FAILURES.Backwards compatibility
Compatible: test-only; no product code changes, and POSIX collection is unchanged.
Removes nothing: five suites are collected on Windows that were not; nothing is skipped or loosened.
Tests
-n auto --dist loadgroup --timeout=180 --max-worker-restart=0): 338 passed, 9 skipped on Python 3.12.13. Each file alone also passes on 3.12.13 and 3.13.5: office preview 40, theme install 139 + 104 + 28 (7 skipped), stop/kill/cancel 27 (2 skipped).test_ci_surface_tests.py,test_platform_collect_ignore.py,test_windows_fail_closed_optin.pyandtest_windows_gap_list.py, 89 passed on 3.12.13. On 3.13.5,test_windows_fail_closed_optin.py::TestFreshWindowsGatewayDelegates::test_health_then_one_session_and_one_prompt_succeedtimes out inwait_untilon this branch and identically on cleanmain.check_comment_history,check_brand_nameandtest_flake_pattern_ratchet.py(60 passed) pass.test_ci_surface_tests.py, and with the PRs that edittest/windows-expected-failures.txtleave both files clean. fix(sandbox): pin sealed paths' parent directories #22969 conflicts withmainin.github/workflows/ci.ymlon its own.Proof: not provable -- test-only change
Manual verification
N/A — test-only change; the Windows runs above are the check, and the Windows matrix collects these suites on this PR.
Related Issues
Fixes #24036
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
🤖 Generated with Claude Code