Repository navigation
Conversation
muhmuhkuh
force-pushed
the
feat/native-windows-mxc
branch
from
October 26, 2026 02:06
8a72fa0 to
d17bf80
Compare
muhmuhkuh
force-pushed
the
feat/native-windows-mxc
branch
from
October 26, 2026 12:01
d17bf80 to
34fdc5c
Compare
5 tasks done
muhmuhkuh
force-pushed
the
feat/native-windows-mxc
branch
from
November 3, 2026 08:51
0135f47 to
f45942b
Compare
muhmuhkuh
force-pushed
the
feat/native-windows-mxc
branch
2 times, most recently
from
November 4, 2026 12:17
19108a7 to
2abbd1c
Compare
muhmuhkuh
force-pushed
the
feat/native-windows-mxc
branch
from
November 4, 2026 16:09
2abbd1c to
f4c1de7
Compare
muhmuhkuh
force-pushed
the
feat/native-windows-mxc
branch
2 times, most recently
from
November 4, 2026 20:13
c2b3149 to
6b8f01b
Compare
muhmuhkuh
force-pushed
the
feat/native-windows-mxc
branch
2 times, most recently
from
November 5, 2026 04:04
a392fd4 to
fd41c79
Compare
muhmuhkuh
force-pushed
the
feat/native-windows-mxc
branch
from
November 5, 2026 08:05
fd41c79 to
0f6adcc
Compare
Finalize managed broker entries after runtime mounts, bind their claims and channels, and await MCP readiness before the first turn. Keep protected SEL material outside the native agent sandbox and admit assigned Work broker stubs.
muhmuhkuh
force-pushed
the
feat/native-windows-mxc
branch
from
November 5, 2026 12:08
0f6adcc to
4cf59e3
Compare
1 task done
1 task done
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Motivation
Goal: Allow operators on compatible native Windows hosts to run Codex ACP with Crew's OS credential masks and readable, immutable governance files.
Selecting Codex on native Windows currently refuses every session because Crew has no OS sandbox backend capable of applying the required credential mask.
Why it matters
Windows users need a working Codex harness while retaining the filesystem isolation required by Crew's enforced permission routing.
Not a goal
What changed (motivation → approach → change)
Native Codex can use Crew tools without exposing the SEL key, and routing changes can retire the processes that pin protected settings before replacing those settings.
native/windows-sandbox,sandbox_windows.py,sandbox_plan.py,sandbox_windows_policy.py,sandbox_windows_launcher.pymcp_gateway,src/kiro_crew/agent_sdk/host_auth.py,src/kiro_crew/security/paths_lists.pymcp_gateway/required.py,stub.pymcp_gateway/native_session.py,acp/runtime_session_create.py,acp/runtime_session_load.py,providers/mirrors/codex.pysrc/kiro_crew/dashboard,config,atomic_write.py,windows_settings.py,platform_compat_wintree.py,src/kiro_crew/slacksandbox.py,sandbox_argv.py,sandbox_delegation.py,sandbox_leaves.py,sandbox_seals.pyacp,scriptswebsite/src/pages,website/src/api,website/src/i18ndocs,test,website/temp-screenshotsThe pinned SDK's direct
ConnectPipeand minimal data-read/write/synchronizeCreateFileWboth return WinError 5 on the measured host. The outside helper authenticates canonical REGISTER before transferring a data handle. It derives scope MACs from the existing host key. No pipe DACL is broadened and no HTTP MCP substitute is introduced.Protected document pins retain their no-delete-sharing flags. Publication leases are task-scoped and revoked on exit; mutating workers drain before final hashes or lease release. Cross-process status claims use PID/start identity and transition-ID compare-and-set. Failed activation keeps admission closed. Explicit recovery activates current saved files without replaying an unsaved request.
Backwards compatibility
The backend remains experimental and opt-in through
KIROCREW_WINDOWS_SANDBOX_EXE; build the helper from the matching source. Unsupported guarantees refuse the launch. Linux namespace, macOS Seatbelt and explicit Kiro delegation keep their existing paths.Windows Codex defaults to
<Crew data home>/codex. ExplicitCODEX_HOMEremains authoritative. Existing desktop chats are left intact; the private profile has independent auth-file state. Other server routing and backend sharing choices remain operator-controlled.Reader: src/kiro_crew/acp/harness/codex.py:resolve_spawn_masks -- entry: chat -- still refuses an enforced spawn without its credential mask.
Reader: src/kiro_crew/sandbox_spawn.py:shielded_prepare_off_loop -- entry: cron|subagent|app -- retains one policy-artifact cleanup path; the runtime-owned channel descriptor lives in private scratch.
Reader: src/kiro_crew/sandbox_wrap.py:wrap_argv -- entry: chat|cron|subagent|app -- retains the existing non-Windows and Kiro delegation decisions.
Reader: src/kiro_crew/mcp_gateway/native_session.py:finalize -- entry: chat|cron|subagent|app -- binds the final native MCP roster after runtime mounts and requires enabled broker routes.
Tests
skill_searchandcron_listcomplete through two ACP approval requests. The agent cannot read the SEL key. Global MCP configuration is empty, so the test exercises the session array. Production key metadata/ACL and Crew settings are unchanged by the local repair.AcpRuntime.spawn()/create_session()also completes with all four catalogs and two trusted, approved tool calls in both the source tree and installed backport. Late mounts republish their claim even when the base roster was empty.10.0.26200and Codex0.164.0.66c0a876reproduced 67 failures on both trees. The one current-only launch-golden failure was fixed and its 20-case launch/profile suite passes. A scoped-runner timeout also reproduces on both trees. Missing POSIX APIs and Windows symlink privilege account for several baseline failures; remaining setup errors still need the repository CI environment.The draft does not claim the complete local gate floor or Linux/macOS CI is green. The configured Opus review model is unavailable locally, and the final revision still requires independent maintainer review. GitHub's fork workflows require maintainer approval before they can execute.
Manual verification
Real MXC and the installed Crew servers load Core, Cron, Work and Dashboard through gatewayd. The finalizer also handles the direct managed entries appended by member/panel mounts; session creation and resume are covered separately. Privileged servers retain the required-broker refusal path, current launch approval and signed per-call identity.
The provider and business API are authenticated loopback fixtures with synthetic homes and keys. The Codex fixture uses a synthetic Responses provider and does not contact a model account. The installed 0.10 backport additionally completes actual ACP tool calls with the SEL key still inaccessible to the agent. This does not claim a whole-app real-provider GUI end-to-end test. The separate
CreateDesktopWdenial from Codex shell sandbox startup is not covered by the MCP repair.Operations and rollback:
docs/guides/windows-install.md,scripts/configure_windows_codex_home.py, andscripts/recover_windows_native_routing.py.Screenshots / video
Actual rendering of the isolated component fixture, with synthetic state: saved but failed activation (desktop), and explicit interruption confirmation (390px).
Related Issues
Part of #16406
Related alternative: #7140 uses WSL2; this proposal runs natively.
Sibling sweep
Swept: git grep -nE 'fallback_exec|write_config_atomically|agent_model_state.json|stub_overrides|CODEX_HOME|_terminate_process' -- src/kiro_crew
Sibling: src/kiro_crew/mcp_gateway/stub_fallback.py -- changed here -- blocks masked-trust managed servers before resolving a direct command.
Sibling: src/kiro_crew/config/loader_document.py -- changed here -- fences supported config aliases before resolution.
Sibling: src/kiro_crew/atomic_write.py -- changed here -- fences all three protected-document publication paths, including model-state writers.
Sibling: src/kiro_crew/acp/runtime_session_setup.py -- changed here -- builds the base roster; native create/load sign only after member and panel mounts.
Sibling: src/kiro_crew/mcp_gateway/manager.py -- changed here -- keeps original owned Windows receipts through confirmed tree retirement.
Sibling: src/kiro_crew/sandbox_plan.py -- changed here -- preserves immutable ancestors and independent credential floors around private windows.
Pattern harvest
Use the existing ownership receipts and an exclusive publication lease rather than weakening immutable file pins. Keep transport failure distinct from authorization and activation state.
Checklist
Contribution License Agreement
Submitted under the repository's Apache-2.0 contribution terms.