Skip to content

fix(apps): degrade a non-list value for a manifest list field - #24453

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
IngridMorstrad:fix/apps-null-notification-channels
Oct 29, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
IngridMorstrad:fix/apps-null-notification-channels

Conversation

@IngridMorstrad

@IngridMorstrad IngridMorstrad commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: An app manifest with a null (or other non-list) value in a list field installs with that field empty instead of failing to parse.

src/kiro_crew/apps/manifest_sections.py documents its parsing as defensive: "a wrong JSON type degrades to the field's empty value". ui.overlays follows that rule. Fourteen other list fields iterate data.get(key, []) directly: in manifest_sections.py, ui.pages, dependencies.capabilities mcp/skills/agents, platform os/arch, publishProvider.kinds and notifications.channels; in manifest.py, the top-level crons, agents, skills, sops, tags and jobFamilies. A key that is present with a non-list value is returned by get instead of the default. A hand-edited null or a number then raises TypeError out of AppManifest.from_dict, and a string is split into one-character entries.

Why it matters

AppManifest.from_dict runs on the registry-install admission pass and on POST /api/apps/register, and neither catches a TypeError. One stray null in an optional field (e.g. "crons": null) therefore fails the whole install or registration with a traceback, when that one field should simply be ignored. The string case silently produces nonsense values instead, e.g. "arch": "arm64" becomes five one-letter architectures.

Not a goal

  • Changing what a well-formed list parses to, or adding validation errors for a wrong type.

What changed (motivation → approach → change)

  • Symptom: a non-list value for any of the fourteen fields raises TypeError out of AppManifest.from_dict (null, number, bool) or is split into characters (string).
  • Root cause: dict.get(key, []) returns the stored value when the key exists, so the [] default never applies to a present null.
  • Change: each of the fourteen reads iterates the value only when it is a list, the same isinstance shape UIConfig.from_dict already uses for overlays. Every non-list degrades to [], except platform.os, which restricts where an app runs and so must never widen:
    • "os": null reads as unset and keeps the absent-key default ["macos", "linux"].
    • Any other non-list ("os": "windows", a number) fails closed. It parses to an empty os, which PlatformConfig.supports_platform matches against no host, and the value is recorded on PlatformConfig.os_type_invalid so validate() refuses it as platform.os: unknown value .... The enable path's client-app check (routes_enable._client_install_manifest → supports_platform) never calls validate(), so an empty list is what keeps it from running an onEnable script where the author restricted the app. On main, the character split made that check fail as well. The marker field is compare=False and never serialized, the same shape as CronEntry.type_invalid_fields.
  • publishProvider.kinds restricts too. An empty list means every kind (PublishHub.tsx: if (p.kinds.length && !p.kinds.includes(kind)) continue), so a wrong type must not degrade to it. "kinds": null reads as unset. Any other non-list is recorded on PublishProviderConfig.kinds_type_invalid, and to_dict() then serializes the provider to nothing. collect_publish_providers reads the serialized manifest, so the artifact page offers that provider for no kind. The parse has to fail closed itself because a self-managed app's app.json never passes install validation. Adding a validate() refusal for it is out of scope (see Not a goal).
  • manifest.py AppManifest.from_dict: crons, agents, skills, sops, tags and jobFamilies get the same guard, inline at each site. A non-list reads exactly as the key being absent: no crons, agents, skills or SOPs are registered and no tags or job families are listed. None of these widens anything, since an empty value already means "declares nothing" (discovery.py and to_dict() omit them). The installed-app view (get_app → to_dict()) and the uninstall preview read the parsed manifest, so they no longer see the raw null either. Open PR feat(apps): list a third-party app's agentTools on an opt-in prompted kirocrew-apps server #17015 also edits AppManifest.from_dict (it adds fields); these hunks change existing lines only.
  • registry_pipeline/install.py install_from_registry: the client-install platform gate read os from the raw registry JSON, so "os": null or a number reached PlatformConfig(os=...).supports_platform and the OS label as a non-iterable, and the endpoint answered HTTP 500. It now reads the parsed admission_manifest.platform.os, so null gives the default and any other non-list supports no platform, the same as the enable path. feat(governance): let a policy govern extension install, app versions and app dev mode #24373 (now merged) edited a different hunk of this function, the admission call just above it; this hunk is the platform gate below it, and the rebase onto it was clean.

The guard is inlined at each site rather than shared through a new helper. test/test_manifest_facade.py requires every name an owner module defines to be re-exported through kiro_crew.apps.manifest, and this PR does not touch that file.

Backwards compatibility

Compatible: every list value parses exactly as before. Only a non-list value changes. It used to raise TypeError (null, number, bool) or yield single-character or dict-key entries (string, object). Now it yields the field's absent-key value. A non-null non-list platform.os still supports no platform and is still refused by validate(), as on main; it just no longer raises first. A non-null non-list publishProvider.kinds makes that provider unavailable; on main a string happened to match no kind (split into characters) and a number failed the whole parse, so neither ever offered it everywhere.

Removes nothing: no field, key, validator or function is removed or renamed; the change only stops non-list input from raising or being split.

Tests

In test/test_app_manifest.py:

  • test_non_list_value_for_a_list_field_degrades runs each of the 13 degrade-to-empty fields (the seven in manifest_sections.py and the six top-level ones in manifest.py) with None, 7, True, "abc" and {"id": "x"}, 65 cases. It asserts that the parse does not raise and that the field is [].
  • test_a_non_list_platform_os_fails_closed_and_is_refused (7, True, "windows", {"id": "x"}) asserts three things: os == []; no platform is supported, before and after a to_dict round trip (the path enable reads); and validate() reports platform.os: unknown value.
  • test_a_null_platform_os_reads_as_unset asserts that "os": null gives the default and validates clean.
  • test_a_non_list_publish_provider_kinds_offers_the_provider_for_no_kind (7, True, "html", {"id": "x"}) asserts the parse does not raise and collect_publish_providers over the serialized manifest offers nothing.

In test/test_apps_registry_coverage_install.py (placed away from #24373's hunks in that file, with a signature-tolerant admission stub):

  • test_a_non_list_platform_os_reaches_the_client_install_answer (None, 7, True, "windows", {"id": "x"} on a host no default names) asserts the client-install answer comes back with required = the default for None and [] otherwise.

Red with the fix reverted on main (8ae4e4f): 36 failed, 4 passed of 40. Every field fails for None/7/True with TypeError ... is not iterable. mcp/skills/agents/arch/kinds and os also fail for a string or object (assert ['a', 'b', 'c'] == []). The 4 passes are pages/channels with a string or object, which their isinstance(dict) element filter already drops. Green with the fix: 40 passed. test_app_manifest_platform_vocabulary.py passes too.

The six manifest.py fields run red on main (c575687) first: 28 failed, 2 passed of 30. Every field fails for None/7/True with TypeError ... is not iterable, and agents/skills/sops/tags/jobFamilies also fail for a string or object (assert ['a', 'b', 'c'] == [], assert ['id'] == []). The 2 passes are crons with a string or object, which its isinstance(dict) element filter already drops. Green with the fix: 30 passed.

The kinds and install tests run red on cb0689f first: the kinds test 4 failed of 4 (assert [{'app': 'test-app', ... }] == [], the provider offered for every kind); the install test 5 failed of 5 (None/7/True: TypeError ... is not iterable; "windows"/{"id": "x"}: the raw value came back as required). Green with the fix: 9 passed.

prove.py --per-hunk catches every production hunk.

Proof: PROVEN test/test_app_manifest.py::test_non_list_value_for_a_list_field_degrades[crons-None], test/test_app_manifest.py::test_non_list_value_for_a_list_field_degrades[crons-7], test/test_app_manifest.py::test_non_list_value_for_a_list_field_degrades[crons-True], test/test_app_manifest.py::test_non_list_value_for_a_list_field_degrades[agents-None], test/test_app_manifest.py::test_non_list_value_for_a_list_field_degrades[agents-7] (head e9c5833)

Local checks on e9c5833 (rebased on 3fccc01): prove.py --per-hunk catches every production hunk. test/test_app_manifest.py, test/test_manifest_facade.py, test/test_publish_providers.py, test/test_apps_registry_coverage_install.py and the other app-manifest/registry tests give 1,543 passed. Every test file that imports kiro_crew.apps.manifest or names AppManifest (73 files) gives 3,577 passed and 1 failed; that one, test_app_agent_launch_copy.py::...[opted-out], fails the same way on main on this box and passes with a clean $HOME (it reads the host's own ~/.kiro). mypy on the production files is clean, and black, isort and flake8 pass.

Manual verification

N/A: this is a pure parsing function, and the parametrized unit test exercises every field and value shape directly.

Related Issues

Closes #24452

Sibling sweep

Swept: git grep -nE 'data.get("[A-Za-z]+", [' -- src/kiro_crew/apps/manifest*.py
Sibling: src/kiro_crew/apps/manifest_sections.py -- changed here
Sibling: src/kiro_crew/apps/registry_pipeline/install.py:526-545 -- changed here
Sibling: src/kiro_crew/apps/routes_listing.py:212 -- not affected -- collect_publish_providers reads the serialized manifest, which no longer carries a non-list kinds
Swept: src/kiro_crew/apps/manifest_contributes.py already guards every list read (commands, sessionControls, panelTabs, fileMenuItems, hosts, keywords, extensions, kinds, surfaces) with isinstance(list).
Sibling: src/kiro_crew/apps/manifest.py -- changed here
Sibling: src/kiro_crew/apps/routes_uninstall.py:156-158 -- not affected -- reads get_app's manifest, which is the parsed and re-serialized manifest
Sibling: src/kiro_crew/apps/execution.py:333 -- not affected -- already checks isinstance(agents, list)

Pattern harvest

Rule candidate: semgrep
Pattern: iterating d.get(key, []) (or passing it to list()) without an isinstance(..., list) check, when d is parsed JSON that can hold a present null.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running labels Oct 26, 2026
@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision e9c5833b86f39b89f817a4d73d8791252cf991e3 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of e9c5833b86f39b89f817a4d73d8791252cf991e3 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the guard sits in the parser that owns these fields, and the two restricting fields (platform.os, publishProvider.kinds) fail closed instead of widening.

Notes

  • publishProvider.kinds with a wrong type quietly drops the provider: to_dict() returns {} and no validate() error explains why. Today that is less visible than the platform.os refusal; a matching validation message would be a small follow-up.

[DESIGN-REVIEWED] e9c5833

Description read

[DESCRIPTION-READ] f05513aaf8e4b1e88a5cb381b941dabb8fc6c19be17e8d4916fdb6bf6ddedc74

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of e9c5833b86f39b89f817a4d73d8791252cf991e3 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. This is a fix at the mechanism level: the grep below finds no data.get(key, []) list read left unguarded in manifest*.py. The two fail-closed fields each have a named cause and one real consumer.

What this change ships

Inventory (7 items) — 7 justified

Intent: make an app manifest with a null or other non-list value in a list field install with that field empty, instead of failing the whole install with a TypeError. FIX.

  1. A non-list value in any of the 13 degrade-to-empty list fields now parses as empty, where it used to raise or be split into characters. — justified
  2. "platform.os": null now gives the default ["macos", "linux"]. — justified
  3. Any other non-list platform.os now matches no platform, and validate() refuses it as platform.os: unknown value. — justified
  4. A non-list publishProvider.kinds now makes that provider available for no kind, where an empty list would have meant every kind. — justified
  5. "kinds": null now reads as unset. — justified
  6. The registry client-install platform gate now reads the parsed os instead of the raw JSON, so null or a number no longer returns HTTP 500. — justified
  7. New internal marker fields os_type_invalid and kinds_type_invalid, never serialized; each has one reader (validate() and to_dict()). — justified

Unfixed siblings: grepped in data\.get\("\w+", \[\]\) and list\(data\.get\(...\[\]\)\) over manifest*.py. Base has 11 hits; together with crons and notifications.channels (stored first, then iterated) that is all 13 degrade-to-empty fields. The diff guards all of them, so 0 are left. The only similar helper, _list_or_empty (manifest_sections.py:149), is nested inside CronEntry.from_dict and can't be reused here.

[FIRST-PRINCIPLES-REVIEWED] e9c5833

Description read

[DESCRIPTION-READ] 18e1d5479950bd3dbf90e4d53929832ff9fdde33efb5cb298628de49b630731b

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed e9c5833b86f39b89f817a4d73d8791252cf991e3 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] e9c5833

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed e9c5833b86f39b89f817a4d73d8791252cf991e3 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] e9c5833

@IngridMorstrad

Copy link
Copy Markdown
Contributor Author

Replies to the two non-blocking notes on 08ebf6d:

  • Design Review (string widens a restricting field): deferred. The module contract in manifest_sections.py is "a wrong JSON type degrades to the field's empty value", and ui.overlays already degrades this way. Refusing a wrong type in validate() would be a new, stricter validator, which is a separate decision and outside this PR's Goal. platform.os is the field where widening would change meaning the most, so it keeps its absent-key default rather than going empty.
  • First Principles (manifest.py siblings untracked): the six manifest.py sites (crons :975; agents/skills/sops/tags/jobFamilies :1041-1062) are listed under Sibling sweep. They were left out on purpose because other open PRs are already editing that file, and no separate issue was filed for them on purpose. Whoever next touches that file can pick them up from this list.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 26, 2026
@IngridMorstrad
IngridMorstrad force-pushed the fix/apps-null-notification-channels branch from 08ebf6d to 589ccc5 Compare October 26, 2026 12:12
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 26, 2026
@IngridMorstrad

Copy link
Copy Markdown
Contributor Author

Pushed 589ccc5 (still one commit, rebased on main 66c0a87). CI shard 5 on 08ebf6d failed test_app_manifest_platform_vocabulary.py::TestOsNames::test_a_bare_string_is_not_read_as_the_name_it_spells: my first cut widened a bare-string platform.os to the default, which is the change in meaning the Design Review note warned about. Now "os": null reads as unset, and any other non-list keeps the default for parsing but is refused by validate() as platform.os: unknown value .... That closes the Design Review note for os, the one restricting field that note named where widening changes meaning. New tests cover both cases, the description is updated, and prove.py on the new head is PROVEN.

@IngridMorstrad

Copy link
Copy Markdown
Contributor Author

Fixed in 1cc5587, which addresses the blocking finding on 589ccc5 from both GPT 6.1 and Opus 5.5 ("invalid OS values silently widen support on enable"). A non-null, non-list platform.os now parses to an empty os, so supports_platform matches no host and the enable path skips onEnable as unsupported_platform, the same outcome as on main. os_type_invalid is kept so validate() still refuses it. null still reads as unset (default macOS + Linux). test_a_non_list_platform_os_fails_closed_and_is_refused asserts no platform is supported both directly and after a to_dict round trip (the path handle_enable_app reads). The description is updated, and prove.py on the new head is PROVEN.

@IngridMorstrad
IngridMorstrad force-pushed the fix/apps-null-notification-channels branch from 589ccc5 to 1cc5587 Compare October 26, 2026 12:55
@IngridMorstrad

Copy link
Copy Markdown
Contributor Author

CI on 1cc5587: the two failing shards are outside this diff (which touches only apps/manifest_sections.py and test/test_app_manifest.py).

All four AI reviews on this head are PASS with no blocking findings. The one remaining Design Review note (track the manifest.py siblings with an issue) is the point answered above: they are listed under Sibling sweep and deliberately not filed.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 26, 2026
@IngridMorstrad
IngridMorstrad force-pushed the fix/apps-null-notification-channels branch from 1cc5587 to cb0689f Compare October 26, 2026 15:11
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 26, 2026
@IngridMorstrad
IngridMorstrad force-pushed the fix/apps-null-notification-channels branch from cb0689f to ab77391 Compare October 26, 2026 16:38
@IngridMorstrad

Copy link
Copy Markdown
Contributor Author

Both blocking findings on cb0689f are addressed in ab77391 (still one commit):

  • Opus 5.5, manifest_sections.py:987, non-list publishProvider.kinds widens to every kind: fixed. A non-null non-list kinds is recorded on PublishProviderConfig.kinds_type_invalid, and to_dict() then serializes the provider to nothing, so collect_publish_providers (which reads the serialized manifest) offers it for no kind instead of all. "kinds": null still reads as unset. The validate() refusal you suggested belongs in AppManifest.validate in manifest.py, which this PR leaves alone, but the read path now fails closed by itself. New test: test_a_non_list_publish_provider_kinds_offers_the_provider_for_no_kind, which fails 4 of 4 on cb0689f and passes on ab77391.
  • GPT 6.1, registry install still crashes on a null OS list: fixed. install_from_registry now takes os from the parsed admission_manifest.platform instead of the raw JSON, so null gives the default and any other non-list supports no platform. That means supports_platform and the OS label never iterate a non-list, and the endpoint answers with the client-install response instead of HTTP 500. New test: test_a_non_list_platform_os_reaches_the_client_install_answer, which fails 5 of 5 on cb0689f (TypeError for null, int and bool; the raw value passed through as required for a string or object) and passes on ab77391. Open PR feat(governance): let a policy govern extension install, app versions and app dev mode #24373 edits a different hunk of the same function (the admission call around L505-519). This one is L526-545, and the new test's admission stub accepts any signature, so it doesn't depend on feat(governance): let a policy govern extension install, app versions and app dev mode #24373's check_version= change.

prove.py --per-hunk reports PROVEN on ab77391, and the PR body's Tests, Proof and Sibling sweep sections are updated.

@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Oct 26, 2026
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 26, 2026
@IngridMorstrad

Copy link
Copy Markdown
Contributor Author

CI on 27b5d72: every AI review is PASS or has no blocking findings (Design, First Principles, GPT 6.1, Opus 5.5). This diff touches only apps/manifest_sections.py, apps/registry_pipeline/install.py and their two test files. The four failing checks are all outside it:

Once #24530 merges, I'll rebase once, which also picks up #24531.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 26, 2026
@IngridMorstrad
IngridMorstrad force-pushed the fix/apps-null-notification-channels branch from 27b5d72 to 7381cbd Compare October 27, 2026 22:23
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 27, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for a missing follow-up issue; the code itself looks sound.

The fix guards all eight list reads in manifest_sections.py. platform.os and publishProvider.kinds fail closed instead of widening, and the registry client-install gate now reads the parsed os. Tests cover every field and value shape. CI is green and every AI lane is PASS or has no blocking findings.

Blocker: the same present-non-list hazard is still in manifest.py for crons, agents, skills, sops, tags and jobFamilies (manifest.py#L975, #L1041-L1062). The PR defers it under Not a goal, and Design Review on this head asks for an issue, but none was filed. A stray null in crons still fails install with a TypeError. Please open one issue covering those six sites and link it in the PR description. Folding the same isinstance(..., list) guard into manifest.py here also clears this.

Reviewed head: 7381cbd423061c0861c86279f9ae6dc4a2948d64.

— crew-pr-reviewer (r131)

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 28, 2026
Fourteen list fields in the app manifest iterated data.get(key, [])
directly: the top-level crons, agents, skills, sops, tags and
jobFamilies, and in the typed blocks ui.pages,
dependencies.capabilities mcp/skills/agents, platform os/arch,
publishProvider.kinds and notifications.channels. When the key is
present with a non-list value, get returns that value instead of the
default. A hand-edited null or number raised TypeError out of
AppManifest.from_dict, so the manifest failed to parse instead of
degrading, and a string was split into single-character entries. The
module's contract is that a wrong JSON type degrades to the field's
empty value; ui.overlays already guards exactly this.

Iterate each of those fields only when it is a list, the overlays
shape. Every non-list reads as the field being absent. Two fields
restrict rather than add, so a wrong type must not widen them:

- platform.os restricts where an app runs. A null reads as unset and
  keeps the default of macos and linux. Any other non-list parses to an
  empty os, which supports no platform, so a reader that never calls
  validate() (the enable path's supports_platform check) fails closed.
  The value is also recorded and refused by validate().
- publishProvider.kinds restricts which artifacts a provider publishes,
  and an empty list means every kind. A null reads as unset. Any other
  non-list makes the provider serialize to nothing, so the artifact
  page never offers it.

The registry install's platform gate read os from the raw manifest JSON,
so the same null or number reached supports_platform and the OS label
and the endpoint answered HTTP 500. It now reads the parsed os.
Well-formed lists parse as before.
@IngridMorstrad
IngridMorstrad force-pushed the fix/apps-null-notification-channels branch from 7381cbd to e9c5833 Compare October 28, 2026 17:11
@IngridMorstrad

Copy link
Copy Markdown
Contributor Author

@iamwhatever The six manifest.py sites (crons, agents, skills, sops, tags, jobFamilies) are now guarded in this PR, with failing-first tests for each, on e9c5833.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Security Scope Review (fork) — 🔴 BLOCK (blocking)

Which legitimate operations does e9c5833b86f39b89f817a4d73d8791252cf991e3 newly refuse? Model proposes, scripts/deny_diff.py decides — updated in place on each push. A script-confirmed regression blocks PR readiness.

the review scope was never resolved: the generate job did not finish (it timed out, failed or was cancelled), so no leg ran; its log names the step that stopped

No [SCOPE-REVIEWED] marker for this head was produced, so the model's text is withheld: it cannot be shown to describe this revision. See the job logs.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Oct 28, 2026
@IngridMorstrad

Copy link
Copy Markdown
Contributor Author

Design Review note on e9c5833 (a non-list publishProvider.kinds drops the provider with no validate() message): leaving that out of this PR, which is about not crashing or widening on a wrong type; a validate() refusal for kinds is listed under Not a goal and fits a small follow-up.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 28, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve at e9c5833.

My previous request is cleared: the six top-level list reads in manifest.py (crons, agents, skills, sops, tags, jobFamilies) now carry the same isinstance(..., list) guard, with tests (manifest.py#L975-L981, #L1046-L1080). The two restricting fields fail closed: a non-list platform.os supports no platform and validate() refuses it, and a non-list publishProvider.kinds offers the provider for no kind (manifest_sections.py#L943-L964). The client-install gate reads the parsed os, so it no longer returns a 500 (install.py#L559-L565).

AI findings judged non-blocking:

  • Design Review note, a non-list kinds drops the provider without a validate() message: on main a string already matched no kind silently and a number crashed the parse, so this adds no new harm, and wrong-type validation is an explicit Not a goal (manifest_sections.py#L1019-L1034).
  • Security Scope Review comment showing BLOCK: it came from a run that never finished; the newer Security Scope Review check on this head concluded success with no security-surface path touched.

The GPT and Opus lanes have no findings, and every check on this head is green.

— crew-pr-reviewer (r134)

@iamwhatever
iamwhatever enabled auto-merge (squash) October 29, 2026 06:55
@iamwhatever
iamwhatever merged commit 818e0b5 into kirodotdev:main Oct 29, 2026
145 of 147 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(apps): a null in a manifest list field (pages, platform.os, notifications.channels, ...) fails the parse

2 participants