Skip to content

test(slack): give weak tests real outcome checks - #24495

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
test-cleanup/weak-slack
Oct 26, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
test-cleanup/weak-slack

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Make 19 weak Slack tests check a real outcome, so a broken Slack ack, audit, log or reply path fails a test instead of passing it.

These tests in test/test_slack*.py either checked nothing or checked only that a mock was called. One of them, test_empty_allowed_users_rejects_all, clicked a message ts that nothing was waiting on, so it passed whether the gate refused the click or not.

Why it matters

A test that only checks "the mock was called" stays green when the code skips the log line, audit record, return value or reply that the test name promises. The Slack layer owns the interactive approval gate, the socket-mode ack and governance denials, where those slips go unnoticed.

Not a goal

  • No product code change. Source files were edited only for the temporary planted bugs below, and reverted.
  • No test removed, renamed or merged: the collected test-id count is unchanged.
  • Rewriting a mock check into another form of mock check. m.assert_called_once_with(x) and assert m.call_args_list == [call(x)] check the same thing, so this PR leaves such tests as main has them.
  • The weak tests outside test/test_slack*.py.

What changed (motivation → approach → change)

An earlier revision of this branch reported 121 fixed tests, but 102 of them only swapped a mock check for another form of mock check (assert_called_once_with to call_args_list == [call(...)], assert_not_called to call_count == 0). Those tests are back to their exact main form. The branch now changes 19 tests, each gaining a check on an outcome the code produces:

Check Tests
Socket-mode ack carries the request's own envelope id test_slack_events_coverage.py: test_unknown_envelope_type_ignored, test_home_tab_other_tab_ignored, test_non_message_event_ignored, test_unhandled_subtype_ignored, test_trusted_bot_other_subtype_still_dropped
Log line, filtered by logger name test_persist_turn_row_swallows_failure (also checks the return value), test_a_stop_signalled_during_the_restart_is_not_swallowed, test_update_failure_is_swallowed, test_slack_none_logs_warning, test_post_failure_skips_ack, test_governance_deny_blocks_transcript_publication, test_session_closing_does_not_spool_restricted_slack_turn
Audit record test_empty_allowed_users_rejects_all (rebuilt, see below), test_dm_mode_opens_dm_and_links (also checks the DM header text)
Return value test_reject_orphaned_tool_swallows_failure: a failed reject reports False
State left behind test_second_call_is_a_no_op: the thread is marked hydrated
Text the user sees test_title_updates_conversation_log: the Slack thread title is set; test_handler_stop_reason_cancelled_skips_consolidation: the partial text still reaches the thread; test_cron_ack_calls_service: the button shows "✅ Acknowledged"

The envelope-id check reads the response the client sent through a small helper, _acked_envelopes. The id is the content of the ack Slack receives, so a dropped or blank id fails. The cron-ack text check reads the update_message call's text, and the scan below still counts that test as weak.

test_empty_allowed_users_rejects_all now runs three clicks with the owner pinned through monkeypatch: no owner set, a non-owner click on a pending approval, and an owner click on a ts with no pending entry. The pending entry survives all three, and each click is audited denied.

Files touched: 11 test files under test/. .github/black-baseline.txt is unchanged: no baselined file was reformatted.

Backwards compatibility

Compatible: test-only change.

Removes nothing: no test, fixture or product code is removed.

Tests

Proof: not provable -- test-only change

  • Weak-test scan (goal_scan.py weak), whole repo, on this branch's base 20c46e9 and on this branch:
    • strict rule (default; an assert on a mock's call record counts as weak): 2,313 on base, 2,295 here, a cut of 18.
    • --loose (an assert on a mock's call record counts as a check): 1,665 on base, 1,646 here, a cut of 19. The one-test gap is test_cron_ack_calls_service.
  • Planted bugs: 13 caught out of 13 tried. Each was a one-line source edit, reverted with git checkout: a blank socket ack envelope id; the home-tab warning text; the usage-row debug text; the shutdown restart-skip log text; the closing-dispatch log text; the "✅ Acknowledged" update text; the new-session failure text; the resume audit set to denied; the governance-drop log text; the approval gate audit set to allowed; _reject_orphaned_tool returning True on failure; the _safe_update failure log removed; the !title thread title cut to 3 characters.
  • Coverage, --cov=kiro_crew on the 11 touched files, union of two runs per side: base 139,919 lines, head 139,920, none lost. Two head runs differ from each other by 2 lines (config/loader_snapshots.py 1087 and 1158, a timing branch these tests do not drive).
  • Collected ids on the 11 files: 729 on base and head.
  • Every touched file passed 3 times at -n 4.
  • test_flake_pattern_ratchet.py and test_wait_discipline_ratchet.py: 113 passed. black (non-baselined touched files), isort, flake8, check_file_line_cap.py, check_comment_history.py: clean.

Determinism: no new sleep, clock or port. caplog reads filter on the logger name. The owner id is set through monkeypatch, not set_owner_id.

Left as main has them (102): the earlier revision only rewrote a mock check in each test below into another form. They are back to their main form and still count as weak. Most drive code that returns None and whose only effect is a call on a mocked collaborator, so an outcome check needs a fake in place of the mock; that is left for a later pass. test_no_module_converts_slack_markdown_directly is in the list too: it already fails through raise AssertionError, so the assert rewrite changed nothing.

Tests left as main has them
  • test_slack_cron_remove_audit.py::TestGatewayDoneRemovalAudit::test_already_removed_job_is_not_audited
  • test_slack_cron_remove_audit.py::TestGatewayDoneRemovalAudit::test_busy_store_defers_without_gateway_audit
  • test_slack_cron_remove_audit.py::TestGatewayDoneRemovalAudit::test_unreadable_store_defers_without_gateway_audit
  • test_slack_cron_remove_audit.py::TestSlackRemoveAllAudit::test_remove_all_nothing_deleted_audits_failed
  • test_slack_cron_remove_audit.py::TestSlackSingleRemoveAudit::test_caller_falls_back_to_surface_when_no_user
  • test_slack_events_coverage.py::TestInitSocketMode::test_dangerously_skip_permissions_enables_yolo
  • test_slack_events_coverage.py::TestOnEventDispatch::test_interactive_is_dispatched
  • test_slack_events_coverage.py::TestOnEventDispatch::test_member_joined_channel_routed_to_prompt
  • test_slack_events_coverage.py::TestOnEventDispatch::test_message_deleted_is_delegated
  • test_slack_events_coverage.py::TestOnEventDispatch::test_slash_command_is_dispatched
  • test_slack_events_coverage.py::TestOnEventDispatch::test_update_pause_refuses_before_interaction_ack
  • test_slack_events_coverage_route_flow.py::TestRouteMessageEnterpriseAndObserve::test_observe_skips_history_for_unauthorized_sender
  • test_slack_events_coverage_route_flow.py::TestRouteMessageQueueing::test_busy_session_enqueues_and_reacts
  • test_slack_events_coverage_route_flow.py::TestRouteMessageStopCommand::test_idle_stop_dismisses_stale_ephemeral
  • test_slack_events_coverage_route_guards.py::TestRouteMessageGuards::test_pure_stop_is_exempt_from_governance_denial
  • test_slack_events_coverage_route_guards.py::TestRouteMessageGuards::test_stop_is_recorded_against_the_threads_owning_session
  • test_slack_events_coverage_route_guards.py::TestRouteMessageGuards::test_stop_is_recorded_before_the_liveness_checks
  • test_slack_gateway.py::TestDeliverResult::test_dashboard_new_slot
  • test_slack_gateway.py::TestDeliverResult::test_dashboard_specific_slot
  • test_slack_gateway.py::TestDeliverResult::test_dashboard_target_slot_not_found
  • test_slack_gateway.py::TestShutdown::test_shutdown_awaits_autonudge_drain
  • test_slack_gateway.py::TestShutdown::test_shutdown_stops_cron
  • test_slack_gateway_channels.py::TestChannelTransportStartGate::test_no_policy_starts_every_transport_as_today
  • test_slack_gateway_channels.py::TestUnreadyChannelBadge::test_no_dashboard_state_is_tolerated
  • test_slack_gateway_coverage_notifications.py::TestTaskNotify::test_denied_title_also_dms_the_owner
  • test_slack_gateway_coverage_nudge_routing.py::TestAutonudgeRouterAndObserver::test_observer_does_not_repeat_a_gated_legacy_terminal_notification
  • test_slack_gateway_coverage_nudge_routing.py::TestAutonudgeRouterAndObserver::test_observer_expired_event_also_notifies
  • test_slack_gateway_coverage_nudge_routing.py::TestAutonudgeRouterAndObserver::test_observer_marks_delivery_only_after_notification_persistence
  • test_slack_gateway_coverage_nudge_routing.py::TestAutonudgeRouterAndObserver::test_observer_notifies_one_structured_terminal_transition
  • test_slack_gateway_coverage_nudge_routing.py::TestAutonudgeRouterAndObserver::test_observer_without_loop_broadcasts_nothing
  • test_slack_gateway_coverage_nudge_routing.py::TestAutonudgeRouterAndObserver::test_restart_deduplicates_terminal_notice_with_delivery_record
  • test_slack_gateway_coverage_nudge_routing.py::TestAutonudgeRouterAndObserver::test_terminal_transition_during_start_is_not_lost
  • test_slack_gateway_cron_exec_coverage_delivery.py::TestTaskNotifyChannelRouting::test_channel_wins_over_the_owner_dm
  • test_slack_gateway_cron_exec_coverage_delivery.py::TestTaskNotifyChannelRouting::test_no_session_key_never_touches_the_channel_ladder
  • test_slack_gateway_cron_exec_coverage_message_arm.py::TestCronMessageDenialAndWiring::test_reaper_not_started_without_sessions
  • test_slack_gateway_memory_boot.py::TestAutoMigrateMemory::test_model_absent_awaits_download_then_sweeps
  • test_slack_gateway_memory_boot.py::TestAutoMigrateMemory::test_skips_migrate_when_already_migrated
  • test_slack_gateway_memory_boot.py::TestAutoMigrateMemory::test_sweep_deferred_when_model_not_ready
  • test_slack_gateway_more_coverage.py::TestAutoMigrateMemory::test_set_memory_migrated_delegates_to_handler
  • test_slack_gateway_more_coverage.py::TestDeliverResultRouting::test_dashboard_arm_without_dashboard_state
  • test_slack_gateway_more_coverage.py::TestDeliverResultRouting::test_default_arm_notifies_even_when_dm_unavailable
  • test_slack_gateway_more_coverage.py::TestDeliverResultRouting::test_slack_only_arm_survives_dm_failure
  • test_slack_gateway_more_coverage.py::TestPersistSlotTitle::test_missing_conversation_log_skips_write
  • test_slack_gateway_more_coverage.py::TestShutdownExtras::test_slot_save_failure_does_not_abort_shutdown
  • test_slack_gateway_more_coverage.py::TestWarnIfKiroCliOutdated::test_transport_error_falls_back_to_plain_kill
  • test_slack_gateway_run.py::TestBgSessionDashboardBranch::test_bg_session_prints_dashboard_url
  • test_slack_gateway_run.py::TestBgSessionDashboardBranch::test_failing_url_announcement_does_not_abort_boot
  • test_slack_gateway_run.py::TestRunMethod::test_run_raises_on_shutdown
  • test_slack_gateway_run.py::TestRunSignalAndBgSession::test_run_with_ollama_config
  • test_slack_gateway_subagent_delivery.py::TestInjectWithRetry::test_acp_process_died_during_injection
  • test_slack_gateway_subagent_delivery.py::TestInjectWithRetry::test_prompt_busy_exhausted
  • test_slack_gateway_subagent_delivery.py::TestSubagentChannelTransportDelivery::test_mirror_link_delivers_into_forum_topic
  • test_slack_gateway_subagent_delivery.py::TestSubagentChannelTransportDelivery::test_origin_link_wins_over_stored_channel
  • test_slack_gateway_subagent_delivery.py::TestSubagentChannelTransportDelivery::test_stored_peer_id_is_resolved_to_a_postable_conversation
  • test_slack_gateway_subagent_delivery.py::TestSubagentChannelTransportDelivery::test_target_snapshotted_before_injection_survives_session_reset
  • test_slack_gateway_subagent_delivery.py::TestSubagentChannelTransportDelivery::test_telegram_parent_reply_reaches_registered_transport
  • test_slack_gateway_subagent_delivery.py::TestSubagentChannelTransportDelivery::test_unified_parent_uses_stored_channel_value
  • test_slack_gateway_subagent_delivery.py::TestSubagentSlackInjection::test_cron_injection_timeout
  • test_slack_gateway_update_apply.py::TestAutoApplyUpdate::test_failure_path_resolves_the_restart_hint_off_the_event_loop
  • test_slack_gateway_update_apply.py::TestAutoApplyUpdate::test_no_project_dir_returns_early
  • test_slack_gateway_update_apply.py::TestCheckMissingDepsPip::test_version_probe_transport_error_does_not_abort_boot
  • test_slack_gateway_update_reset.py::TestAutoApplyUpdateResetPath::test_reset_then_frontend_then_pip
  • test_slack_handler.py::TestHookIntegration::test_auto_reply_records_agent_in_first_turn
  • test_slack_handler.py::TestHookIntegration::test_spawn_command_records_agent_in_first_turn
  • test_slack_handler_coverage_branches.py::TestCompactCommandFailureArms::test_compact_failure_tears_down_even_when_every_cleanup_fails
  • test_slack_handler_coverage_branches.py::TestCompactCommandFailureArms::test_reporting_and_audit_failures_are_swallowed
  • test_slack_inline_stop.py::TestHandleInlineStop::test_allowed_soft_stop
  • test_slack_inline_stop.py::TestHandleInlineStop::test_hard_stop_callback
  • test_slack_inline_stop.py::TestHandleSessionEnd::test_end_resolves_key
  • test_slack_inline_stop.py::TestHandleSessionEnd::test_end_with_consolidator
  • test_slack_interactions_coverage.py::TestAckHandlers::test_cron_ack_marks_matching_notification
  • test_slack_interactions_coverage.py::TestAckHandlers::test_cron_ack_without_job_id_is_a_noop
  • test_slack_interactions_coverage.py::TestAckHandlers::test_subagent_ack_marks_matching_notification
  • test_slack_interactions_coverage.py::TestAgentSelect::test_empty_selection_is_a_noop
  • test_slack_interactions_coverage.py::TestAgentSelect::test_non_owner_rejected
  • test_slack_interactions_coverage.py::TestAgentSelect::test_reset_rejected_by_setter_aborts
  • test_slack_interactions_coverage.py::TestAgentSelect::test_switch_rejected_by_setter_aborts
  • test_slack_interactions_coverage.py::TestAgentSelect::test_unresolvable_agent_aborts
  • test_slack_interactions_coverage.py::TestChannelsModal::test_refresh_without_orch_is_a_noop
  • test_slack_interactions_coverage.py::TestDispatchPayloadParsing::test_message_action_routed_to_shortcut
  • test_slack_interactions_coverage.py::TestDispatchPayloadParsing::test_payload_without_actions_returns_before_auth
  • test_slack_interactions_coverage.py::TestDispatchPayloadParsing::test_unknown_action_without_channel_does_nothing
  • test_slack_interactions_coverage.py::TestDispatchPayloadParsing::test_view_payload_routed
  • test_slack_interactions_coverage.py::TestDispatchRouting::test_dashboard_copy_without_url_posts_nothing
  • test_slack_interactions_coverage.py::TestDispatchRouting::test_review_cancel_is_exempt_from_governance
  • test_slack_interactions_coverage.py::TestDispatchRouting::test_spent_options_marker_is_a_noop
  • test_slack_interactions_coverage.py::TestDispatchTransportToolApproval::test_governance_deny_resolves_approval_as_denied
  • test_slack_interactions_coverage.py::TestResumeChoice::test_dashboard_state_link_is_notified
  • test_slack_interactions_coverage.py::TestResumeChoice::test_dm_unavailable
  • test_slack_interactions_coverage.py::TestResumeChoice::test_malformed_json_value_is_rejected
  • test_slack_interactions_coverage.py::TestResumeChoice::test_missing_session_key_is_rejected
  • test_slack_interactions_coverage.py::TestResumeChoice::test_thread_mode_links_session
  • test_slack_interactions_coverage.py::TestResumeChoice::test_unknown_mode_returns_without_linking
  • test_slack_interactions_coverage.py::TestResumeChoice::test_without_sessions_returns
  • test_slack_interactions_coverage.py::TestSessionResume::test_empty_value_is_rejected
  • test_slack_interactions_coverage.py::TestSessionResume::test_without_sessions_returns
  • test_slack_interactions_coverage.py::TestStopCancel::test_api_delete_failure_is_swallowed
  • test_slack_interactions_coverage.py::TestStopCancel::test_without_response_url_deletes_via_api
  • test_slack_interactions_coverage.py::TestStopConfirm::test_response_url_failure_is_swallowed
  • test_slack_interactions_coverage.py::TestStopConfirm::test_soft_stop_notifies_thread
  • test_slack_interactions_coverage.py::TestViewRegistry::test_submission_falls_back_to_forward_handler
  • test_slack_render_pipeline.py::test_no_module_converts_slack_markdown_directly

Manual verification

N/A — test-only change; the runs above are the evidence.

Related Issues

N/A — part of the ongoing weak-test cleanup; no tracking issue.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 26, 2026 16:51
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 26, 2026
@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 0c216dca75790797632120f840660008acf22933 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 0c216dca75790797632120f840660008acf22933 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 0c216dca75790797632120f840660008acf22933 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Test-only change that adds real outcome checks to 19 Slack tests. It removes no assertion that pinned the opposite behaviour, so no design-level concern applies.

Notes

  • The ## Backwards compatibility section has both a Compatible: line and a Removes nothing: line. Pick one: the section's expected shape is a single Removes nothing: line.

[DESIGN-REVIEWED] 0c216dc

Description read

[DESCRIPTION-READ] 1bf829cc57e32d50155e0dc0173a9e8dec20511aa1e76e4cd21b2c7c74496252

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 0c216dca75790797632120f840660008acf22933 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 0c216dc

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 0c216dca75790797632120f840660008acf22933 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 0c216dca75790797632120f840660008acf22933 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 0c216dc

Verdict parsed from the review's SHA-scoped output markers for commit 0c216dca75790797632120f840660008acf22933.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 0c216dca75790797632120f840660008acf22933 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 26, 2026
@iamwhatever
iamwhatever force-pushed the test-cleanup/weak-slack branch from 848013a to db16063 Compare October 26, 2026 17:03
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 26, 2026
@iamwhatever
iamwhatever force-pushed the test-cleanup/weak-slack branch from db16063 to 64a6c1b Compare October 26, 2026 17:42
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 26, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

The red Backend Tests shards on head 64a6c1b are main's, not this PR's: test_telegram_dispatcher.py::TestABusyReplyCarriesItsContext (2 tests) fails the same way on a clean origin/main 20c46e9 and is tracked in #24514; the three test_crew_log_fullscan_guard.py XPASS(strict) reds are the stale xfails #24485 removed on main after this branch's base. This PR touches neither file. It will rebase once #24514 is fixed.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 26, 2026
@iamwhatever
iamwhatever marked this pull request as draft October 26, 2026 19:14
@iamwhatever
iamwhatever force-pushed the test-cleanup/weak-slack branch from 64a6c1b to bb52310 Compare October 26, 2026 19:23
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 26, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Reworked to bb52310 (one commit, rebased on main 20c46e9).

The earlier revision counted 121 fixed tests, but 102 of them only rewrote one mock check into another form, for example m.assert_called_once_with(x) into assert m.call_args_list == [call(x)], or m.assert_not_called() into assert m.call_count == 0. Both forms check the same mock record and catch the same bugs, so those rewrites made no test stronger. The weak-test scan now follows the strict rule: an assert that reads a mock's call record (call_args, call_args_list, call_count, called, await_count and the like) counts as weak, the same as assert_called*.

Those 102 tests are back to their exact main form. The 19 tests that remain each check an outcome: an ack's envelope id, a log line, an audit record, a return value, state left behind or text the user sees. Under the strict rule the repo-wide weak count drops by 18 (2,313 to 2,295); with --loose it drops by 19 (1,665 to 1,646). The PR body lists both groups and the evidence.

@iamwhatever
iamwhatever marked this pull request as ready for review October 26, 2026 19:32
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Disposition: Backend Tests (3.12, 4) and Backend Tests (Windows) (4) fail on two tests in test/test_telegram_dispatcher.py (TestABusyReplyCarriesItsContext::test_a_declined_steer_with_an_injection_parent_audits_once_at_the_queue and ::test_an_injection_reply_on_the_queue_path_audits_exactly_once, assert [] == ['telegram_reply_parent']). This PR touches no Telegram code or test. The fix is open in #24531 (clear the busy flag before the drain in those injection-audit tests); this branch will rebase once it lands.

@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 26, 2026
@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Oct 26, 2026
@iamwhatever
iamwhatever force-pushed the test-cleanup/weak-slack branch from bb52310 to 0c216dc Compare October 26, 2026 20:59
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 26, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) October 26, 2026 23:06

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 1 auto-approve: test (11 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: test-only changes that add real outcome assertions to existing Slack tests.

@KiroCrewCaptain
KiroCrewCaptain merged commit e34e23d into main Oct 26, 2026
108 of 111 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the test-cleanup/weak-slack branch October 26, 2026 23:06
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants