Repository navigation
feat(enterprise): display-only sign-in notice when the login gate relocks an open dashboard - #24499
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: it adds one display-only notice to the existing relock path, the app keeps its place in the tree, and the commit includes screenshots of this revision. [DESIGN-REVIEWED] abaf12d Description read[DESCRIPTION-READ] 0be127459feca29eafc8b63269a3fdb4039971651f6eb71a2a5b87cc706ebbe7 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (10 items) — 10 justifiedIntent: when a login expires and the gate locks a dashboard that is already open, tell the enterprise user to sign in again without losing drafts. This is an ADDITION; it closes #23882.
[FIRST-PRINCIPLES-REVIEWED] abaf12d Description read[DESCRIPTION-READ] 91a005fd29773d0f779455921457f484a78024b8ae6f196dd4369ea64a344e2d That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS No blocker. The blind reader understood all three notice variants (owner, bundled CLI, non-owner), and the seven committed screenshots show each one in both themes and at 390 px. Notes
[UX-REVIEWED] abaf12d Description read[DESCRIPTION-READ] c1ab6f1f7868ca117f5450ae7fa4b5108487a2abf6a95e259bdd8742e9616e1f That sha256 names everything this verdict read: the PR description, plus the 10 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
e3b995c to
9b1e956
Compare
9b1e956 to
c5d83f2
Compare
c5d83f2 to
9c1047a
Compare
9c1047a to
3bb53f7
Compare
3bb53f7 to
6219855
Compare
|
Opus 5.5 (bundled or Fixed in 6219855 without making the card interactive. A selectable
Test: |
6219855 to
2e41510
Compare
|
Opus 5.5 (relock notice stays painted over a remote Crew, Fixed in 2e41510. The notice now portals into the local pane's overlay container, which App hides with Test: |
2e41510 to
25bde0e
Compare
|
UX (owner line does not say where to run Evidence gap (bundled-CLI hint not captured): closed. The description now includes the owner notice with the bundled CLI, dark and light at 1280 px, plus dark at 390 px. Notes, answered without code:
|
…ocks an open dashboard A relock keeps the app mounted and adds a notice beside it, above every modal layer, saying to sign in again with the login command (a non-owner is told to ask the owner). The notice is display only: pointer-events-none, nothing focusable, no handlers, so it cannot close, block or reach into an open dialog, popover or draft. The status poll keeps probing while locked, so the notice clears once the gate reopens. oss is unchanged. Refs #23882
25bde0e to
abaf12d
Compare
|
UX (the bundled-CLI notice says "Run this" above a command the same card then calls wrong): real, fixed in abaf12d.
Notes, answered without code:
|
Post-merge review at
|
Problem / Motivation
Goal: When the enterprise login gate closes on a dashboard that is already open, tell the user to sign in again, without losing any page or dialog draft.
Follow-up to #23697 (runtime relock, merged). Since #23697, a lost or expired login closes the gate, and the gateway refuses every API but sign-in with 403
enterprise_gate_closed. The open dashboard stays mounted on purpose, so drafts are kept. But nothing tells the user why every request now fails. #23882 tracks the missing screen.Review of #23697 removed its relock screen after three rounds of real findings: replacing the app dropped page drafts, a cover above an open modal could not be clicked, and closing the modals to free it dropped their drafts.
Why it matters
Without this, an enterprise user whose login expires sees only a stream of failed requests and no reason or remedy.
Not a goal
kiro-cli login), as on the first-run screen.ossbehaviour. The notice keys onenterprise_login_required, which only an enterprise gateway sends.What changed (motivation → approach → change)
Product-shape decision: the accepted RFC
docs/request-for-change/rfc-crew-enterprise-edition.md, section "Enterprise gate" (a lost login closes the gate). The owner rated runtime expiry low priority, so this is the smallest UI that is safe next to open dialogs.website/src/components/KiroPrerequisiteRelockNotice.tsx. A small card at the top of the window. For the owner it says "Sign in required / Run this in a terminal to sign in again. This notice clears once you do." abovekiro-cli login. When the gateway's own command is longer (the desktop app's bundled CLI, or aKIROCREW_KIRO_BINoverride off PATH, perlogin_commands_for), the card cannot let anyone copy it, and the bare command is not that owner's. So the card shows no command and its main line says: open the dashboard in a new window or tab, whose sign-in screen shows the exact command with a copy button, and this window keeps its work. A non-owner cannot sign the gateway in, so they get "Ask the Kiro Crew owner to sign this gateway in again. This notice clears once they do." instead, with no command.pointer-events-none, has nothing focusable and no event handlers. Every click, key, focus and scroll goes to what is under it, as if it were not there. So it cannot close or block an open Radix dialog,Modalor popover, or touch a draft in one. It sits atz-[10002], above the top modal layer (z-[10001]), so it stays readable, and insets from the safe area (top-safe-offset-4,left-safe,right-safe) so a notched phone does not hide it. It describes the local gateway, so it portals into the local pane's overlay container (localOverlayContainer(), new inwebsite/src/components/overlayRoot.tsx), which App hides while a remote Crew is in front.KiroPrerequisiteGate. The relock path (unlessRelocked, unchanged in when it fires) now renders the app plus the notice, instead of the app alone. The app keeps its tree position, so nothing remounts.kiroPrerequisiteIsBlocking). Once the login is back and the gate reopens, the next poll removes the notice.Spec:
docs/system-specs/modules/platform-context.md§ Enterprise gate now describes the notice.Copy reuses
sign_in_required. Three new keys,components.kiroPrerequisiteGate.relock_run_in_terminal(the owner line),relock_ask_owner(the non-owner line) andrelock_exact_command_hint(the bundled-CLI line), are in every catalog (sourcewebsite/src/i18n/locales/en.manual.json) underwebsite/src/i18n/locales/(en-XA regenerated withnpm run i18n:pseudo). The first-run owner line ("install Kiro CLI ... this dashboard will open") is wrong during a relock, so it is not reused.Earlier local review rounds tried a notice with copy and "Check sign-in again" buttons. Each round found one more outside-click or outside-focus handler that those buttons could trip (page shortcut keys, popover focus-outside, capture-phase
mousedownin comment and session-control popovers, Radix scroll lock). Dropping the buttons removes that whole class. The poll already does what "Check sign-in again" did.Backwards compatibility
Compatible.
ossgateways never sendenterprise_login_required, so they never reach this path. The testoss: an established install that signs out shows no notice and keeps the apppins it. In an enterprise build the only change is the added notice during a relock.Reader: website/src/components/KiroPrerequisiteGate.tsx:KiroPrerequisiteGate -- crew page -- the relock path now adds the notice beside the app; test/KiroPrerequisiteGate.enterprise.test.tsx
Tests
website/src/test/KiroPrerequisiteGate.enterprise.test.tsx:pointer-events-noneand no focusable element.pointerdown,mousedown,click,keydown,focusin,wheelandtouchmovefired on it all reachdocument. Mutation-checked: adding astopPropagationhandler, or droppingpointer-events-none, fails it.Modal, each holding a draft, are left open with the draft on relock.kiro-cli login. The bare command shows no hint. A bundled CLI and an off-PATHKIROCREW_KIRO_BINcommand each show the hint as the main line (text-sm, strong), with neither the bare command nor the run-in-a-terminal line nor the long command, and the card stays display only.Local gates:
eslint src/ --max-warnings 0,tsc -p tsconfig.app.json, phantom-classes, restyle ratchet, i18n strings and the file line cap all pass. TheKiroPrerequisiteGate*,safeAreaandsrc/i18nsuites pass (1,287 tests), andcheck-i18n-keysresolves every key. Local GPT and Opus review ran before the first push.Manual verification
Built the bundle and ran it in Chromium with every
/apiroute answered locally: the status flips from open toenterprise_login_requiredand other routes return 403. Each capture shows the notice above an open dialog (the import-setup dialog), which stays open.Narrow (390 px), owner with bundled CLI:
Related Issues
Closes #23882
Refs #23697
Sibling sweep
Siblings: none -- KiroPrerequisiteGate's unlessRelocked is the only relock render path, and every locked branch goes through it
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)