Repository navigation
chore(src): drop history comments in non-app subpackages, part 1 - #24500
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. Every changed line in the patch is a What this change shipsInventory (3 items) — 3 justifiedIntent: make source comments in 13 non-app subpackages describe current behaviour instead of PR or review history. This is a FIX, a cleanup that AGENTS.md mandates.
[FIRST-PRINCIPLES-REVIEWED] 29b6b69 Description read[DESCRIPTION-READ] b55204e77f1c40d4dd1e1789b2093fa1f6e2e382c93e5787671eabf28a9a73af That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. Every line the patch adds or removes is a [DESIGN-REVIEWED] 29b6b69 Description read[DESCRIPTION-READ] 1b9fe842eca6fc15166aa1d526916ceea22b508b27d9c8ba2695b74b03c29f80 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Backend Tests (3.12, 2/4) and Windows (2/4) red at 30c49dd. Shard 2: the three stale strict xfails fixed by #24485 (merged after this head was cut). Shard 4: |
Rewrite "this change exists to fix", "this PR exists to produce", "an earlier revision/draft", "GPT review rN" and similar narration in `#` comments across agent_parts, apple_speech, autonudge_service, config, crew_log, discord, knowledge, llm_helpers_parts, mcp_gateway, mcp_tools, monitoring, subagent_manager and vector_memory_runtime as the rule each one carries. Comments only: every touched file has the same AST as its base. Governance, grant, tool-gate, credential and redaction code is left for its own reviewed pass.
30c49dd to
29b6b69
Compare
|
macOS (3) red: teardown errors in |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: chore (17 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: comment-only edits that drop change-history wording from source comments; no code line changes.
Problem / Motivation
Goal: Remove PR-history narration from
#comments in the non-app subpackages ofsrc/kiro_crew/, with no behaviour change, as part 1 of the last step of the source-comment rollout piloted in #23966 (slack/).With
dashboard/, the top-level modules and the builtin apps done or in review, the remaining history comments are spread thinly over many subpackages, so this PR takes them in one pass instead of one PR per two-line package. The comments narrate the branch that wrote them instead of the rule: "the bug this change exists to fix", "the one artifact this PR exists to produce", "GPT's prescribed remedy was ... Declined", "(GPT review r23)", "an earlier draft of this entry", "how an earlier revision leaked slots", "exactly as before this feature existed". AGENTS.md and the worktree-dev skill say comments state current behaviour and the non-obvious why, with no review rounds or task log.Why it matters
"This change" and "this PR" stop meaning anything once the PR merges, and a review tag tells a reader who asked, not why the code is right.
Not a goal
slack/,dashboard/, top-level modules,apps/).What changed (motivation → approach → change)
17 files in 13 subpackages touched. Only
#comment lines changed.Subpackages:
agent_parts,apple_speech,autonudge_service,config,crew_log,discord,knowledge,llm_helpers_parts,mcp_gateway,mcp_tools,monitoring,subagent_manager,vector_memory_runtime.Every rewrite states the rule, not its history. Before pushing I checked the added lines for anything over 100 columns and for leftover "this change", "this PR", "earlier revision", round, GPT, Opus or "before this feature" wording; there is none.
Examples, one per kind
1. Review-round tag (
apple_speech/__init__.py)2. "This change exists to" (
agent_parts/spec_lookup.py)3. Review proposal, kept as the decision (
autonudge_service/gate.py)4. "An earlier draft" narration, kept as the rule (
crew_log/projection_dashboard.py)5. "Before this feature" (
subagent_manager/run_turn.py)What was kept, and why
acp/runtime_reader_loop.pyand "an earlier version" of an installed store inwhatsapp/client.py: old releases the code still meets.mcp_gateway/apps.py: an external spec draft the code still reads.Opusas an audio codec (telegram,whatsapp,doctor_checks,apple_speech) and model ids invalidation_parts/agent_sdk/backends_models.py.Skipped security files
Not edited, even where they carry history comments:
agent_sdk/backends.py(governance ceilings),agent_sdk/tool_gate.py,agent_parts/spec_grants.py,agent_parts/spec_rebuild.py(ceiling-filtered installer),agent_materialization/fork_refresh.py(grants),diag/procs.py(credential redaction),mcp_gateway/rewriter_launch.py(spec-controlled fields),decisions/points/tool_risk.py,pod/runtime_home.py(SSO tokens),messaging/dispatch_admission.py. They get their own reviewed pass.Backwards compatibility
Compatible: only comments change; every touched file has the same AST as its base.
Removes nothing: no code, key, record, validator or public function changes.
Tests
Proof: not provable -- copy-only change
AST-identical proof.
goal_scan.py astcheck <merge-base>comparesast.dump(ast.parse(src))for every.pyfile changed against the merge base (9d51fb4db0); docstring-only differences would be reported separately and there are none:Gates on the touched files:
flake8,isort --check-only: cleanblack:scripts/check_black_formatting.pypassesmypy:Success: no issues found in 17 source filescheck_comment_history.pyandcheck_brand_name.py: passtest/test_*<module>*.pyfiles for the touched modules,KIROCREW_PROFILE=standalone pytest -n 4): 10781 passed, 49 skipped, 23 failed. All 23 are intest_pi_gate_extension_steer.pyandtest_pi_gate_extension_mcp.pyand fail withmise ERROR error parsing config filefrom this host's tool-version manager; none touches a changed module.Manual verification
N/A — comment-only change; the AST check proves the compiled code is unchanged.
Related Issues
None.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.