Repository navigation
feat: add a default-off Visual refresh feature preview flag - #24618
dodgeblaster wants to merge 1 commit into
Conversation
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The blind reader correctly identified the one new switch, "Visual refresh", and said they would use it. Screenshots show it off in light and dark themes and on after a click. Notes
[UX-REVIEWED] b9787f2 Description read[DESCRIPTION-READ] e49b9c0c86aac6c611642e979879c3c02d5c21084516349e78045db96a00f446 That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK The switch has no reader. Nothing reads What this change shipsInventory (5 items) — 2 justifiedIntent: let the dashboard restyle merge to
BlockersPreview flag with no gated surface — zero consumers [FIRST-PRINCIPLES-REVIEWED] b9787f2 Description read[DESCRIPTION-READ] 192ff5c043ea200ccb5c635b3903e7f62dc32de81a3187df8cf47ea0fb1bd209 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: it adds a default-off flag the same way the existing preview flags work, takes nothing away, and has screenshots of this revision. Notes
[DESIGN-REVIEWED] b9787f2 Description read[DESCRIPTION-READ] 71d5076d52078b40949e1267ed29126e81b706f8205247984acf59a318e6c3e4 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
bolichen97
left a comment
There was a problem hiding this comment.
Reviewed head 2a76e7a.
The code is clean: the new flag follows the existing preview flag pattern in previewFlags.ts, reads as off when storage is absent or denied, and the new test pins both the default and that clicking writes only its own key. The i18n catalogs, context sidecar, generated registries and feature map row are all consistent with the change. I found no correctness issues.
Two things keep this from being merge ready:
- First Principles Review blocks on the premise: the switch has no reader yet, so turning it on changes nothing a user can see. Either land the flag together with the first restyle that reads it, or make the card description say up front that it has no visible effect yet. That is a product call for a maintainer.
- Screenshot Evidence and the UX lane both need a screenshot of the Feature Previews section with the new card in the off state.
Since this is a feature that adds a user visible settings surface, I am leaving the approval to a maintainer.
|
This branch now has merge conflicts with |
2a76e7a to
69bca7b
Compare
|
Rebased onto current The rebase isn't purely textual. Since #22913, preview switches are kept on the gateway, and Local runs:
|
69bca7b to
3a6a81a
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Reviewed head 3a6a81a.
I read the full diff (24 files, one commit). It adds the visual_refresh preview flag, which is off by default: PREVIEW_VISUAL_REFRESH in previewFlags.ts, a card in FeaturePreviewsSection, a matching entry in sections_dashboard.py, i18n strings, and the test update that expects 10 switches. I found no code issues in it.
On this head the AI review lanes pass and no CI check has failed so far. Some lanes are still running.
This is a large UI change, so this review leaves it as a comment only. A maintainer needs to sign off on the visual design before it can be approved.
3a6a81a to
0ffc646
Compare
|
Rebased onto current Main had added an Local runs on this head:
|
|
[operator: bolichen97] Continuing this in #32377; thanks for the start. |
9a18dda to
85008e6
Compare
|
Rebased onto current
Local: black, isort, flake8, mypy, comment-history, brand-name and feature-map gates pass; |
85008e6 to
6db35e0
Compare
|
Rebased again (head Main's LTS change (#33592) now draws each preview card only while previews are unlocked ( Local: black, isort, flake8, comment-history, brand-name and feature-map gates pass; previewSurfaces, the LTS test and the i18n suites (1,270 tests), tsc and eslint pass. The earlier red on Backend Tests shard 6 ( |
6db35e0 to
b1484e5
Compare
Adds a preview flag, mc-preview-visual-refresh, with its switch in Settings > Developer > Feature Previews, so the dashboard visual refresh can land on main in pieces without changing what anyone sees. Like the other switches it is kept on the gateway under dashboard.feature_previews.visual_refresh (added to FEATURE_PREVIEW_FLAGS and PREVIEW_FLAGS). Off is the dashboard as it is today; nothing reads the flag yet. Part of #24595
b1484e5 to
b9787f2
Compare
|
Rebased onto current Main added a
Same 26 files as the previous head. Local: black, isort, flake8, comment-history, brand-name and feature-map gates, tsc, eslint, 193 related backend tests and 1,335 related frontend tests pass. |
|
Closing as superseded by #32377 (@bolichen97), which adds the same default-off Checked file by file against this PR's head The branch |
Problem / Motivation
Goal: Let the dashboard visual refresh land on
mainin pieces behind a default-off Feature Previews switch, so nobody sees it until it is ready.A visual refresh of the dashboard is starting. Without a gate, every piece that merges changes what every user sees, before the new look is finished or agreed.
Why it matters
The refresh can be built and reviewed on
mainin small PRs instead of a long-lived branch, while the dashboard everyone uses stays exactly as it is.Not a goal
What changed (motivation → approach → change)
Settings > Developer > Feature Previews gets a Visual refresh switch. It is off by default and changes nothing in this build; its description says pieces appear as they land.
It uses the existing preview flag mechanism, the same shape as the composable-layout and Folder conductor flags:
PREVIEW_VISUAL_REFRESH(mc-preview-visual-refresh) inwebsite/src/utils/previewFlags.ts, read withusePreviewFlag. Like every switch since #22913 it is kept on the gateway underdashboard.feature_previews.visual_refresh, so the name is added toPREVIEW_FLAGSand to the gateway'sFEATURE_PREVIEW_FLAGS(config/sections_dashboard.py, pinned equal bytest_feature_previews_config.py), anddocs/configuration.mdlists it. An absent or unknown value reads as off.The card is toggle-only in
FeaturePreviewsSection.tsx. Its label and description are in all twelve catalogs with translator context inen.context.json;en-XA, the config baseline (config-baseline.json), the settings registry (settings-registry.generated.json,commandPalette/settingsRegistry.gen.ts) and the UI index (ui-index.generated.json) are regenerated; the Developer row ofdocs/feature-map/README.mdcounts the new preview.Backwards compatibility
Compatible: a new, unset switch reads as off on the gateway and in the browser cache, so every existing install renders the dashboard unchanged.
Removes nothing: the diff only adds a flag, a settings card, its strings and the gateway's name for it.
Tests
website/src/test/previewSurfaces.test.tsx: the Feature Previews section now counts fourteen switches (both count assertions), and a new test pins that Visual refresh starts off, turns on when clicked, and writes onlymc-preview-visual-refreshamong preview keys. It passed 5 times in shuffled order (-t "Visual refresh" --sequence.shuffle). The i18n suite (catalog parity, changed-value style checks for every locale, pseudolocale, context sidecar) passes withI18N_BASE_REFat the merge base.website/src/test/ltsFeaturePreviewsOff.test.tsx: an LTS build draws no Visual refresh switch, like every other preview card (the card sits inside the section'spreviewsOffguard), and Settings search does not offer it there (developer.visual-refreshis inPREVIEW_FLAG_SETTING_IDSinsettingsSearchCore.ts). Each check fails without its fix.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Rendered the built dashboard (
npm run build, served byscripts/lib/serve-dist.mjswithstub-dashboard-api.mjs) in Playwright at/settings/developer/feature-previews: the card renders in both themes, reads off by default, and flips on when clicked (screenshots below).Screenshots / video
Settings > Developer > Feature Previews on this revision, real built SPA with stubbed API. The Visual refresh card sits between Agent harness per mate and the KAS engine card.
Off (default), light:
Off (default), dark:
On after a click, light:
Related Issues
Part of #24595
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)