Skip to content

test: fold same-file twin test bodies into parametrized tests - #24626

Merged
chenmingwei23 merged 1 commit into
mainfrom
test-cleanup/twins-same-file
Oct 27, 2026
Merged

chenmingwei23 merged 1 commit into
mainfrom
test-cleanup/twins-same-file

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Fold same-file test functions whose bodies are identical into one parametrized test each, so scripts/find_duplicate_test_bodies.py drops from 286 to 225 groups with every case still collected and checked.

Sixty-one groups of tests in the same file share one body word for word; each copy only feeds the body different parametrize data (or none). They read as separate behaviours but are one check, and every new copy makes the suite longer to read and easier to let drift.

Why it matters

Duplicate bodies hide which behaviour a file really checks and multiply the edit when that check changes. This is batch 1 of the twin-body cleanup (target: 170 or fewer groups); it takes the safest groups first, those whose copies live in the same file and read the same data.

Not a goal

  • Cross-file twins and security-labelled twins: later batches.
  • Look-alike groups (same text, different per-file or per-class data, listed below): left alone.
  • Folding per-module contract tests into shared helpers.
  • Any change under src/kiro_crew.

What changed (motivation → approach → change)

Duplicate body → the copies differ only in data → one test per group whose parametrize list is the concatenation of the copies' lists.

  • test/named_cases_helpers.py adds named_cases(old_name, argnames, argvalues, ids=, marks=). It turns one former test's parametrize arguments into pytest.param entries whose id is <old test name>-<old param id>. The old param id is rebuilt the way pytest builds it (explicit pytest.param(id=), then ids=, then the value, then <argname><index> with the index inside the old list), so the part after the name is the id the case had before. A former test that was not parametrized becomes one case whose id is its name.
  • In 49 test files, each group's copies become one test named for the shared behaviour, in the place of the first copy. Every other decorator was identical across each group's copies and stays on the merged test. Copies in different classes of one file were checked to read nothing class-specific (no self attribute, class fixture or autouse fixture that differs).
  • test_qualified_model_ids.py::TestSchemas: the two copies with stacked parametrize were merged on the inner name list only; the shared SCHEMAS outer parametrize is unchanged.
  • docs/system-specs/modules/claude-code-provider.md names the renamed TestModelRegistry pin.

How groups were classified (all 286 groups, origin/main): for every name a body reads, the script followed its binding through module constants, helpers, fixtures (including fixtures of fixtures), class attributes and class fixtures in each file. A group whose copies resolve any of those to different code or data is a look-alike and is not touched. test_ratchet_scope.py::test_the_fixture_ignores_ambient_git_state looked like a twin but calls request.getfixturevalue("repo"), which resolves to a different class fixture in each class, so it was reclassified as a look-alike and left alone.

Backwards compatibility

Compatible: test-only change; every collected case still runs with the same marks.

Reader: docs/system-specs/modules/claude-code-provider.md:TestModelRegistry pin -- release -- updated to test_the_claude_code_default_is_canonical in this PR
Reader: test/windows-expected-failures.txt:node ids -- release -- lists none of the 49 touched files, so no entry changes
Reader: setup.cfg and .github/*:deselects and baselines -- release -- no deselect, ratchet baseline or workflow names a renamed test (git grep -w over every old name outside its own file found only the doc above)

Tests

Proof: not provable -- test-only change

Evidence on the 49 touched test files plus test_ratchet_scope.py (untouched), base = merge-base 5285bc2878be:

  • Collected ids: 4,892 before and 4,892 after. 899 ids changed, and every one maps one to one: path::[Class::]old_name[p] → path::[Class::]new_name[old_name-p], and an unparametrized old_name → new_name[old_name]. The script that checked this found 0 unmapped and 0 extra ids.
  • Marks per id: a collection plugin dumped every item's marks (skipif, xfail, asyncio, xdist_group, usefixtures and the rest, with their arguments). For all 4,892 ids, old id vs mapped new id: 0 differences. No touched file appears in test/windows-expected-failures.txt.
  • Runs: 3 runs with -n 4 (KIROCREW_PROFILE=standalone): 4,890 passed and 2 skipped each time. The base gives the same 2 skips.
  • Coverage of kiro_crew, union of 2 runs per side: lines 133,750 base vs 133,753 head, 0 lost. Branches 12,413 vs 12,417, 0 lost.
  • Planted failure: making _is_safe_repo_identifier always return True fails all 13 cases of the merged test_rejects_an_unsafe_repo_identifier, the cases of its four former tests.
  • Twin groups (scripts/find_duplicate_test_bodies.py): 286 → 225. Tests in groups: 771 → 629.
  • Gates: flake8, isort, black (on the non-baselined files), check_comment_history, check_brand_name, check_file_line_cap, check_subprocess_encoding, test_flake_pattern_ratchet.py, test_wait_discipline_ratchet.py, test_file_line_cap.py, plus the related tests the scoped runner names and the test-tree meta tests (test_conftest_parts_reach, test_ci_surface_tests, test_leaf_test_scope, test_cwd_relative_repo_reads_gate, test_git_maintenance_ratchet): all green.

No timed waits, caplog reads or shared state were added. The merged bodies are the original bodies.

Manual verification

N/A — unit coverage sufficient: test-only refactor, verified by the id, mark and coverage comparisons above.

Related Issues

N/A

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

Old test → new test, per group (61 groups)
Group File Old tests New test
16 test/test_session_markdown.py test_gpt_2_completed_blocks_and_empty_items_set_fence_ownership
test_list_exit_edges_found_by_differential_fuzzing
test_gpt_10_a_hyphen_setext_underline_ends_the_paragraph
test_gpt_11_an_empty_list_item_opens_no_paragraph
test_gpt_12_a_lazy_quote_continuation_opens_no_top_level_paragraph
test_gpt_15_container_edge_cases_are_decided_by_the_parser
test_a_later_heading_stays_structural_after_the_block
41 test/test_lesson_write_outcome.py TestVolatileLessonWriteBoundary::test_selected_or_session_identity_is_refused_in_knowledge
TestVolatileLessonWriteBoundary::test_sentence_boundary_behavioral_pin_cannot_bypass_through_knowledge
TestVolatileLessonWriteBoundary::test_prefixed_direct_imperative_cannot_bypass_through_knowledge
TestDurableModelVersionReferences::test_model_identity_controls_are_refused
TestVolatileLessonWriteBoundary::test_a_volatile_model_identity_is_refused_in_knowledge
42 test/test_link_unfurl_vet_and_extraction.py test_vet_rejects_blocked_suffixes
test_vet_rejects_internal_ipv4_literals
test_vet_rejects_internal_ipv6_literals
test_vet_rejects_multicast_despite_is_global
test_vet_rejects_an_internal_or_blocked_host
43 test/test_qualified_model_ids.py TestGrammar::test_a_segment_must_start_alphanumeric
TestGrammar::test_no_segment_is_empty
TestGrammar::test_a_colon_is_only_a_trailing_tag_of_a_qualified_id
TestGrammar::test_the_charset_is_closed
TestGrammar::test_a_malformed_name_does_not_match
44 test/test_registries_api.py TestIsSafeRepoIdentifier::test_accepts_valid_ssh_urls
TestIsSafeRepoIdentifier::test_accepts_valid_https_urls
TestIsSafeRepoIdentifier::test_accepts_valid_scp_urls
TestIsSafeRepoIdentifier::test_accepts_bare_names
TestIsSafeRepoIdentifier::test_accepts_a_valid_repo_identifier
45 test/test_registries_api.py TestIsSafeRepoIdentifier::test_rejects_http_plaintext
TestIsSafeRepoIdentifier::test_rejects_path_traversal
TestIsSafeRepoIdentifier::test_rejects_shell_metacharacters
TestIsSafeRepoIdentifier::test_rejects_ambiguous_forms
TestIsSafeRepoIdentifier::test_rejects_an_unsafe_repo_identifier
47 test/test_validation.py TestFilePathShape::test_accepts_posix_absolute
TestFilePathShape::test_accepts_urlreserved_and_punctuation
TestFilePathShape::test_accepts_shell_metacharacters
TestFilePathShape::test_accepts_windows_absolute
TestFilePathShape::test_accepts_a_file_path_shape
59 test/test_artifact_tags.py TestNormalizeTag::test_control_format_and_whitespace_characters_are_rejected
TestNormalizeTag::test_symbols_and_other_punctuation_are_rejected
TestNormalizeTag::test_enclosing_marks_are_rejected
TestNormalizeTag::test_a_disallowed_character_is_rejected
76 test/test_session_markdown.py test_fence_closer_and_indent_rules
test_an_info_string_opens_where_the_fence_kind_allows_it
test_html_comment_and_fence_interplay
test_the_unterminated_block_closer_is_reported
77 test/test_slugs.py TestRefusedSlugChar::test_names_the_first_character_the_slug_cannot_hold
TestRefusedSlugChar::test_reports_the_character_as_typed_before_lowercasing
TestRefusedSlugChar::test_a_character_that_cannot_stand_alone_is_reported_as_its_code_point
TestRefusedSlugChar::test_reports_the_refused_character
80 test/test_tailnet_origin.py TestValidation::test_rejects_structurally_bad_names
TestValidation::test_rejects_names_outside_the_reported_suffix
TestValidation::test_rejects_non_strings
TestValidation::test_rejects_an_invalid_name
82 test/gui_user/test_x11.py TestDisplayGuard::test_refuses_real_or_empty_displays
TestDisplayGuard::test_refuses_remote_or_malformed_displays
TestDisplayGuard::test_refuses_a_display_it_must_not_touch
83 test/test_agent_avatar.py TestSafeAvatar::test_missing_traits_collapses
TestSafeAvatarGhostReactions::test_bare_ghost_still_collapses
TestSafeAvatar::test_a_bare_ghost_collapses
86 test/test_agent_slash_command.py test_a_single_agent_name_is_a_switch
TestTelegramAndSlackUnchanged::test_slack_parser_reads_as_before
test_the_parser_reads_the_agent_switch
88 test/test_ai_review_workflows_scope_verdict.py TestPerHeadMonotonicFloor::test_same_repo_new_head_with_no_prior_stays_green
TestPerHeadMonotonicFloor::test_same_repo_a_well_formed_empty_listing_publishes_clean
TestPerHeadMonotonicFloor::test_same_repo_no_prior_or_empty_listing_stays_green
89 test/test_ai_review_workflows_scope_verdict.py TestPerHeadMonotonicFloor::test_fork_new_head_with_no_prior_publishes_clean
TestPerHeadMonotonicFloor::test_fork_a_well_formed_empty_listing_publishes_clean
TestPerHeadMonotonicFloor::test_fork_no_prior_or_empty_listing_publishes_clean
101 test/test_artifact_source.py TestNonGitProjectsLink::test_unmarked_directory_still_copies
TestClassifySourceProjectWalk::test_no_repo_no_project_is_copy
TestNonGitProjectsLink::test_an_unmarked_directory_is_copied
102 test/test_artifact_tags.py TestNormalizeTag::test_letters_marks_and_digits_of_any_script_are_admitted
TestNormalizeTag::test_existing_ascii_tags_pass_unchanged
TestNormalizeTag::test_an_admitted_tag_passes_unchanged
104 test/test_auto_research_guards.py TestRequireAuth::test_returns_401_when_no_user
TestRequireAuth::test_rejects_raw_token
TestRequireAuth::test_a_request_without_a_user_gets_401
105 test/test_aws_control_backup_job.py TestRunnerResolvesItsTarget::test_an_unreachable_account_fails_without_falling_back
TestScheduledPathFallsBackToTheVerifiedProfile::test_the_owner_path_does_not_fall_back_on_an_expired_cache
TestRunnerResolvesItsTarget::test_an_unreachable_account_does_not_fall_back
108 test/test_channel_blocked_tools.py test_blocked_tool_matcher_precision
test_dispatch_verb_matcher_precision
test_tool_matcher_precision
115 test/test_chat_title.py test_prose_replies_rejected
test_unspaced_script_prose_rejected
test_prose_replies_are_rejected
116 test/test_chat_title.py test_real_titles_accepted
test_unspaced_script_titles_accepted
test_real_titles_are_accepted
117 test/test_chat_title.py test_skip_with_reason_yields_no_title
test_keep_is_a_control_word_on_the_initial_path
test_a_control_reply_yields_no_title
118 test/test_chat_title.py test_legitimate_titles_survive_the_new_checks
test_short_titles_in_any_script_survive_the_sentence_shape
test_a_legitimate_title_survives
119 test/test_check_feature_map.py TestNonFeatures::test_ignored_inside_watched_trees
TestNonFeatures::test_outside_watched_trees
TestNonFeatures::test_a_non_feature_path_is_not_a_feature
135 test/test_config_load_pipeline_field_defaults.py TestAMovedFieldDefaultMovesTheBuild::test_the_build_follows_the_field
TestAMovedFieldDefaultMovesTheBuild::test_a_value_of_its_own_holds_when_the_default_moves
TestAMovedFieldDefaultMovesTheBuild::test_a_moved_default_reads_as_expected
138 test/test_crewmate_import_route.py test_an_entry_outside_the_two_folders_is_refused
test_the_size_caps_refuse_before_the_rest_is_read
test_a_bad_bundle_is_refused
145 test/test_decisions_local_provider.py TestIsLoopbackEndpoint::test_a_literal_loopback_address_is_local
TestIsLoopbackEndpoint::test_the_unspecified_address_dials_this_machine_and_is_local
TestIsLoopbackEndpoint::test_a_local_address_is_loopback
168 test/test_exfil_outbound_sends_allowed.py TestOutboundSendsAreNotRefused::test_allowed
TestOrdinaryCommandsNeverRefused::test_allowed
TestOutboundSendsAreNotRefused::test_the_command_is_allowed
169 test/test_feedback.py TestNewUserSessionWindow::test_past_window_but_server_dedup_not_due_stays_not_eligible
TestApiFeedbackEligible::test_not_eligible_when_aperture_returns_null_body
TestNewUserSessionWindow::test_a_null_aperture_body_is_not_eligible
171 test/test_find_ui.py test_seeded_newcomer_words_on_pages_and_settings
test_runtime_labelled_chips_are_found_by_newcomer_words
test_newcomer_words_find_their_target
173 test/test_frontmatter.py TestWrittenValuesStayLoadableYaml::test_a_control_character_is_refused
TestWrittenValuesStayLoadableYaml::test_unspellable_values_are_refused_not_mangled
TestWrittenValuesStayLoadableYaml::test_an_unwritable_value_is_refused
178 test/test_handlers_mcp_coverage_gateway_servers.py TestGatewaySetStub::test_validation_matrix_is_400
TestGatewaySetStubBatch::test_validation_matrix_is_400
TestGatewaySetStub::test_an_invalid_body_is_400
179 test/test_handlers_messaging_coverage_channels.py TestHelpers::test_is_valid_webex_email
TestHelpers::test_is_valid_webex_email_shape_rules
TestHelpers::test_webex_email_validity
182 test/test_image_refs_replay_strip.py TestBarePathPassIsNarrowerThanTheInliner::test_code_and_url_spans_keep_their_text
TestBarePathPassKeepsProse::test_prose_keeps_every_word
TestBarePathPassIsNarrowerThanTheInliner::test_the_text_is_kept
183 test/test_image_refs_replay_strip.py TestBarePathPassKeepsProse::test_the_reference_inside_prose_is_still_stripped
TestBarePathPassKeepsProse::test_a_spaced_path_whose_shape_vouches_for_it_is_stripped
TestBarePathPassKeepsProse::test_the_reference_is_stripped
184 test/test_imessage_client.py TestOwnEchoLedger::test_resolved_records_are_still_bounded
TestOwnEchoLedger::test_the_ledger_is_bounded
TestOwnEchoLedger::test_the_echo_ledger_is_bounded
185 test/test_inline_payload_scoped_regressions.py TestACallIsJudgedByWhatItResolvesTo::test_every_static_binding_reaches_the_runner
TestACallIsJudgedByWhatItResolvesTo::test_every_static_binding_reaches_the_loader
TestACallIsJudgedByWhatItResolvesTo::test_every_static_binding_is_a_credential_mint
187 test/test_is_interrupted.py TestInterrupted::test_clean_completion_is_not_interrupted
TestCompletedCompaction::test_ordinary_completed_turn_is_finished
TestInterrupted::test_a_completed_turn_is_not_interrupted
188 test/test_issue_gate_refs.py TestWhatDoesNotCount::test_unlisted_keywords_do_not_count
TestWhatDoesNotCount::test_keyword_must_start_the_trailer
TestWhatDoesNotCount::test_the_line_declares_nothing
203 test/test_kiro_prerequisite.py TestConfigSetHintsForLauncher::test_a_percent_in_the_path_leaves_only_the_powershell_row
TestConfigSetHintsForLauncher::test_a_bang_in_the_path_leaves_only_the_powershell_row
TestConfigSetHintsForLauncher::test_a_special_character_in_the_path_leaves_only_the_powershell_row
206 test/test_mcp_browser_tool.py test_navigate_classifier_rejects_percent_encoded_hosts
test_navigate_classifier_rejects_raw_non_ascii_private_hosts
test_navigate_classifier_rejects_a_disguised_private_host
209 test/test_mcp_gatewayd_coverage.py TestReadFirstFrame::test_undecodable_or_invalid_json_returns_none
TestReadFirstFrame::test_non_object_json_is_refused
TestReadFirstFrame::test_a_bad_first_frame_returns_none
210 test/test_meetings_store.py TestSafeMeetingId::test_rejects_unsafe
TestSafeMeetingId::test_rejects_non_string
TestSafeMeetingId::test_rejects_an_unsafe_id
213 test/test_model_registry.py TestModelRegistry::test_fable_5_not_default
TestModelRegistry::test_default_canonical
TestModelRegistry::test_the_claude_code_default_is_canonical
214 test/test_model_selection_scenarios.py TestEntitlementPredicate::test_unserved_model_is_unusable
TestExplicitPickRefusal::test_unavailable_pick_would_be_flagged_by_the_predicate
TestEntitlementPredicate::test_an_unserved_model_is_unusable
220 test/test_options_marker_label_closers.py TestAcceptedCosts::test_a_nested_head_is_not_swallowed_into_a_label
TestLookalikeBracketPairsParse::test_a_nested_head_is_still_refused
TestAcceptedCosts::test_a_nested_head_is_refused
222 test/test_options_marker_terminator.py TestAnUnterminatedMarkerDoesNotEatItsLine::test_it_is_refused
TestWhatMustNotHaveChanged::test_every_previously_refused_shape_still_is
TestAnUnterminatedMarkerDoesNotEatItsLine::test_the_marker_is_refused
223 test/test_papyrus_doc_title.py test_reads_the_title
test_turns_latex_into_plain_text
test_reads_the_title_as_plain_text
225 test/test_pinned_fs_descendant.py TestByNameArm::test_it_yields_none_and_validates_a_clean_chain
TestByNameArm::test_a_clean_chain_is_not_refused_negative_control
TestByNameArm::test_a_clean_chain_yields_none_and_validates
233 test/test_project_scan_models.py TestIsPruned::test_listed_directories_are_pruned
TestIsPruned::test_dot_directories_are_pruned
TestIsPruned::test_the_directory_is_pruned
237 test/test_qualified_model_ids.py TestGrammar::test_qualified_nested_and_colon_ids_are_accepted
TestGrammar::test_legacy_and_bracket_names_are_unchanged
TestGrammar::test_an_accepted_name_matches
249 test/test_session_markdown.py test_html_container_exit_leaves_a_later_code_fence_top_level
test_gpt_6_a_quoted_comment_releases_the_markdown_when_its_quote_ends
test_a_later_code_fence_is_top_level
251 test/test_sibling_list_check.py test_well_formed_sections_pass
test_documented_forms_pass
test_the_section_passes
252 test/test_skill_provider_github.py TestMaterialisation::test_reserved_device_names_are_refused_at_every_level
TestMaterialisation::test_a_reserved_stem_with_several_extensions_is_still_reserved
TestMaterialisation::test_a_reserved_device_name_is_refused
253 test/test_skill_provider_http.py TestIsInternalUrl::test_encoded_internal_is_blocked
TestIsInternalUrl::test_plain_internal_is_blocked
TestIsInternalUrl::test_an_internal_url_is_blocked
260 test/test_slugs.py TestRefusedSlugChar::test_what_the_normalizer_turns_into_slug_characters_is_not_blamed
TestRefusedSlugChar::test_empty_when_every_character_is_a_slug_character
TestRefusedSlugChar::test_no_character_is_blamed
266 test/test_spawn_reasoning_effort.py TestSchema::test_unknown_level_is_rejected
TestSchema::test_non_string_is_rejected
TestSchema::test_a_bad_level_is_rejected
273 test/test_transcribe_ffmpeg.py TestBundledFfmpeg::test_resolves_the_exact_packaged_resource
TestBundledFfmpeg::test_packaged_cli_without_electron_parent_uses_release_decoder
TestBundledFfmpeg::test_the_packaged_resource_is_resolved
238 test/test_qualified_model_ids.py TestSchemas::test_a_qualified_id_passes_unchanged
TestSchemas::test_legacy_names_pass_unchanged
TestSchemas::test_an_accepted_name_passes_unchanged
Look-alike groups left alone (170: 134 plain, 36 with a security-word name)

Each group's copies share the body text but read different data per file or class (module constants, _OWNERS lists, per-file fixtures such as a template's html, class fixtures). Folding them would need a shared helper per contract, which this pass does not do.

  • test_the_class_only_scan_can_fail x13: test_acp_bindings.py, test_backend_bindings.py, test_client_bindings.py, test_cron_service_bindings.py, test_history_bindings.py, test_runtime_bindings.py, test_session_bindings.py, test_session_handle_bindings.py, test_session_lifecycle_bindings.py, test_ssh_tunnel_manager_bindings.py, test_taskrunner_bindings.py, test_transport_dispatch_composition.py, test_transport_dispatch_webex_composition.py
  • test_no_owner_imports_the_facade_at_run_time x13: test_acp_bindings.py, test_artifacts_bindings.py, test_backend_bindings.py, test_client_bindings.py, test_history_bindings.py, test_runtime_bindings.py, test_sel_bindings.py, test_session_bindings.py, test_session_handle_bindings.py, test_session_lifecycle_bindings.py, test_session_map_bindings.py, test_ssh_tunnel_manager_bindings.py, test_taskrunner_bindings.py
  • test_no_owner_keeps_an_unbound_self_function x11: test_acp_bindings.py, test_artifacts_bindings.py, test_client_bindings.py, test_driver_owner_bindings.py, test_history_bindings.py, test_session_allocation_bindings.py, test_session_handle_bindings.py, test_session_lifecycle_bindings.py, test_skills_bindings.py, test_ssh_tunnel_manager_bindings.py, test_taskrunner_bindings.py
  • test_no_bound_function_needs_its_class_body x9: test_acp_bindings.py, test_client_bindings.py, test_history_bindings.py, test_runtime_bindings.py, test_session_bindings.py, test_session_handle_bindings.py, test_session_lifecycle_bindings.py, test_ssh_tunnel_manager_bindings.py, test_taskrunner_bindings.py
  • test_each_owner_names_the_fields_it_writes_and_reads x9: test_acp_bindings.py, test_client_bindings.py, test_runtime_bindings.py, test_session_bindings.py, test_session_handle_bindings.py, test_session_lifecycle_bindings.py, test_skills_bindings.py, test_ssh_tunnel_manager_bindings.py, test_taskrunner_bindings.py
  • test_the_field_scan_counts_every_read_and_write_shape x8: test_acp_bindings.py, test_client_bindings.py, test_runtime_bindings.py, test_session_bindings.py, test_session_handle_bindings.py, test_session_lifecycle_bindings.py, test_ssh_tunnel_manager_bindings.py, test_taskrunner_bindings.py
  • test_the_detector_answers_both_ways x7: test_acp_refactor_create_guard.py, test_agent_refactor_create_guard.py, test_artifacts_refactor_create_guard.py, test_cli_doctor_refactor_create_guard.py, test_pod_runtime_refactor_create_guard.py, test_sandbox_refactor_create_guard.py, test_source_providers_refactor_create_guard.py
  • test_the_owner_edge_check_sees_every_spelling x6: test_chat_handlers_composition_contract.py, test_dashboard_agents_composition_contract.py, test_dashboard_files_composition_contract.py, test_dashboard_server_composition_contract.py, test_handlers_messaging_composition_contract.py, test_hooks_composition_contract.py
  • test_the_class_body_scan_can_fail x6: test_client_discord_composition_contract.py, test_client_telegram_composition_contract.py, test_renderer_discord_composition_contract.py, test_renderer_telegram_composition_contract.py, test_session_tree_projection_facade.py, test_telegram_transport_dispatch_composition_contract.py
  • test_leaf_test_scope_derives_this_file_as_a_corpus_gate x6: test_cron_script_facade.py, test_routes_parts_sage_composition_contract.py, test_security_posture_facade.py, test_security_split_patch_reach.py, test_session_storage_parts.py, test_warm_runtime_patch_reach.py
  • test_it_reads_the_hosts_own_field_bag x6: test_dashboard_template_flow.py, test_dashboard_template_office.py, test_dashboard_template_pr-watch.py, test_dashboard_template_roadmap.py, test_dashboard_template_standup.py, test_dashboard_template_swimlane.py
  • test_inert_mention_allowed (+5 names) x6: test_denied_commands_security_cost.py, test_denied_commands_security_kill.py, test_denied_commands_security_mentions.py, test_denied_commands_security_mint.py
  • test_argument_does_not_break_the_match (+4 names) x6: test_discord_app_commands.py, test_telegram_parity_commands.py, test_webex_dispatch.py, test_wecom_commands_and_ingest.py
  • test_the_test_tree_walk_reaches_every_collected_tree x6: test_gate_bindings.py, test_run_bindings.py, test_runner_facade.py, test_store_parts_bindings.py, test_store_taskq_bindings.py, test_taskq_bridge_bindings.py
  • test_leaf_test_scope_derives_this_file_as_a_corpus_gate x6: test_gate_bindings.py, test_run_bindings.py, test_runner_facade.py, test_store_parts_bindings.py, test_store_taskq_bindings.py, test_taskq_bridge_bindings.py
  • test_a_block_comment_refuses_the_line (+5 names) x6: test_name_grant.py, test_name_grant_windows.py
  • test_the_facade_installs_its_mirror_when_run_as_a_script x5: test_client_discord_composition_contract.py, test_client_telegram_composition_contract.py, test_renderer_discord_composition_contract.py, test_renderer_telegram_composition_contract.py, test_session_tree_projection_facade.py
  • test_the_shared_loader_accepts_it x5: test_dashboard_template_flow.py, test_dashboard_template_office.py, test_dashboard_template_roadmap.py, test_dashboard_template_standup.py, test_dashboard_template_swimlane.py
  • test_each_path_is_present x5: test_dashboard_template_flow.py, test_dashboard_template_office.py, test_dashboard_template_roadmap.py, test_dashboard_template_standup.py, test_dashboard_template_swimlane.py
  • test_it_renders_on_load_and_on_every_message x5: test_dashboard_template_flow.py, test_dashboard_template_office.py, test_dashboard_template_roadmap.py, test_dashboard_template_standup.py, test_dashboard_template_swimlane.py
  • test_data_consumer_exemption_does_not_cover_a_real_run (+4 names) x5: test_denied_commands_security_cost.py, test_denied_commands_security_kill.py, test_denied_commands_security_mentions.py, test_denied_commands_security_mint.py
  • test_the_member_set_is_the_frozen_inventory x5: test_gate_bindings.py, test_run_bindings.py, test_store_parts_bindings.py, test_store_taskq_bindings.py, test_taskq_bridge_bindings.py
  • test_the_sweep_reports_a_global_the_namespace_does_not_bind x4: test_agent_parts.py, test_cli_doctor_parts.py, test_sandbox_launcher_program_parts.py, test_subagent_parts_composition_contract.py
  • test_the_class_only_scan_can_fail x4: test_artifacts_bindings.py, test_context_assembly_bindings.py, test_driver_owner_bindings.py, test_skills_bindings.py
  • test_no_name_of_the_family_is_excluded_from_the_mirror x4: test_artifacts_parts_contract.py, test_control_parts_contract.py, test_session_control_parts_contract.py, test_spawn_parts_contract.py
  • test_owners_import_only_owners_listed_before_them x4: test_artifacts_parts_contract.py, test_control_parts_contract.py, test_session_control_parts_contract.py, test_spawn_parts_contract.py
  • test_every_owner_logs_under_the_facades_name x4: test_client_discord_composition_contract.py, test_client_telegram_composition_contract.py, test_renderer_discord_composition_contract.py, test_renderer_telegram_composition_contract.py
  • test_a_moved_member_is_its_owners_function x4: test_client_discord_composition_contract.py, test_client_telegram_composition_contract.py, test_renderer_discord_composition_contract.py, test_renderer_telegram_composition_contract.py
  • test_every_owner_function_of_self_is_bound_on_the_class x4: test_client_discord_composition_contract.py, test_client_telegram_composition_contract.py, test_renderer_discord_composition_contract.py, test_renderer_telegram_composition_contract.py
  • test_no_bound_function_needs_the_class_body x4: test_client_discord_composition_contract.py, test_client_telegram_composition_contract.py, test_renderer_discord_composition_contract.py, test_renderer_telegram_composition_contract.py
  • test_each_guarded_construct_stays_in_the_facade x4: test_client_discord_composition_contract.py, test_client_telegram_composition_contract.py, test_renderer_discord_composition_contract.py, test_renderer_telegram_composition_contract.py
  • test_the_globstar_matcher_reads_patterns_as_the_reviewers_do x4: test_dashboard_agents_composition_contract.py, test_dashboard_files_composition_contract.py, test_dashboard_server_composition_contract_guards.py, test_handlers_messaging_composition_contract.py
  • test_each_resolved_value_has_the_declared_type x4: test_dashboard_template_flow.py, test_dashboard_template_roadmap.py, test_dashboard_template_standup.py, test_dashboard_template_swimlane.py
  • test_it_reaches_no_network x4: test_dashboard_template_office.py, test_dashboard_template_roadmap.py, test_dashboard_template_standup.py, test_dashboard_template_swimlane.py
  • test_agent_resolves_to_kirocrew_when_unset x4: test_feishu_dispatch.py, test_teams_dispatch.py, test_webex_dispatch.py, test_wecom_dispatch.py
  • test_compact_none_capability_preserves_dispatch x4: test_feishu_dispatch.py, test_teams_dispatch.py, test_webex_dispatch.py, test_wecom_dispatch.py
  • test_no_name_patched_through_run_is_read_by_an_owner (+2 names) x4: test_gate_bindings.py, test_run_bindings.py, test_runner_facade.py, test_store_taskq_bindings.py
  • test_agent_reply (+3 names) x4: test_slack_handler_coverage.py
  • test_no_test_patches_a_forwarded_name_that_it_may_create x3: test_acp_refactor_create_guard.py, test_agent_refactor_create_guard.py, test_pod_runtime_refactor_create_guard.py
  • test_leaf_test_scope_derives_this_file_as_a_corpus_gate x3: test_agent_parts.py, test_cli_doctor_parts.py, test_sandbox_launcher_program_parts.py
  • test_the_patch_scan_reads_every_spelling_and_nothing_else x3: test_agent_parts.py, test_cli_doctor_parts.py, test_sandbox_launcher_program_parts.py
  • test_the_patch_scan_finds_every_known_seam x3: test_agent_parts.py, test_cli_doctor_parts.py, test_sandbox_launcher_program_parts.py
  • test_the_owner_import_check_sees_every_spelling x3: test_agent_parts.py, test_cli_doctor_parts.py, test_subagent_parts_composition_contract.py
  • test_the_package_init_defines_nothing x3: test_agent_parts.py, test_cli_doctor_parts.py, test_sandbox_launcher_program_parts.py
  • test_the_importer_check_sees_every_spelling x3: test_agent_parts.py, test_cli_doctor_parts.py, test_subagent_parts_composition_contract.py
  • test_the_frozen_inventory_is_not_empty x3: test_app_backend_composition_contract.py, test_apps_registry_composition_contract.py, test_aws_control_backup_composition_contract.py
  • test_every_module_holding_a_name_holds_the_same_object x3: test_app_backend_composition_contract.py, test_apps_registry_composition_contract.py, test_aws_control_backup_composition_contract.py
  • test_the_reader_flags_every_spelling_and_only_those x3: test_app_backend_composition_contract_patch_spellings.py, test_apps_registry_composition_contract_patch_spellings.py, test_aws_control_backup_composition_contract_patch_guards.py
  • test_each_owner_names_the_fields_it_writes_and_reads x3: test_backend_bindings.py, test_sel_bindings.py, test_session_map_bindings.py
  • test_self_test_passes x3: test_check_comment_history.py, test_subprocess_encoding_gate.py, test_sync_io_in_async_gate.py
  • test_prompt_does_not_carry_the_retired_verbosity_token x3: test_conductor_agent.py, test_pipeline_conductor_agent.py, test_security_conductor_agent.py
  • test_the_sibling_import_scan_catches_a_planted_import x3: test_context_composition_contract_facade.py, test_skills_composition_contract.py, test_vector_memory_composition_contract.py
  • test_the_patch_scan_finds_every_known_seam x3: test_cron_script_facade.py, test_security_posture_facade.py, test_session_storage_parts.py
  • test_leaf_test_scope_derives_this_file_as_a_corpus_gate x3: test_fleet_probe_owners.py, test_pr_status_owners.py, test_push_guard_owners.py
  • test_every_name_the_one_file_script_bound_is_still_bound_on_the_facade (+1 names) x3: test_fleet_probe_owners.py, test_pr_status_owners.py, test_push_guard_owners.py
  • test_no_owner_imports_the_facade_at_run_time x3: test_runner_facade.py, test_store_parts_bindings.py, test_store_taskq_bindings.py
  • test_each_class_an_owner_defines_carries_its_frozen_module x3: test_runner_facade.py, test_store_parts_bindings.py, test_store_taskq_bindings.py
  • test_leaf_test_scope_derives_this_file_as_a_corpus_gate x3: test_runtime_bindings.py, test_session_allocation_bindings.py, test_session_handle_bindings.py
  • test_the_placement_scan_finds_each_construct_it_pins x3: test_telegram_transport_dispatch_composition_contract.py, test_transport_dispatch_composition.py, test_transport_dispatch_webex_composition.py
  • test_an_owner_imports_the_facade_only_for_type_checking_and_no_project_module x2: test_agent_parts.py, test_cli_doctor_parts.py
  • test_the_facade_helper_is_only_ever_called_in_place x2: test_app_backend_composition_contract.py, test_apps_registry_composition_contract.py
  • test_the_reader_follows_a_production_re_export x2: test_app_backend_composition_contract_patch_spellings.py, test_apps_registry_composition_contract_patch_spellings.py
  • test_leaf_test_scope_derives_this_file_as_a_corpus_gate x2: test_app_backend_composition_contract_patch_spellings.py, test_apps_registry_composition_contract_patch_spellings.py
  • test_precondition_a_declaring_manifest_is_admitted_when_untampered x2: test_app_signing_payload_executed_fields.py, test_app_signing_payload_resource_and_ui_fields.py
  • test_delete_missing_404 (+1 names) x2: test_artifact_comment_handlers.py, test_artifacts_handlers_coverage.py
  • test_edit_missing_404 (+1 names) x2: test_artifact_comment_handlers.py, test_artifacts_handlers_coverage.py
  • test_the_scan_reads_every_file_that_names_the_facade (+1 names) x2: test_artifacts_refactor_create_guard.py, test_source_providers_refactor_create_guard.py
  • test_no_owner_keeps_an_unbound_self_function x2: test_backend_bindings.py, test_sel_bindings.py
  • test_the_owner_set_is_the_package x2: test_chat_handlers_composition_contract.py, test_chat_runner_base_surface.py
  • test_the_package_holds_exactly_the_composed_modules x2: test_chat_persistence_composition_contract.py, test_context_composition_contract_facade.py
  • test_the_package_init_imports_nothing x2: test_chat_persistence_composition_contract.py, test_context_composition_contract_facade.py
  • test_no_owner_anchors_a_path_on_its_own_file x2: test_chat_persistence_composition_contract.py, test_context_composition_contract_facade.py
  • test_the_package_holds_exactly_the_composed_parts x2: test_chat_persistence_parts_composition_contract.py, test_routes_parts_sage_composition_contract.py
  • test_the_package_init_holds_only_its_docstring x2: test_chat_persistence_parts_composition_contract.py, test_routes_parts_sage_composition_contract.py
  • test_the_owners_are_every_sibling_module_in_layer_order x2: test_client_discord_composition_contract.py, test_renderer_discord_composition_contract.py
  • test_an_owner_imports_only_owners_below_it_and_never_its_facade x2: test_client_discord_composition_contract.py, test_renderer_discord_composition_contract.py
  • test_the_class_keeps_every_base_member x2: test_client_discord_composition_contract.py, test_renderer_discord_composition_contract.py
  • test_every_base_member_keeps_its_kind_and_signature x2: test_client_discord_composition_contract.py, test_renderer_discord_composition_contract.py
  • test_only_the_family_imports_an_owner x2: test_client_discord_composition_contract.py, test_renderer_discord_composition_contract.py
  • test_the_owner_import_scan_finds_an_outside_importer x2: test_client_discord_composition_contract.py, test_renderer_discord_composition_contract.py
  • test_each_moved_class_is_served_whole_from_its_owner x2: test_client_discord_composition_contract.py, test_renderer_discord_composition_contract.py
  • test_the_owners_are_every_sibling_module_in_layer_order x2: test_client_telegram_composition_contract.py, test_renderer_telegram_composition_contract.py
  • test_an_owner_imports_only_owners_below_it_and_never_its_facade x2: test_client_telegram_composition_contract.py, test_renderer_telegram_composition_contract.py
  • test_the_class_keeps_every_base_member_and_gains_none x2: test_client_telegram_composition_contract.py, test_renderer_telegram_composition_contract.py
  • test_every_base_member_keeps_its_kind_and_signature x2: test_client_telegram_composition_contract.py, test_renderer_telegram_composition_contract.py
  • test_the_sibling_import_scan_allows_a_module_import x2: test_context_composition_contract_facade.py, test_skills_composition_contract.py
  • test_both_exempted_caller_classes_are_fenced (+1 names) x2: test_cron_session_control.py, test_session_control_lineage_fence.py
  • test_missing_testpaths_exits_rather_than_scanning_nothing (+1 names) x2: test_cwd_relative_repo_reads_gate.py, test_testpaths_coverage_gate.py
  • test_the_owner_set_is_the_package x2: test_dashboard_agents_composition_contract.py, test_slack_handler_composition_contract.py
  • test_the_owner_set_is_the_package x2: test_dashboard_files_composition_contract.py, test_handlers_messaging_composition_contract.py
  • test_it_reads_only_the_work_fold x2: test_dashboard_template_flow.py, test_dashboard_template_roadmap.py
  • test_assert_floor_passes_default_authority (+1 names) x2: test_denied_commands_authority.py, test_platform_context.py
  • test_assert_floor_rejects_non_authority (+1 names) x2: test_denied_commands_authority.py, test_platform_context.py
  • test_a_quoted_literal_construct_pattern_stays_denied (+1 names) x2: test_denied_commands_security_kill.py
  • test_function_not_forwarding_to_a_protected_program_allowed (+1 names) x2: test_denied_commands_security_kill.py, test_denied_commands_security_mint.py
  • test_mint_spellings_still_blocked (+1 names) x2: test_denied_commands_security_kill.py, test_denied_commands_security_mint.py
  • test_quote_aware_window_still_sees_the_kill (+1 names) x2: test_denied_commands_security_kill.py
  • test_payload_without_a_protected_command_allowed (+1 names) x2: test_denied_commands_security_kill.py, test_denied_commands_security_mint.py
  • test_interpreter_argv_literal_blocked (+1 names) x2: test_denied_commands_security_mint.py, test_denied_commands_security_ssh_self.py
  • test_a_genuine_netcat_exec_is_denied_by_this_row (+1 names) x2: test_denied_commands_security_rows.py, test_denied_commands_security_ssh_self.py
  • test_sso_plus_profile_passes x2: test_deploy_script_validation.py
  • test_unterminated_options_tag_is_not_redos x2: test_discord.py, test_telegram.py
  • test_save_rejects_non_numeric_user_ids x2: test_discord_config_handlers.py, test_telegram_config_handlers.py
  • test_soft_threshold_bounds x2: test_discord_config_handlers.py, test_telegram_config_handlers.py
  • test_every_host_deny_is_preceded_by_the_shared_steer x2: test_eval_subagent_deny_notice.py, test_taskrunner_deny_notice.py
  • test_every_reject_audits_before_the_steer x2: test_eval_subagent_deny_notice.py, test_taskrunner_deny_notice.py
  • test_every_steer_names_its_cause_explicitly x2: test_eval_subagent_deny_notice.py, test_taskrunner_deny_notice.py
  • test_each_owner_imports_on_its_own_before_the_facade x2: test_events_facade.py, test_interactions_facade.py
  • test_save_rejects_whitespace_credentials x2: test_feishu_config_handlers.py, test_wecom_config_handlers.py
  • test_strict_guard_is_actually_armed x2: test_folder_watcher_off_loop_guard.py, test_knowledge_agent_sync_off_loop.py
  • test_the_resolution_scan_can_fail x2: test_gate_bindings.py, test_run_bindings.py
  • test_nothing_else_in_src_imports_an_owner x2: test_gate_bindings.py, test_run_bindings.py
  • test_a_foreign_child_may_read_it x2: test_gateway_id_sandbox_seal.py, test_skill_projection_sandbox_seal.py
  • test_macos_denies_writes_but_not_reads x2: test_gateway_id_sandbox_seal.py, test_skill_projection_sandbox_seal.py
  • test_a_named_port_is_still_used_as_the_fallback (+1 names) x2: test_instance_credential_pairing.py
  • test_a_404_still_reads_as_feature_absent (+1 names) x2: test_issue_radar_deps.py
  • test_a_parenthetical_citation_is_removed_as_one_unit x2: test_issue_radar_routes_ai_coverage.py, test_issue_radar_routes_coverage.py
  • test_a_non_string_does_not_raise (+1 names) x2: test_issue_radar_routes_ai_coverage.py, test_issue_radar_routes_coverage.py
  • test_absent_and_empty_default_to_issue x2: test_issue_radar_routes_ai_coverage_lists_and_investigation.py, test_issue_radar_routes_coverage.py
  • test_missing_params_is_400 x2: test_issue_radar_routes_coverage.py
  • test_an_unconnected_repo_is_404 x2: test_issue_radar_routes_coverage.py
  • test_missing_params_is_400 x2: test_issue_radar_routes_coverage.py
  • test_a_malformed_or_non_object_payload_is_400 x2: test_issue_radar_routes_coverage.py, test_issue_radar_routes_coverage_label_and_issue_writes.py
  • test_an_unconnected_repo_is_404 x2: test_issue_radar_routes_coverage.py
  • test_missing_params_is_400 x2: test_issue_radar_routes_coverage.py
  • test_an_unconnected_repo_is_404_before_the_permission_gate x2: test_issue_radar_routes_coverage_label_and_issue_writes.py
  • test_the_watcher_fires_only_on_completion x2: test_main_macos_failure_watch.py, test_scheduled_failure_watch.py
  • test_the_declared_set_matches_what_is_advertised x2: test_mcp_crew_log.py, test_mcp_debug.py
  • test_non_member_session_is_untouched x2: test_member_dispatch_mount.py, test_member_panel_mount.py
  • test_kiro_backend_is_untouched x2: test_member_dispatch_mount.py, test_member_panel_mount.py
  • test_returns_none_when_nothing_is_installed (+1 names) x2: test_papyrus_latex.py, test_papyrus_tectonic.py
  • test_prompt_drives_patrol_with_monitor_start_not_wait x2: test_pipeline_conductor_agent.py, test_security_conductor_agent.py
  • test_a_siblings_clean_check_run_does_not_pass_this_pr x2: test_pr_readiness_evaluate.py
  • test_a_previous_attempts_clean_check_run_does_not_pass_a_rerun x2: test_pr_readiness_evaluate.py
  • test_the_template_origin_keeps_auto_maintenance_off x2: test_preflight_write_permission.py, test_push_guard.py
  • test_ships_in_warn_mode x2: test_proof_line_check.py, test_sibling_list_check.py
  • test_enforcement_applies_to_pull_requests_opened_on_or_after_the_date x2: test_proof_line_check.py, test_sibling_list_check.py
  • test_the_signature_digest_ignores_an_object_address_in_either_spelling x2: test_runtime_bindings.py, test_session_handle_bindings.py
  • test_the_bound_function_scans_include_every_static_method x2: test_runtime_bindings.py, test_session_handle_bindings.py
  • test_sandbox_exec_not_found_returns_false (+1 names) x2: test_sandbox_probe.py
  • test_operator_extension_corpus_default_config_rejects (+1 names) x2: test_security_oauth_urls.py
  • test_the_field_scan_counts_every_read_and_write_shape x2: test_sel_bindings.py, test_session_map_bindings.py
  • test_no_bound_function_needs_its_class_body x2: test_session_allocation_bindings.py, test_skills_bindings.py
  • test_the_bound_function_scans_include_every_static_method x2: test_session_lifecycle_bindings.py, test_taskrunner_bindings.py
  • test_the_runtime_package_holds_exactly_the_composed_modules x2: test_skills_composition_contract.py, test_vector_memory_composition_contract.py
  • test_the_package_ships_with_the_wheel x2: test_skills_composition_contract.py, test_vector_memory_composition_contract.py
  • test_the_package_init_imports_nothing x2: test_skills_composition_contract.py, test_vector_memory_composition_contract.py
  • test_no_runtime_module_reads_a_seam_as_a_bare_global x2: test_skills_composition_contract.py, test_vector_memory_composition_contract.py
  • test_no_runtime_module_defines_an_async_function x2: test_skills_composition_contract.py, test_vector_memory_composition_contract.py
  • test_a_construct_a_guard_reads_stays_where_the_guard_reads_it x2: test_slack_gateway_composition_contract.py, test_slack_handler_composition_contract.py
  • test_a_refused_subdirectory_is_skipped_and_recorded (+1 names) x2: test_snapshot_unreadable_entries.py
  • test_a_refused_subdirectory_is_skipped_on_the_by_name_walk (+1 names) x2: test_snapshot_unreadable_entries.py
  • test_row_is_registered_as_a_default_on_capability x2: test_social_share_governance.py, test_tailnet_governance.py
  • test_the_budget_alone_hands_the_reader_the_key x2: test_split_credential_boundary_channel_delivery.py, test_split_credential_boundary_rotation_and_tally.py
  • test_the_kind_reader_tells_a_coroutine_from_a_function x2: test_store_parts_bindings.py, test_store_taskq_bindings.py
  • test_each_member_keeps_its_kind_signature_and_owner x2: test_store_parts_bindings.py, test_store_taskq_bindings.py
  • test_each_owner_imports_only_owners_listed_before_it x2: test_store_parts_bindings.py, test_store_taskq_bindings.py
  • test_each_owner_names_the_fields_it_writes_and_reads x2: test_store_parts_bindings.py, test_store_taskq_bindings.py
  • test_help_command x2: test_teams_dispatch.py, test_webex_dispatch.py
  • test_every_base_name_still_resolves x2: test_transport_dispatch_composition.py, test_transport_dispatch_webex_composition.py
  • test_a_moved_name_is_its_owners_object x2: test_transport_dispatch_composition.py, test_transport_dispatch_webex_composition.py
  • test_the_mirror_serves_exactly_the_moved_names_the_facade_does_not_bind x2: test_transport_dispatch_composition.py, test_transport_dispatch_webex_composition.py
  • test_the_owner_list_is_the_layer_order_and_names_every_owner_on_disk x2: test_transport_dispatch_composition.py, test_transport_dispatch_webex_composition.py
  • test_no_owner_takes_a_sync_io_module_through_a_from_import x2: test_transport_dispatch_composition.py, test_transport_dispatch_webex_composition.py
  • test_the_sync_io_gate_reports_a_blocking_call_planted_in_each_coroutine_owner x2: test_transport_dispatch_composition.py, test_transport_dispatch_webex_composition.py
  • test_no_owner_holds_what_the_facade_guards_read_by_path x2: test_transport_dispatch_composition.py, test_transport_dispatch_webex_composition.py
  • test_conversation_state x2: test_webex_dispatch.py, test_wecom_dispatch.py
  • test_parse_mid_turn_override x2: test_webex_dispatch.py, test_wecom_commands_and_ingest.py
  • test_a_bare_override_is_recognized (+1 names) x2: test_webex_dispatch.py, test_wecom_commands_and_ingest.py
  • test_a_complete_or_unrelated_message_is_not_a_bare_override (+1 names) x2: test_webex_dispatch.py, test_wecom_commands_and_ingest.py

@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners October 26, 2026 22:53
@iamwhatever
iamwhatever requested a review from CrysisDeu October 26, 2026 22:53
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 26, 2026
@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 967e57e65288f084b3192bf2f679c6b4b501ccc4 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 967e57e65288f084b3192bf2f679c6b4b501ccc4 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 967e57e65288f084b3192bf2f679c6b4b501ccc4 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the change only touches tests, a revert undoes it cleanly, and nothing outside the patch reads a renamed test except the doc this PR updates.

Notes

  • named_cases copies pytest's own param-id rules in _value_id/_auto_id, so a later pytest change to how it builds ids would make the old ids drift without any failure. Once the batches finish and CI history no longer needs the old ids, the merged tests could use plain ids= instead.

[DESIGN-REVIEWED] 967e57e

Description read

[DESCRIPTION-READ] e4bb005a7122cbaa4e5eb79806c65f7aeceae24a9c0a0bf0f2d8f286babbe3a2

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 967e57e65288f084b3192bf2f679c6b4b501ccc4 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 967e57e

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 967e57e65288f084b3192bf2f679c6b4b501ccc4 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 967e57e65288f084b3192bf2f679c6b4b501ccc4 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 967e57e

Verdict parsed from the review's SHA-scoped output markers for commit 967e57e65288f084b3192bf2f679c6b4b501ccc4.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 967e57e65288f084b3192bf2f679c6b4b501ccc4 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 27, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

CI disposition: Backend Tests (Windows) (6) is red because of main, not this PR.

The failures are in test/test_slack_team_id_env.py::TestSpawnEnv (FileNotFoundError: [WinError 2]), a file this PR does not touch. Main has the same red since #22380; it is tracked in #24612, and #24613 fixes it. I will rebase onto main once #24613 lands.

Sixty-one groups of tests in one file share a body word for word and
differ only in parametrize data. Each group becomes one parametrized
test; named_cases keeps every case and ids it <old name>-<old param id>,
so all 899 changed ids map one to one and keep their marks. Duplicate
body groups drop from 286 to 225.
@iamwhatever
iamwhatever force-pushed the test-cleanup/twins-same-file branch from 8ca6b53 to 967e57e Compare October 27, 2026 01:21
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 27, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Rebased onto main 8a518e121b, which carries #24609 (the test_slack_team_id_env.py Windows fix behind the shard 6 red). New head 967e57e652. Main did not touch any of this PR's files in between. The touched files rerun green locally (4,890 passed, 2 skipped), and CI is re-running.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 27, 2026
@chenmingwei23
chenmingwei23 merged commit f12a0cf into main Oct 27, 2026
107 checks passed
@chenmingwei23
chenmingwei23 deleted the test-cleanup/twins-same-file branch October 27, 2026 06:03
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants