Repository navigation
fix(dashboard): open the row the Skills, Steering and Prompts filters name - #24771
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: one shared helper fixes the auto-pick rule in all three tabs, and the screenshots match the stated behaviour. Notes
[DESIGN-REVIEWED] 7dddc0d Description read[DESCRIPTION-READ] 971ea93e550fd33a5b6c5441f8f37e0f4a9b188e6cc6b5eb2b96323d59ebeab9 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. All three tabs now use one helper, so the fix covers the cause, the auto-pick rule they shared, and every sibling is accounted for. Notes
What this change shipsInventory (6 items) — 5 justifiedIntent: make typing a name in a Customize list filter open that row instead of the first row whose description mentions it. FIX (#20262).
[FIRST-PRINCIPLES-REVIEWED] 7dddc0d Description read[DESCRIPTION-READ] 1b97f821eac2b103f4524264a0f42295b71fdf9f65c01d82ddd9a3f817e78aca That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the PR adds no controls or copy, and it only changes which row opens by itself. The before and after screenshots show that row. Notes
[UX-REVIEWED] 7dddc0d Description read[DESCRIPTION-READ] 5128bdfaa07317a22adcd0d2e8864423c0b23c6352cb1cc9b44eca3aa1d8cddd That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
0dad77d to
86ed694
Compare
86ed694 to
cba4560
Compare
cba4560 to
4cbdf10
Compare
… name The auto-pick took the first visible row, and both filters also match descriptions, so typing "widgets" opened Artifacts. It now opens the best name or key match; a row the user clicked stays open while still listed. Closes #20262
4cbdf10 to
7dddc0d
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Tier 1 auto-approve: fix (7 files). Criteria: no conflict, no requested changes, security path denylist clean, design-doc gate clean, security checklist all-NO, no reviewer-lane findings, readiness signal fresh for this head SHA, declared category matches the diff. Category: dashboard Skills, Steering and Prompts tabs open the best filter match unless the user picked a row, plus tests.
Problem / Motivation
Goal: When you type in the Skills or Steering filter, the page opens the row you typed, not just the first row it shows.
On Customize › Skills, typing "widgets" left two rows, Artifacts and Widgets, and opened Artifacts on the right. Artifacts is listed because its description mentions widgets. The user had to stop and check which skill they were looking at. The Steering tab does the same.
Why it matters
The filter is how people find one skill or steering file. Opening a different one makes the filter look broken and slows every first-time user down; the nightly GUI user test hit it three times.
Not a goal
What changed (motivation → approach → change)
The Skills, Steering and Prompts tabs open a row on their own so the right pane is never empty. That auto-pick always took the first visible row, and each filter also matches descriptions, so the first row can be one that only mentions the query.
Now the auto-pick takes the best match for the filter text:
A row the user clicked stays open while the filter still shows it. The shared rule lives in
website/src/utils/filterSelection.ts;SkillsTab.tsx,SteeringTab.tsxandPromptsTab.tsxcall it.Backwards compatibility
Compatible: the list, its order and the empty-filter default are unchanged; only which row opens by itself while filtering moves.
Removes nothing: no row, field, route or key is hidden or removed.
Tests
website/src/test/SkillsTabFilterSelection.test.tsx: exact and partial name matches open the typed skill; a clicked skill stays open; a clicked skill that the filter hides moves to the best match; description-only matches keep the first row. Three of the five fail on main.website/src/test/SteeringTab.test.tsx: the same two cases for Steering; the name-match case fails on main.website/src/test/PromptsTab.test.tsx: the same two cases for Prompts; the name-match case fails on main.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Reverted the two components to main and re-ran the new tests: the name-match cases fail, the rest pass. Ran the Skills, Steering, Prompts, Capabilities and list-detail test files (339 tests),
tsc -p tsconfig.app.jsonand eslint on the changed files.Screenshots / video
Customize › Skills with "widgets" typed. The API is stubbed with three skills; Artifacts' description mentions widgets.
Before (main): Artifacts opens.
After: Widgets opens; Artifacts stays listed.
Related Issues
Closes #20262
Sibling sweep
Swept: git grep -nE "set(Selected|Active)[A-Za-z]((all)?[Ff]iltered[A-Za-z][0]|(all)?[Ff]iltered[0]" -- website/src/pages
Sibling: website/src/pages/overview/SteeringTab.tsx:584 -- changed here
Sibling: website/src/pages/overview/PromptsTab.tsx:432 -- changed here
Sibling: website/src/pages/chat/crew-window/crewWindowAgentMode.tsx:100 -- not affected -- Enter picks the row only when exactly one row matches
Sibling: website/src/pages/chat/crew-window/crewWindowModelPicker.tsx:86 -- not affected -- Enter picks the row only when exactly one row matches
Sibling: website/src/pages/overview/AgentTemplatesTab.tsx:604 -- not affected -- it re-picks only when the selection leaves the unfiltered list, so typing a filter never moves it
Pattern harvest
Not generalizable: the defect is one auto-select rule shared by three list tabs, and all three now use one helper.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)