Skip to content

fix(members): call the New mate card's optional field Goal - #24915

Merged
iamwhatever merged 1 commit into
mainfrom
crew/issue-triage/KiroCrew-19229
Oct 29, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
crew/issue-triage/KiroCrew-19229

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The New mate card names its optional field with the same word the mate's first message and Goals tab use: "goal".

The New mate card's optional field was labelled What it looks after. The new mate's first message then asks the user to confirm its goal, and its profile has a Goals tab. The UX review on #18805 found readers only guessed that the two names meant the same thing.

Why it matters

Every user who makes a mate meets both words in the first minute. Two names for one thing make them wonder whether they filled in the wrong field.

Not a goal

  • No change to the first message itself: it already says "goal".
  • No other copy sweep on the Mates page, the profile card or the Goals tab.
  • No change to what the field stores (still the crew record's description).
  • The crew editor: on current main it has no field for this value, so there is no label to change there.

What changed (motivation → approach → change)

Decision: the word is goal. It is the word the product already uses most for this idea: the Goals tab, the goal tools (set_goal, goal_read), the Daily Goal Reminder and the first message.

  • The card's field label (pages.membersPage.create_job in website/src/i18n/locales/*.json) changes from "What it looks after" to "Goal" in every shipped language. Each translation reuses that language's own singular word from the Goals tab (goals_goal_number), so no new translation is made up. The pseudo-locale is regenerated.
  • The docs, the GUI test scenario and the screenshot and guide scripts that quote the old label now say "Goal", as does a comment in src/kiro_crew/guide_catalog.py.

Backwards compatibility

Compatible: only a visible label and its translations change; the i18n key, the stored field and every API stay the same.

Removes nothing: the field, its key and its stored value are all kept; only its label text changes.

Tests

  • New website/src/pages/members/crewmateGoalWording.test.ts: for every shipped language, the card label (create_job) must equal the singular goal word of the Goals tab (goals_goal_number), and English must read "Goal". On main 13 of its 14 cases fail.
  • Existing New mate card tests now find the field by "Goal".
  • Ran: crewmateGoalWording.test.ts, NewCrewmateDialog.test.tsx, MembersPage.createLinks.test.tsx, MembersPage.newCrewmate.test.tsx, MembersPage.newCrewmateOutcomes.test.tsx (133 tests, all pass), plus node scripts/i18n-check.mjs (exit 0).

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

Checked in Chromium against a production build of the capture/crewmates-page-create.html harness (stubbed API, served on 127.0.0.1 by vite preview): the New mate card opens from the empty roster, Advanced settings unfolds, the field reads "Goal · optional", and "What it looks after" appears nowhere in the card. Dark and light both.

Screenshots / video

New mate card, Advanced settings unfolded, Goal field filled, dark then light:

New mate card, Advanced settings, Goal field, dark theme

New mate card, Advanced settings, Goal field, light theme

Related Issues

Closes #19229

Sibling sweep

Swept: git grep -n "looks after" -- ':!docs/request-for-change'
Sibling: website/src/pages/members/NewCrewmateDialog.tsx -- changed here
Sibling: src/kiro_crew/docs/crew-members.md -- changed here
Sibling: docs/system-specs/modules/crew-mode.md -- changed here
Sibling: docs/feature-map/README.md -- changed here
Sibling: CHANGELOG.md -- not affected -- a past release entry, kept as history

Pattern harvest

Not generalizable: one label picked before the goal feature named the idea; the new test pins this label to the Goals tab word.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 2a7bc7f7e2eca396369d18fbd8bb9cf342199ed4 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: the relabel names who was confused (the UX review on #18805, issue #19229), it changes no default or stored field, and every other item only follows the new label.

What this change ships

Inventory (4 items) — 4 justified

Intent: A person making a new mate should see the same word, "Goal", on the card's optional field as in the mate's first message and on its Goals tab. FIX.

  1. The New mate card's optional field now reads "Goal" instead of "What it looks after", in every shipped language — justified
  2. Docs, the GUI scenario, the screenshot scripts and the guide-catalog comment now say "Goal" — justified
  3. Existing New mate card tests now find the field by "Goal" — justified
  4. A new test pins each language's card label to the singular word on its Goals tab — justified

[FIRST-PRINCIPLES-REVIEWED] 2a7bc7f

Description read

[DESCRIPTION-READ] 7dbb1582f8eab623ed3b4b8b7a61fe10489396ae378430cfdc8d0ac2572ae324

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 2a7bc7f7e2eca396369d18fbd8bb9cf342199ed4 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Only the label text changes. Both screenshots show "Goal · optional", and the blind reader correctly read it as the plain-language goal for the mate, without being told that's what it was for.

[UX-REVIEWED] 2a7bc7f

Description read

[DESCRIPTION-READ] 510e2a719e1429924e7e7166d8af564d2e50e2f5ebbec4f34b7cdde1d4d02b0d

That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 2a7bc7f7e2eca396369d18fbd8bb9cf342199ed4 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Only a label changes. The card now uses the word "goal", which the first message and the Goals tab already use. The new test ties each language's label to its Goals-tab word, and screenshots of this revision are attached.

[DESIGN-REVIEWED] 2a7bc7f

Description read

[DESCRIPTION-READ] 6155deeadd363033305f53e7ee99d086564acb00aa4bfd52adc01aabf6d378d6

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 2a7bc7f7e2eca396369d18fbd8bb9cf342199ed4 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 2a7bc7f

Verdict parsed from the review's SHA-scoped output markers for commit 2a7bc7f7e2eca396369d18fbd8bb9cf342199ed4.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 2a7bc7f7e2eca396369d18fbd8bb9cf342199ed4 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 2a7bc7f7e2eca396369d18fbd8bb9cf342199ed4 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 2a7bc7f

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 2a7bc7f7e2eca396369d18fbd8bb9cf342199ed4 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 27, 2026
@iamwhatever
iamwhatever enabled auto-merge (squash) October 27, 2026 18:20
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Status at head eda5c6797dfc: every check except Screenshot Evidence passes (105/106, readiness passed).

This is a copy-only change: the New mate card's optional field label changes from "What it looks after" to "Goal", in every shipped language. No layout, key or stored value changes.

Screenshot Evidence is red because there is no image. The capture script website/scripts/capture-crewmates-page-create.mjs cannot fire load on this host: its first page timed out at 30 s, and again at 15 min with a local timeout bump. A warm-up load of the same URL on the same dev server takes 4 s, so the server itself works.

A maintainer is asked to either attach a screenshot of the card's Advanced settings ("Goal · optional"), or apply no-screenshots.

🤖 AI-assisted comment 🤖

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 27, 2026
@iamwhatever
iamwhatever force-pushed the crew/issue-triage/KiroCrew-19229 branch from eda5c67 to f16d571 Compare October 27, 2026 19:25
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Oct 27, 2026
@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Oct 27, 2026
@iamwhatever
iamwhatever force-pushed the crew/issue-triage/KiroCrew-19229 branch from f16d571 to 4fee170 Compare October 28, 2026 16:30
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 28, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

Screenshots are now in the PR description, and Screenshot Evidence is green on head 4fee170cf7.

They show the New mate card with Advanced settings unfolded and the field labelled "Goal · optional", in dark and light themes. I captured them in Chromium from a production build of the capture/crewmates-page-create.html page (API stubbed), served with vite preview on 127.0.0.1. "What it looks after" no longer appears anywhere in the card.

This covers the maintainer ask in #24915 (comment). No no-screenshots label is needed.

🤖 AI-assisted comment 🤖

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 28, 2026
@iamwhatever
iamwhatever force-pushed the crew/issue-triage/KiroCrew-19229 branch from 4fee170 to 9eb433a Compare October 28, 2026 21:08
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 28, 2026
@iamwhatever
iamwhatever force-pushed the crew/issue-triage/KiroCrew-19229 branch from 9eb433a to 2a7bc7f Compare October 28, 2026 23:57
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 28, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of the watch holder (bolichen). Design and First Principles pass on this head (or skipped for docs only), UX skipped or pass, all checks green, no conflict, no open change request.

@iamwhatever
iamwhatever merged commit eef83a8 into main Oct 29, 2026
107 checks passed
@iamwhatever
iamwhatever deleted the crew/issue-triage/KiroCrew-19229 branch October 29, 2026 00:47
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use one word for a crewmate's goal on the card, editor and first message

2 participants