Repository navigation
fix(members): call the New mate card's optional field Goal - #24915
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: the relabel names who was confused (the UX review on #18805, issue #19229), it changes no default or stored field, and every other item only follows the new label. What this change shipsInventory (4 items) — 4 justifiedIntent: A person making a new mate should see the same word, "Goal", on the card's optional field as in the mate's first message and on its Goals tab. FIX.
[FIRST-PRINCIPLES-REVIEWED] 2a7bc7f Description read[DESCRIPTION-READ] 7dbb1582f8eab623ed3b4b8b7a61fe10489396ae378430cfdc8d0ac2572ae324 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Only the label text changes. Both screenshots show "Goal · optional", and the blind reader correctly read it as the plain-language goal for the mate, without being told that's what it was for. [UX-REVIEWED] 2a7bc7f Description read[DESCRIPTION-READ] 510e2a719e1429924e7e7166d8af564d2e50e2f5ebbec4f34b7cdde1d4d02b0d That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Only a label changes. The card now uses the word "goal", which the first message and the Goals tab already use. The new test ties each language's label to its Goals-tab word, and screenshots of this revision are attached. [DESIGN-REVIEWED] 2a7bc7f Description read[DESCRIPTION-READ] 6155deeadd363033305f53e7ee99d086564acb00aa4bfd52adc01aabf6d378d6 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Status at head This is a copy-only change: the New mate card's optional field label changes from "What it looks after" to "Goal", in every shipped language. No layout, key or stored value changes. Screenshot Evidence is red because there is no image. The capture script A maintainer is asked to either attach a screenshot of the card's Advanced settings ("Goal · optional"), or apply 🤖 AI-assisted comment 🤖 |
eda5c67 to
f16d571
Compare
f16d571 to
4fee170
Compare
|
Screenshots are now in the PR description, and Screenshot Evidence is green on head They show the New mate card with Advanced settings unfolded and the field labelled "Goal · optional", in dark and light themes. I captured them in Chromium from a production build of the This covers the maintainer ask in #24915 (comment). No 🤖 AI-assisted comment 🤖 |
4fee170 to
9eb433a
Compare
9eb433a to
2a7bc7f
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved on behalf of the watch holder (bolichen). Design and First Principles pass on this head (or skipped for docs only), UX skipped or pass, all checks green, no conflict, no open change request.
Problem / Motivation
Goal: The New mate card names its optional field with the same word the mate's first message and Goals tab use: "goal".
The New mate card's optional field was labelled What it looks after. The new mate's first message then asks the user to confirm its goal, and its profile has a Goals tab. The UX review on #18805 found readers only guessed that the two names meant the same thing.
Why it matters
Every user who makes a mate meets both words in the first minute. Two names for one thing make them wonder whether they filled in the wrong field.
Not a goal
description).What changed (motivation → approach → change)
Decision: the word is goal. It is the word the product already uses most for this idea: the Goals tab, the goal tools (
set_goal,goal_read), the Daily Goal Reminder and the first message.pages.membersPage.create_jobinwebsite/src/i18n/locales/*.json) changes from "What it looks after" to "Goal" in every shipped language. Each translation reuses that language's own singular word from the Goals tab (goals_goal_number), so no new translation is made up. The pseudo-locale is regenerated.src/kiro_crew/guide_catalog.py.Backwards compatibility
Compatible: only a visible label and its translations change; the i18n key, the stored field and every API stay the same.
Removes nothing: the field, its key and its stored value are all kept; only its label text changes.
Tests
website/src/pages/members/crewmateGoalWording.test.ts: for every shipped language, the card label (create_job) must equal the singular goal word of the Goals tab (goals_goal_number), and English must read "Goal". On main 13 of its 14 cases fail.crewmateGoalWording.test.ts,NewCrewmateDialog.test.tsx,MembersPage.createLinks.test.tsx,MembersPage.newCrewmate.test.tsx,MembersPage.newCrewmateOutcomes.test.tsx(133 tests, all pass), plusnode scripts/i18n-check.mjs(exit 0).Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
Checked in Chromium against a production build of the
capture/crewmates-page-create.htmlharness (stubbed API, served on 127.0.0.1 byvite preview): the New mate card opens from the empty roster, Advanced settings unfolds, the field reads "Goal · optional", and "What it looks after" appears nowhere in the card. Dark and light both.Screenshots / video
New mate card, Advanced settings unfolded, Goal field filled, dark then light:
Related Issues
Closes #19229
Sibling sweep
Swept: git grep -n "looks after" -- ':!docs/request-for-change'
Sibling: website/src/pages/members/NewCrewmateDialog.tsx -- changed here
Sibling: src/kiro_crew/docs/crew-members.md -- changed here
Sibling: docs/system-specs/modules/crew-mode.md -- changed here
Sibling: docs/feature-map/README.md -- changed here
Sibling: CHANGELOG.md -- not affected -- a past release entry, kept as history
Pattern harvest
Not generalizable: one label picked before the goal feature named the idea; the new test pins this label to the Goals tab word.
Checklist