Repository navigation
refactor(crew): remove the ghost-face picker from the avatar builder - #24932
IngridMorstrad wants to merge 1 commit into
Conversation
2b88b48 to
7b74921
Compare
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
First Principles Review (Opus 5.5, fork) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK product-shape change without accepted RFC: the PR removes the ghost-face builder and the Reactions authoring, which existing users had. No RFC on the base records that decision, and no maintainer override exists for this head. What this change shipsInventory (9 items) — 7 justifiedIntent: make the Icon tier the only way to author a crewmate's avatar, while existing ghost faces keep rendering. This is an ADDITION (the removal of a capability).
Blockersproduct-shape change without accepted RFC — removal of a user-facing capability (items 1–2) [FIRST-PRINCIPLES-REVIEWED] 1c4c247 Description read[DESCRIPTION-READ] 88264e3e745200a127c4f10481104271d81971603c6ad90ba9b63511ea450a6e That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5, fork) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing the rewritten reaction notices on the Picture and Library panes. This PR changes their copy, but no screenshot shows either pane. Evidence gaps
Notes
[UX-REVIEWED] 1c4c247 Description read[DESCRIPTION-READ] 6987e18618de6dae21d8dbc50504e7a0a0d475cfad34811a9ef4a399cf46794f That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. The PR removes an authoring entry point, not data. A stored ghost is still accepted, renders unchanged and is returned as-is on Apply with no pick. The removed Notes
[DESIGN-REVIEWED] 1c4c247 Description read[DESCRIPTION-READ] 7f8f1ccf3cae74cf82174dd1b355799b4897c78f4d3cd75e4c7198a84bf940d7 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
Security Scope Review (fork) — 🔴 BLOCK (blocking)Which legitimate operations does the review scope was never resolved: the generate job did not finish (it timed out, failed or was cancelled), so no leg ran; its log names the step that stopped No |
2a93a34 to
a58dd7a
Compare
a58dd7a to
50bafad
Compare
|
The remaining red check is First Principles' product-shape gate, not a code finding. Its only Blocker clears through either an accepted RFC covering the removal of ghost-face and reaction editing for existing ghost crewmates, or a maintainer posting For context: #16232 shipped the Icon tier and said "Hiding the ghost tabs from new users is a deliberate follow-up PR." Issue #18616 is that follow-up, and this PR implements it. Avatars already stored as ghosts still render unchanged. The data model, validator and renderer are untouched, and opening the editor without picking keeps the stored ghost as-is. Every other review and check on this head is green. |
50bafad to
f35bb07
Compare
f35bb07 to
fb3ddc3
Compare
fb3ddc3 to
6ab160d
Compare
6ab160d to
067fbd5
Compare
067fbd5 to
d62feba
Compare
Closes kirodotdev#18616 The icon-avatar tier (kirodotdev#16232) shipped as the primary crewmate creator, and that PR deliberately left "hiding the ghost-face builder tabs" to a follow-up. This is that follow-up: it removes the ghost-face selection UI so a new or edited crewmate can no longer author a ghost face, and defaults every crewmate to the Icon (SVG pose + colour) tier. The ghost data model, types, API/backend fields and all rendering are kept, so crewmates already wearing a ghost face render exactly as before, with no migration. - `CrewAvatarBuilder` no longer offers the "Ghost face" tier tab or its "Reactions" sub-tab, in either the create or the edit flow. - Every crewmate opens on the Icon tier: `tierOf()` returns `icon` for a stored ghost record, so an existing ghost crewmate now lands on Icon too. - A stored ghost is kept and the preview matches what Apply saves. On the Icon tier a ghost crewmate that has not picked yet previews its stored ghost through the real renderer (not a seeded pose) and highlights no pose/colour; Apply with no pick hands the stored ghost back verbatim. Only an actual pose or colour pick replaces it. A `didReset` flag (separate from `resetToDefault`, which a tier switch clears) makes a Reset survive a tier detour, so the keep-the-stored-ghost shortcut cannot resurrect a ghost the user reset. - Reset lands every crew on the Icon tier; a ghost crew still undresses to its name-derived face (`null`) via the reset path. - Removed the now-unused `mode_face` / `mode_reactions` tab strings, and dropped the "Switch to Ghost face" / "Reactions belong to the ghost face" references from the picture/pack reaction notices (`react_absent_note`, `react_retired_cue_note_picture`, `react_retired_cue_note_pack`) across every locale, since that tab no longer exists. Removed the now-unused `Ghost` / `Sparkles` lucide imports. - Deleted the authoring code the removed tabs were the only way to reach: the face and Reactions pane bodies, the trait/motion/sound helpers, the per-state reaction row, the ghost-building tail of `buildResult`, the now-unused `savedReactions` prop (and its one caller in `CrewEditorNextDialog`), and the 70 catalog keys only that UI used (`axis_*`, `opt_*`, `motion_*`, `sound_*`, `react_hint`/`react_motion`/`react_sound`/`react_reset_state`, `randomize`, `mirror`) in every locale, plus their translator notes. Stored ghost records, their types, validator and renderer are untouched. - Tests: `CrewAvatarBuilder.test.tsx` asserts the new create/edit behaviour, the stored-ghost edge case, the preview-matches-Apply rule, and that a Reset survives a tier detour. The obsolete ghost/reactions authoring tests (which drove the removed tabs) were pruned; the still-reachable picture/pack reaction-notice tests were updated to the new copy. - Docs: the owning specs (`config.md`, `learn-cron-dashboard.md`) and the feature map now say the Ghost face tier and its Reactions tab are gone in every flow, that a stored ghost is kept as-is and opens on Icon, and that Apply with no pick returns it unchanged. The builder is the single shared create/edit avatar component. Its tier strip, tier resolution, and Icon-pane preview change; the ghost record readers and the `CrewAvatar` renderer are untouched. ``` CrewAvatarBuilder.tsx (tier strip: Icon | Picture | Library; ghost tab removed) ├─ tierOf() ghost record → opens on Icon ├─ Icon pane ghost + unpicked → previews stored ghost via CrewAvatar, │ no pose selected (preview matches Apply) ├─ buildResult() ghost + unpicked + not reset → returns ghost verbatim; │ ghost + reset → null (undress) └─ CrewAvatar.tsx (unchanged — stored ghosts render as before) i18n/locales/*.json mode_face / mode_reactions removed; ghost-tab references dropped from the picture/pack reaction notices ``` None. No data model, type, or backend field changed; stored ghost records are read and rendered exactly as before and are never migrated. - `CrewAvatarBuilder.test.tsx`, `.reactions.test.tsx`, `.library.test.tsx`, `CrewEditorNextDialog.test.tsx`, `CrewRoster.test.tsx`, `NewCrewmateDialog.test.tsx` — all green (191 tests). - Red/green proof: against origin/main the new edge-case tests fail for the right reason (a stored ghost crew opens on the ghost face pane, so `avatar-icon-pane` and the icon pose grid are absent); green on the fix. - Local gates green: typecheck, eslint, the full i18n gate chain (keys/parity/dead-keys/pseudo/strings). Compatible. Stored ghost-face crewmates keep their records and render identically; nothing is migrated or rewritten. The user-visible change is that the ghost-face authoring tabs are gone, the builder opens on the Icon tier, and a ghost crewmate can no longer edit its ghost face or its reaction motions/sounds from this dialog — its stored ghost is kept and still renders, and Reset still returns it to the name-derived default. None. This is a UI-surface removal with no new I/O or runtime cost.
d62feba to
1c4c247
Compare
|
Stale-PR triage: code and every other check are green on If a maintainer signs off, the exact override for the current head is: Otherwise, the alternative is to narrow this PR to keep the Ghost face tab for existing ghost crews. |
|
Closing this. As the triage noted, main already covers the safe scope via #20392: the Ghost face tab is hidden for new crews and kept for crewmates already wearing a ghost. Narrowing this PR would make it identical to main, and the full removal needs a product sign-off that isn't worth a maintainer's time for this small change. Thanks for the review. |
Problem / Motivation
Goal: A crewmate can no longer build or set a ghost face in the avatar editor, and every crewmate's avatar editor opens on the Icon (SVG pose + colour) tier.
The icon-avatar tier (#16232) shipped as the primary crewmate creator, and that
PR deliberately left "hiding the ghost-face builder tabs from new users" to a
later PR. Today the ghost-face builder (the "捏脸" trait tabs + its Reactions
layer) is still offered beside the Icon tier, so a user creating or editing a
crewmate can still hand-build a ghost face. #18616 asks for this follow-up.
Why it matters
The icon tier is the intended primary creator; leaving the ghost-face builder
reachable keeps two parallel ways to set an identity, one of which the product
is moving away from. Removing the picker makes the Icon tier the single creation
path while leaving existing ghost crewmates' stored faces intact and rendering.
Not a goal
rendering exactly as before.
CrewAvatar).ghost face or its reaction motions/sounds from this dialog (see Backwards
compatibility). Base left that path open for ghost-wearing crews; Remove ghost-face icon picker UI from crewmate create/edit; default new mates to SVG icon + colour #18616 is
the decision to close it. The stored ghost is kept and still renders; only the
authoring entry point is gone. Not rebuilding an equivalent editor on another
tier is intentional, not an oversight.
What changed (motivation → approach → change)
The ghost-face picker was the ghost tier's tab plus its Reactions sub-tab in the
one shared create/edit component (
CrewAvatarBuilder). Approach: remove thosetwo tabs, open every crew (including an existing ghost one) on the Icon tier, and
keep a stored ghost verbatim so nothing is migrated — with the Icon pane's
preview showing that stored ghost so it matches what Apply saves.
CrewAvatarBuilderno longer renders the "Ghost face" tier tab or its"Reactions" sub-tab, in either flow.
tierOf()opens a ghost record on Icon.Preview matches Apply: a ghost crewmate that has not picked previews its stored
ghost through the real renderer (not a seeded pose) and highlights no
pose/colour; Apply with no pick returns the stored ghost verbatim. A
didResetflag (separate from
resetToDefault, which a tier switch clears) makes a Resetsurvive a tier detour, so the keep-the-ghost shortcut cannot resurrect a ghost
the user reset.
Removed the now-unused
mode_face/mode_reactionstab strings, and droppedthe "Switch to Ghost face" / "Reactions belong to the ghost face" text from the
picture/pack reaction notices across every locale (that tab no longer exists).
Removed the now-unused
Ghost/Sparkleslucide imports.Tests updated accordingly (see Tests).
Deleted the authoring code the removed tabs were the only way to reach: the
face and Reactions pane bodies, the trait/motion/sound helpers, the per-state
reaction row, the ghost-building tail of
buildResult, the now-unusedsavedReactionsprop (and its one caller inCrewEditorNextDialog), and the70 catalog keys only that UI used (
axis_*,opt_*,motion_*,sound_*,react_hint/react_motion/react_sound/react_reset_state,randomize,mirror) in every locale, plus their translator notes. Stored ghost records,their types, validator and renderer are untouched.
Docs: the owning specs (
config.md,learn-cron-dashboard.md) and the feature map now say the Ghost face tier and its Reactions tab are gone in every flow, that a stored ghost is kept as-is and opens on Icon, and that Apply with no pick returns it unchanged.Backwards compatibility
Compatible: the ghost record, its type, and every reader of it are unchanged;
this removes an authoring entry point, not data. Readers of what is taken away:
{kind:'ghost'}record unchanged; covered by CrewAvatarBuilder.test.tsx "a stored ghost crew now opens on the Icon pane (Remove ghost-face icon picker UI from crewmate create/edit; default new mates to SVG icon + colour #18616)"editingAgent.avatarfor a ghost record; no ghost field removed, covered by CrewEditorNextDialog.test.tsxCapability removed (accepted, per Not a goal): an existing ghost crewmate can no
longer edit its ghost face or its reaction motions/sounds from this dialog. Its
stored ghost is kept and still renders; Reset still returns it to the
name-derived default.
Tests
CrewAvatarBuilder.test.tsx,.reactions.test.tsx,.library.test.tsx,CrewEditorNextDialog.test.tsx,CrewRoster.test.tsx,NewCrewmateDialog.test.tsx— all green (191 tests). New
#18616tests lock in: no Ghost face/Reactions tabin either flow; a ghost crew opens on Icon with its stored ghost kept until a
pick; the Icon pane previews the stored ghost and selects no pose (preview
matches Apply); and a Reset survives a tier detour (commits null, not the ghost).
Proof: not provable -- frontend test (prove.py runs Python only)
Red/green evidence (new edge-case tests, production reverted to origin/main):
Green on the fix. Local gates also green: typecheck, eslint, the full i18n gate
chain (keys/parity/dead-keys/pseudo/strings).
Manual verification
N/A — covered by the component tests plus the committed before/after screenshots
below.
Screenshots / video
Committed under
temp-screenshots/18616-ghost-face-picker-removed/(fork PR, socommitted rather than
--attach). Captured pod-free against the built SPA viawebsite/scripts/capture-18616-ghost-face-picker-removed.mjs.Before — editing a ghost crew on
mainopens on the Ghost face pane; stripshows
Icon | Ghost face | Picture | Library | Reactions:After — the same ghost crew opens on Icon; strip shows only
Icon | Picture | Library; the pane previews the stored ghost (matching whatApply keeps) with no pose selected:
After — a crew with no stored avatar opens on Icon, same strip:
Related Issues
Closes #18616
Note: #18616 is
tier:T3and currently carries no triage label, so the IssueGate will stay red until a maintainer marks it
triaged. That is expected for aT3 and is not something this PR can resolve.