Skip to content

refactor(crew): remove the ghost-face picker from the avatar builder - #24932

Closed
IngridMorstrad wants to merge 1 commit into
kirodotdev:mainfrom
IngridMorstrad:fix/18616-remove-ghost-face-picker
Closed

IngridMorstrad wants to merge 1 commit into
kirodotdev:mainfrom
IngridMorstrad:fix/18616-remove-ghost-face-picker

Conversation

@IngridMorstrad

@IngridMorstrad IngridMorstrad commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A crewmate can no longer build or set a ghost face in the avatar editor, and every crewmate's avatar editor opens on the Icon (SVG pose + colour) tier.

The icon-avatar tier (#16232) shipped as the primary crewmate creator, and that
PR deliberately left "hiding the ghost-face builder tabs from new users" to a
later PR. Today the ghost-face builder (the "捏脸" trait tabs + its Reactions
layer) is still offered beside the Icon tier, so a user creating or editing a
crewmate can still hand-build a ghost face. #18616 asks for this follow-up.

Why it matters

The icon tier is the intended primary creator; leaving the ghost-face builder
reachable keeps two parallel ways to set an identity, one of which the product
is moving away from. Removing the picker makes the Icon tier the single creation
path while leaving existing ghost crewmates' stored faces intact and rendering.

Not a goal

  • Does NOT change the ghost data model, types, API or backend fields.
  • Does NOT migrate or rewrite any stored ghost-face crewmate; they keep
    rendering exactly as before.
  • Does NOT touch the ghost rendering code (CrewAvatar).
  • Deliberately REMOVES, for an existing ghost crewmate, the ability to edit its
    ghost face or its reaction motions/sounds from this dialog (see Backwards
    compatibility). Base left that path open for ghost-wearing crews; Remove ghost-face icon picker UI from crewmate create/edit; default new mates to SVG icon + colour #18616 is
    the decision to close it. The stored ghost is kept and still renders; only the
    authoring entry point is gone. Not rebuilding an equivalent editor on another
    tier is intentional, not an oversight.

What changed (motivation → approach → change)

The ghost-face picker was the ghost tier's tab plus its Reactions sub-tab in the
one shared create/edit component (CrewAvatarBuilder). Approach: remove those
two tabs, open every crew (including an existing ghost one) on the Icon tier, and
keep a stored ghost verbatim so nothing is migrated — with the Icon pane's
preview showing that stored ghost so it matches what Apply saves.

  • CrewAvatarBuilder no longer renders the "Ghost face" tier tab or its
    "Reactions" sub-tab, in either flow. tierOf() opens a ghost record on Icon.

  • Preview matches Apply: a ghost crewmate that has not picked previews its stored
    ghost through the real renderer (not a seeded pose) and highlights no
    pose/colour; Apply with no pick returns the stored ghost verbatim. A didReset
    flag (separate from resetToDefault, which a tier switch clears) makes a Reset
    survive a tier detour, so the keep-the-ghost shortcut cannot resurrect a ghost
    the user reset.

  • Removed the now-unused mode_face / mode_reactions tab strings, and dropped
    the "Switch to Ghost face" / "Reactions belong to the ghost face" text from the
    picture/pack reaction notices across every locale (that tab no longer exists).
    Removed the now-unused Ghost / Sparkles lucide imports.

  • Tests updated accordingly (see Tests).

  • Deleted the authoring code the removed tabs were the only way to reach: the
    face and Reactions pane bodies, the trait/motion/sound helpers, the per-state
    reaction row, the ghost-building tail of buildResult, the now-unused
    savedReactions prop (and its one caller in CrewEditorNextDialog), and the
    70 catalog keys only that UI used (axis_*, opt_*, motion_*, sound_*,
    react_hint/react_motion/react_sound/react_reset_state, randomize,
    mirror) in every locale, plus their translator notes. Stored ghost records,
    their types, validator and renderer are untouched.

  • Docs: the owning specs (config.md, learn-cron-dashboard.md) and the feature map now say the Ghost face tier and its Reactions tab are gone in every flow, that a stored ghost is kept as-is and opens on Icon, and that Apply with no pick returns it unchanged.

Backwards compatibility

Compatible: the ghost record, its type, and every reader of it are unchanged;
this removes an authoring entry point, not data. Readers of what is taken away:

  • Reader: website/src/components/CrewAvatar.tsx:CrewAvatar -- crew page -- renders a stored {kind:'ghost'} record unchanged; covered by CrewAvatarBuilder.test.tsx "a stored ghost crew now opens on the Icon pane (Remove ghost-face icon picker UI from crewmate create/edit; default new mates to SVG icon + colour #18616)"
  • Reader: website/src/components/CrewAvatarBuilder.tsx:buildResult -- crew page -- icon tier + unpicked + not-reset + stored ghost returns the ghost verbatim; test "applying without a pick keeps the stored ghost face unchanged"
  • Reader: website/src/components/crew/CrewEditorNextDialog.tsx:retiredCueFrom -- crew page -- still reads editingAgent.avatar for a ghost record; no ghost field removed, covered by CrewEditorNextDialog.test.tsx

Capability removed (accepted, per Not a goal): an existing ghost crewmate can no
longer edit its ghost face or its reaction motions/sounds from this dialog. Its
stored ghost is kept and still renders; Reset still returns it to the
name-derived default.

Tests

CrewAvatarBuilder.test.tsx, .reactions.test.tsx, .library.test.tsx,
CrewEditorNextDialog.test.tsx, CrewRoster.test.tsx, NewCrewmateDialog.test.tsx
— all green (191 tests). New #18616 tests lock in: no Ghost face/Reactions tab
in either flow; a ghost crew opens on Icon with its stored ghost kept until a
pick; the Icon pane previews the stored ghost and selects no pose (preview
matches Apply); and a Reset survives a tier detour (commits null, not the ghost).

Proof: not provable -- frontend test (prove.py runs Python only)

Red/green evidence (new edge-case tests, production reverted to origin/main):

× editing a stored ghost crew opens on the Icon tier
  Unable to find an element by: [data-testid="avatar-icon-pane"]   (main opens on the ghost face pane)
× a stored ghost crew that DOES pick an SVG pose saves an icon override
  Unable to find an element by: [data-testid="avatar-icon-pose-pose-3"]

Green on the fix. Local gates also green: typecheck, eslint, the full i18n gate
chain (keys/parity/dead-keys/pseudo/strings).

Manual verification

N/A — covered by the component tests plus the committed before/after screenshots
below.

Screenshots / video

Committed under temp-screenshots/18616-ghost-face-picker-removed/ (fork PR, so
committed rather than --attach). Captured pod-free against the built SPA via
website/scripts/capture-18616-ghost-face-picker-removed.mjs.

Before — editing a ghost crew on main opens on the Ghost face pane; strip
shows Icon | Ghost face | Picture | Library | Reactions:

before

After — the same ghost crew opens on Icon; strip shows only
Icon | Picture | Library; the pane previews the stored ghost (matching what
Apply keeps) with no pose selected:

after-edit

After — a crew with no stored avatar opens on Icon, same strip:

after-create

Related Issues

Closes #18616

Note: #18616 is tier:T3 and currently carries no triage label, so the Issue
Gate will stay red until a maintainer marks it triaged. That is expected for a
T3 and is not something this PR can resolve.

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running labels Oct 27, 2026
@IngridMorstrad
IngridMorstrad force-pushed the fix/18616-remove-ghost-face-picker branch from 2b88b48 to 7b74921 Compare October 27, 2026 18:19
@IngridMorstrad IngridMorstrad changed the title fix(crew): remove the ghost-face picker from the avatar builder refactor(crew): remove the ghost-face picker from the avatar builder Oct 27, 2026
@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 1c4c247d4b1bd5c343f928b192a38002b4b26d8c via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 1c4c247

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — 🔴 BLOCK

Premise-level review of 1c4c247d4b1bd5c343f928b192a38002b4b26d8c via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: BLOCK

product-shape change without accepted RFC: the PR removes the ghost-face builder and the Reactions authoring, which existing users had. No RFC on the base records that decision, and no maintainer override exists for this head.

What this change ships

Inventory (9 items) — 7 justified

Intent: make the Icon tier the only way to author a crewmate's avatar, while existing ghost faces keep rendering. This is an ADDITION (the removal of a capability).

  1. The create flow no longer offers the "Ghost face" tab — unjustified move (no recorded decision)
  2. A crew that already wears a ghost can no longer edit its face or its Reactions (motions and sounds) — unjustified move (no recorded decision)
  3. A ghost crew's builder opens on Icon instead of Ghost face — justified
  4. The Icon pane previews the stored ghost with no pose picked; Apply without a pick keeps the ghost — justified
  5. A Reset survives switching tabs, so Apply saves null and the ghost does not come back — justified
  6. The "Switch to Ghost face" wording is gone from the picture and pack notices in every locale — justified
  7. The ghost-authoring code, the savedReactions prop and 70 catalog keys are deleted — justified
  8. The specs and the feature map now describe the removal — justified
  9. A screenshot harness and committed before/after images — justified

Blockers

product-shape change without accepted RFC — removal of a user-facing capability (items 1–2)
Trigger: the description says it "Deliberately REMOVES, for an existing ghost crewmate, the ability to edit its ghost face or its reaction motions/sounds". The diff rewrites the pin still offers the Ghost face tab for a crew that already wears one, which the icon-tier PR (#16232) kept on purpose. The base RFC status list has no RFC about the avatar, ghost face or icon tier; I grepped docs/request-for-change/ and docs/decisions/ and found 0 matches. Issue #18616 is neither of the two accepted records.
Outcome: every ghost-wearing user loses face and reaction editing, and nobody has recorded that decision.
Clears when: an RFC covering removal of the ghost-face and Reactions authoring is merged on the base with a non-draft status (then push or rebase), or a maintainer posts /ai-review override first-principles 1c4c247d4b1bd5c343f928b192a38002b4b26d8c product-shape: <decision>.

[FIRST-PRINCIPLES-REVIEWED] 1c4c247

Description read

[DESCRIPTION-READ] 88264e3e745200a127c4f10481104271d81971603c6ad90ba9b63511ea450a6e

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of 1c4c247d4b1bd5c343f928b192a38002b4b26d8c via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing the rewritten reaction notices on the Picture and Library panes. This PR changes their copy, but no screenshot shows either pane.

Evidence gaps

  • react_absent_note ("A picture stays still and silent; a pack from the Library plays its own art and sound.") on the Picture/Library pane is not shown. Close it with a screenshot of the Picture pane showing the note.
  • react_retired_cue_note_picture / react_retired_cue_note_pack ("Saved sounds on this crew ({{states}}) no longer play — …") are not shown. These notices lost their only next step ("Switch to Ghost face…"). Close it with screenshots of a crew with saved sounds open on the Picture pane, and on a Library pack.

Notes

  • reset_default "Reset avatar and reactions to default" still names "reactions", which no tab in this dialog lets the user see or edit any more (attachment-01/02). Rename it to "Reset avatar to default", or add a one-line hint that saved reaction sounds reset too.
  • In attachment-02 the stored winking ghost shows on a purple preview while no swatch or pose is selected. Nothing tells the user why. A short caption like "Current look — pick a pose to replace it" under the preview would explain it.

[UX-REVIEWED] 1c4c247

Description read

[DESCRIPTION-READ] 6987e18618de6dae21d8dbc50504e7a0a0d475cfad34811a9ef4a399cf46794f

That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of 1c4c247d4b1bd5c343f928b192a38002b4b26d8c via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. The PR removes an authoring entry point, not data. A stored ghost is still accepted, renders unchanged and is returned as-is on Apply with no pick. The removed savedReactions prop and catalog keys have no readers left outside the patch.

Notes

  • Base kept the Ghost face tab open for crews already wearing a ghost, and its tests pinned that. This PR removes that path as a stated decision tied to Remove ghost-face icon picker UI from crewmate create/edit; default new mates to SVG icon + colour #18616, not as a gap. A maintainer still has to confirm the issue covers closing editing for existing ghosts, not just stopping new ones.
  • An existing ghost's motions/sounds now have no editor anywhere. A user who wants to silence a stored ghost preset can only Reset the avatar or change tier. Say this explicitly in the decision record.

[DESIGN-REVIEWED] 1c4c247

Description read

[DESCRIPTION-READ] 7f8f1ccf3cae74cf82174dd1b355799b4897c78f4d3cd75e4c7198a84bf940d7

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 1c4c247d4b1bd5c343f928b192a38002b4b26d8c via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 1c4c247

@github-actions

Copy link
Copy Markdown
Contributor

Security Scope Review (fork) — 🔴 BLOCK (blocking)

Which legitimate operations does 2b88b48d2db63c796eae0b1ed827c603b15618dc newly refuse? Model proposes, scripts/deny_diff.py decides — updated in place on each push. A script-confirmed regression blocks PR readiness.

the review scope was never resolved: the generate job did not finish (it timed out, failed or was cancelled), so no leg ran; its log names the step that stopped

No [SCOPE-REVIEWED] marker for this head was produced, so the model's text is withheld: it cannot be shown to describe this revision. See the job logs.

@IngridMorstrad
IngridMorstrad force-pushed the fix/18616-remove-ghost-face-picker branch 3 times, most recently from 2a93a34 to a58dd7a Compare October 27, 2026 20:41
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 27, 2026
@IngridMorstrad
IngridMorstrad force-pushed the fix/18616-remove-ghost-face-picker branch from a58dd7a to 50bafad Compare October 27, 2026 21:21
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 27, 2026
@IngridMorstrad

IngridMorstrad commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor Author

The remaining red check is First Principles' product-shape gate, not a code finding. Its only Blocker clears through either an accepted RFC covering the removal of ghost-face and reaction editing for existing ghost crewmates, or a maintainer posting /ai-review override first-principles <head-sha> product-shape: <decision> against the current head.

For context: #16232 shipped the Icon tier and said "Hiding the ghost tabs from new users is a deliberate follow-up PR." Issue #18616 is that follow-up, and this PR implements it. Avatars already stored as ghosts still render unchanged. The data model, validator and renderer are untouched, and opening the editor without picking keeps the stored ghost as-is.

Every other review and check on this head is green.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 27, 2026
@IngridMorstrad
IngridMorstrad force-pushed the fix/18616-remove-ghost-face-picker branch from 50bafad to f35bb07 Compare October 27, 2026 22:15
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 27, 2026
@IngridMorstrad
IngridMorstrad force-pushed the fix/18616-remove-ghost-face-picker branch from f35bb07 to fb3ddc3 Compare October 27, 2026 23:16
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 27, 2026
@IngridMorstrad
IngridMorstrad force-pushed the fix/18616-remove-ghost-face-picker branch from fb3ddc3 to 6ab160d Compare October 28, 2026 00:50
@github-actions github-actions Bot added readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention labels Oct 28, 2026
@IngridMorstrad
IngridMorstrad force-pushed the fix/18616-remove-ghost-face-picker branch from 6ab160d to 067fbd5 Compare October 28, 2026 01:28
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 28, 2026
@IngridMorstrad
IngridMorstrad force-pushed the fix/18616-remove-ghost-face-picker branch from 067fbd5 to d62feba Compare October 28, 2026 03:15
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 28, 2026
Closes kirodotdev#18616

The icon-avatar tier (kirodotdev#16232) shipped as the primary crewmate creator, and that
PR deliberately left "hiding the ghost-face builder tabs" to a follow-up. This is
that follow-up: it removes the ghost-face selection UI so a new or edited
crewmate can no longer author a ghost face, and defaults every crewmate to the
Icon (SVG pose + colour) tier. The ghost data model, types, API/backend fields
and all rendering are kept, so crewmates already wearing a ghost face render
exactly as before, with no migration.

- `CrewAvatarBuilder` no longer offers the "Ghost face" tier tab or its
  "Reactions" sub-tab, in either the create or the edit flow.
- Every crewmate opens on the Icon tier: `tierOf()` returns `icon` for a stored
  ghost record, so an existing ghost crewmate now lands on Icon too.
- A stored ghost is kept and the preview matches what Apply saves. On the Icon
  tier a ghost crewmate that has not picked yet previews its stored ghost
  through the real renderer (not a seeded pose) and highlights no pose/colour;
  Apply with no pick hands the stored ghost back verbatim. Only an actual pose
  or colour pick replaces it. A `didReset` flag (separate from `resetToDefault`,
  which a tier switch clears) makes a Reset survive a tier detour, so the
  keep-the-stored-ghost shortcut cannot resurrect a ghost the user reset.
- Reset lands every crew on the Icon tier; a ghost crew still undresses to its
  name-derived face (`null`) via the reset path.
- Removed the now-unused `mode_face` / `mode_reactions` tab strings, and dropped
  the "Switch to Ghost face" / "Reactions belong to the ghost face" references
  from the picture/pack reaction notices (`react_absent_note`,
  `react_retired_cue_note_picture`, `react_retired_cue_note_pack`) across every
  locale, since that tab no longer exists. Removed the now-unused `Ghost` /
  `Sparkles` lucide imports.
- Deleted the authoring code the removed tabs were the only way to reach: the
  face and Reactions pane bodies, the trait/motion/sound helpers, the per-state
  reaction row, the ghost-building tail of `buildResult`, the now-unused
  `savedReactions` prop (and its one caller in `CrewEditorNextDialog`), and the
  70 catalog keys only that UI used (`axis_*`, `opt_*`, `motion_*`, `sound_*`,
  `react_hint`/`react_motion`/`react_sound`/`react_reset_state`, `randomize`,
  `mirror`) in every locale, plus their translator notes. Stored ghost records,
  their types, validator and renderer are untouched.
- Tests: `CrewAvatarBuilder.test.tsx` asserts the new create/edit behaviour, the
  stored-ghost edge case, the preview-matches-Apply rule, and that a Reset
  survives a tier detour. The obsolete ghost/reactions authoring tests (which
  drove the removed tabs) were pruned; the still-reachable picture/pack
  reaction-notice tests were updated to the new copy.

- Docs: the owning specs (`config.md`, `learn-cron-dashboard.md`) and the feature map now say the Ghost face tier and its Reactions tab are gone in every flow, that a stored ghost is kept as-is and opens on Icon, and that Apply with no pick returns it unchanged.

The builder is the single shared create/edit avatar component. Its tier strip,
tier resolution, and Icon-pane preview change; the ghost record readers and the
`CrewAvatar` renderer are untouched.

```
CrewAvatarBuilder.tsx  (tier strip: Icon | Picture | Library; ghost tab removed)
  ├─ tierOf()          ghost record → opens on Icon
  ├─ Icon pane         ghost + unpicked → previews stored ghost via CrewAvatar,
  │                    no pose selected (preview matches Apply)
  ├─ buildResult()     ghost + unpicked + not reset → returns ghost verbatim;
  │                    ghost + reset → null (undress)
  └─ CrewAvatar.tsx    (unchanged — stored ghosts render as before)
i18n/locales/*.json    mode_face / mode_reactions removed; ghost-tab references
                       dropped from the picture/pack reaction notices
```

None. No data model, type, or backend field changed; stored ghost records are
read and rendered exactly as before and are never migrated.

- `CrewAvatarBuilder.test.tsx`, `.reactions.test.tsx`, `.library.test.tsx`,
  `CrewEditorNextDialog.test.tsx`, `CrewRoster.test.tsx`,
  `NewCrewmateDialog.test.tsx` — all green (191 tests).
- Red/green proof: against origin/main the new edge-case tests fail for the
  right reason (a stored ghost crew opens on the ghost face pane, so
  `avatar-icon-pane` and the icon pose grid are absent); green on the fix.
- Local gates green: typecheck, eslint, the full i18n gate chain
  (keys/parity/dead-keys/pseudo/strings).

Compatible. Stored ghost-face crewmates keep their records and render
identically; nothing is migrated or rewritten. The user-visible change is that
the ghost-face authoring tabs are gone, the builder opens on the Icon tier, and
a ghost crewmate can no longer edit its ghost face or its reaction motions/sounds
from this dialog — its stored ghost is kept and still renders, and Reset still
returns it to the name-derived default.

None. This is a UI-surface removal with no new I/O or runtime cost.
@IngridMorstrad
IngridMorstrad force-pushed the fix/18616-remove-ghost-face-picker branch from d62feba to 1c4c247 Compare October 29, 2026 17:03
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Oct 29, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

Stale-PR triage: code and every other check are green on 1c4c247, and it is MERGEABLE. The only blocker is the First Principles product-shape gate: this PR removes ghost-face and Reactions editing for crewmates that already wear a ghost, which main still allows (main already hides Ghost face for new crews). That is a product decision for a maintainer, not a code fix.

If a maintainer signs off, the exact override for the current head is:

/ai-review override first-principles 1c4c247d4b1bd5c343f928b192a38002b4b26d8c product-shape: #18616 accepted — Icon is the only avatar authoring path; existing ghost faces keep rendering unchanged but are no longer editable.

Otherwise, the alternative is to narrow this PR to keep the Ghost face tab for existing ghost crews.

@IngridMorstrad

Copy link
Copy Markdown
Contributor Author

Closing this. As the triage noted, main already covers the safe scope via #20392: the Ghost face tab is hidden for new crews and kept for crewmates already wearing a ghost. Narrowing this PR would make it identical to main, and the full removal needs a product sign-off that isn't worth a maintainer's time for this small change. Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ghost-face icon picker UI from crewmate create/edit; default new mates to SVG icon + colour

2 participants