Repository navigation
feat(dashboard): move MCP Management to Customize → Connections - #24933
iamwhatever merged 1 commit into
Conversation
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the panel is moved, not rewritten, the old URLs redirect, the approval endpoints stay owner-gated on the server, and committed screenshots cover the new placement. Notes
[DESIGN-REVIEWED] 4b64a19 Description read[DESCRIPTION-READ] d926279491dc2c5364c1ce27e720d0bb259d48f2916dfff733a78c564a7af255 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5, fork) — ✅ PASSUX-level review of UX-Verdict: PASS Screenshots show every new or changed control: the section on the MCP Servers sub-tab, the Developer menu without the MCP Management page, and the message for non-owners. No first-time reader has looked at them in this fork lane; pushing the branch to this repository adds that read. Notes
[UX-REVIEWED] 4b64a19 Description read[DESCRIPTION-READ] a7d56a3800989c9fe7d91116ebfd6a0cee9fd0ec095bc8caf3d51343982122a3 That sha256 names everything this verdict read: the PR description, plus the 13 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The move rests on a linked report (#24920), and the redirects keep every old URL working. The other additions follow from putting MCP Management on the same tab as the servers list. What this change shipsInventory (9 items) — 8 justifiedIntent: let people approve, stub and share MCP servers from the place where they already manage those servers. This is a MOVE (an ADDITION in kind).
[FIRST-PRINCIPLES-REVIEWED] 4b64a19 Description read[DESCRIPTION-READ] 605985ed49b57258743f8a25ce3a60f4efa2621b42d3b877566edbac0c916986 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
34029c2 to
45a55c6
Compare
|
Thanks — all three blocking findings were real (UX/data-loss from co-mounting), and the new revision (
The "after" screenshots now show the MCP Management body scrolled into its new place (the earlier ones cut off at the sub-tab strip). |
45a55c6 to
1556ad7
Compare
|
Round 2 (
UX notes also applied: the "Open MCP Gateway" tip no longer mentions Developer Mode. (MCP Management's internal "Servers" sub-view label vs the panel's "MCP Servers" sub-tab: left as-is for now — renaming it is inside |
1556ad7 to
80e38a6
Compare
|
Round 3 ( |
80e38a6 to
a32f782
Compare
|
Round 4 (
Evidence gaps:
Two UX Notes (advisory, not blockers) deferred, happy to follow up:
If you'd prefer either note folded in now, say so and I'll do it. |
a32f782 to
cce7bdd
Compare
cce7bdd to
ed2b585
Compare
ed2b585 to
f74877d
Compare
|
Opus 5.5 (blocking, Because MCP Management now sits on the MCP Servers sub-tab, non-owner sessions mount it too. The only owner-gated read it makes is
A new case in |
832d1c6 to
fadb5a4
Compare
|
Opus 5.5 (blocking, |
iamwhatever
left a comment
There was a problem hiding this comment.
Recommendation: REQUEST_CHANGES (issue required) at fadb5a4079a3752a96d339b85ff545ffb351508a.
The move itself is sound. MCP Management mounts lazily as a #mcp-management section under the MCP Servers list (ConnectionsPage), and both old URLs redirect. Its "Ask the agent" hand-offs are withheld while the list holds unapplied edits. No backend handler changes, and the approve/enable endpoints stay owner-gated. All lanes pass on this head, every check is green, and the branch merges cleanly with current main.
Blocker: two follow-ups you deferred have no linked issue.
- The inline reason when "Ask the agent" is withheld while edits are staged (McpManagement.tsx). Your comment says "Still deferred".
- Renaming MCP Management's inner "Servers" sub-view so it does not read like the "MCP Servers" sub-tab (deferred here).
Please fix them now, or open one issue per item and link both in the description.
AI findings judged non-blocking
- UX Review: the tip still says "Shared MCP gateway" toggle, mixes
›/→, and its button reads "Open MCP Gateway". These are wording nits (tips_curated.json). - Design Review: the description does not mention the non-owner footprint 403 handling. The code is correct and tested (footprint query); adding a line to the body would help.
- Design Review: other exits still drop staged edits. McpTab behaves the same way on
main. - First Principles: the capture script and PNGs are committed. A fork PR cannot attach evidence, and they have no runtime effect.
— crew-pr-reviewer (r134)
|
Thanks. I went with the issues route; both are linked under Follow-ups in the description:
I also added a line to the description about the non-owner footprint 403 handling, per the Design Review note. There's no code change, so the head stays at |
|
GPT 6.1 (blocking,
|
|
UX Review (Opus 5.5, blocking,
The second evidence gap (an error notice with edits staged, "Ask the agent" withheld) is the behaviour tracked by follow-up #25690. |
|
GPT 6.1 (2 blocking,
On the UX review's "no error styling, no Ask the agent" suggestion for that refusal: |
|
Opus 5.5 (blocking, UX Review ( |
|
UX Review (non-owner owner-only notice shown as an error with "Ask the agent"): keeping the current code, deliberately. The 403 is a rejected request, and Skipping the read for non-owners would avoid the error entirely, but the dashboard has no client-side owner signal, and adding one is out of scope here. A maintainer can override this if they prefer muted status text for this surface. |
|
Opus 5.5 (blocking, On the note about the refused footprint read re-fetching on remount/focus: non-blocking, and the same pattern Frontend Tests (2) on |
iamwhatever
left a comment
There was a problem hiding this comment.
Approve at 092b8bb.
Our r134 change request is resolved: both deferred items are now tracked in #25690 and #25691 and linked under Follow-ups. The move is sound. MCP Management mounts lazily as the #mcp-management section under the MCP Servers list (ConnectionsPage.tsx#L816-L830), both old URLs redirect, and the backend changes are text only. All lanes pass on this head and every check is green.
On the non-owner notice: the author kept it on ErrorNotice because the blocking errors-use-error-notice rule requires it, and the wording now says the figures are owner-only. That reply holds; a maintainer can still choose muted text.
AI findings judged non-blocking:
- Design: confirm launch/stub refuse non-owners. Both POSTs call
require_owner_dashboard_request, unchanged here (mcp_gateway_stubs.py#L240-L243, #L321-L323). - Design: a capture script still lists
mcp-pool. Dev-only screenshot sweep, and the old URL redirects (capture-side-panel-pane-inset.mjs#L234). - UX: the tip mixes
›and→. Wording nit (tips_curated.json#L57). - First Principles: the move lacks an owner decision. Issue #24920, filed by a maintainer, says the team decided on this move.
— crew-pr-reviewer (r139)
|
Rebased onto main to clear a conflict; no change to the approved diff. Could you re-approve? |
MCP Management (stub MCP servers, share their backends, Sharing assessment) was one of the Settings → Developer internals pages, among logs, telemetry and storage, away from the MCP servers it governs. The share-refused notice on the MCP Servers list sent people to that separate page to approve a launch. Render McpManagement as a section below the servers list in Customize → Connections → MCP Servers (/capabilities?tab=mcp&view=mcp-servers); the component is reparented, not rewritten. Drop the mcp-pool page from Settings → Developer and redirect both old links, /settings/developer/mcp-pool and /developer?tab=mcp-pool, to the new section so bookmarks, docs and tips keep working. While the servers list holds unapplied edits, MCP Management's "Ask the agent" hand-offs are withheld so they cannot navigate away and drop them. Point MCP_MANAGEMENT_PATH, the doctor message, the curated tip, docs, the feature map and the GUI feature catalog at the new location, remove the now-unused tab label from every locale, and add tests for the redirects, the placement and the repeat-link scroll. Closes kirodotdev#24920
|
Rebased onto main to pick up the Windows E2E fix (#28792); no change to the approved diff. Could you re-approve? |
iamwhatever
left a comment
There was a problem hiding this comment.
Approve at 4b64a19.
This head is our r139-approved 092b8bb rebased onto main: git range-diff shows only main-side context lines and regenerated digests changing, with the same 61 files. The move is sound. MCP Management mounts lazily as the #mcp-management section under the MCP Servers list (ConnectionsPage.tsx#L818-L843), both old URLs redirect, launch and stub POSTs stay owner-gated, and the Python changes are text only. The two deferred items are tracked in #25690 and #25691. All lanes pass on this head and every check is green.
AI findings judged non-blocking:
- Design:
McpManagement*.tsxstill lives underpages/settings/. File placement only, no behaviour (McpManagement.tsx). - UX: the owner-only notice uses error styling with "Ask the agent". The author kept
ErrorNoticebecause the blockingerrors-use-error-noticerule requires it, and the text names the owner-only reason (McpManagementHero.tsx#L165-L177). A maintainer can still choose muted text. - UX: no reason shown when "Ask the agent" is withheld. Tracked in #25690.
- First Principles: the
footprint_owner_onlykey is not named in the description. Description wording only; the string ships in all catalogs.
— crew-pr-reviewer (r144)
Problem / Motivation
Goal: MCP Management sits next to the MCP servers it governs, in Customize → Connections → MCP Servers, instead of among the Settings → Developer internals pages.
MCP Management — the surface that stubs MCP servers, routes their backends to one shared process, and shows the Sharing assessment — is one of the Settings → Developer internals pages (
/settings/developer/mcp-pool), filed between Storage and Memory, away from the MCP servers list it acts on. The MCP Servers list's "share refused" notice sends people to that separate page to approve a launch.Closes #24920
Why it matters
Approving a refused MCP launch, stubbing a server so it can render its own UI (MCP Apps), and sharing a backend across sessions are mainstream actions on the servers in that list, not developer internals like logs and telemetry.
Not a goal
McpManagement.tsx,McpManagementHero.tsx,McpManagementAssessment.tsxandMcpManagementLaunchReview.tsxis gating eachaskAgenthand-off onmcpStagedEditsContext; their layout and behaviour are otherwise the ones feat(mcp-gateway): share an MCP server with one labelled switch #19661 shipped./api/mcp*endpoint.What changed (motivation → approach → change)
Goal: put MCP Management where users already manage MCP servers.
Approach: the Customize → Connections tab's MCP Servers sub-tab (
/capabilities?tab=mcp&view=mcp-servers) hosts the MCP servers list. MCP Management acts on exactly those servers, so it renders as a section directly below that list — not on the Services sub-tab (connector cards, a different thing), The heavyMcpManagement.tsxis reparented, not rewritten.Change:
ConnectionsPage.tsx— the MCP Servers sub-tab now renders<McpManagement />as a section (#mcp-managementanchor) below<McpTab />; a scroll-on-arrival effect brings that section into view when the URL carries the#mcp-managementfragment.DeveloperPanel.tsxdrops themcp-poolpage (rail entry, render branch, lazy import) anddeveloperSubs.tsdrops its key; a REPLACE redirect sends/settings/developer/mcp-poolto the new section (the SubNav would otherwise silently show Feature Previews).DeveloperPage.tsx's/developer?tab=redirect sendsmcp-poolthere too. While the servers list holds unapplied edits, everyaskAgenthand-off in the McpManagement family (McpManagement,-Assessment,-Hero,-LaunchReview) is withheld viamcpStagedEditsContext, so it cannot navigate away and drop them.McpShareRefusedNotice.tsx—MCP_MANAGEMENT_PATH→/capabilities?tab=mcp&view=mcp-servers#mcp-management(the one source of truth the redirect imports), so the link keeps the MCP Servers sub-tab and lands on the section instead of the Services gallery.McpTab.tsx+mcpStagedEditsContext.tsx— while scope/tool edits are staged, MCP Management withholds its "Ask the agent" hand-off (which would navigate to /chat and drop those edits). McpTab publishespendingCount > 0through a small panel-scoped context; theaskAgentnotices in MCP Management read it. Other navigation keeps its existing behaviour (no blanket leave guard).McpManagement.tsxtreats that as a permanent refusal: no retry and no 30s polling (each refusal writes an audit row). A refused read is still a rejected request, so it goes through the shared inlineErrorNotice(with the staged-edit hand-off decision, pererrors-use-error-notice), but its message names the reason, "Memory figures are visible to the crew owner only.", instead of the generic "Could not read how much memory MCP servers use." that other failed reads show.McpCustomServerModal.tsx+McpTab.tsxapply — invalidate['mcpGatewayServers']after add/edit/apply so a newly installed or changed server appears in MCP Management without a reload.developerPage.tabs.mcpPool.*, addedconnectionsPage.mcp_management_headingacross all 14 catalogs (pseudolocale regenerated).docs/architecture/mcp.md,docs/feature-map/README.md,docs/guides/secrets-env.md,src/kiro_crew/docs/mcp-apps.md,src/kiro_crew/doctor_checks/mcp.py, and the "Open MCP Gateway" tip now point at Customize → Connections' MCP Servers sub-tab.ui-index.generated.jsonregenerated; the gonedeveloper-mcp-poolrender surface is dropped fromscripts/lib/i18n-surfaces.mjs+render-baseline.json.Review rounds (addressed in this single commit)
The fork AI-review lanes raised real UX/data-loss defects introduced by co-mounting; all are fixed above:
#mcp-management; MCP Management renders only on that sub-tab, not Services.mcpStagedEditsContext), rather than a blanket leave guard that would silently block every exit.['mcpGatewayServers']invalidation on add/edit/apply.doctor_checks/mcp.pynamed a tab that no longer exists, and a backend test asserted the old path (Opus) → message +test/test_doctor_mcp_share_refused.pyupdated to the new location.McpBrowserModal's install callback also invalidates['mcpGatewayServers'].#mcp-managementURL re-scrolls.['mcp-servers']query to finish loading, so the taller table can no longer push the section back below the fold.Ordering note re #19661
#19661 (the MCP Management rewrite) has merged and this branch is rebased on it. The two overlap only in the
askAgentprops this PR gates, plus thesettingsCoverage.test.tswaivers for the McpManagement files.Follow-ups
ErrorNotice).Backwards compatibility
Compatible:
/settings/developer/mcp-pooland/developer?tab=mcp-poolboth redirect (REPLACE) to the new location, so bookmarks, docs links and older tips still reach MCP Management. No endpoint, type or config key changes.Removes nothing but the Settings → Developer
mcp-poolpage entry, and the redirects preserve its URLs; the component's routes and every/api/mcp*endpoint it calls are unchanged, and the Connections page loads it lazily, as Settings → Developer did.MCP_MANAGEMENT_PATHis the one source of truth, used byMcpShareRefusedNotice.tsx,DeveloperPanel.tsxandDeveloperPage.tsx, covered byMcpShareRefusedNotice.test.tsx,DeveloperPanel.test.tsxandMcpManagementMove.test.tsx.Tests
website/src/test/McpManagementMove.test.tsxlocks in the move, written test-first and shown red onorigin/mainfor the right reason, then green on this change:Unable to find [data-testid="mcp-management"](the sub-tab rendered only the servers list)/settings/developer/mcp-poolredirects (DeveloperPanel.test.tsx)/capabilities?tab=mcp&view=mcp-servers#mcp-management#mcp-managementURL scrolls againscrollIntoView(effect deps unchanged)scrollIntoViewfires while['mcp-servers']is still pending (shown red with the loading gate removed)/developer?tab=mcp-poolredirects to/capabilities?tab=mcp&view=mcp-servers#mcp-managementwherenever appears (no redirect on main)Proof: not provable -- frontend test (prove.py runs Python only). The red/green table is the equivalent for a frontend-only change.
Also green locally:
tsc,eslinton the changed files, the catalog-parity / dead-keys / key-reference / english-identity suites,settingsCoverage.test.ts,lint:i18n,i18n:check,docs-lint.sh, and the ConnectionsPage / CapabilitiesPage / DeveloperPage / McpManagement / McpCustomServerModal test files. The render-time i18n gate adds no new finding (capabilities-mcpstays 0; the gonedeveloper-mcp-poolsurface is dropped from the baseline); the only surfaces above the debt record are pre-existingsettings-display-*drift on main, unrelated to this diff.Manual verification
Rendered the real built SPA under the screenshot harness (
capture-24920-mcp-management-move.mjs): MCP Management renders in Customize → Connections' MCP Servers sub-tab in both themes, scrolled into view via the#mcp-managementfragment; the Settings → Developer rail has no MCP Management page; and/settings/developer/mcp-poolredirects to the new section.Screenshots / video
Committed under
temp-screenshots/(a fork PR cannot usegh --attach).Before — MCP Management as a Developer tab (captured before main merged the Developer page into Settings → Developer, #24810):
After — MCP Management as a section in Customize → Connections' MCP Servers sub-tab, scrolled into view below the servers list, no Developer Mode:
After — unscrolled: the Connections page, its MCP Servers sub-tab, the servers list, and the MCP Management section directly below it:
After — the Settings → Developer rail no longer lists MCP Management:
After — a non-owner session: the owner-only footprint read answers 403, and the error notice names the owner-only reason:
Rebase onto #24810 and #19661
Main merged the Developer page into Settings → Developer (#24810) and rewrote MCP Management (#19661). This revision keeps main's code for both and re-applies only the move: MCP Management leaves the new Settings → Developer SubNav, both old URLs redirect, and the hand-off gating covers #19661's new
McpManagementHero.tsxandMcpManagementLaunchReview.tsxnotices. The GUI feature catalog entrydeveloper-mcp-poolbecomesconnections-mcp-management.