Repository navigation
feat(aws-control): name the searched region on the no-drive setup card - #24934
Conversation
|
Screenshot note: this host is too short on memory (load above 80 on 16 cores) to build the SPA for a browser capture, so no screenshot is attached yet. The card renders one extra muted line under the existing body text, "No drive found in . Only this region was searched, so a drive in another region of this account will not show here.", only when the drive status carries searched_region. Unit tests in ConsoleView.test.tsx and AwsControlPage.test.tsx cover both the present and absent cases. A maintainer may add the no-screenshots label or ask for a capture from a less loaded host. 🤖 AI-assisted comment 🤖 |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is an additive, optional line on the setup card that the old backend payload doesn't affect, and the description includes two screenshots of this revision. [DESIGN-REVIEWED] 18f27e9 Description read[DESCRIPTION-READ] 15ce9e1798385bdfa37938f07689e75d29ddb7bc6e798bdc3cfed680dd0c298e That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS The backend already sends What this change shipsInventory (3 items) — 3 justifiedIntent: when no drive is found, the owner sees which region was searched, so they don't create a second drive in another region. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 18f27e9 Description read[DESCRIPTION-READ] 4ec14c8e3f2f7204d2e07390c47a9a18b91635ce21ca9cf776d352d89ea97075 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. Both states of the new line are in the screenshots, and the blind reader understood it as intended: "it only looked in one place, and I might already have a drive somewhere else". Notes
[UX-REVIEWED] 18f27e9 Description read[DESCRIPTION-READ] 6d9002dc553e2c049ea0aeaa04d96a100f83d098308f3af645bd9ca7cb79d317 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
a7d8ae7 to
ab68bc8
Compare
|
self-added: yes
🤖 AI-assisted comment 🤖 |
ab68bc8 to
18f27e9
Compare
|
Review-ready at head 18f27e9: PR Readiness passed (label Note: origin/main has gained 17 commits since this head went green, and some touch the same locale files (new keys only). GitHub still reports the PR as mergeable, so I have not rebased; a maintainer may ask for a re-sync before merging. Waiting on a maintainer review. I have not merged, approved or enabled auto-merge. 🤖 AI-assisted comment 🤖 |
Problem / Motivation
Goal: When AWS Control finds no drive, the setup card names the region it searched, so an owner knows a drive in another region of the same account will not show there.
Since PR #24892 the drive status returns
{"exists": false, "searched_region": "<region>"}. The dashboard ignored the field. The setup card said only "set up a drive" and offered to create one, so an owner whose profile points at another region could make a second drive in the same account.Why it matters
The drive is one per AWS account, but discovery looks in one region. Without the region on screen, the owner decides to create a drive without knowing where it looked.
Not a goal
What changed (motivation → approach → change)
The status already carries the searched region; only the screen was missing it.
DrivePaneGatenow passessearched_regiontoSetupCard. When it is present, the card adds one line: "No drive found in {{region}}. Only this region was searched, so a drive in another region of this account will not show here." When an older backend leaves the field out, the card shows exactly today's text. TheDriveStatustype gains the optional field. The new keyapps.awsControl.console.setup_searched_regionis inen.manual.json, every translated catalog, and the regenerateden-XApseudolocale.Decision (most conservative): the line is added under the existing body text rather than replacing it, so the create button and today's copy stay as they are.
Backwards compatibility
Compatible: the field is optional; a payload without it renders the card unchanged.
Removes nothing: the diff only adds a line, an optional type field and a catalog key.
Tests
ConsoleView.test.tsx›SetupCard› "names the searched region when the drive status reports one (AWS Control: show the searched region on the no-drive setup card #24913)": the line renders with the region, and the old body text is still there.ConsoleView.test.tsx›SetupCard› "keeps today's text when an older backend sends no searched region": no region line; body and costs note unchanged.AwsControlPage.test.tsx›DrivePaneGate› "the setup card names the region the drive status searched (AWS Control: show the searched region on the no-drive setup card #24913)": the page passessearched_regionfrom the status payload through to the card.Both #24913 tests fail with the production hunks reverted (checked locally) and pass with them.
Proof: not provable -- frontend test
Manual verification
Built the SPA and loaded
/aws-control/filesin Chromium with stubbed API replies: the region line shows whensearched_regionis set and is absent when it is not (screenshots below).Screenshots / video
Built SPA, AWS Control Files pane, no drive yet, dark theme (fixtures, no AWS).
With
searched_region: "us-west-2": the new line sits under the body text.Older backend, no
searched_region: the card is unchanged.Related Issues
Closes #24913
Related: #24887 / PR #24892.
Checklist