Repository navigation
fix(steering): list links outside the readable tree as linked, not shown - #25152
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. The listing now matches what kiro-cli actually loads. The read path still refuses links outside the readable tree, and the screenshots cover the new state. Notes
[DESIGN-REVIEWED] f439db4 Description read[DESCRIPTION-READ] 28c22d4f12bad9c2e5f88200490c3bec5c9cd0d42d4abcc6b8044bb7660d979d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks, but the new "Sessions can still load it" sentence is only true for kiro-cli's own sessions. Kiro Crew's own steering loader still drops these links. Notes
What this change shipsInventory (6 items) — 3 justifiedIntent: make Settings → Steering show every steering link a session loads, even when the link points outside the folders the dashboard may read — FIX.
[FIRST-PRINCIPLES-REVIEWED] f439db4 Description read[DESCRIPTION-READ] c5be30948321940bf7d262229e1ba198840546c0d37b6f655c3aeb83d89d5746 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The blind reader understood the "Linked, not shown" sentence correctly, and the screenshots show every changed state: the not-shown link on desktop and at phone width, and the refused read. Notes
[UX-REVIEWED] f439db4 Description read[DESCRIPTION-READ] bcb5e167bf1dce02feb54a32a4991c15fc56fa50a89e76f9a6a61bfb5fc3d9ef That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
70cce23 to
f439db4
Compare
|
|
|
HOLD (open maintainer decision) at The code is sound as far as I can tell: an outside-trust-base leaf link is listed by name only with resolve_steering_file) is unchanged, and the tab skips the detail fetch for such an entry. All checks are green and all five AI lanes PASS; the earlier GPT/Opus askAgent findings are fixed in this head.
Why HOLD: #14627 is labelled AI findings judged non-blocking
— crew-pr-reviewer (r133) |
Problem / Motivation
Goal: The Steering tab lists every steering link a session can load, and marks a link whose target is outside the folders the dashboard may read as "linked, not shown" instead of hiding it.
A global steering file in
~/.kiro/steering/that is a symlink into a checkout outside$HOME(for example/workplace/<user>/<repo>/...) is missing from Settings → Steering. kiro-cli still follows the link and loads the file into every session, so the tab says fewer files are in effect than really are.Why it matters
Keeping a checkout outside
$HOMEis common (dev desktops use/workplace). On those hosts the tab under-reports the steering a session reads, and nothing says a file was dropped. That makes "why does the agent follow this rule?" hard to answer.Not a goal
steering.sourcesdirection in fix: admit approved global steering symlinks #14007).What changed (motivation → approach → change)
Symptom → cause → change:
$HOMEfor global, the steering root for workspace)readable: false, no target path, no size, no head metadataGET /api/steering/<key>)The listing decides "outside" from the already-resolved path string (
_target_outsideinsrc/kiro_crew/dashboard/handlers/steering.py), so the target is never opened, read or named; the only thing the listing shows is that the target exists. Every other entry gainsreadable: true. The frontend (website/src/pages/overview/SteeringTab.tsx,website/src/types/index.capabilities.ts) skips the detail fetch and the mode chip for a not-shown entry. The new string is in all 13 locale catalogs underwebsite/src/i18n/locales/. The steering spec (docs/system-specs/modules/steering-viewer.md) and the user doc (src/kiro_crew/docs/steering-and-hooks.md) describe the new state, andtest/requires-real-symlinks.txtlists the renamed and new symlink tests.Backwards compatibility
Compatible: the listing only gains entries and an optional
readablefield; an older tab ignores the field and an absent field reads as readable. No accepted request is refused and no key is renamed.Removes nothing: the read and write paths refuse exactly what they refused on main, and every entry main listed is still listed with the same fields.
Tests
test/test_steering_api.py::TestLinkedEntries— an outside link (global and workspace) lists by name only with no target, size or body in the response; the listing never callsPath.statoros.openon the target; the read endpoint still 404s; sensitive targets and a link to the base folder stay hidden; admissible links reportreadable: true.website/src/test/SteeringTab.test.tsx— a not-shown entry renders the sentence, disables Edit/Delete, shows no body or mode chip and never calls the detail API; a refused detail read shows its error and the agent hand-off instead of "Loading…".Proof: PROVEN test/test_steering_api.py::TestLinkedEntries::test_link_escaping_home_lists_by_name_only, test/test_steering_api.py::TestLinkedEntries::test_link_escaping_home_never_opens_or_stats_target, test/test_steering_api.py::TestLinkedEntries::test_workspace_link_to_project_file_outside_root_is_never_read, test/test_steering_api.py::TestLinkedEntries::test_workspace_link_escaping_project_lists_by_name_only (head 83c8d7954a0d)
The new frontend test fails on main (no
readablehandling) and passes here.Manual verification
Ran this branch's dashboard on an isolated localhost gateway with a throwaway
$HOME: a regular file, a link inside$HOME, andcontext/team-rules.mdlinking to a file outside$HOMEwhose body holds a marker string. Steering (3) listed all three; the outside link showed the "linked, not shown" sentence with Edit/Delete disabled, and the rendered page contained neither the marker string nor the target's folder name, on desktop and at 390 px. The first-run setup gate was answered "ready" in that browser only, because this host has no OS sandbox; the steering responses were real.Screenshots / video
Desktop: the outside link is listed and selected, with the sentence in place of a body.
Phone width (390 px):
A refused detail read (a 324 KB file over the 256 KiB cap) now shows its error with the agent hand-off, instead of "Loading…":
Related Issues
Closes #14627
Sibling sweep
Swept: git grep -n "steering_target_admissible|_link_trust_base" -- src/
Sibling: src/kiro_crew/context_assembly/agent_spec.py -- not affected -- the session loader keeps its own HOME gate; this PR changes only what the tab lists
Sibling: src/kiro_crew/dashboard/handlers/steering.py -- not affected -- its read path (resolve_steering_file) must keep refusing an outside target, which the tests pin
Pattern harvest
Not generalizable: a listing that silently dropped entries its own gate refused to read; the fix is specific to the steering tab's list-versus-read split.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)