Skip to content

feat(crew-mode): composer chip, welcome, approval cards and the crew member view - #25183

Merged
bolichen97 merged 1 commit into
mainfrom
feat/crew-mode-7-crew-member-view-main
Oct 29, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
feat/crew-mode-7-crew-member-view-main

Conversation

@bolichen97

@bolichen97 bolichen97 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Add the composer Crew Mode chip and welcome, the conductor's approval cards, and the crew member view (breadcrumb, steer composer, reopen when the conductor is closed), the last piece, which turns Crew Mode on from the UI.

Part of landing Crew Mode (#24860): this is part 7 of 7. Parts 5 and 6 are on main (#25097, which carried #24931), so this pull request's diff is this part alone.

Part 4, #25480 (the crew list, timeline, steer and approve routes), is on main, so the approval cards and the crew member's message box post to routes main serves. This is the last part.

Why it matters

This completes the feature: a person turns Crew Mode on from the composer, sees the welcome, decides crew approvals on the conductor's card, and opens a crew member in the main pane to read it and steer it. Everything it calls lands in parts 1 to 6.

Not a goal

What changed (motivation → approach → change)

A plain, Persistent chat on the default agent gets a Crew Mode chip on its welcome state. Pressing it switches the chat to the conductor and shows the Crew Mode welcome. Until the first message the mark can be pressed again to turn Crew Mode off; from the first message on it is locked. A chat on a conductor that is itself the default agent is in Crew Mode the same way, with no way off. A conductor chat's composer has no agent picker and stacks its crew's approval cards above the composer. Opening a crew member shows it in the main pane with a breadcrumb and the conductor's normal composer as its message box, whose placeholder names the crew member and what a send does.

Surface What a person sees
Composer, welcome state A Crew Mode chip beside the memory-mode chip; while a reply runs it is dimmed with a plain border (unavailable, not pressed), with the line "Available after the reply." Pressed, it moves into the composer footer as the Crew Mode mark: a pressed toggle (named "Crew Mode", hint "Turn off Crew Mode. You can do this until you send your first message.") until the first message, then a read-only status. For the one round-trip of the switch, either way, the message box is held with "Turning Crew Mode on…" (or "…off…") as its placeholder and the draft kept, the way a memory-mode switch holds it: a send that reached the server first would start the turn on the agent the chat is leaving, and the switch would be refused.
Crew Mode welcome The title, "You set the goal. Your crew does the work.", a five-step flow and, in a root chat, a Task board button. Plays once; reduced motion draws the final frame.
Conductor composer No agent picker; one approval card per waiting crew member: the exact tool input, Approve and Reject in one row, and Trust this crew member on its own row with its scope beside it: "Approves this and lets this crew member run tools without asking until Kiro Crew restarts."
Crew member, main pane A breadcrumb (conductor › crew member; three crumbs for a sub-conductor's crew member; the crumbs are labels) with Back to main chat, the breadcrumb's one control, and the conductor's composer as the message box, its placeholder naming the target and what a send does ("Message : it reads this before its next step"); a too-long message keeps the draft and says so ("A message to can be at most 50,000 characters. Shorten it to send.").
Crew member, conductor closed The composer is off; the line reads "Main chat is closed. Open it again to message ." with an Open main chat button, and the breadcrumb's button reads Open main chat too.
Crew member, approval pending No approval band of its own: "Waiting for approval in " with a link that opens it, in the main pane and in a Split View pane; the conductor's side panel and All Dashboards show it as information with "Open the approval card". The crew member's approval raises no note, chime, banner or badge of its own; the conductor's card is where it is decided.
Delivered message A message another chat sent drops its [sent by session ...] line and is labelled "From conductor", "From a crew member" or "From another chat".

website/scripts/capture-crew-mode-7.mjs is the screenshot harness for these surfaces. The chip and welcome are CrewModeChip and CrewModeWelcome; the switch is pages/chat/page/crewModeSwitch.ts, an ordinary agent switch to the catalog's conductor. The cards, breadcrumb and gate are components/crew/CrewApprovalCards, CrewWorkerBreadcrumb and CrewWorkerComposerGate, sharing useCrewRoot. ComposerDockView, ChatTitleOverlay, ChatTranscriptView, ChatPage and ChatPane wire them in; ChatInput, chat-input/approval.ts and chat-input/props.ts carry the approval-chrome switch. The command center's attention item for a crew member's approval (command-center/model.ts, AttentionCard.tsx) is information that links to the card, with no Approve or Reject of its own; a crew member's own approval frame or native permission row raises no note, chime, banner or badge (hooks/websocket/approvals.ts, chatStream.ts). lib/crewSeed.ts and pages/chat/UserMessage.tsx label a delivered message, with utils/pinnedPrompt.ts and usePinnedPrompt.ts doing the same for the pinned card; FollowUpBar places its tip below so it never covers a card's buttons. Strings are in the twelve locale files plus en.manual.json; docs/system-specs/modules/learn-cron-dashboard.md names the chip and welcome.

Backwards compatibility

Compatible: the chip is offered only on a plain, Persistent, default-agent welcome state, so no existing composer control changes for other chats.

Removes: the conductor templates leave every normal chat's agent picker. Today a person can pick kirocrew-conductor, kirocrew-ledger-conductor, kirocrew-pipeline-conductor, kirocrew-security-conductor or kirocrew-team-lead from the picker; after this merges the Crew Mode chip is the one way onto the configured conductor (agent.crew_mode_agent), and the other conductors are reached by configuring that key. This is the design's shape (#24860; the catalog that main serves since #24895 says so in agent_catalog.py: "the whole conductor family, which a normal chat's agent picker leaves out so Crew Mode is the way in"). Reader: website/src/lib/crewMode.ts:withoutConductors -- picker -- drops a conductor row unless it is a crewmate, covered by crewMode.test.ts; website/src/hooks/useAgents.ts applies it to every picker. A chat already running a conductor is not moved: on a conductor chat the picker is replaced by the Crew Mode mark (website/src/pages/chat/page/ComposerDockView.tsx:ComposerDockView, covered by ChatPage.crewMode.test.tsx and crewModeUiR1.test.tsx). Crewmates stay listed whatever their name.

Merge order: main already serves the catalog's conductor set and stamps slot rows with crew_root (#24895, part 1), so the picker rule and the chip take effect as soon as this merges. The approval cards and the crew member view read the crew-workers routes and the session lists of parts 2 to 6; parts 1 to 6 are all on main.

Tests

  • CrewModeChip.test.tsx, ChatPage.composerDock.test.tsx, ChatPage.crewMode.test.tsx and crewModeUiR1.test.tsx: the chip's offer, busy state, the switch, the off toggle, the lock and the hold on the message box for the switch's round-trip.
  • crewMode.test.ts and useAgents.conductorChange.test.tsx: the picker leaves every conductor template out and keeps crewmates, and it re-filters when only the configured conductor changes.
  • CrewApprovalCards.test.tsx, crewApprovalOneRule.test.tsx and crewWorkerQuiet.test.ts: one card per request, the three decisions, that a crew member's own composer draws no approval band, and that its approval frame raises no note, chime or badge.
  • CrewWorkerBreadcrumb.test.tsx, CrewWorkerComposerGate.test.tsx, ChatPane.crewMode.test.tsx, ChatPane.crewRootClosed.test.tsx and ChatPage.crewWorkerSessionsAside.test.tsx: the breadcrumb, the gate, the closed-conductor state and the sessions list hiding.
  • UserMessage.sessionSeed.test.tsx, ChatInput.approvalNudge.test.tsx, FollowUpBar.test.tsx and ChatPage.pageOwners.test.ts: the delivered-message label, the approval nudge, the tip placement and the page owners.

N/A -- not a fix PR for a Proof line.

Manual verification

The flow was exercised end to end on the full Crew Mode branch: the chip turns Crew Mode on, the welcome plays, a crew member's approval shows on the conductor's card and is decided there, and the crew member view opens, steers and reopens a closed conductor. The stubbed-gateway captures (capture-crew-mode-7.mjs) exercise this head's own code for the card, the notice, the crew member view, the chip and the mark.

Screenshots / video

Dark theme, desktop width. The chip and welcome captures come from the full Crew Mode branch on a live gateway; every other capture comes from this branch's built dashboard with the gateway's answers stubbed from fixtures (website/scripts/capture-crew-mode-7.mjs, the repository's screenshot harness), so they show this head's code.

The composer's Crew Mode chip on a new chat's welcome state, beside the memory-mode chip:

Crew Mode chip on the welcome state

The same chip while a reply runs: dimmed with a plain border, so it reads as unavailable and not as pressed, with the line "Available after the reply." beside it:

Crew Mode chip unavailable while a reply runs

The Crew Mode welcome after the chip is pressed. The footer's Crew Mode mark is the chip, moved: until the first message it is a pressed toggle named "Crew Mode" whose hint reads "Turn off Crew Mode. You can do this until you send your first message."; pressing it brings both chips back:

Crew Mode welcome

Recording: the chip pressed, both chips leave and the mark lands in the footer, then the mark pressed and the chips return (the harness's slot list does not refresh after the switch, so the side panel it opens still reads the chat as plain; on a live gateway the Crew tab lists the crew):

chip-to-mark.webm

The conductor's approval card above the composer: the crew member's title, its task line, the exact tool input, Approve and Reject in one row, and Trust this crew member on its own row with its scope line beside it:

Conductor chat with the approval card

The approval card alone

The crew member opened in the main pane while that approval waits: the breadcrumb with its status, Back to main chat, the "From conductor" label on the delivered message, no approval band of its own, and the line "Waiting for approval in " with the link that opens it:

Crew member view while its approval waits

The same approval in the conductor's side panel, Dashboard tab, Approvals: information with "Open the approval card", no Approve or Reject of its own (the Overview section's own read is stubbed out in the harness, so it shows its failure notice):

Conductor side panel with the crew approval notice

The crew approval notice alone

A message past the 50,000-character limit: the draft stays in the box and the notice names the crew member and the limit. The box's placeholder names the crew member and what a send does:

Message too long

A finished crew member in the main pane (breadcrumb: Done); its box still names it and what a send does:

Finished crew member view

The same crew member with its conductor's tab closed: the line says the main chat is closed and that opening it again lets the person message the crew member, with Open main chat on the line and in the breadcrumb; the box is off:

Crew member view with the conductor closed

Related Issues

Closes #24860

First parts: #24895, #25131, #25480, #24931, #25097

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners October 28, 2026 08:03
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 28, 2026
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 91f38f01ce7bc880465d5904ed89dc7ed6201961 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: Crew Mode is an ordinary agent switch, and the one take-away (conductors leave the picker) reaches only the pickers named under Reader.

Notes

  • The other readers of useAgents (SchedulePage, ChannelPage, CrewEditor, shellKeyboard) read the unfiltered agents, not choices. So cron, channel and crew-editor bindings to a conductor template are unaffected. The description could say so.
  • crewMode.ts holds the catalog in module-level variables, and crewCatalogKey exists only to make the picker re-filter when that catalog changes. Returning the conductor set from useAgents would remove that workaround and its two exhaustive-deps suppressions.

[DESIGN-REVIEWED] 91f38f0

Description read

[DESCRIPTION-READ] 86aa8f829e3123b6cc569dc9aed969cf12100b3100f7641dd60b0ec3430fc82d

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@bolichen97 overrode this lane for 91f38f01ce7bc880465d5904ed89dc7ed6201961 via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 91f38f01ce7bc880465d5904ed89dc7ed6201961 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The blind reader read every primary control correctly (chip, Approve/Reject, Back to main chat, Open main chat), and the chip-to-mark move uses a shared layout id and has a recording.

Notes

  • "Trust this crew member": the reader would not press it because "I don't know what 'run tools' could include". Say what the trust covers in the scope line, e.g. "…lets Rain haiku write files and run commands without asking until Kiro Crew restarts."
  • One approval has four names. The dashboard card says "Edit tmp/cm-haiku-rain.txt" while the conductor's card says "Rain haiku needs approval · Save the haiku". The reader matched them only by the filename. Have AttentionCard lead with the same " needs approval" title.
  • Two composers look usable when they are not. In the too-long state (shot-09) the send arrow stays bright purple. In the closed-conductor state (shot-11) the box is empty with no placeholder, and the reader asked "it looks usable but probably isn't". Dim the send button while steerTooLong, and give the closed state a placeholder that repeats "Main chat is closed".

[UX-REVIEWED] 91f38f0

Description read

[DESCRIPTION-READ] ceab68ee538e34f3c4100f234aa73aa1920cb3d429cc5c8fcfaf18a903b90157

That sha256 names everything this verdict read: the PR description, plus the 14 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 91f38f01ce7bc880465d5904ed89dc7ed6201961 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 91f38f0

Verdict parsed from the review's SHA-scoped output markers for commit 91f38f01ce7bc880465d5904ed89dc7ed6201961.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 91f38f01ce7bc880465d5904ed89dc7ed6201961 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 91f38f01ce7bc880465d5904ed89dc7ed6201961 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 91f38f0

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 91f38f01ce7bc880465d5904ed89dc7ed6201961 false-positive: <reason, 20 to 500 characters>

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Trust's scope is hidden in a tooltip span=90f7c7b85720

fixed in c2f7780: Trust this crew member now sits on its own row under Approve and Reject, with its scope line ("Approves this and lets this crew member run tools without asking until the gateway restarts.") rendered beside it and bound by aria-describedby, so a blind reader hears it before pressing; the tooltip-only form is gone.
The chip-to-mark motion has no recording: both end states are in the attached captures (chip on the welcome state; the mark in the footer after the press), and the move is a Framer Motion layoutId swap with a plain swap under reduced motion. A recording needs the full stack live and is added when the hold lifts.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Three action buttons in one row on the approval card span=263a4c071f76

fixed in c2f7780: Approve and Reject stay in one row (primary + secondary); Trust this crew member moves to its own row with its scope line beside it, so no row holds more than two buttons and no decision is hidden in an overflow menu.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Steer ledger failure rendered as a muted line span=c1c92f802414

fixed in c2f7780: every ledger_error the server reports as a failed write (no_item, crew_log_off, crew_log_unit_unknown, not_recorded and the unknown-code fallback) now renders through ErrorNotice (inline) with askAgent on and a dismiss; only item_closed, which reports nothing failed, stays status text.

@bolichen97
bolichen97 force-pushed the feat/crew-mode-7-crew-member-view-main branch from 2a874d1 to c2f7780 Compare October 28, 2026 08:16
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Turning Crew Mode off can't be found after the chip moves span=818a98c22c98

fixed in 87282b4 (description and evidence; the code already did what the finding asks): the chip moves into the footer mark with a shared Framer Motion layoutId, and until the first message that mark IS a pressed toggle (aria-pressed, name "Crew Mode", hint "Turn off Crew Mode. You can do this until you send your first message."); pressing it brings both chips back. The description now says so in the Composer row and under the welcome capture, and a recording of press, mark, press-back is attached (capture-crew-mode-7.mjs, this head's built dashboard).

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • "Trust this crew member": the reader would not dare press it span=53ae153f2e3e

fixed in 87282b4: the scope line is reworded in user terms in all 12 locales ("Approves this and lets this crew member run tools without asking until Kiro Crew restarts."), sits beside Trust on its own row and is bound by aria-describedby; a current capture of the card (full pane and card alone) is attached, plus the crew member view while its approval waits, the disabled chip with "Available after the reply." and the too-long steer notice, all rendered from this head by website/scripts/capture-crew-mode-7.mjs.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • The conductor card posts to a crew-workers/approve route this branch does not carry span=67cf3fb048b4

Rebutted: merge order, not a defect in the shape that ships. This pull request is part 7 of 7 and is HELD (auto-merge off, stated in the description) until parts 1 to 4 land; the routes the card, the Crew tab and the steer box call (/crew-workers, /crew-timeline, /steer, /approve, handlers/crew_workers.py) are part 4 of the recorded seven-part landing (#24860). On the stack as merged, every crew approval is decided on this card; a per-surface fallback to the per-slot band for a gateway without the routes would be a second decision path that exists only during a window the hold already prevents.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 28, 2026
@bolichen97
bolichen97 force-pushed the feat/crew-mode-7-crew-member-view-main branch from c2f7780 to 87282b4 Compare October 28, 2026 08:42
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 28, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Crew approval decided only through crew-workers routes this tree does not register span=67cf3fb048b4

Rebutted: merge order, not a defect in the shape that ships. This is part 7 of 7 and is HELD (auto-merge off; the description says so) until parts 1 to 4 land; the routes the card, the Crew tab and the steer box call are part 4 of the recorded landing (#24860), and the stack merges 5, 6 and 7 together after them. A per-surface fallback to the per-slot band for a gateway without those routes would add a second decision path that exists only in a window the hold already prevents; not security or data loss: a tool call waits for the card.

@bolichen97

Copy link
Copy Markdown
Contributor Author

/ai-review override fable 87282b4 not-applicable: agent: merge order, not a defect in the shipped shape: part 7 of 7, held until parts 1 to 4 land (#24860); the crew-workers approve, list, timeline and steer routes are part 4, and 5, 6 and 7 merge together after it. Not security or data loss: a tool call waits for the conductor's card.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@bolichen97 recorded a not-applicable release (class not-applicable) for the fable AI finding on 87282b4f48680ecab1402604f59cbe28858fc393.

agent: merge order, not a defect in the shipped shape: part 7 of 7, held until parts 1 to 4 land (#24860); the crew-workers approve, list, timeline and steer routes are part 4, and 5, 6 and 7 merge together after it. Not security or data loss: a tool call waits for the conductor's card.

This decision applies only to this commit. A new push requires a new judgment.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Record the hand-off decision for failed reopens span=f7bd184150c7

fixed in b372e46: the breadcrumb's reopen-failure ErrorNotice now carries askAgent with a comment saying why nothing is lost (the breadcrumb holds no draft; the composer's draft is saved per chat in utils/chatDrafts). Every ErrorNotice this part adds now records its hand-off decision.

@bolichen97
bolichen97 force-pushed the feat/crew-mode-7-crew-member-view-main branch from 87282b4 to b372e46 Compare October 28, 2026 09:01
@bolichen97

Copy link
Copy Markdown
Contributor Author

/ai-review override fable b372e46 reissue: agent: same ruling for the rebased head (rebase onto #25097 plus one askAgent on the breadcrumb's notice; the card's approve route is unchanged): merge order, held until parts 1 to 4 land (#24860), not security or data loss. Record: #25183 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@bolichen97 recorded a reissue release (class reissue) for the fable AI finding on b372e468535272488b169dc70aad06b66a78cd79.

agent: same ruling for the rebased head (rebase onto #25097 plus one askAgent on the breadcrumb's notice; the card's approve route is unchanged): merge order, held until parts 1 to 4 land (#24860), not security or data loss. Record: #25183 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@bolichen97
bolichen97 force-pushed the feat/crew-mode-7-crew-member-view-main branch from b372e46 to 31e7ffb Compare October 28, 2026 09:53
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: onto #25097's head 5301994483 (parts 5 and 6 squashed into this branch's first commit so the pull request holds two). This part's own commit also fixes the two full-suite reds that were its own on b372e46853: the Trust scope line now reads {{productName}} instead of the literal product name in all 12 locales (ko keeps the particle in both forms), and the too-long-steer notice carries the content column's px-4 gutter. Two reds on that head come from the stacked parts and are not this part's to change: pages.chatSidebar.filter_crew_hint (fr spacing before the colon, #24931) and SessionRow.tsx's inline ErrorNotice truncate on its root (#25097); they leave this diff when those parts fix them. CI re-running.

@bolichen97

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 5cec0ab reissue: agent: same ruling, no code change; this push only replaces a test sleep with a wait. Links the owner-decision record #25183 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@bolichen97 recorded a reissue release (class reissue) for the fable AI finding on 5cec0abe714e1a668ddfe778645e8803b8284019.

agent: same ruling for the new head (the crew-workers approve route lands with part 4, #25480, before this merges); this push only replaces a test sleep with a wait, no code change. Record: #25183 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@bolichen97 recorded a reissue release (class reissue) for the first-principles AI finding on 5cec0abe714e1a668ddfe778645e8803b8284019.

agent: same ruling, no code change; this push only replaces a test sleep with a wait. Links the owner-decision record #25183 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@bolichen97

Copy link
Copy Markdown
Contributor Author
span=298005a744c7
  • Separate active Crew Mode from toggle eligibility (crewModeSwitch.ts:51, sites crewModeSwitch.ts:85, ChatTranscriptView.tsx:150, ChatPage.tsx:1159)

Fixed in ba8c2bb. useCrewModeSwitch now computes a plainChat base (Crew Mode served, no legacy mode, no instance, not an app chat, a memory mode that allows it). crewModeOn is that base plus runsCrewMode(...), with no toggle condition. crewModeEligible adds the default-conductor exclusion and is now read only by the chip offer (ChatPage.tsx crewModeOffered). So a chat opened on a conductor that is itself the default agent has the Crew Mode welcome, its Open task board action (taskBoardOffered = (eligible || on) && root) and no memory-mode chip. Turning off also requires eligibility, since off would switch back to the same conductor. Test, red before: ChatPage.crewMode.test.tsx "is not offered when the conductor itself is the default agent" now also asserts the welcome, the board button, no memory chip and no turn-off control.

@bolichen97

Copy link
Copy Markdown
Contributor Author
span=f7bd184150c7
  • Keep the nested breadcrumb within the two-action cap (CrewWorkerBreadcrumb.tsx:75, sites :69, :82)

Fixed in ba8c2bb. The root crumb duplicated Back (both opened the main chat), so it is now a label (<span>, same title, ghost badge and truncation). Back is the one control that opens the conductor, and the sub-conductor crumb stays a button. The row holds at most two buttons in every state. Test, red before: CrewWorkerBreadcrumb.test.tsx "reads main chat > sub-conductor > member, with at most two actions in the row" asserts the root crumb is a SPAN and the nav holds exactly 2 buttons. Swept the other new rows in this PR (CrewWorkerComposerGate, AttentionCard): each keeps one or two actions per row.

@bolichen97

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles ba8c2bb reissue: agent: same ruling; this push rebases onto main (part 4 merged) and fixes two GPT findings (default-conductor Crew Mode state, breadcrumb root crumb), neither touches the picker. Links the owner-decision record #25183 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@bolichen97 recorded a reissue release (class reissue) for the first-principles AI finding on ba8c2bb1d2a52561838aebb5480584fe42c6453f.

agent: same ruling; this push rebases onto main (part 4 merged) and fixes two GPT findings (default-conductor Crew Mode state, breadcrumb root crumb), neither touches the picker. Links the owner-decision record #25183 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@bolichen97

Copy link
Copy Markdown
Contributor Author
span=c6be93993f46
  • Key approval cards by request instance (CrewApprovalCards.tsx:82, site :15)

Fixed in a4d0aa0. requestKey is now the request's whole identity: worker, origin, request_id, request_mid and request_instance. The card's React key and the firstSeen order both use it, so a replacement delivered under the same id mounts a fresh card (no stale done, no stale terminal refusal) and takes its own place in the stack. Tests, each red before: CrewApprovalCards.test.tsx "gives a replacement request under the same id a fresh card after a decision" (new request_mid) and "gives a replacement request under the same id usable buttons after a terminal refusal" (new coordinator request_instance after a 404). Swept the other per-request state this PR adds: none other keys on request_id alone. This push also rebases onto main 8a1e0fb. The Backend Lint red on the old head is main's own mypy error (_frame_parents moved to crew_filing), fixed by #25706; this PR touches no Python.

@bolichen97

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles a4d0aa0 reissue: agent: same ruling; this push keys the approval cards by the full request identity and rebases onto main, neither touches the picker. Links the owner-decision record #25183 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@bolichen97 recorded a reissue release (class reissue) for the first-principles AI finding on a4d0aa0df5b0a6cfb185a2134ae5d66bdce3eb78.

agent: same ruling; this push keys the approval cards by the full request identity and rebases onto main, neither touches the picker. Links the owner-decision record #25183 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • Three action controls in the worker header row when a sub-conductor dispatched it span=ae352628ebac

Fixed in 2faf59f. The sub-conductor crumb is now a label (<span>, same title, truncation and narrow-header order), like the root crumb. The breadcrumb's one control is Back, so the crew-worker-header row holds at most two: Back and the side panel button. The sub-conductor still opens from the Crew tab like any crew member. Test, red before: CrewWorkerBreadcrumb.test.tsx "reads main chat > sub-conductor > member, with Back its one control" asserts both crumbs are SPAN and the breadcrumb holds exactly 1 button. This push also rebases onto main 33834b9.

@bolichen97

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 2faf59f reissue: agent: same ruling; this push makes the sub-conductor crumb a label and rebases onto main, neither touches the picker. Links the owner-decision record #25183 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@bolichen97 recorded a reissue release (class reissue) for the first-principles AI finding on 2faf59f333379e05bc54c601b09c662d089e69d7.

agent: same ruling; this push makes the sub-conductor crumb a label and rebases onto main, neither touches the picker. Links the owner-decision record #25183 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@bolichen97

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 9d5d8f11668bd93ec8f3405fb2cd76e1af10cd81 reissue: agent: same ruling; this push only rebases onto main after #25706 (main's mypy fix) merged, no code change. Links the owner-decision record #25183 (comment)

@bolichen97

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 9d5d8f1 reissue: agent: same ruling; this push only rebases onto main after #25706 (main's mypy fix) merged, no code change. Corrects comment 6493582478, which named a wrong SHA. Links the owner-decision record #25183 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

AI-review override not recorded: 9d5d8f11668bd93ec8f3405fb2cd76e1af10cd81 is not the current PR head. Re-run the command with 9d5d8f1166b42b4034235a99cc631e43506f2753.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@bolichen97 recorded a reissue release (class reissue) for the first-principles AI finding on 9d5d8f1166b42b4034235a99cc631e43506f2753.

agent: same ruling; this push only rebases onto main after #25706 (main's mypy fix) merged, no code change. Corrects comment 6493582478, which named a wrong SHA. Links the owner-decision record #25183 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@bolichen97

Copy link
Copy Markdown
Contributor Author
span=298005a744c7
  • Track pending Crew Mode switches separately per chat (crewModeSwitch.ts:75, sites :84, :103, ComposerDockView.tsx:571, ChatPage.tsx:678/896/1159)

Fixed in 91f38f0. turningOn and turningOff are now sets of slot keys, not one key each. A press adds its own chat's key, and the settle removes only that key, so a second chat's press no longer drops the first chat's hold. Every consumer reads the hold through crewModeSwitching / crewModeChosen, which now check .has(currentSlot.key), so the composer, voice auto-submit and the welcome all keep A held. Tests, each red before: crewModeSwitch.test.tsx "keeps chat A held when chat B turns Crew Mode on while A's switch is in flight" (B lands first, A stays held until its own switch lands) and the same for turning off. Swept the PR for other single-key useState<string | null> pending state: these two were the only ones. This push also rebases onto main 9fb1d4a.

@bolichen97

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 91f38f0 reissue: agent: same ruling; this push keys pending Crew Mode switches per chat and rebases onto main, neither touches the picker. Links the owner-decision record #25183 (comment)

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@bolichen97 recorded a reissue release (class reissue) for the first-principles AI finding on 91f38f01ce7bc880465d5904ed89dc7ed6201961.

agent: same ruling; this push keys pending Crew Mode switches per chat and rebases onto main, neither touches the picker. Links the owner-decision record #25183 (comment)

This decision applies only to this commit. A new push requires a new judgment.

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

Requesting changes at 91f38f01ce. Auto-merge is on, so this holds it.

Blocking: a crew member's tool approval is muted again, and nothing at the conductor level tells the person. This is the same defect I raised on #24931; main fixed it in #25097 by not muting.

  • website/src/hooks/websocket/approvals.ts:198 returns early for isCrewWorkerSlot(data.slot), skipping the chime, the unread mark, the bell notification (which also drives the OS toast) and the banner; :176-179 does the same on reconnect reconcile; chatStream.ts:62 mutes the native permission row's chime and toast.
  • isCrewWorkerSlot is true whenever the conductor is a live slot, whether or not it is on screen.
  • The server does not roll a worker's pending_approval up to the root row, and the root row's needs-approval only reads its own (SessionRow.tsx:737).
  • Result: with the person in another chat or away from the window, the worker waits with no signal. The card can decide it, but nobody is told. The muting rule is only in this PR's spec edit (crew-mode.md:4665), with no docs/decisions/ entry.

Suggested fix, either or both:

  1. Keep the chime, notification, banner and toast, but point the notification's slot at crew_root, title it with the crew member's name, and open the conductor's card on click; targetsCurrentView already suppresses the banner while the conductor is on screen.
  2. Show needs-approval on the root row when crewWaitingApprovals(slots)[root.key] > 0.
    Add a test: with the conductor live but not the current chat, a worker approval produces a notification and a chime.

Checked and fine: the card approves through POST .../crew-workers/{worker}/approve (from #25480), which refuses app callers, is owner-only, binds request_mid/request_instance, delegates to api_chat_slot_approve and writes SEL; no path lets the conductor agent or a worker approve itself. pageEnvironment.ts:40 still filters through crewModeView. 41 new i18n keys are in all 13 locales. 426 vitest pass; mutations on the closed-conductor rule, crewModeView, and the crewCard conversion each redden named tests.

Owner design notes on the session list (both lines are already on main; fine as a follow-up):

  1. The round badge at SessionRow.tsx:1478 (CrewGhostBadge size={26} plus mr-2) costs every Crew Mode root row about 34px of title width. MemberRowHead already shows a 16px avatar inline on the title line; inlining a 12px KiroGhostMark in the eyebrow line would give the width back.
  2. "CREW MODE" reads as "CRE W MODE". It is not the string (every locale is plain Crew Mode). At 10px, tracking-[0.12em] is 1.2px, so letters land on fractional pixels; at DPR 1 the W shifts right by 1px, and under the gradient background-clip: text its thin diagonals look darker, so the gap reads wider. Measured in Linux Chromium with Space Grotesk: gaps 2, 2, 3 (E-W), 2, 2, 4px at DPR 1; tracking-[1px] makes E-W 2px. Not verified on macOS or Windows.

@bolichen97

Copy link
Copy Markdown
Contributor Author

[operator: bolichen97] @buluoray thanks, the blocking finding is right: this merged with the mute on main.

  • Fix: fix(crew-mode): a crew member's tool approval alerts the person, pointed at its conductor #25847 (issue Crew member tool approvals give no signal while the Crew chat is not on screen #25810). It takes both of your options. The chime, unread mark, bell note, banner and OS toast fire again. The bell note points at the Crew chat, carries the Crew member's name, offers no Approve or Reject, and opening it leads to the approval card. Option 1 alone does not mark the row: a native permission row makes no bell note for any chat. So the Crew chat's row shows "Approval needed · N" while it runs, unless the Crew chat itself owes a decision. The test you asked for is in crewMemberApprovalNotify.test.ts. It fails on main and passes with the fix. The rule is in docs/decisions/2026-10-29-crew-member-approvals-notify.md, and the spec line now matches it.
  • Session-row design notes (12px mark in the eyebrow, tracking-[1px]): these ship in a separate follow-up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crew Mode: run a chat as a conductor with its crew in the side panel

3 participants