Repository navigation
feat(crew-mode): composer chip, welcome, approval cards and the crew member view - #25183
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: Crew Mode is an ordinary agent switch, and the one take-away (conductors leave the picker) reaches only the pickers named under Reader. Notes
[DESIGN-REVIEWED] 91f38f0 Description read[DESCRIPTION-READ] 86aa8f829e3123b6cc569dc9aed969cf12100b3100f7641dd60b0ec3430fc82d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ human override accepted@bolichen97 overrode this lane for |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The blind reader read every primary control correctly (chip, Approve/Reject, Back to main chat, Open main chat), and the chip-to-mark move uses a shared layout id and has a recording. Notes
[UX-REVIEWED] 91f38f0 Description read[DESCRIPTION-READ] ceab68ee538e34f3c4100f234aa73aa1920cb3d429cc5c8fcfaf18a903b90157 That sha256 names everything this verdict read: the PR description, plus the 14 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
|
|
2a874d1 to
c2f7780
Compare
|
|
|
c2f7780 to
87282b4
Compare
|
|
/ai-review override fable 87282b4 not-applicable: agent: merge order, not a defect in the shipped shape: part 7 of 7, held until parts 1 to 4 land (#24860); the crew-workers approve, list, timeline and steer routes are part 4, and 5, 6 and 7 merge together after it. Not security or data loss: a tool call waits for the conductor's card. |
Human judgment recorded@bolichen97 recorded a not-applicable release (class
This decision applies only to this commit. A new push requires a new judgment. |
|
87282b4 to
b372e46
Compare
|
/ai-review override fable b372e46 reissue: agent: same ruling for the rebased head (rebase onto #25097 plus one askAgent on the breadcrumb's notice; the card's approve route is unchanged): merge order, held until parts 1 to 4 land (#24860), not security or data loss. Record: #25183 (comment) |
Human judgment recorded@bolichen97 recorded a reissue release (class
This decision applies only to this commit. A new push requires a new judgment. |
b372e46 to
31e7ffb
Compare
|
Rebased: onto #25097's head |
|
/ai-review override first-principles 5cec0ab reissue: agent: same ruling, no code change; this push only replaces a test sleep with a wait. Links the owner-decision record #25183 (comment) |
Human judgment recorded@bolichen97 recorded a reissue release (class
This decision applies only to this commit. A new push requires a new judgment. |
Human judgment recorded@bolichen97 recorded a reissue release (class
This decision applies only to this commit. A new push requires a new judgment. |
span=298005a744c7
|
span=f7bd184150c7
|
|
/ai-review override first-principles ba8c2bb reissue: agent: same ruling; this push rebases onto main (part 4 merged) and fixes two GPT findings (default-conductor Crew Mode state, breadcrumb root crumb), neither touches the picker. Links the owner-decision record #25183 (comment) |
Human judgment recorded@bolichen97 recorded a reissue release (class
This decision applies only to this commit. A new push requires a new judgment. |
span=c6be93993f46
|
|
/ai-review override first-principles a4d0aa0 reissue: agent: same ruling; this push keys the approval cards by the full request identity and rebases onto main, neither touches the picker. Links the owner-decision record #25183 (comment) |
Human judgment recorded@bolichen97 recorded a reissue release (class
This decision applies only to this commit. A new push requires a new judgment. |
|
|
/ai-review override first-principles 2faf59f reissue: agent: same ruling; this push makes the sub-conductor crumb a label and rebases onto main, neither touches the picker. Links the owner-decision record #25183 (comment) |
Human judgment recorded@bolichen97 recorded a reissue release (class
This decision applies only to this commit. A new push requires a new judgment. |
|
/ai-review override first-principles 9d5d8f11668bd93ec8f3405fb2cd76e1af10cd81 reissue: agent: same ruling; this push only rebases onto main after #25706 (main's mypy fix) merged, no code change. Links the owner-decision record #25183 (comment) |
|
/ai-review override first-principles 9d5d8f1 reissue: agent: same ruling; this push only rebases onto main after #25706 (main's mypy fix) merged, no code change. Corrects comment 6493582478, which named a wrong SHA. Links the owner-decision record #25183 (comment) |
|
AI-review override not recorded: |
Human judgment recorded@bolichen97 recorded a reissue release (class
This decision applies only to this commit. A new push requires a new judgment. |
span=298005a744c7
|
|
/ai-review override first-principles 91f38f0 reissue: agent: same ruling; this push keys pending Crew Mode switches per chat and rebases onto main, neither touches the picker. Links the owner-decision record #25183 (comment) |
Human judgment recorded@bolichen97 recorded a reissue release (class
This decision applies only to this commit. A new push requires a new judgment. |
buluoray
left a comment
There was a problem hiding this comment.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:
Requesting changes at 91f38f01ce. Auto-merge is on, so this holds it.
Blocking: a crew member's tool approval is muted again, and nothing at the conductor level tells the person. This is the same defect I raised on #24931; main fixed it in #25097 by not muting.
website/src/hooks/websocket/approvals.ts:198returns early forisCrewWorkerSlot(data.slot), skipping the chime, the unread mark, the bell notification (which also drives the OS toast) and the banner;:176-179does the same on reconnect reconcile;chatStream.ts:62mutes the native permission row's chime and toast.isCrewWorkerSlotis true whenever the conductor is a live slot, whether or not it is on screen.- The server does not roll a worker's
pending_approvalup to the root row, and the root row's needs-approval only reads its own (SessionRow.tsx:737). - Result: with the person in another chat or away from the window, the worker waits with no signal. The card can decide it, but nobody is told. The muting rule is only in this PR's spec edit (
crew-mode.md:4665), with nodocs/decisions/entry.
Suggested fix, either or both:
- Keep the chime, notification, banner and toast, but point the notification's
slotatcrew_root, title it with the crew member's name, and open the conductor's card on click;targetsCurrentViewalready suppresses the banner while the conductor is on screen. - Show needs-approval on the root row when
crewWaitingApprovals(slots)[root.key] > 0.
Add a test: with the conductor live but not the current chat, a worker approval produces a notification and a chime.
Checked and fine: the card approves through POST .../crew-workers/{worker}/approve (from #25480), which refuses app callers, is owner-only, binds request_mid/request_instance, delegates to api_chat_slot_approve and writes SEL; no path lets the conductor agent or a worker approve itself. pageEnvironment.ts:40 still filters through crewModeView. 41 new i18n keys are in all 13 locales. 426 vitest pass; mutations on the closed-conductor rule, crewModeView, and the crewCard conversion each redden named tests.
Owner design notes on the session list (both lines are already on main; fine as a follow-up):
- The round badge at
SessionRow.tsx:1478(CrewGhostBadge size={26}plusmr-2) costs every Crew Mode root row about 34px of title width.MemberRowHeadalready shows a 16px avatar inline on the title line; inlining a 12pxKiroGhostMarkin the eyebrow line would give the width back. - "CREW MODE" reads as "CRE W MODE". It is not the string (every locale is plain
Crew Mode). At 10px,tracking-[0.12em]is 1.2px, so letters land on fractional pixels; at DPR 1 the W shifts right by 1px, and under the gradientbackground-clip: textits thin diagonals look darker, so the gap reads wider. Measured in Linux Chromium with Space Grotesk: gaps 2, 2, 3 (E-W), 2, 2, 4px at DPR 1;tracking-[1px]makes E-W 2px. Not verified on macOS or Windows.
|
[operator: bolichen97] @buluoray thanks, the blocking finding is right: this merged with the mute on
|
Problem / Motivation
Goal: Add the composer Crew Mode chip and welcome, the conductor's approval cards, and the crew member view (breadcrumb, steer composer, reopen when the conductor is closed), the last piece, which turns Crew Mode on from the UI.
Part of landing Crew Mode (#24860): this is part 7 of 7. Parts 5 and 6 are on
main(#25097, which carried #24931), so this pull request's diff is this part alone.Part 4, #25480 (the crew list, timeline, steer and approve routes), is on
main, so the approval cards and the crew member's message box post to routesmainserves. This is the last part.Why it matters
This completes the feature: a person turns Crew Mode on from the composer, sees the welcome, decides crew approvals on the conductor's card, and opens a crew member in the main pane to read it and steer it. Everything it calls lands in parts 1 to 6.
Not a goal
mainthrough feat(crew-mode): the Crew panel, crew list and timeline #25097).What changed (motivation → approach → change)
A plain, Persistent chat on the default agent gets a Crew Mode chip on its welcome state. Pressing it switches the chat to the conductor and shows the Crew Mode welcome. Until the first message the mark can be pressed again to turn Crew Mode off; from the first message on it is locked. A chat on a conductor that is itself the default agent is in Crew Mode the same way, with no way off. A conductor chat's composer has no agent picker and stacks its crew's approval cards above the composer. Opening a crew member shows it in the main pane with a breadcrumb and the conductor's normal composer as its message box, whose placeholder names the crew member and what a send does.
[sent by session ...]line and is labelled "From conductor", "From a crew member" or "From another chat".website/scripts/capture-crew-mode-7.mjsis the screenshot harness for these surfaces. The chip and welcome areCrewModeChipandCrewModeWelcome; the switch ispages/chat/page/crewModeSwitch.ts, an ordinary agent switch to the catalog's conductor. The cards, breadcrumb and gate arecomponents/crew/CrewApprovalCards,CrewWorkerBreadcrumbandCrewWorkerComposerGate, sharinguseCrewRoot.ComposerDockView,ChatTitleOverlay,ChatTranscriptView,ChatPageandChatPanewire them in;ChatInput,chat-input/approval.tsandchat-input/props.tscarry the approval-chrome switch. The command center's attention item for a crew member's approval (command-center/model.ts,AttentionCard.tsx) is information that links to the card, with no Approve or Reject of its own; a crew member's own approval frame or native permission row raises no note, chime, banner or badge (hooks/websocket/approvals.ts,chatStream.ts).lib/crewSeed.tsandpages/chat/UserMessage.tsxlabel a delivered message, withutils/pinnedPrompt.tsandusePinnedPrompt.tsdoing the same for the pinned card;FollowUpBarplaces its tip below so it never covers a card's buttons. Strings are in the twelve locale files plusen.manual.json;docs/system-specs/modules/learn-cron-dashboard.mdnames the chip and welcome.Backwards compatibility
Compatible: the chip is offered only on a plain, Persistent, default-agent welcome state, so no existing composer control changes for other chats.
Removes: the conductor templates leave every normal chat's agent picker. Today a person can pick
kirocrew-conductor,kirocrew-ledger-conductor,kirocrew-pipeline-conductor,kirocrew-security-conductororkirocrew-team-leadfrom the picker; after this merges the Crew Mode chip is the one way onto the configured conductor (agent.crew_mode_agent), and the other conductors are reached by configuring that key. This is the design's shape (#24860; the catalog thatmainserves since #24895 says so inagent_catalog.py: "the whole conductor family, which a normal chat's agent picker leaves out so Crew Mode is the way in"). Reader:website/src/lib/crewMode.ts:withoutConductors-- picker -- drops a conductor row unless it is a crewmate, covered bycrewMode.test.ts;website/src/hooks/useAgents.tsapplies it to every picker. A chat already running a conductor is not moved: on a conductor chat the picker is replaced by the Crew Mode mark (website/src/pages/chat/page/ComposerDockView.tsx:ComposerDockView, covered byChatPage.crewMode.test.tsxandcrewModeUiR1.test.tsx). Crewmates stay listed whatever their name.Merge order:
mainalready serves the catalog's conductor set and stamps slot rows withcrew_root(#24895, part 1), so the picker rule and the chip take effect as soon as this merges. The approval cards and the crew member view read the crew-workers routes and the session lists of parts 2 to 6; parts 1 to 6 are all onmain.Tests
CrewModeChip.test.tsx,ChatPage.composerDock.test.tsx,ChatPage.crewMode.test.tsxandcrewModeUiR1.test.tsx: the chip's offer, busy state, the switch, the off toggle, the lock and the hold on the message box for the switch's round-trip.crewMode.test.tsanduseAgents.conductorChange.test.tsx: the picker leaves every conductor template out and keeps crewmates, and it re-filters when only the configured conductor changes.CrewApprovalCards.test.tsx,crewApprovalOneRule.test.tsxandcrewWorkerQuiet.test.ts: one card per request, the three decisions, that a crew member's own composer draws no approval band, and that its approval frame raises no note, chime or badge.CrewWorkerBreadcrumb.test.tsx,CrewWorkerComposerGate.test.tsx,ChatPane.crewMode.test.tsx,ChatPane.crewRootClosed.test.tsxandChatPage.crewWorkerSessionsAside.test.tsx: the breadcrumb, the gate, the closed-conductor state and the sessions list hiding.UserMessage.sessionSeed.test.tsx,ChatInput.approvalNudge.test.tsx,FollowUpBar.test.tsxandChatPage.pageOwners.test.ts: the delivered-message label, the approval nudge, the tip placement and the page owners.N/A -- not a fix PRfor a Proof line.Manual verification
The flow was exercised end to end on the full Crew Mode branch: the chip turns Crew Mode on, the welcome plays, a crew member's approval shows on the conductor's card and is decided there, and the crew member view opens, steers and reopens a closed conductor. The stubbed-gateway captures (
capture-crew-mode-7.mjs) exercise this head's own code for the card, the notice, the crew member view, the chip and the mark.Screenshots / video
Dark theme, desktop width. The chip and welcome captures come from the full Crew Mode branch on a live gateway; every other capture comes from this branch's built dashboard with the gateway's answers stubbed from fixtures (
website/scripts/capture-crew-mode-7.mjs, the repository's screenshot harness), so they show this head's code.The composer's Crew Mode chip on a new chat's welcome state, beside the memory-mode chip:
The same chip while a reply runs: dimmed with a plain border, so it reads as unavailable and not as pressed, with the line "Available after the reply." beside it:
The Crew Mode welcome after the chip is pressed. The footer's Crew Mode mark is the chip, moved: until the first message it is a pressed toggle named "Crew Mode" whose hint reads "Turn off Crew Mode. You can do this until you send your first message."; pressing it brings both chips back:
Recording: the chip pressed, both chips leave and the mark lands in the footer, then the mark pressed and the chips return (the harness's slot list does not refresh after the switch, so the side panel it opens still reads the chat as plain; on a live gateway the Crew tab lists the crew):
chip-to-mark.webm
The conductor's approval card above the composer: the crew member's title, its task line, the exact tool input, Approve and Reject in one row, and Trust this crew member on its own row with its scope line beside it:
The crew member opened in the main pane while that approval waits: the breadcrumb with its status, Back to main chat, the "From conductor" label on the delivered message, no approval band of its own, and the line "Waiting for approval in " with the link that opens it:
The same approval in the conductor's side panel, Dashboard tab, Approvals: information with "Open the approval card", no Approve or Reject of its own (the Overview section's own read is stubbed out in the harness, so it shows its failure notice):
A message past the 50,000-character limit: the draft stays in the box and the notice names the crew member and the limit. The box's placeholder names the crew member and what a send does:
A finished crew member in the main pane (breadcrumb: Done); its box still names it and what a send does:
The same crew member with its conductor's tab closed: the line says the main chat is closed and that opening it again lets the person message the crew member, with Open main chat on the line and in the breadcrumb; the box is off:
Related Issues
Closes #24860
First parts: #24895, #25131, #25480, #24931, #25097
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)