Repository navigation
feat(workflows): hold Kiro Agent plan handoffs for a person on every channel - #25459
kyleseaman wants to merge 1 commit into
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: one predicate ( Notes
[DESIGN-REVIEWED] a94e626 Description read[DESCRIPTION-READ] 3fcb22a08f4ef64af49a41fdd69f8a684421ba029b48bd1b8bb2ca5b12f024a1 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Every rung this PR closes is one main already closes on the dashboard chat path, and the flag stays off by default. One re-export has no consumers. Notes
What this change shipsInventory (10 items) — 9 justifiedIntent: when a developer turns on Kiro Workflows, a plan handoff from a KAS run waits for a person on every channel and is never answered automatically. This is an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] a94e626 Description read[DESCRIPTION-READ] c739356c426df98819970d44449f7f8dca21c0062c0e1638341f60c107f7a160 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — 🔴 changes requested (blocking)GPT 6.1 found at least one blocking issue that must be resolved before merging This comment is updated in place on each push. BLOCKING -- src/kiro_crew/messaging/driver.py:1584 -- Auto-mode channels reject attended plan handoffs without asking
[BLOCK-MERGE] a94e626 Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1 — MEDIUM harm, upheld. Under auto approval, every plan handoff on these channels is refused and no person is asked. This PR exists to hold those handoffs for a person, so its goal fails on a whole approval mode. It fails closed and the agent sees the refusal, so it is recoverable.
False positive or not applicable? A repository writer can comment: |
102dbec to
87d2e9d
Compare
af54535 to
9cb242b
Compare
87d2e9d to
2e1f8d3
Compare
9cb242b to
45001d6
Compare
2e1f8d3 to
4c1d139
Compare
45001d6 to
ca829fd
Compare
a57464d to
0a2397e
Compare
9a3e58d to
45f6b67
Compare
0a2397e to
2f734ed
Compare
45f6b67 to
a9dd6c0
Compare
2f734ed to
781f017
Compare
a9dd6c0 to
0ef14fe
Compare
781f017 to
67be079
Compare
0ef14fe to
9b882db
Compare
9b882db to
a94e626
Compare
…channel A Kiro Agent workflow plan handoff is the person's call in every approval mode. Channel trust and YOLO on a messaging channel, Slack's turn approvals and permission ladder, the messaging driver's auto-approve gate, the tool-permission gate and the unattended (no-approver) path never answer one on the person's behalf: an attended surface shows the card, an unattended one refuses with a reason. A gate deny still wins. Other requests are unchanged; a chat model's own question is a _kiro/userInput request on the elicitation path.
67be079 to
552b9b6
Compare
a94e626 to
3abb813
Compare
|
Stale-PR cleanup check: this is part of the stacked Kiro Workflows series (base |
Off by default behind
agent.kas_workflows(Developer › Feature Previews); with it off, behaviour is main's. The holds act only on Kiro Agent plan handoffs, which exist only with workflows on.Problem / Motivation
Goal: When Crew's agent backend is Kiro Agent (KAS), a developer can turn on Kiro Workflows and launch, watch, answer and control KAS workflow runs from the dashboard, with every question or approval a run raises held for a person.
Why it matters
Kiro Agent is the default harness and ships its own workflow engine (recipes, multi-step runs, steps that park for input), but Crew drops the whole
_kiro/workflow/*surface: a KAS chat cannot start a workflow, nobody sees a run's steps, and a step that asks a question stalls with no sign anywhere. A run left to channel auto-answer paths could have a person's answer given on their behalf.Not a goal
agent.kas_workflows); with it off, Crew behaves exactly as main.workflow_run, saved Crew workflows). They keep running.What changed (motivation → approach → change)
A Kiro Agent workflow plan handoff is the person's call in every approval mode. These paths used to auto-approve one (a chat model's own question is a
_kiro/userInputrequest on main's elicitation path, not held here):channel.py,messaging/driver.pyslack/gateway_runtime/turn_approvals.py,slack/handler_runtime/permission_ladder.py,slack/gateway.py,slack/handler.pytool_permission.pyllm_helpers_parts/tool_approval.pykas_workflows/person_hold.py,channel.py,dashboard/interaction_coordinator.py,dashboard/chat_api/slot_approval.pyAn attended surface shows the card; an unattended one refuses with a reason. A gate deny still wins. Every other request is unchanged. A grant made while a handoff waits does not answer it either: the hold site marks the future (the channel card, and
request_approval(person_only=True)from the Slack gateway's two background calls), and both bulk loops inapi_chat_modeleave a marked one pending, so only the card's own buttons settle it.Stack
Split out of #25395, which was over the 1 MB review cap. Merge bottom-up. Only a PR based on
maingets CI (ci.ymlandfast-gate.ymlrun onpull_request: branches: [main]), so each stacked PR is rebased ontomainonce the one below it merges. A and the B1a protocol PR do not depend on each other. C2's UI uses A's card, which is on main.feat/kas-wf-1-session-cardsmainfeat/kas-wf-2-backendmainfeat/kas-wf-2b-enginemainfeat/kas-wf-2c-dashboardfeat/kas-wf-2b-enginefeat/kas-wf-3-person-holdsfeat/kas-wf-2c-dashboardfeat/kas-wf-4-frontendfeat/kas-wf-3-person-holdsfeat/kas-wf-4b-frontend-uifeat/kas-wf-4-frontendBackwards compatibility
Compatible: only KAS plan handoffs, which exist only with the switch on, change path.
Removes nothing: only additions.
Tests
test_kas_channel_person_hold.py,test_kas_unattended_person_hold.py,test_kas_bulk_grant_person_hold.py(an all-slots Trust and a YOLO grant leave a held background and a held channel handoff pending while settling an ordinary request beside each; red with either the marks or the sweep guards reverted),test_slack_gateway.py,test_slack_handler_more_coverage.py.Proof: not provable -- other: feature PR, not a fix; each behaviour has its own test named above.
Manual verification
N/A — unit coverage per channel path; a live channel check needs the UI PRs.
Screenshots / video
N/A — this PR changes no website file, so it has no rendered surface.
Related Issues
N/A — no tracking issue, by the owner's choice.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)