Repository navigation
ci: retry a failed dependency review and report a graph-API outage as could-not-run - #25611
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The cause is an outage on GitHub's side that this repository can't fix. Every item has a named harm, backed by the linked runs and #25082. Notes
What this change shipsInventory (6 items) — 5 justifiedIntent: stop a GitHub dependency-graph outage from showing up as a license failure on every open PR. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] e8c6775 Description read[DESCRIPTION-READ] 2fb35ee1389e1cbc7217ab802d1601d5b25aafd3f56bdc3cbbee2465956e3564 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: every path still fails closed, the take-away check finds nothing removed, and the change is a workflow edit that a revert undoes cleanly. Notes
[DESIGN-REVIEWED] e8c6775 Description read[DESCRIPTION-READ] 77e8c969799bf046a4a54ec69912f0e050bcacfaac4e387d7a5c5cb8cac608c0 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
3c62e35 to
bf9b0c0
Compare
bf9b0c0 to
e8c6775
Compare
iamwhatever
left a comment
There was a problem hiding this comment.
Approve at e8c67756601abbd5f74bfc7ed0d74b68464b915f.
The gate stays fail-closed. A failed review is retried once. If the retry passes, the gate passes with a warning, and every other path of the verdict step ends in exit 1 (dependency-review.yml#L54-L105). The trigger and permissions are unchanged. The token is used only for a GET in a step that runs no PR code, and the override-label path is untouched. CI and every AI lane are green on this head.
AI findings judged non-blocking
- First Principles Review (Note): three API probes after a retry is oversized. This only adds about 40s on a path that already fails (dependency-review.yml#L93-L101).
- Design Review (Note): a flapping API can make an outage read as a license verdict. Only the message wording is affected; the job fails either way (dependency-review.yml#L95-L98).
— crew-pr-reviewer (r135)
Problem / Motivation
Goal: a GitHub dependency-graph outage no longer reads as a license failure on every open PR.
Between about 23:00 and 00:10 UTC on 10-27/28, and again around 18:05 UTC on 10-28,
Dependency License Gatefailed PRs from forks and the same repo alike withDependency review is not supported on this repository. Please ensure that Dependency graph is enabled. PRs opened after the window passed, so the settings never changed. The gate runsactions/dependency-review-actiononce and fails on any error.Why it matters
Every PR in an outage window needs a rerun or a new push, and the red check reads like a policy finding.
Not a goal
license-overridelabel path, or the job's permissions.Intended? / Repro
Intended? No. The workflow's header (
.github/workflows/dependency-review.yml:1-17on main) describes a license gate; an API outage is not a license decision.Repro: run 40602827883 job 122545495755 (#9749, 00:04) and run 40606266923 job 122546412890 (#25074) fail with the message above; #25057, #25070, #25072, #25073 went red in the same window and later PRs passed.
What changed (motivation → approach → change)
Symptom: outage reported as a policy failure. Cause: one attempt, no classification. Change: retry once, then tell an outage from a verdict, as the issue suggests.
.github/workflows/dependency-review.yml:id: reviewandcontinue-on-error: true.review_retry, alsocontinue-on-error).Report the review verdictruns whenever the first review failed. A passing retry passes the gate with a warning. Two failures: it probesGET repos/{repo}/dependency-graph/compare/{base}...{head}up to 3 times. An API that answers → fails as the action's license verdict. An API that does not → fails as "could not run", naming the API's answer and saying it is not a license finding.docs/ci/ci-and-reviews.md: the license-gate paragraph states the rule.Security
The job's token and permissions are unchanged (
contents: read,pull-requests: write). The probe is a GET with that token. No path can pass the gate without a successful review.Backwards compatibility
Compatible: a passing first review is unchanged. A real license failure still fails, about 80s later (the pause and the retry).
Removes nothing.
Tests
test/test_dependency_license_gate_outage.py(new):continue-on-error; the retry uses the same action and config, after the pause; the verdict step runs on the first failure and reads the retry's outcome.gh: a passing retry passes with no probe; two failures with a working API fail as a license verdict after one probe; two failures with the API down fail as "could not run", carrying the API'sHTTP 503, after three probes.test/test_pr_quality_gates.py::test_the_job_is_read_only_and_the_write_scoped_gate_stays_separatestill holds (the job still uses the action and keepspull-requests: write).Proof: not provable -- other: this host runs no local tests; CI runs the new tests
Manual verification
The workflow parses as YAML and the verdict script passes
bash -n. Static gates: black, isort, flake8,scripts/docs_lint.py,scripts/check_comment_history.py.Related Issues
Fixes #25082
Sibling sweep
Swept: git grep -n "dependency-review-action" -- .github test
Sibling: .github/workflows/dependency-review.yml -- changed here (the only caller)
Sibling: test/test_pr_quality_gates.py -- not affected (its assertions still hold)
Pattern harvest
Not generalizable: one third-party action call.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.