Skip to content

refactor(apps): mount the shared ResizeHandle on the app column splitters - #25618

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
refactor/app-splitters-resize-handle-9580
Oct 29, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
refactor/app-splitters-resize-handle-9580

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: every draggable column edge in the dashboard is the same grip: Spec Builder's and Code Review Sage's splitters mount the shared ResizeHandle, like the Sessions sidebar, Crew Members, Issue Radar, Task Runner and Projects.

Three app splitters still drew their own flat strip (w-1.5 … hover:bg-accent/30): a 6px translucent band on hover instead of the 2px rounded accent bar the rest of the dashboard shows.

Why it matters

Two apps look different from their neighbours on the same affordance. And because these three never mounted the shared component, the next restyle of the grip would miss them again.

Not a goal

  • Changing resize ranges, persistence or collapse behaviour.
  • The sidebar's horizontal history-pane splitter (a different affordance).

Intended? / Repro

Intended? No. #9428 unified the grip; these three were left out only for that PR's scope (see the issue).

Repro (current main):

  • website/src/apps/code-review-sage/Workspace.tsx:45, website/src/apps/spec-builder/components/ColumnSplitter.tsx:46, website/src/apps/spec-builder/components/SpecDetail.tsx:815: each draws cursor-col-resize hover:bg-accent/30.
  • grep -rn 'hover:bg-accent/30' website/src/apps finds all three. Hovering any of them shows the flat band (Before shots below).

What changed (motivation → approach → change)

Symptom: three splitters look and behave differently. Cause: hand-rolled copies. Change: mount ResizeHandle and adapt each caller.

  • components/ResizeHandle.tsx: optional title prop (defaults to the generic copy), so each surface keeps its own tooltip. Its doc no longer names these splitters as exceptions.
  • apps/code-review-sage/Workspace.tsx: the local Splitter is gone; the rail edge is <ResizeHandle … onNudge={rail.nudge} value/min/max />, so it also gains keyboard resize, which it lacked.
  • apps/spec-builder/components/ColumnSplitter.tsx: a thin wrapper over ResizeHandle that keeps its props. ResizeHandle nudges in px (16, or 64 with Shift); the wrapper hands the caller one step per 16px, so ArrowLeft/Right still call onNudge(-1) / onNudge(1).
  • apps/spec-builder/components/SpecDetail.tsx: the document divider's hand-rolled mouse drag (window mousemove/mouseup) moves to usePointerDrag (mouse, touch and pen, with pointer capture). It keeps the 25–75% clamp, the body cursor/selection lock during a drag (released on end and on unmount), the 4% arrow step, and hidden on a phone.
  • aria-labels and tooltip texts are unchanged on all three.

Screenshots

Captured with Playwright on Spec Builder's real ColumnSplitter between two panes, run against main (before) and this branch (after). The capture page is not committed. Code Review Sage's rail edge and the Spec Builder document divider draw the same markup before and the same component after.

Before, hover (dark):

Before, hover, dark: the old 6px translucent band

After, hover (dark):

After, hover, dark: the shared 2px rounded accent bar

After, keyboard focus (light):

After, keyboard focus, light: the shared grip with its focus ring

Security

No security surface: presentational components.

Backwards compatibility

Compatible. Same labels, ranges and stored widths. Code Review Sage's rail edge gains arrow-key resize; Spec Builder's column splitter gains Shift+arrow (4 steps). Removes nothing user-facing.

Tests

  • website/src/test/ResizeHandle.parity.test.tsx: the three files join the surfaces that must mount ResizeHandle and hand-roll no vertical separator.
  • website/src/test/SpecBuilderSpecDetailCoverage.test.tsx: the drag test drives pointer events (down / move / up) instead of mouse events; the clamp, cursor lock and "a move after the end does nothing" assertions are unchanged. The arrow-key test is unchanged (48% then 44%).
  • website/src/test/specBuilderNarrowViewport.test.ts: the "divider hidden on a phone" pin reads the ResizeHandle className.
  • website/src/test/SpecBuilderColumnSplitterCov80.test.tsx: unchanged and still holds (separator semantics, ±1 steps, ignored keys, spread pointer handlers).

On main the parity test fails for the three new surfaces.

Proof: not provable -- other: this host runs no local tests; CI runs them. Visual evidence is the attached captures

Manual verification

Playwright captures of before/after (attached). Static gates run locally: eslint on the edited files, tsc -p tsconfig.app.json, check-i18n-strings, check-theme-colors, check-phantom-classes.

Related Issues

Fixes #9580

Sibling sweep

Swept: grep -rn 'hover:bg-accent/30|cursor-col-resize' website/src/apps
Sibling: apps/code-review-sage/Workspace.tsx -- changed here
Sibling: apps/spec-builder/components/ColumnSplitter.tsx, SpecDetail.tsx -- changed here
Sibling: apps/issue-radar, apps/papyrus -- not affected (already mount ResizeHandle)

Pattern harvest

Not generalizable: the parity test now lists these surfaces, which is the guard against a future copy.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners October 29, 2026 03:35
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of adcb0475cd09c58bd6819e053aea440ee7f437b1 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

No design-level concerns: all three splitters now mount the shared ResizeHandle, the step unit is converted at each caller, and the parity test stops a new hand-rolled copy from landing.

Notes

  • The SpecDetail divider's hidden relies on cn's tailwind-merge replacing the default flex. The narrow-viewport test only matches the source text, so a rendered toHaveClass('hidden') check on a phone would pin the behaviour.

[DESIGN-REVIEWED] adcb047

Description read

[DESCRIPTION-READ] c51c9d2bd291ea5d74605c017b8edc341423cf32026ec70f69f58e5f2b013686

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of adcb0475cd09c58bd6819e053aea440ee7f437b1 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. Two column edges outside apps/ still draw the hand-rolled strip that the Goal says no edge should draw.

Notes

  • Item 1 — symptom-level: the Goal says "every draggable column edge in the dashboard is the same grip", but the sweep only covered website/src/apps. Grepping cursor-col-resize across website/src outside tests finds 2 unfixed siblings: website/src/pages/WebhooksPage.tsx:1365 (w-1.5 shrink-0 cursor-col-resize hover:bg-accent/30) and website/src/pages/chat/FileBrowserRail.tsx:616 (hover:bg-accent/40). Subtraction: replace both hand-rolled strips with the existing ResizeHandle, or narrow the Goal's "every" claim to the app splitters.

What this change ships

Inventory (7 items) — 6 justified

Intent: make the app column splitters look and behave like the dashboard's shared resize grip (#9580). This is a FIX.

  1. Spec Builder's column splitter and document divider, and Code Review Sage's rail edge, now show the 2px accent grip instead of the flat 6px band — symptom-level (2 siblings in pages/ left unfixed)
  2. Code Review Sage's rail edge now resizes with the arrow keys — justified
  3. Spec Builder's column splitter gains Shift+arrow for 4× steps — justified
  4. Spec Builder's document divider now drags with touch and pen (pointer capture) — justified
  5. ResizeHandle takes an optional title (3 consumers) — justified
  6. The ResizeHandle doc no longer lists these splitters as exceptions — justified
  7. The parity test now requires all three surfaces to mount ResizeHandle — justified

[FIRST-PRINCIPLES-REVIEWED] adcb047

Description read

[DESCRIPTION-READ] 904add5e75ff99ad052d1b1555295d71f0b963eb48e41fad0f179976831dc17a

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)

UX-level review of adcb0475cd09c58bd6819e053aea440ee7f437b1 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

cannot evaluate: missing the Code Review Sage rail edge and the Spec Builder document divider, which both now mount ResizeHandle. The only shots are of a synthetic two-pane page, and none shows the new grip at rest.

Evidence gaps

  • Code Review Sage rail edge: Workspace.tsx swaps Splitter for <ResizeHandle … onNudge={rail.nudge} /> and adds arrow-key resize, but no screenshot shows the edge. Needed: a hover shot and a keyboard-focus shot of the real Workspace between the rail and the report pane.
  • Spec Builder document divider: SpecDetail.tsx replaces its <div onMouseDown> with <ResizeHandle handleProps={dividerDrag} />, but no screenshot shows it. Needed: a hover shot of the divider between the chat and docs columns in a loaded spec.
  • New grip at rest: shot-01 is the old strip on hover. Shots 02 and 03 show only hover and focus. Needed: an "After, resting" shot.
  • The real page: all three shots come from an uncommitted Playwright page with empty panes. On that page the grip spans only the 88px header strip, and the blind reader called it "oddly short for a divider". Shots of Spec Builder itself would show whether the grip runs the full column height.

Notes

  • The blind reader identified the grip on shots 02 and 03 only as "a guess". It read the before state's "thick, dull" band as heavier than the active states, which matches what the PR is fixing.

[UX-REVIEWED] adcb047

Description read

[DESCRIPTION-READ] 0b50b447509708d3aaee5efc0f9bdfe6c7e5dbaa7b9412899bb35ad530795a4c

That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed adcb0475cd09c58bd6819e053aea440ee7f437b1 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] adcb047

Verdict parsed from the review's SHA-scoped output markers for commit adcb0475cd09c58bd6819e053aea440ee7f437b1.

False positive or not applicable? A repository writer can comment:
/ai-review override fable adcb0475cd09c58bd6819e053aea440ee7f437b1 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of adcb0475cd09c58bd6819e053aea440ee7f437b1 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] adcb047

False positive or not applicable? A repository writer can comment:
/ai-review override gpt adcb0475cd09c58bd6819e053aea440ee7f437b1 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 29, 2026
@CrysisDeu
CrysisDeu force-pushed the refactor/app-splitters-resize-handle-9580 branch from 8716d05 to 30abf77 Compare October 29, 2026 08:10
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 29, 2026
@CrysisDeu
CrysisDeu force-pushed the refactor/app-splitters-resize-handle-9580 branch from 30abf77 to adcb047 Compare October 29, 2026 11:32
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 29, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of the watch holder (bolichen). Design and First Principles pass on this head (or skipped / author override), UX skipped or pass, no conflict, no open change request.

@KiroCrewCaptain
KiroCrewCaptain merged commit 25b3711 into main Oct 29, 2026
139 of 146 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the refactor/app-splitters-resize-handle-9580 branch October 29, 2026 19:53
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mount the shared ResizeHandle on Spec Builder's and Code Review Sage's column splitters

2 participants