Repository navigation
refactor(apps): mount the shared ResizeHandle on the app column splitters - #25618
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS No design-level concerns: all three splitters now mount the shared Notes
[DESIGN-REVIEWED] adcb047 Description read[DESCRIPTION-READ] c51c9d2bd291ea5d74605c017b8edc341423cf32026ec70f69f58e5f2b013686 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Two column edges outside Notes
What this change shipsInventory (7 items) — 6 justifiedIntent: make the app column splitters look and behave like the dashboard's shared resize grip (#9580). This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] adcb047 Description read[DESCRIPTION-READ] 904add5e75ff99ad052d1b1555295d71f0b963eb48e41fad0f179976831dc17a That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing the Code Review Sage rail edge and the Spec Builder document divider, which both now mount Evidence gaps
Notes
[UX-REVIEWED] adcb047 Description read[DESCRIPTION-READ] 0b50b447509708d3aaee5efc0f9bdfe6c7e5dbaa7b9412899bb35ad530795a4c That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
8716d05 to
30abf77
Compare
30abf77 to
adcb047
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Approved on behalf of the watch holder (bolichen). Design and First Principles pass on this head (or skipped / author override), UX skipped or pass, no conflict, no open change request.
Problem / Motivation
Goal: every draggable column edge in the dashboard is the same grip: Spec Builder's and Code Review Sage's splitters mount the shared
ResizeHandle, like the Sessions sidebar, Crew Members, Issue Radar, Task Runner and Projects.Three app splitters still drew their own flat strip (
w-1.5 … hover:bg-accent/30): a 6px translucent band on hover instead of the 2px rounded accent bar the rest of the dashboard shows.Why it matters
Two apps look different from their neighbours on the same affordance. And because these three never mounted the shared component, the next restyle of the grip would miss them again.
Not a goal
Intended? / Repro
Intended? No. #9428 unified the grip; these three were left out only for that PR's scope (see the issue).
Repro (current main):
website/src/apps/code-review-sage/Workspace.tsx:45,website/src/apps/spec-builder/components/ColumnSplitter.tsx:46,website/src/apps/spec-builder/components/SpecDetail.tsx:815: each drawscursor-col-resize hover:bg-accent/30.grep -rn 'hover:bg-accent/30' website/src/appsfinds all three. Hovering any of them shows the flat band (Before shots below).What changed (motivation → approach → change)
Symptom: three splitters look and behave differently. Cause: hand-rolled copies. Change: mount
ResizeHandleand adapt each caller.components/ResizeHandle.tsx: optionaltitleprop (defaults to the generic copy), so each surface keeps its own tooltip. Its doc no longer names these splitters as exceptions.apps/code-review-sage/Workspace.tsx: the localSplitteris gone; the rail edge is<ResizeHandle … onNudge={rail.nudge} value/min/max />, so it also gains keyboard resize, which it lacked.apps/spec-builder/components/ColumnSplitter.tsx: a thin wrapper overResizeHandlethat keeps its props. ResizeHandle nudges in px (16, or 64 with Shift); the wrapper hands the caller one step per 16px, so ArrowLeft/Right still callonNudge(-1)/onNudge(1).apps/spec-builder/components/SpecDetail.tsx: the document divider's hand-rolled mouse drag (windowmousemove/mouseup) moves tousePointerDrag(mouse, touch and pen, with pointer capture). It keeps the 25–75% clamp, the body cursor/selection lock during a drag (released on end and on unmount), the 4% arrow step, andhiddenon a phone.aria-labels and tooltip texts are unchanged on all three.Screenshots
Captured with Playwright on Spec Builder's real
ColumnSplitterbetween two panes, run against main (before) and this branch (after). The capture page is not committed. Code Review Sage's rail edge and the Spec Builder document divider draw the same markup before and the same component after.Before, hover (dark):
After, hover (dark):
After, keyboard focus (light):
Security
No security surface: presentational components.
Backwards compatibility
Compatible. Same labels, ranges and stored widths. Code Review Sage's rail edge gains arrow-key resize; Spec Builder's column splitter gains Shift+arrow (4 steps). Removes nothing user-facing.
Tests
website/src/test/ResizeHandle.parity.test.tsx: the three files join the surfaces that must mountResizeHandleand hand-roll no vertical separator.website/src/test/SpecBuilderSpecDetailCoverage.test.tsx: the drag test drives pointer events (down / move / up) instead of mouse events; the clamp, cursor lock and "a move after the end does nothing" assertions are unchanged. The arrow-key test is unchanged (48% then 44%).website/src/test/specBuilderNarrowViewport.test.ts: the "divider hidden on a phone" pin reads theResizeHandleclassName.website/src/test/SpecBuilderColumnSplitterCov80.test.tsx: unchanged and still holds (separator semantics, ±1 steps, ignored keys, spread pointer handlers).On main the parity test fails for the three new surfaces.
Proof: not provable -- other: this host runs no local tests; CI runs them. Visual evidence is the attached captures
Manual verification
Playwright captures of before/after (attached). Static gates run locally: eslint on the edited files,
tsc -p tsconfig.app.json,check-i18n-strings,check-theme-colors,check-phantom-classes.Related Issues
Fixes #9580
Sibling sweep
Swept: grep -rn 'hover:bg-accent/30|cursor-col-resize' website/src/apps
Sibling: apps/code-review-sage/Workspace.tsx -- changed here
Sibling: apps/spec-builder/components/ColumnSplitter.tsx, SpecDetail.tsx -- changed here
Sibling: apps/issue-radar, apps/papyrus -- not affected (already mount ResizeHandle)
Pattern harvest
Not generalizable: the parity test now lists these surfaces, which is the guard against a future copy.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.