Repository navigation
fix(members): label the post-create roster retry 'Refresh the list' - #25633
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS This change only edits copy. No decision record names the old label, and the PR includes before/after renders. [DESIGN-REVIEWED] ebd139f Description read[DESCRIPTION-READ] 68f38f69ae1281d64df58386a769eb7efd8af5101576ac917368b00c03dccee4 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. This PR changes one label, and the blind reader read the new label correctly ("sure", "yes") in all four after screenshots. Notes
[UX-REVIEWED] ebd139f Description read[DESCRIPTION-READ] 16a72983203e4dfae1aba3ca48b7449a15beda90e274cd3cb81ffbd64170ceb8 That sha256 names everything this verdict read: the PR description, plus the 11 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
iamwhatever
left a comment
There was a problem hiding this comment.
APPROVE at ebd139f4d408b47053b66bed5111f1ed9d1709fa.
Copy-only fix: the post-create retry label becomes Refresh the list in every catalog, matching the notice's own wording, and the new test pins that the retry only re-reads the roster (no second create, greeting or message). The new capture script binds its dev server to 127.0.0.1. All checks are green and no review requests changes.
AI findings judged non-blocking
- First Principles (PASS note; the verdict was withheld from the PR and read from the run artifact), the new capture script duplicates the existing harness: dev-only evidence tooling, no user impact.
KiroCrew/website/scripts/capture-roster-retry-label.mjs
Lines 1 to 40 in ebd139f
- UX (PASS note), mobile shows no roster after the retry: outside this label fix and offered as an optional idea, not a promised follow-up.
KiroCrew/website/src/pages/members/MembersPageThread.tsx
Lines 648 to 653 in ebd139f
— crew-pr-reviewer (r135)
Problem / Motivation
Goal: the retry on the "created, but the list didn't refresh" notice says that it re-reads the list, not that it does something to the crewmates.
After a create lands and the roster re-read fails, the Crewmates page shows
Radar was created, but the list didn't refresh.with a button labelledRefresh your mates. A blind UX reader on PR #12924 was unsure whether that refreshes the crewmates themselves or only reads the roster again.Why it matters
The button sits right after a sentence saying a crewmate was just created. A label that names the crewmates can read as "do something to Radar again" (restart it, create it again). The action only re-reads the roster, so the label should say that.
Not a goal
Intended? / Repro
Intended? No. The code comment above the button on main says the label "names the one step it repeats" so it cannot read as "create Radar again"; the step it repeats is the roster read (
website/src/pages/members/MembersPage.tsx:736retryPostCreatecallslistCreatedoropenCreated, both of which onlyrosterQuery.refetch()). The labelRefresh your matesnames the crewmates instead of the list, which is the ambiguity the UX review found.Repro (current main, 4efafcf): create a crewmate while
GET /api/membersfails after the create. The notice showsRadar was created, but the list didn't refresh.with the buttonRefresh your mates(website/src/pages/members/MembersPageThread.tsx:663, keypages.membersPage.create_retry_roster,website/src/i18n/locales/en.json:8064). The before frames below are that state, captured from main's catalog.What changed (motivation → approach → change)
Symptom: a retry label that names the crewmates. Cause: the catalog string names the roster's rows, not the roster. Change: name the list, using the term the same notice and its sibling strings already use (
the list didn't refresh,Refresh the list for {{name}} before adding another mate.).pages.membersPage.create_retry_roster:Refresh your mates→Refresh the list, in all 12 catalogs. Each locale reuses the noun its owncreate_roster_failed/add_member_pending_rosterstrings use for the list, in the register the old label had:Liste aktualisieren, esActualizar la lista, frActualiser la liste, itAggiorna l'elenco, ptAtualizar a lista, ruОбновить список, ja一覧を更新, ko목록 새로고침, zh-CN刷新列表, hiसूची रिफ़्रेश करो, bnতালিকাটি রিফ্রেশ করো.scripts/gen-pseudolocale.mjs.MembersPageThread.tsx: the comment above the button quotes the new label.scripts/capture-roster-retry-label.mjs(new): evidence harness for this state, desktop and mobile, dark and light. It stubs a create that lands and roster reads that fail, then presses the retry and checks it sent one more roster read, no second create and no chat message. Withselfit starts a Vite dev server in-process on a loopback ephemeral port.scripts/capture-crewmates-page-create.mjs: its two label checks expect the new label.Backwards compatibility
Compatible: copy only. No key, testid, API or behavior changes.
Removes nothing: no key, field or error path is removed.
Tests
MembersPage.newCrewmateOutcomes.test.tsx, new:the roster retry is a list re-read, not a greeting resend: its label reads the list, and a click sends no create and no message. The label is exactlyRefresh the listand carries no send/again/message/greet/mates wording; a press against a still-failing roster makes another roster read and nocreateKirocrewAgent,memberGreet,sendChator thread open for the new crewmate.Refresh the list.MembersPage.createLinks.test.tsx: the stay-in-chosen-chat retry test also asserts the create was sent only once.Proof: not provable -- other: this host runs no local tests; CI runs the new tests
Manual verification
Captured with
node scripts/capture-roster-retry-label.mjs self <dir>against this branch, and with main'sen.jsonfor the before frames (28/28 checks OK in each run, including the "no second create, no message" checks). Static gates run locally: eslint on the changed files,tsc -p tsconfig.app.json --noEmit,scripts/check-i18n-keys.mjs,scripts/i18n-check.mjs,gen-pseudolocale.mjs --check,scripts/check_file_line_cap.py.Desktop, dark: before / after
Mobile, light: before / after
Desktop light and mobile dark
Related Issues
Fixes #14474
Sibling sweep
Swept: git grep -n "Refresh your mates|Refresh your crewmates|create_retry_roster"
Sibling: website/src/pages/members/MembersPageThread.tsx -- changed here (the one render site and its comment)
Sibling: website/src/pages/members/MembersPage.newCrewmateOutcomes.test.tsx -- changed here (label assertions)
Sibling: website/scripts/capture-crewmates-page-create.mjs -- changed here (label checks)
Sibling: website/src/i18n/locales/*.json -- changed here (all 12 catalogs plus en-XA)
Pattern harvest
Rule candidate: a retry button's label names the thing it re-reads (the list), never the items in it, so it cannot read as acting on those items.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.