Skip to content

feat(dashboard): scroll every tab strip sideways with one wheel hook - #25680

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
abirkel:fix/tab-strips-wheel-hook
Oct 29, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
abirkel:fix/tab-strips-wheel-hook

Conversation

@abirkel

@abirkel abirkel commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A vertical mouse wheel scrolls every tab and chip strip sideways, with the same rules on each one.

Only the side panel tab row uses the shared wheel hook from #22024. The other strips differ:

  • The follow-up bar cancels every wheel event over its row, even at either end, so the page cannot scroll there.
  • The embed strip adds the raw wheel delta from a passive handler, so the page scrolls with the strip.
  • The session, terminal and File Explorer tab strips ignore the wheel.

Why it matters

With a mouse wheel and no trackpad, a user cannot reach a tab or chip that is clipped off the edge of these strips.

Not a goal

What changed (motivation → approach → change)

The hook already has the rules we want. The five strips needed to use it.

Each strip binds the hook from its scroller's ref. The follow-up bar and the embed strip already had a ref callback, so the hook goes in there and their own wheel handlers are deleted. The other three strips (SessionTabStrip, the terminal strip in BottomTerminalPanel, and the File Explorer apps/file-explorer/TabStrip.tsx) get a small ref callback that calls the edge-cue hook and the wheel hook.

A wheel over the follow-up bar or the embed strip now behaves like the side panel: the page scrolls once the row is at an end, and a wheel with Ctrl, Shift, Alt or Meta held is left alone.

Backwards compatibility

Compatible: no props, keys or APIs change. Only the wheel behaviour above changes.

Reader: website/src/components/FollowUpBar.tsx:setScroller -- chat -- the hook binds from the same ref callback | FollowUpBar.scrollEdges.test.tsx "scrolls sideways on a vertical wheel only while the chips are clipped"
Reader: website/src/components/EmbedTabStrip.tsx:setStrip -- app -- the hook binds from the same ref callback | EmbedTabStripCoverage.test.tsx "turns vertical wheel movement into horizontal scrolling"

Tests

One shared helper, expectWheelToScrollRow, checks that a strip scrolls sideways while clipped and leaves the wheel to the page at its far end and while the row fits. Each of the five strips has a test that calls it. Removing the wheel binding from any one strip fails that strip's test. I deleted the embed strip's "keeps the wheel translation" test, because the handler it guarded is gone.

Manual verification

I ran each strip's real component in Chromium 145, 320 px wide with ten tabs, over a tall page. All 37 checks pass here, and 19 fail on main.

  • A wheel over a clipped row scrolls the row. At the end of the row, the next wheel scrolls the page. A row that fits leaves the wheel to the page. With Alt held, the row stays put.
  • On main, the session, terminal and File Explorer strips ignored the wheel. The follow-up bar never let the page scroll at its end. The embed strip scrolled the page and did not reliably move its row.
  • A wheel in the middle of a drag raised no errors in the terminal or embed strip, and no tab was lost. The embed row did not move mid-drag, as on main. I could not tell whether the terminal tabs reordered, because they share one label.

Not checked: touchpad, Windows, macOS, Firefox, WebKit, page zoom and display scaling.

Screenshots / video

Why no screenshot: the change binds a wheel listener and moves no pixel.

Related Issues

Closes #22154
Part of #23982

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Only the side panel tab row uses useWheelToHorizontal. The follow-up
bar cancels every wheel event over its row, even at either end, so the
page cannot scroll while the pointer is over the chips. The embed
strip adds the raw wheel delta from a passive handler, so the page
scrolls with the strip. The session, terminal and File Explorer tab
strips ignore the wheel.

Bind useWheelToHorizontal on all five strips and delete the two
handlers it replaces. The follow-up bar and the embed strip now let
the page scroll at the ends of the row, and they ignore a wheel with a
modifier key held.
@abirkel
abirkel requested review from a team and KiroCrewCaptain as code owners October 29, 2026 06:35
@abirkel
abirkel requested a review from buluoray October 29, 2026 06:35
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running labels Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ✅ PASS

UX-level review of b3a9c5427d70fb55cc8b763d070c5a60a39cd2e1 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. The diff only binds the existing wheel hook to five tab and chip strips. It adds or changes no control, label or state that a screenshot could show.

[UX-REVIEWED] b3a9c54

Description read

[DESCRIPTION-READ] 1d5f71d8c9396899c8e282a915ffa0b77db7badaf9ade0be39389c0e362e95d9

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of b3a9c5427d70fb55cc8b763d070c5a60a39cd2e1 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: the five strips now use the existing shared wheel hook, so they all follow the same rules, and the two hand-written handlers that broke the page scroll are deleted.

[DESIGN-REVIEWED] b3a9c54

Description read

[DESCRIPTION-READ] 2e23b990c829d800a2a8f9c6a3e8609e3003e0cf768910b5197c7b430b183d9c

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of b3a9c5427d70fb55cc8b763d070c5a60a39cd2e1 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing to check. Every strip now uses the existing useWheelToHorizontal hook, and two hand-rolled wheel handlers are deleted rather than kept beside it.

What this change ships

Inventory (7 items) — 7 justified

Intent: let mouse-wheel users reach clipped tabs and chips in every strip, with the same wheel rules on each one. This is a FIX (Closes #22154).

  1. Session tab strip scrolls sideways on a vertical wheel — justified
  2. Terminal tab strip scrolls sideways on a vertical wheel — justified
  3. File Explorer tab strip scrolls sideways on a vertical wheel — justified
  4. Follow-up bar lets the page scroll once its row is at an end; its own handler is deleted — justified
  5. Embed strip no longer scrolls the page along with the row; its passive handler is deleted — justified
  6. Wheel with Ctrl, Shift, Alt or Meta held is now left alone on the follow-up bar and embed strip — justified
  7. A shared expectWheelToScrollRow test helper replaces the embed strip's "keeps the wheel translation" pin, whose handler is gone (the description says so) — justified

[FIRST-PRINCIPLES-REVIEWED] b3a9c54

Description read

[DESCRIPTION-READ] 8fd6ee82e8e58e63ba17164343fb9aaa6e8f506b05c927cb0ee10ebf3bb143f8

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed b3a9c5427d70fb55cc8b763d070c5a60a39cd2e1 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] b3a9c54

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed b3a9c5427d70fb55cc8b763d070c5a60a39cd2e1 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] b3a9c54

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 29, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving b3a9c54.

Each strip now binds the existing useWheelToHorizontal hook from its scroller's ref (hook). The two hand-written handlers are deleted: the follow-up bar's handler always cancelled the wheel, and the embed strip's passive handler let the page scroll too. The shared test helper checks scrolling while clipped, the hand-off at the far end and a row that fits, and every strip calls it (helpers.tsx#L125). All fork AI lanes passed without notes, checks are green, and there are no other reviews.

— crew-pr-reviewer (r135)

@iamwhatever
iamwhatever enabled auto-merge (squash) October 29, 2026 16:38
@iamwhatever
iamwhatever merged commit bc20551 into kirodotdev:main Oct 29, 2026
90 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 29, 2026
@abirkel
abirkel deleted the fix/tab-strips-wheel-hook branch November 10, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Share one wheel-to-horizontal hook across the side panel, follow-up bar and embed tab strips

2 participants