Repository navigation
docs(rfc): sandbox seals the gateway checkout's git control files - #25692
Conversation
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS This PR only adds a document. It records a sandbox-widening decision for a maintainer to approve, which is the route AGENTS.md requires. Notes
[DESIGN-REVIEWED] 5cfa2bb Description read[DESCRIPTION-READ] a566617afaf780e66651a0c04751e06076ef4a1cbb1e190de4dc1288349a4fcb That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
ce534fd to
020ea27
Compare
020ea27 to
5cfa2bb
Compare
Problem / Motivation
Goal: Record the decision to seal the gateway checkout's git control files inside the agent sandbox, so #24812 has an accepted RFC on main.
PR #24812 makes the gateway checkout's
.gitconfig, hooks and info read-only inside the sandbox. First Principles blocks it as a product-shape change with no recorded decision: agents losegit push -u,git remote add,gh pr checkoutandpre-commit installin that checkout. This PR is that RFC.Why it matters
Without a recorded decision, #24812 stays blocked, and a later reader cannot tell whether the lost commands were chosen or accidental.
Not a goal
What changed (motivation → approach → change)
One new RFC,
docs/request-for-change/rfc-sandbox-gateway-checkout-git-seal.md(statusaccepted), and its row in thedocs/request-for-change/README.mdindex. It states the threat, the decision, what agents lose and where, the workaround, per-OS behavior, known limits (the Linuxcommondirgap leaves a person's terminal git exposed), alternatives and rollback.Scope was read from #24812's code at
ee9bb8e5f5:gateway_checkout_roots()insandbox_git_control.pycovers onlyKIROCREW_PROJECT_DIRand the gateway's own source checkout. Linked worktrees of that checkout share its sealed config, so the RFC names a separate clone as the workaround. Other repositories are unaffected.The
acceptedstatus takes effect when a maintainer merges this PR. A maintainer who does not accept it should setstatus: draftinstead.Backwards compatibility
Compatible: documentation only.
Removes nothing: this PR adds one document and one index row.
Tests
N/A — docs only.
scripts/docs-lint.shpasses.Manual verification
N/A — docs only; claims about main were read at
7df9837c60, claims about the change at #24812 headee9bb8e5f5.Related Issues
Refs #24812
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)