Repository navigation
test: backport three test-only fixes the 0.11.0-rc.2 run needs - #25759
Conversation
The v0.11.0-rc.2 release run failed two Test Release Candidate shards on tests main has already fixed: - test(skills): wait for the coalesced follow-up prune before asserting (#24142) (cherry picked from commit 5d98031) - test(skills): freeze the lease-scan clock in the legacy-lock test (#24257) (cherry picked from commit 3ff45cb) - test: pin the prune clock in the seam pruning test (#24191) (cherry picked from commit 33fd421) #24191's test seeds a 2026-09-25 history file and prunes at 30 days, so it fails on every run after 2026-10-25. #24142 follows the end-prune coalescing that #23913 brought to this branch.
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Test-only backport that fixes the root causes (a date-dependent prune clock and an un-awaited coalesced prune) and changes no production code. Notes
[DESIGN-REVIEWED] beaf3d2 Description read[DESCRIPTION-READ] 1cfe6da57b876f53a754c54126bb8eaa1330afb7b458145909952bda5623a215 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: The 0.11.0 release branch passes its own release test shards.
The
v0.11.0-rc.2release run failed twoTest Release Candidate SHAshards:test_memory_files_substitution.py::...::test_pruning_removes_from_the_seam_and_leaves_local_files_alone:assert 2 == 1. The test seeds a2026-09-25history file and prunes at 30 days, so it fails on every run after 2026-10-25.test_native_skill_projection_rewrites.py::test_two_concurrent_releases_each_prune_their_own_view: the second release's prune is coalesced (fix(skill-projection): coalesce end prunes so a fan-out cannot hold the start queue #23913, now on this branch), and the test asserted before it ran.Why it matters
The stable
v0.11.0tag needs a successful same-commit prerelease run. With these two tests red, no 0.11.0 RC can clearstable-gate.Not a goal
What changed (motivation → approach → change)
Three test-only main PRs that already fix exactly these tests are cherry-picked and squashed into one commit:
Backwards compatibility
Compatible: test-only change.
Removes nothing: only tests change.
Tests
pytest test/test_memory_files_substitution.py test/test_native_skill_projection_rewrites.py: 66 passed.test_native_skill_projection_rewrites.pythen passed 3 more times under-n 4.v0.11.0-rc.1,e379f74d3aandfff71bf30e, and passed onmain.Manual verification
N/A — test-only change.
Related Issues
Release run: https://github.com/kirodotdev/KiroCrew/actions/runs/40848242663
Checklist
Contribution License Agreement
Contributed under the project's Apache-2.0 license.