Skip to content

test: backport three test-only fixes the 0.11.0-rc.2 run needs - #25759

Merged
bolichen97 merged 1 commit into
release/0.11.0from
backport/0.11.0-test-fixes
Oct 29, 2026
Merged

bolichen97 merged 1 commit into
release/0.11.0from
backport/0.11.0-test-fixes

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The 0.11.0 release branch passes its own release test shards.

The v0.11.0-rc.2 release run failed two Test Release Candidate SHA shards:

  • test_memory_files_substitution.py::...::test_pruning_removes_from_the_seam_and_leaves_local_files_alone: assert 2 == 1. The test seeds a 2026-09-25 history file and prunes at 30 days, so it fails on every run after 2026-10-25.
  • test_native_skill_projection_rewrites.py::test_two_concurrent_releases_each_prune_their_own_view: the second release's prune is coalesced (fix(skill-projection): coalesce end prunes so a fan-out cannot hold the start queue #23913, now on this branch), and the test asserted before it ran.

Why it matters

The stable v0.11.0 tag needs a successful same-commit prerelease run. With these two tests red, no 0.11.0 RC can clear stable-gate.

Not a goal

  • No production code change.
  • No other test from main.

What changed (motivation → approach → change)

Three test-only main PRs that already fix exactly these tests are cherry-picked and squashed into one commit:

Backwards compatibility

Compatible: test-only change.

Removes nothing: only tests change.

Tests

  • pytest test/test_memory_files_substitution.py test/test_native_skill_projection_rewrites.py: 66 passed. test_native_skill_projection_rewrites.py then passed 3 more times under -n 4.
  • Before: the memory test failed on v0.11.0-rc.1, e379f74d3a and fff71bf30e, and passed on main.

Manual verification

N/A — test-only change.

Related Issues

Release run: https://github.com/kirodotdev/KiroCrew/actions/runs/40848242663

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

The v0.11.0-rc.2 release run failed two Test Release Candidate shards on
tests main has already fixed:

- test(skills): wait for the coalesced follow-up prune before asserting (#24142)
  (cherry picked from commit 5d98031)
- test(skills): freeze the lease-scan clock in the legacy-lock test (#24257)
  (cherry picked from commit 3ff45cb)
- test: pin the prune clock in the seam pruning test (#24191)
  (cherry picked from commit 33fd421)

#24191's test seeds a 2026-09-25 history file and prunes at 30 days, so it
fails on every run after 2026-10-25. #24142 follows the end-prune
coalescing that #23913 brought to this branch.
@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners October 29, 2026 11:09
@bolichen97
bolichen97 requested review from buluoray and removed request for a team October 29, 2026 11:09
@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision beaf3d2bc65ec1338cd9b57a2baf9489e5028316 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision beaf3d2bc65ec1338cd9b57a2baf9489e5028316 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of beaf3d2bc65ec1338cd9b57a2baf9489e5028316 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Test-only backport that fixes the root causes (a date-dependent prune clock and an un-awaited coalesced prune) and changes no production code.

Notes

[DESIGN-REVIEWED] beaf3d2

Description read

[DESCRIPTION-READ] 1cfe6da57b876f53a754c54126bb8eaa1330afb7b458145909952bda5623a215

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of beaf3d2bc65ec1338cd9b57a2baf9489e5028316 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] beaf3d2

False positive or not applicable? A repository writer can comment:
/ai-review override gpt beaf3d2bc65ec1338cd9b57a2baf9489e5028316 false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed beaf3d2bc65ec1338cd9b57a2baf9489e5028316 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] beaf3d2

Verdict parsed from the review's SHA-scoped output markers for commit beaf3d2bc65ec1338cd9b57a2baf9489e5028316.

False positive or not applicable? A repository writer can comment:
/ai-review override fable beaf3d2bc65ec1338cd9b57a2baf9489e5028316 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 29, 2026
@bolichen97
bolichen97 merged commit c7a85c8 into release/0.11.0 Oct 29, 2026
25 checks passed
@bolichen97
bolichen97 deleted the backport/0.11.0-test-fixes branch October 29, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant