Skip to content

refactor(slack): remove two Block Kit builders that nothing calls - #25843

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
refactor/remove-dead-slack-builders
Oct 29, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
refactor/remove-dead-slack-builders

Conversation

@RohanK6

@RohanK6 RohanK6 commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Two Slack Block Kit builders that nothing calls are gone from the tree.

confirmation_dialog in src/kiro_crew/slack/blocks.py and build_subagent_ack_block in src/kiro_crew/slack/format.py have no caller. A reader who finds them assumes something still posts that confirm dialog or that acknowledge button, and has to grep the tree to learn that nothing does.

Why it matters

Dead builders look like live API. They cost every reader of the Slack modules a search, and they invite a new caller to copy a shape the product no longer uses.

Not a goal

  • No change to the Slack action handlers in src/kiro_crew/slack/interactions.py or to SUBAGENT_ACK_ACTION_PREFIX.
  • No change to any Block Kit message the gateway posts today.
  • No sweep of other unused code in the Slack package.

What changed (motivation → approach → change)

No caller → delete the dead code → the two functions are removed, and nothing else.

Removed File Callers on main
confirmation_dialog src/kiro_crew/slack/blocks.py none
build_subagent_ack_block src/kiro_crew/slack/format.py none

Neither function was the last user of any import, so no import changes.

The handlers stay on purpose. mc_stop_confirm and mc_stop_cancel near line 280 of src/kiro_crew/slack/interactions.py, and the SUBAGENT_ACK_ACTION_PREFIX branch near line 243, answer clicks on buttons with those action ids. Slack keeps every message the gateway posted earlier, so an old message can still carry one of those buttons, and its click must still get an answer.

Backwards compatibility

Compatible: no runtime path called either function, so nothing that works today stops working.

Reader: src/kiro_crew/slack/interactions.py:dispatch -- chat -- still routes mc_stop_confirm, mc_stop_cancel and subagent_ack_ clicks from earlier messages, and reads SUBAGENT_ACK_ACTION_PREFIX, which stays; test_slack_interactions_coverage.py::test_subagent_ack_marks_matching_notification

Tests

No new test: the change removes code that nothing runs. The proof is the caller search, plus the related suites passing:

Manual verification

N/A — no runtime path reached either function, so there is nothing to exercise by hand.

Related Issues

Closes #25842

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

confirmation_dialog in slack/blocks.py and build_subagent_ack_block in
slack/format.py have no caller in src, test, scripts or website, and
no export list or dynamic lookup names them. They read as live API
that nothing posts.

The button handlers in slack/interactions.py and the
SUBAGENT_ACK_ACTION_PREFIX constant stay: messages posted earlier can
still carry those buttons, and a click must still be answered.

Closes #25842
@RohanK6
RohanK6 requested review from a team and KiroCrewCaptain as code owners October 29, 2026 17:54
@RohanK6
RohanK6 requested a review from cruisercohen October 29, 2026 17:54
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 1f1a6c98953973b57385dc7352ce7273a85d7ec9 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 1f1a6c98953973b57385dc7352ce7273a85d7ec9 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Neither builder has a caller anywhere in the tree, and the click handlers that answer buttons on earlier messages are kept.

[DESIGN-REVIEWED] 1f1a6c9

Description read

[DESCRIPTION-READ] 1196957f776346b593fc491aabb2432eebf3a2c37a9997f28068c16dfe6c6fe7

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 1f1a6c98953973b57385dc7352ce7273a85d7ec9 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (2 items) — 2 justified

Intent: let people reading the Slack modules see only code that runs, by deleting two Block Kit builders nothing calls (a FIX).

  1. The unused confirmation_dialog builder for a confirm/deny dialog is removed from slack/blocks.py — justified
  2. The unused build_subagent_ack_block builder for an acknowledge button is removed from slack/format.py — justified

[FIRST-PRINCIPLES-REVIEWED] 1f1a6c9

Description read

[DESCRIPTION-READ] 85c1a38f15b886b220e3759739bf0919580da259f5e2e3dbd9944e22089c0d83

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 1f1a6c98953973b57385dc7352ce7273a85d7ec9 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 1f1a6c9

Verdict parsed from the review's SHA-scoped output markers for commit 1f1a6c98953973b57385dc7352ce7273a85d7ec9.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 1f1a6c98953973b57385dc7352ce7273a85d7ec9 false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 1f1a6c98953973b57385dc7352ce7273a85d7ec9 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 1f1a6c9

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 1f1a6c98953973b57385dc7352ce7273a85d7ec9 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 29, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of the watch holder (bolichen). Design and First Principles pass on this head (or skipped / author override), UX skipped or pass, no conflict, no open change request.

@KiroCrewCaptain
KiroCrewCaptain merged commit ae71b7e into main Oct 29, 2026
92 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the refactor/remove-dead-slack-builders branch October 29, 2026 19:51
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(slack): remove two Block Kit builders that nothing calls

2 participants